Inspection of "Fixed tests" - aimeos/ai-controller-frontend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0c1242...d48b9a )

by Aimeos

created 2018-09-27 09:28 UTC

Status

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -15,31 +15,31 @@
 block discarded – undo
 	{
 		$target = '\\Aimeos\\Controller\\Frontend\\Product\\Iface';
 
-		$controller = \Aimeos\Controller\Frontend\Product\Factory::createController( \TestHelperFrontend::getContext() );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Product\Factory::createController(\TestHelperFrontend::getContext());
+		$this->assertInstanceOf($target, $controller);
 
-		$controller = \Aimeos\Controller\Frontend\Product\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Product\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
+		$this->assertInstanceOf($target, $controller);
 	}
 
 
 	public function testCreateControllerInvalidImplementation()
 	{
-		$this->setExpectedException( '\\Aimeos\\MW\\Common\\Exception' );
-		\Aimeos\Controller\Frontend\Product\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
+		$this->setExpectedException('\\Aimeos\\MW\\Common\\Exception');
+		\Aimeos\Controller\Frontend\Product\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
 	}
 
 
 	public function testCreateControllerInvalidName()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Product\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Product\Factory::createController(\TestHelperFrontend::getContext(), '%^');
 	}
 
 
 	public function testCreateControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Product\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Product\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
 	}
 }

Please login to merge, or discard this patch.

frontend/tests/Controller/Frontend/Service/Decorator/BaseTest.php 1 patch

Spacing +46 added lines, -46 removed lines patch added patch discarded remove patch

@@ -20,130 +20,130 @@
 block discarded – undo
 	{
 		$this->context = \TestHelperFrontend::getContext();
 
-		$this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Service\Standard' )
+		$this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Service\Standard')
 			->disableOriginalConstructor()
 			->getMock();
 
-		$this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Service\Decorator\Base' )
-			->setConstructorArgs( [$this->stub, $this->context] )
+		$this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Service\Decorator\Base')
+			->setConstructorArgs([$this->stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->context, $this->object, $this->stub );
+		unset($this->context, $this->object, $this->stub);
 	}
 
 
 	public function testConstructException()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
 
-		$this->setExpectedException( '\Aimeos\MW\Common\Exception' );
+		$this->setExpectedException('\Aimeos\MW\Common\Exception');
 
-		$this->getMockBuilder( '\Aimeos\Controller\Frontend\Service\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$this->getMockBuilder('\Aimeos\Controller\Frontend\Service\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	public function testCall()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Service\Standard' )
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Service\Standard')
 			->disableOriginalConstructor()
-			->setMethods( ['invalid'] )
+			->setMethods(['invalid'])
 			->getMock();
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Service\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Service\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 
-		$stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
+		$stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
 
-		$this->assertTrue( $object->invalid() );
+		$this->assertTrue($object->invalid());
 	}
 
 
 	public function testCheckAttributes()
 	{
-		$this->stub->expects( $this->once() )->method( 'checkAttributes' )
-			->will( $this->returnValue( [] ) );
+		$this->stub->expects($this->once())->method('checkAttributes')
+			->will($this->returnValue([]));
 
-		$this->assertEquals( [], $this->object->checkAttributes( -1, [] ) );
+		$this->assertEquals([], $this->object->checkAttributes( -1, [] ));
 	}
 
 
 	public function testGetProvider()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( $this->context, 'service' );
-		$provider = $manager->getProvider( $manager->findItem( 'unitcode', [], 'service', 'delivery' ), 'delivery' );
+		$manager = \Aimeos\MShop\Factory::createManager($this->context, 'service');
+		$provider = $manager->getProvider($manager->findItem('unitcode', [], 'service', 'delivery'), 'delivery');
 
-		$this->stub->expects( $this->once() )->method( 'getProvider' )
-			->will( $this->returnValue( $provider ) );
+		$this->stub->expects($this->once())->method('getProvider')
+			->will($this->returnValue($provider));
 
-		$this->assertSame( $provider, $this->object->getProvider( -1 ) );
+		$this->assertSame($provider, $this->object->getProvider( -1 ));
 	}
 
 
 	public function testGetProviders()
 	{
-		$this->stub->expects( $this->once() )->method( 'getProviders' )
-			->will( $this->returnValue( [] ) );
+		$this->stub->expects($this->once())->method('getProviders')
+			->will($this->returnValue([]));
 
-		$this->assertEquals( [], $this->object->getProviders( 'payment' ) );
+		$this->assertEquals([], $this->object->getProviders('payment'));
 	}
 
 
 	public function testProcess()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'process' )
-			->will( $this->returnValue( new \Aimeos\MShop\Common\Item\Helper\Form\Standard() ) );
+		$this->stub->expects($this->once())->method('process')
+			->will($this->returnValue(new \Aimeos\MShop\Common\Item\Helper\Form\Standard()));
 
-		$this->assertInstanceOf( 'Aimeos\MShop\Common\Item\Helper\Form\Iface', $this->object->process( $item, -1, [], [] ) );
+		$this->assertInstanceOf('Aimeos\MShop\Common\Item\Helper\Form\Iface', $this->object->process($item, -1, [], []));
 	}
 
 
 	public function testUpdatePush()
 	{
-		$response = $this->getMockBuilder( '\Psr\Http\Message\ResponseInterface' )->getMock();
-		$request = $this->getMockBuilder( '\Psr\Http\Message\ServerRequestInterface' )->getMock();
+		$response = $this->getMockBuilder('\Psr\Http\Message\ResponseInterface')->getMock();
+		$request = $this->getMockBuilder('\Psr\Http\Message\ServerRequestInterface')->getMock();
 
-		$this->stub->expects( $this->once() )->method( 'updatePush' )
-			->will( $this->returnValue( $response ) );
+		$this->stub->expects($this->once())->method('updatePush')
+			->will($this->returnValue($response));
 
-		$this->assertInstanceOf( '\Psr\Http\Message\ResponseInterface', $this->object->updatePush( $request, $response, 'test' ) );
+		$this->assertInstanceOf('\Psr\Http\Message\ResponseInterface', $this->object->updatePush($request, $response, 'test'));
 	}
 
 
 	public function testUpdateSync()
 	{
-		$response = $this->getMockBuilder( '\Psr\Http\Message\ResponseInterface' )->getMock();
-		$request = $this->getMockBuilder( '\Psr\Http\Message\ServerRequestInterface' )->getMock();
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
+		$response = $this->getMockBuilder('\Psr\Http\Message\ResponseInterface')->getMock();
+		$request = $this->getMockBuilder('\Psr\Http\Message\ServerRequestInterface')->getMock();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'updateSync' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('updateSync')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( 'Aimeos\MShop\Order\Item\Iface', $this->object->updateSync( $request, $response, [], 'test', -1 ) );
+		$this->assertInstanceOf('Aimeos\MShop\Order\Item\Iface', $this->object->updateSync($request, $response, [], 'test', -1));
 	}
 
 
 	public function testGetController()
 	{
-		$result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
+		$result = $this->access('getController')->invokeArgs($this->object, []);
 
-		$this->assertSame( $this->stub, $result );
+		$this->assertSame($this->stub, $result);
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Service\Decorator\Base' );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Service\Decorator\Base');
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/Service/FactoryTest.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -15,31 +15,31 @@
 block discarded – undo
 	{
 		$target = '\\Aimeos\\Controller\\Frontend\\Service\\Iface';
 
-		$controller = \Aimeos\Controller\Frontend\Service\Factory::createController( \TestHelperFrontend::getContext() );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Service\Factory::createController(\TestHelperFrontend::getContext());
+		$this->assertInstanceOf($target, $controller);
 
-		$controller = \Aimeos\Controller\Frontend\Service\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Service\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
+		$this->assertInstanceOf($target, $controller);
 	}
 
 
 	public function testCreateControllerInvalidImplementation()
 	{
-		$this->setExpectedException( '\\Aimeos\\MW\\Common\\Exception' );
-		\Aimeos\Controller\Frontend\Service\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
+		$this->setExpectedException('\\Aimeos\\MW\\Common\\Exception');
+		\Aimeos\Controller\Frontend\Service\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
 	}
 
 
 	public function testCreateControllerInvalidName()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Service\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Service\Factory::createController(\TestHelperFrontend::getContext(), '%^');
 	}
 
 
 	public function testCreateControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Service\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Service\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
 	}
 }

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/Order/Decorator/BaseTest.php 1 patch

Spacing +41 added lines, -41 removed lines patch added patch discarded remove patch

@@ -20,134 +20,134 @@
 block discarded – undo
 	{
 		$this->context = \TestHelperFrontend::getContext();
 
-		$this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Order\Standard' )
+		$this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Order\Standard')
 			->disableOriginalConstructor()
 			->getMock();
 
-		$this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Order\Decorator\Base' )
-			->setConstructorArgs( [$this->stub, $this->context] )
+		$this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Order\Decorator\Base')
+			->setConstructorArgs([$this->stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->context, $this->object, $this->stub );
+		unset($this->context, $this->object, $this->stub);
 	}
 
 
 	public function testConstructException()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
 
-		$this->setExpectedException( '\Aimeos\MW\Common\Exception' );
+		$this->setExpectedException('\Aimeos\MW\Common\Exception');
 
-		$this->getMockBuilder( '\Aimeos\Controller\Frontend\Order\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$this->getMockBuilder('\Aimeos\Controller\Frontend\Order\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	public function testCall()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Order\Standard' )
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Order\Standard')
 			->disableOriginalConstructor()
-			->setMethods( ['invalid'] )
+			->setMethods(['invalid'])
 			->getMock();
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Order\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Order\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 
-		$stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
+		$stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
 
-		$this->assertTrue( $object->invalid() );
+		$this->assertTrue($object->invalid());
 	}
 
 
 	public function testAddItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'addItem' )->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('addItem')->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Order\Item\Iface', $this->object->addItem( -1, '' ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Order\Item\Iface', $this->object->addItem( -1, '' ));
 	}
 
 
 	public function testCreateFilter()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'createFilter' )->will( $this->returnValue( $search ) );
+		$this->stub->expects($this->once())->method('createFilter')->will($this->returnValue($search));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->createFilter() );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->createFilter());
 	}
 
 
 	public function testGetItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'getItem' )->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('getItem')->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Order\Item\Iface', $this->object->getItem( -1 ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Order\Item\Iface', $this->object->getItem( -1 ));
 	}
 
 
 	public function testSaveItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'saveItem' );
+		$this->stub->expects($this->once())->method('saveItem');
 
-		$this->object->saveItem( $item );
+		$this->object->saveItem($item);
 	}
 
 
 	public function testSearchItems()
 	{
-		$search = $this->getMockBuilder( '\Aimeos\MW\Criteria\Iface' )->getMock();
+		$search = $this->getMockBuilder('\Aimeos\MW\Criteria\Iface')->getMock();
 
-		$this->stub->expects( $this->once() )->method( 'searchItems' )->will( $this->returnValue( [] ) );
+		$this->stub->expects($this->once())->method('searchItems')->will($this->returnValue([]));
 
-		$this->assertEquals( [], $this->object->searchItems( $search ) );
+		$this->assertEquals([], $this->object->searchItems($search));
 	}
 
 
 	public function testUnblock()
 	{
-		$orderItem = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
+		$orderItem = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'unblock' );
+		$this->stub->expects($this->once())->method('unblock');
 
-		$this->object->unblock( $orderItem );
+		$this->object->unblock($orderItem);
 	}
 
 
 	public function testUpdate()
 	{
-		$orderItem = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
+		$orderItem = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'update' );
+		$this->stub->expects($this->once())->method('update');
 
-		$this->object->update( $orderItem );
+		$this->object->update($orderItem);
 	}
 
 
 	public function testGetController()
 	{
-		$result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
+		$result = $this->access('getController')->invokeArgs($this->object, []);
 
-		$this->assertSame( $this->stub, $result );
+		$this->assertSame($this->stub, $result);
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Order\Decorator\Base' );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Order\Decorator\Base');
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/Order/FactoryTest.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -16,31 +16,31 @@
 block discarded – undo
 	{
 		$target = '\\Aimeos\\Controller\\Frontend\\Order\\Iface';
 
-		$controller = \Aimeos\Controller\Frontend\Order\Factory::createController( \TestHelperFrontend::getContext() );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Order\Factory::createController(\TestHelperFrontend::getContext());
+		$this->assertInstanceOf($target, $controller);
 
-		$controller = \Aimeos\Controller\Frontend\Order\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Order\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
+		$this->assertInstanceOf($target, $controller);
 	}
 
 
 	public function testCreateControllerInvalidImplementation()
 	{
-		$this->setExpectedException( '\\Aimeos\\MW\\Common\\Exception' );
-		\Aimeos\Controller\Frontend\Order\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
+		$this->setExpectedException('\\Aimeos\\MW\\Common\\Exception');
+		\Aimeos\Controller\Frontend\Order\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
 	}
 
 
 	public function testCreateControllerInvalidName()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Order\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Order\Factory::createController(\TestHelperFrontend::getContext(), '%^');
 	}
 
 
 	public function testCreateControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Order\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Order\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
 	}
 }

Please login to merge, or discard this patch.

frontend/tests/Controller/Frontend/Customer/Decorator/BaseTest.php 1 patch

Spacing +60 added lines, -60 removed lines patch added patch discarded remove patch

@@ -20,76 +20,76 @@  discard block
 block discarded – undo
 	{
 		$this->context = \TestHelperFrontend::getContext();
 
-		$this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Standard' )
+		$this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Standard')
 			->disableOriginalConstructor()
 			->getMock();
 
-		$this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
-			->setConstructorArgs( [$this->stub, $this->context] )
+		$this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
+			->setConstructorArgs([$this->stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->context, $this->object, $this->stub );
+		unset($this->context, $this->object, $this->stub);
 	}
 
 
 	public function testConstructException()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
 
-		$this->setExpectedException( '\Aimeos\MW\Common\Exception' );
+		$this->setExpectedException('\Aimeos\MW\Common\Exception');
 
-		$this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	public function testCall()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Standard' )
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Standard')
 			->disableOriginalConstructor()
-			->setMethods( ['invalid'] )
+			->setMethods(['invalid'])
 			->getMock();
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 
-		$stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
+		$stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
 
-		$this->assertTrue( $object->invalid() );
+		$this->assertTrue($object->invalid());
 	}
 
 
 	public function testAddItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'addItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('addItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->addItem( [] ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->addItem([]));
 	}
 
 
 	public function testCreateItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'createItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('createItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->createItem() );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->createItem());
 	}
 
 
 	public function testDeleteItem()
 	{
-		$this->stub->expects( $this->once() )->method( 'deleteItem' );
+		$this->stub->expects($this->once())->method('deleteItem');
 
 		$this->object->deleteItem( -1 );
 	}
@@ -97,61 +97,61 @@  discard block
 block discarded – undo
 
 	public function testEditItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'editItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('editItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->editItem( -1, [] ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->editItem( -1, [] ));
 	}
 
 
 	public function testGetItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'getItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('getItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->getItem( -1 ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->getItem( -1 ));
 	}
 
 
 	public function testFindItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'findItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('findItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->findItem( 'test' ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->findItem('test'));
 	}
 
 
 	public function testSaveItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'saveItem' );
+		$this->stub->expects($this->once())->method('saveItem');
 
-		$this->object->saveItem( $item );
+		$this->object->saveItem($item);
 	}
 
 
 	public function testCreateAddressItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'createAddressItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('createAddressItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->createAddressItem() );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->createAddressItem());
 	}
 
 
 	public function testDeleteAddressItem()
 	{
-		$this->stub->expects( $this->once() )->method( 'deleteAddressItem' );
+		$this->stub->expects($this->once())->method('deleteAddressItem');
 
 		$this->object->deleteAddressItem( -1 );
 	}
@@ -159,49 +159,49 @@  discard block
 block discarded – undo
 
 	public function testEditAddressItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'editAddressItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('editAddressItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->editAddressItem( -1, [] ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->editAddressItem( -1, [] ));
 	}
 
 
 	public function testGetAddressItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'getAddressItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('getAddressItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->getAddressItem( -1 ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->getAddressItem( -1 ));
 	}
 
 
 	public function testSaveAddressItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'saveAddressItem' );
+		$this->stub->expects($this->once())->method('saveAddressItem');
 
-		$this->object->saveAddressItem( $item );
+		$this->object->saveAddressItem($item);
 	}
 
 
 	public function testGetController()
 	{
-		$result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
+		$result = $this->access('getController')->invokeArgs($this->object, []);
 
-		$this->assertSame( $this->stub, $result );
+		$this->assertSame($this->stub, $result);
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Customer\Decorator\Base');
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/Customer/FactoryTest.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -15,31 +15,31 @@
 block discarded – undo
 	{
 		$target = '\\Aimeos\\Controller\\Frontend\\Customer\\Iface';
 
-		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext() );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext());
+		$this->assertInstanceOf($target, $controller);
 
-		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
+		$this->assertInstanceOf($target, $controller);
 	}
 
 
 	public function testCreateControllerInvalidImplementation()
 	{
-		$this->setExpectedException( '\\Aimeos\\MW\\Common\\Exception' );
-		\Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
+		$this->setExpectedException('\\Aimeos\\MW\\Common\\Exception');
+		\Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
 	}
 
 
 	public function testCreateControllerInvalidName()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), '%^');
 	}
 
 
 	public function testCreateControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
 	}
 }

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/Stock/Decorator/BaseTest.php 1 patch

Spacing +40 added lines, -40 removed lines patch added patch discarded remove patch

@@ -20,119 +20,119 @@
 block discarded – undo
 	{
 		$this->context = \TestHelperFrontend::getContext();
 
-		$this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Standard' )
+		$this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Standard')
 			->disableOriginalConstructor()
 			->getMock();
 
-		$this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
-			->setConstructorArgs( [$this->stub, $this->context] )
+		$this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
+			->setConstructorArgs([$this->stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->context, $this->object, $this->stub );
+		unset($this->context, $this->object, $this->stub);
 	}
 
 
 	public function testConstructException()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
 
-		$this->setExpectedException( '\Aimeos\MW\Common\Exception' );
+		$this->setExpectedException('\Aimeos\MW\Common\Exception');
 
-		$this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	public function testCall()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Standard' )
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Standard')
 			->disableOriginalConstructor()
-			->setMethods( ['invalid'] )
+			->setMethods(['invalid'])
 			->getMock();
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 
-		$stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
+		$stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
 
-		$this->assertTrue( $object->invalid() );
+		$this->assertTrue($object->invalid());
 	}
 
 
 	public function testAddFilterCodes()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'addFilterCodes' )
-			->will( $this->returnArgument( 0 ) );
+		$this->stub->expects($this->once())->method('addFilterCodes')
+			->will($this->returnArgument(0));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterCodes( $search, [] ) );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterCodes($search, []));
 	}
 
 
 	public function testAddFilterTypes()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'addFilterTypes' )
-			->will( $this->returnArgument( 0 ) );
+		$this->stub->expects($this->once())->method('addFilterTypes')
+			->will($this->returnArgument(0));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes( $search, [] ) );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes($search, []));
 	}
 
 
 	public function testCreateFilter()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'createFilter' )
-			->will( $this->returnValue( $search ) );
+		$this->stub->expects($this->once())->method('createFilter')
+			->will($this->returnValue($search));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->createFilter() );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->createFilter());
 	}
 
 
 	public function testGetItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'getItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('getItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Stock\Item\Iface', $this->object->getItem( -1 ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Stock\Item\Iface', $this->object->getItem( -1 ));
 	}
 
 
 	public function testSearchItems()
 	{
-		$filter = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
+		$filter = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( [] ) );
+		$this->stub->expects($this->once())->method('searchItems')
+			->will($this->returnValue([]));
 
-		$this->assertEquals( [], $this->object->searchItems( $filter ) );
+		$this->assertEquals([], $this->object->searchItems($filter));
 	}
 
 
 	public function testGetController()
 	{
-		$result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
+		$result = $this->access('getController')->invokeArgs($this->object, []);
 
-		$this->assertSame( $this->stub, $result );
+		$this->assertSame($this->stub, $result);
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Stock\Decorator\Base');
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/Stock/FactoryTest.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -15,31 +15,31 @@
 block discarded – undo
 	{
 		$target = '\\Aimeos\\Controller\\Frontend\\Stock\\Iface';
 
-		$controller = \Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext() );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext());
+		$this->assertInstanceOf($target, $controller);
 
-		$controller = \Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
+		$this->assertInstanceOf($target, $controller);
 	}
 
 
 	public function testCreateControllerInvalidImplementation()
 	{
-		$this->setExpectedException( '\\Aimeos\\MW\\Common\\Exception' );
-		\Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
+		$this->setExpectedException('\\Aimeos\\MW\\Common\\Exception');
+		\Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
 	}
 
 
 	public function testCreateControllerInvalidName()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), '%^');
 	}
 
 
 	public function testCreateControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
 	}
 }

Please login to merge, or discard this patch.

		@@ -20,130 +20,130 @@
		block discarded – undo
20	20	{
21	21	$this->context = \TestHelperFrontend::getContext();
22	22
23		- $this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Service\Standard' )
	23	+ $this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Service\Standard')
24	24	->disableOriginalConstructor()
25	25	->getMock();
26	26
27		- $this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Service\Decorator\Base' )
28		- ->setConstructorArgs( [$this->stub, $this->context] )
	27	+ $this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Service\Decorator\Base')
	28	+ ->setConstructorArgs([$this->stub, $this->context])
29	29	->getMockForAbstractClass();
30	30	}
31	31
32	32
33	33	protected function tearDown()
34	34	{
35		- unset( $this->context, $this->object, $this->stub );
	35	+ unset($this->context, $this->object, $this->stub);
36	36	}
37	37
38	38
39	39	public function testConstructException()
40	40	{
41		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
	41	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
42	42
43		- $this->setExpectedException( '\Aimeos\MW\Common\Exception' );
	43	+ $this->setExpectedException('\Aimeos\MW\Common\Exception');
44	44
45		- $this->getMockBuilder( '\Aimeos\Controller\Frontend\Service\Decorator\Base' )
46		- ->setConstructorArgs( [$stub, $this->context] )
	45	+ $this->getMockBuilder('\Aimeos\Controller\Frontend\Service\Decorator\Base')
	46	+ ->setConstructorArgs([$stub, $this->context])
47	47	->getMockForAbstractClass();
48	48	}
49	49
50	50
51	51	public function testCall()
52	52	{
53		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Service\Standard' )
	53	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Service\Standard')
54	54	->disableOriginalConstructor()
55		- ->setMethods( ['invalid'] )
	55	+ ->setMethods(['invalid'])
56	56	->getMock();
57	57
58		- $object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Service\Decorator\Base' )
59		- ->setConstructorArgs( [$stub, $this->context] )
	58	+ $object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Service\Decorator\Base')
	59	+ ->setConstructorArgs([$stub, $this->context])
60	60	->getMockForAbstractClass();
61	61
62		- $stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
	62	+ $stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
63	63
64		- $this->assertTrue( $object->invalid() );
	64	+ $this->assertTrue($object->invalid());
65	65	}
66	66
67	67
68	68	public function testCheckAttributes()
69	69	{
70		- $this->stub->expects( $this->once() )->method( 'checkAttributes' )
71		- ->will( $this->returnValue( [] ) );
	70	+ $this->stub->expects($this->once())->method('checkAttributes')
	71	+ ->will($this->returnValue([]));
72	72
73		- $this->assertEquals( [], $this->object->checkAttributes( -1, [] ) );
	73	+ $this->assertEquals([], $this->object->checkAttributes( -1, [] ));
74	74	}
75	75
76	76
77	77	public function testGetProvider()
78	78	{
79		- $manager = \Aimeos\MShop\Factory::createManager( $this->context, 'service' );
80		- $provider = $manager->getProvider( $manager->findItem( 'unitcode', [], 'service', 'delivery' ), 'delivery' );
	79	+ $manager = \Aimeos\MShop\Factory::createManager($this->context, 'service');
	80	+ $provider = $manager->getProvider($manager->findItem('unitcode', [], 'service', 'delivery'), 'delivery');
81	81
82		- $this->stub->expects( $this->once() )->method( 'getProvider' )
83		- ->will( $this->returnValue( $provider ) );
	82	+ $this->stub->expects($this->once())->method('getProvider')
	83	+ ->will($this->returnValue($provider));
84	84
85		- $this->assertSame( $provider, $this->object->getProvider( -1 ) );
	85	+ $this->assertSame($provider, $this->object->getProvider( -1 ));
86	86	}
87	87
88	88
89	89	public function testGetProviders()
90	90	{
91		- $this->stub->expects( $this->once() )->method( 'getProviders' )
92		- ->will( $this->returnValue( [] ) );
	91	+ $this->stub->expects($this->once())->method('getProviders')
	92	+ ->will($this->returnValue([]));
93	93
94		- $this->assertEquals( [], $this->object->getProviders( 'payment' ) );
	94	+ $this->assertEquals([], $this->object->getProviders('payment'));
95	95	}
96	96
97	97
98	98	public function testProcess()
99	99	{
100		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
	100	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
101	101
102		- $this->stub->expects( $this->once() )->method( 'process' )
103		- ->will( $this->returnValue( new \Aimeos\MShop\Common\Item\Helper\Form\Standard() ) );
	102	+ $this->stub->expects($this->once())->method('process')
	103	+ ->will($this->returnValue(new \Aimeos\MShop\Common\Item\Helper\Form\Standard()));
104	104
105		- $this->assertInstanceOf( 'Aimeos\MShop\Common\Item\Helper\Form\Iface', $this->object->process( $item, -1, [], [] ) );
	105	+ $this->assertInstanceOf('Aimeos\MShop\Common\Item\Helper\Form\Iface', $this->object->process($item, -1, [], []));
106	106	}
107	107
108	108
109	109	public function testUpdatePush()
110	110	{
111		- $response = $this->getMockBuilder( '\Psr\Http\Message\ResponseInterface' )->getMock();
112		- $request = $this->getMockBuilder( '\Psr\Http\Message\ServerRequestInterface' )->getMock();
	111	+ $response = $this->getMockBuilder('\Psr\Http\Message\ResponseInterface')->getMock();
	112	+ $request = $this->getMockBuilder('\Psr\Http\Message\ServerRequestInterface')->getMock();
113	113
114		- $this->stub->expects( $this->once() )->method( 'updatePush' )
115		- ->will( $this->returnValue( $response ) );
	114	+ $this->stub->expects($this->once())->method('updatePush')
	115	+ ->will($this->returnValue($response));
116	116
117		- $this->assertInstanceOf( '\Psr\Http\Message\ResponseInterface', $this->object->updatePush( $request, $response, 'test' ) );
	117	+ $this->assertInstanceOf('\Psr\Http\Message\ResponseInterface', $this->object->updatePush($request, $response, 'test'));
118	118	}
119	119
120	120
121	121	public function testUpdateSync()
122	122	{
123		- $response = $this->getMockBuilder( '\Psr\Http\Message\ResponseInterface' )->getMock();
124		- $request = $this->getMockBuilder( '\Psr\Http\Message\ServerRequestInterface' )->getMock();
125		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
	123	+ $response = $this->getMockBuilder('\Psr\Http\Message\ResponseInterface')->getMock();
	124	+ $request = $this->getMockBuilder('\Psr\Http\Message\ServerRequestInterface')->getMock();
	125	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
126	126
127		- $this->stub->expects( $this->once() )->method( 'updateSync' )
128		- ->will( $this->returnValue( $item ) );
	127	+ $this->stub->expects($this->once())->method('updateSync')
	128	+ ->will($this->returnValue($item));
129	129
130		- $this->assertInstanceOf( 'Aimeos\MShop\Order\Item\Iface', $this->object->updateSync( $request, $response, [], 'test', -1 ) );
	130	+ $this->assertInstanceOf('Aimeos\MShop\Order\Item\Iface', $this->object->updateSync($request, $response, [], 'test', -1));
131	131	}
132	132
133	133
134	134	public function testGetController()
135	135	{
136		- $result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
	136	+ $result = $this->access('getController')->invokeArgs($this->object, []);
137	137
138		- $this->assertSame( $this->stub, $result );
	138	+ $this->assertSame($this->stub, $result);
139	139	}
140	140
141	141
142		- protected function access( $name )
	142	+ protected function access($name)
143	143	{
144		- $class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Service\Decorator\Base' );
145		- $method = $class->getMethod( $name );
146		- $method->setAccessible( true );
	144	+ $class = new \ReflectionClass('\Aimeos\Controller\Frontend\Service\Decorator\Base');
	145	+ $method = $class->getMethod($name);
	146	+ $method->setAccessible(true);
147	147
148	148	return $method;
149	149	}

		@@ -20,134 +20,134 @@
		block discarded – undo
20	20	{
21	21	$this->context = \TestHelperFrontend::getContext();
22	22
23		- $this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Order\Standard' )
	23	+ $this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Order\Standard')
24	24	->disableOriginalConstructor()
25	25	->getMock();
26	26
27		- $this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Order\Decorator\Base' )
28		- ->setConstructorArgs( [$this->stub, $this->context] )
	27	+ $this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Order\Decorator\Base')
	28	+ ->setConstructorArgs([$this->stub, $this->context])
29	29	->getMockForAbstractClass();
30	30	}
31	31
32	32
33	33	protected function tearDown()
34	34	{
35		- unset( $this->context, $this->object, $this->stub );
	35	+ unset($this->context, $this->object, $this->stub);
36	36	}
37	37
38	38
39	39	public function testConstructException()
40	40	{
41		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
	41	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
42	42
43		- $this->setExpectedException( '\Aimeos\MW\Common\Exception' );
	43	+ $this->setExpectedException('\Aimeos\MW\Common\Exception');
44	44
45		- $this->getMockBuilder( '\Aimeos\Controller\Frontend\Order\Decorator\Base' )
46		- ->setConstructorArgs( [$stub, $this->context] )
	45	+ $this->getMockBuilder('\Aimeos\Controller\Frontend\Order\Decorator\Base')
	46	+ ->setConstructorArgs([$stub, $this->context])
47	47	->getMockForAbstractClass();
48	48	}
49	49
50	50
51	51	public function testCall()
52	52	{
53		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Order\Standard' )
	53	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Order\Standard')
54	54	->disableOriginalConstructor()
55		- ->setMethods( ['invalid'] )
	55	+ ->setMethods(['invalid'])
56	56	->getMock();
57	57
58		- $object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Order\Decorator\Base' )
59		- ->setConstructorArgs( [$stub, $this->context] )
	58	+ $object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Order\Decorator\Base')
	59	+ ->setConstructorArgs([$stub, $this->context])
60	60	->getMockForAbstractClass();
61	61
62		- $stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
	62	+ $stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
63	63
64		- $this->assertTrue( $object->invalid() );
	64	+ $this->assertTrue($object->invalid());
65	65	}
66	66
67	67
68	68	public function testAddItem()
69	69	{
70		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
	70	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
71	71
72		- $this->stub->expects( $this->once() )->method( 'addItem' )->will( $this->returnValue( $item ) );
	72	+ $this->stub->expects($this->once())->method('addItem')->will($this->returnValue($item));
73	73
74		- $this->assertInstanceOf( '\Aimeos\MShop\Order\Item\Iface', $this->object->addItem( -1, '' ) );
	74	+ $this->assertInstanceOf('\Aimeos\MShop\Order\Item\Iface', $this->object->addItem( -1, '' ));
75	75	}
76	76
77	77
78	78	public function testCreateFilter()
79	79	{
80		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createSearch();
	80	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createSearch();
81	81
82		- $this->stub->expects( $this->once() )->method( 'createFilter' )->will( $this->returnValue( $search ) );
	82	+ $this->stub->expects($this->once())->method('createFilter')->will($this->returnValue($search));
83	83
84		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->createFilter() );
	84	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->createFilter());
85	85	}
86	86
87	87
88	88	public function testGetItem()
89	89	{
90		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
	90	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
91	91
92		- $this->stub->expects( $this->once() )->method( 'getItem' )->will( $this->returnValue( $item ) );
	92	+ $this->stub->expects($this->once())->method('getItem')->will($this->returnValue($item));
93	93
94		- $this->assertInstanceOf( '\Aimeos\MShop\Order\Item\Iface', $this->object->getItem( -1 ) );
	94	+ $this->assertInstanceOf('\Aimeos\MShop\Order\Item\Iface', $this->object->getItem( -1 ));
95	95	}
96	96
97	97
98	98	public function testSaveItem()
99	99	{
100		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
	100	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
101	101
102		- $this->stub->expects( $this->once() )->method( 'saveItem' );
	102	+ $this->stub->expects($this->once())->method('saveItem');
103	103
104		- $this->object->saveItem( $item );
	104	+ $this->object->saveItem($item);
105	105	}
106	106
107	107
108	108	public function testSearchItems()
109	109	{
110		- $search = $this->getMockBuilder( '\Aimeos\MW\Criteria\Iface' )->getMock();
	110	+ $search = $this->getMockBuilder('\Aimeos\MW\Criteria\Iface')->getMock();
111	111
112		- $this->stub->expects( $this->once() )->method( 'searchItems' )->will( $this->returnValue( [] ) );
	112	+ $this->stub->expects($this->once())->method('searchItems')->will($this->returnValue([]));
113	113
114		- $this->assertEquals( [], $this->object->searchItems( $search ) );
	114	+ $this->assertEquals([], $this->object->searchItems($search));
115	115	}
116	116
117	117
118	118	public function testUnblock()
119	119	{
120		- $orderItem = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
	120	+ $orderItem = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
121	121
122		- $this->stub->expects( $this->once() )->method( 'unblock' );
	122	+ $this->stub->expects($this->once())->method('unblock');
123	123
124		- $this->object->unblock( $orderItem );
	124	+ $this->object->unblock($orderItem);
125	125	}
126	126
127	127
128	128	public function testUpdate()
129	129	{
130		- $orderItem = \Aimeos\MShop\Factory::createManager( $this->context, 'order' )->createItem();
	130	+ $orderItem = \Aimeos\MShop\Factory::createManager($this->context, 'order')->createItem();
131	131
132		- $this->stub->expects( $this->once() )->method( 'update' );
	132	+ $this->stub->expects($this->once())->method('update');
133	133
134		- $this->object->update( $orderItem );
	134	+ $this->object->update($orderItem);
135	135	}
136	136
137	137
138	138	public function testGetController()
139	139	{
140		- $result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
	140	+ $result = $this->access('getController')->invokeArgs($this->object, []);
141	141
142		- $this->assertSame( $this->stub, $result );
	142	+ $this->assertSame($this->stub, $result);
143	143	}
144	144
145	145
146		- protected function access( $name )
	146	+ protected function access($name)
147	147	{
148		- $class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Order\Decorator\Base' );
149		- $method = $class->getMethod( $name );
150		- $method->setAccessible( true );
	148	+ $class = new \ReflectionClass('\Aimeos\Controller\Frontend\Order\Decorator\Base');
	149	+ $method = $class->getMethod($name);
	150	+ $method->setAccessible(true);
151	151
152	152	return $method;
153	153	}

		@@ -20,119 +20,119 @@
		block discarded – undo
20	20	{
21	21	$this->context = \TestHelperFrontend::getContext();
22	22
23		- $this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Standard' )
	23	+ $this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Standard')
24	24	->disableOriginalConstructor()
25	25	->getMock();
26	26
27		- $this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
28		- ->setConstructorArgs( [$this->stub, $this->context] )
	27	+ $this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
	28	+ ->setConstructorArgs([$this->stub, $this->context])
29	29	->getMockForAbstractClass();
30	30	}
31	31
32	32
33	33	protected function tearDown()
34	34	{
35		- unset( $this->context, $this->object, $this->stub );
	35	+ unset($this->context, $this->object, $this->stub);
36	36	}
37	37
38	38
39	39	public function testConstructException()
40	40	{
41		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
	41	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
42	42
43		- $this->setExpectedException( '\Aimeos\MW\Common\Exception' );
	43	+ $this->setExpectedException('\Aimeos\MW\Common\Exception');
44	44
45		- $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
46		- ->setConstructorArgs( [$stub, $this->context] )
	45	+ $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
	46	+ ->setConstructorArgs([$stub, $this->context])
47	47	->getMockForAbstractClass();
48	48	}
49	49
50	50
51	51	public function testCall()
52	52	{
53		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Standard' )
	53	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Standard')
54	54	->disableOriginalConstructor()
55		- ->setMethods( ['invalid'] )
	55	+ ->setMethods(['invalid'])
56	56	->getMock();
57	57
58		- $object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
59		- ->setConstructorArgs( [$stub, $this->context] )
	58	+ $object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
	59	+ ->setConstructorArgs([$stub, $this->context])
60	60	->getMockForAbstractClass();
61	61
62		- $stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
	62	+ $stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
63	63
64		- $this->assertTrue( $object->invalid() );
	64	+ $this->assertTrue($object->invalid());
65	65	}
66	66
67	67
68	68	public function testAddFilterCodes()
69	69	{
70		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
	70	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
71	71
72		- $this->stub->expects( $this->once() )->method( 'addFilterCodes' )
73		- ->will( $this->returnArgument( 0 ) );
	72	+ $this->stub->expects($this->once())->method('addFilterCodes')
	73	+ ->will($this->returnArgument(0));
74	74
75		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterCodes( $search, [] ) );
	75	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterCodes($search, []));
76	76	}
77	77
78	78
79	79	public function testAddFilterTypes()
80	80	{
81		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
	81	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
82	82
83		- $this->stub->expects( $this->once() )->method( 'addFilterTypes' )
84		- ->will( $this->returnArgument( 0 ) );
	83	+ $this->stub->expects($this->once())->method('addFilterTypes')
	84	+ ->will($this->returnArgument(0));
85	85
86		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes( $search, [] ) );
	86	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes($search, []));
87	87	}
88	88
89	89
90	90	public function testCreateFilter()
91	91	{
92		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
	92	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
93	93
94		- $this->stub->expects( $this->once() )->method( 'createFilter' )
95		- ->will( $this->returnValue( $search ) );
	94	+ $this->stub->expects($this->once())->method('createFilter')
	95	+ ->will($this->returnValue($search));
96	96
97		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->createFilter() );
	97	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->createFilter());
98	98	}
99	99
100	100
101	101	public function testGetItem()
102	102	{
103		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createItem();
	103	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createItem();
104	104
105		- $this->stub->expects( $this->once() )->method( 'getItem' )
106		- ->will( $this->returnValue( $item ) );
	105	+ $this->stub->expects($this->once())->method('getItem')
	106	+ ->will($this->returnValue($item));
107	107
108		- $this->assertInstanceOf( '\Aimeos\MShop\Stock\Item\Iface', $this->object->getItem( -1 ) );
	108	+ $this->assertInstanceOf('\Aimeos\MShop\Stock\Item\Iface', $this->object->getItem( -1 ));
109	109	}
110	110
111	111
112	112	public function testSearchItems()
113	113	{
114		- $filter = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
	114	+ $filter = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
115	115
116		- $this->stub->expects( $this->once() )->method( 'searchItems' )
117		- ->will( $this->returnValue( [] ) );
	116	+ $this->stub->expects($this->once())->method('searchItems')
	117	+ ->will($this->returnValue([]));
118	118
119		- $this->assertEquals( [], $this->object->searchItems( $filter ) );
	119	+ $this->assertEquals([], $this->object->searchItems($filter));
120	120	}
121	121
122	122
123	123	public function testGetController()
124	124	{
125		- $result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
	125	+ $result = $this->access('getController')->invokeArgs($this->object, []);
126	126
127		- $this->assertSame( $this->stub, $result );
	127	+ $this->assertSame($this->stub, $result);
128	128	}
129	129
130	130
131		- protected function access( $name )
	131	+ protected function access($name)
132	132	{
133		- $class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' );
134		- $method = $class->getMethod( $name );
135		- $method->setAccessible( true );
	133	+ $class = new \ReflectionClass('\Aimeos\Controller\Frontend\Stock\Decorator\Base');
	134	+ $method = $class->getMethod($name);
	135	+ $method->setAccessible(true);
136	136
137	137	return $method;
138	138	}

		@@ -15,31 +15,31 @@
		block discarded – undo
15	15	{
16	16	$target = '\\Aimeos\\Controller\\Frontend\\Product\\Iface';
17	17
18		- $controller = \Aimeos\Controller\Frontend\Product\Factory::createController( \TestHelperFrontend::getContext() );
19		- $this->assertInstanceOf( $target, $controller );
	18	+ $controller = \Aimeos\Controller\Frontend\Product\Factory::createController(\TestHelperFrontend::getContext());
	19	+ $this->assertInstanceOf($target, $controller);
20	20
21		- $controller = \Aimeos\Controller\Frontend\Product\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
22		- $this->assertInstanceOf( $target, $controller );
	21	+ $controller = \Aimeos\Controller\Frontend\Product\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
	22	+ $this->assertInstanceOf($target, $controller);
23	23	}
24	24
25	25
26	26	public function testCreateControllerInvalidImplementation()
27	27	{
28		- $this->setExpectedException( '\\Aimeos\\MW\\Common\\Exception' );
29		- \Aimeos\Controller\Frontend\Product\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
	28	+ $this->setExpectedException('\\Aimeos\\MW\\Common\\Exception');
	29	+ \Aimeos\Controller\Frontend\Product\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
30	30	}
31	31
32	32
33	33	public function testCreateControllerInvalidName()
34	34	{
35		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
36		- \Aimeos\Controller\Frontend\Product\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
	35	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	36	+ \Aimeos\Controller\Frontend\Product\Factory::createController(\TestHelperFrontend::getContext(), '%^');
37	37	}
38	38
39	39
40	40	public function testCreateControllerNotExisting()
41	41	{
42		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
43		- \Aimeos\Controller\Frontend\Product\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
	42	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	43	+ \Aimeos\Controller\Frontend\Product\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
44	44	}
45	45	}

		@@ -16,31 +16,31 @@
		block discarded – undo
16	16	{
17	17	$target = '\\Aimeos\\Controller\\Frontend\\Order\\Iface';
18	18
19		- $controller = \Aimeos\Controller\Frontend\Order\Factory::createController( \TestHelperFrontend::getContext() );
20		- $this->assertInstanceOf( $target, $controller );
	19	+ $controller = \Aimeos\Controller\Frontend\Order\Factory::createController(\TestHelperFrontend::getContext());
	20	+ $this->assertInstanceOf($target, $controller);
21	21
22		- $controller = \Aimeos\Controller\Frontend\Order\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
23		- $this->assertInstanceOf( $target, $controller );
	22	+ $controller = \Aimeos\Controller\Frontend\Order\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
	23	+ $this->assertInstanceOf($target, $controller);
24	24	}
25	25
26	26
27	27	public function testCreateControllerInvalidImplementation()
28	28	{
29		- $this->setExpectedException( '\\Aimeos\\MW\\Common\\Exception' );
30		- \Aimeos\Controller\Frontend\Order\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
	29	+ $this->setExpectedException('\\Aimeos\\MW\\Common\\Exception');
	30	+ \Aimeos\Controller\Frontend\Order\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
31	31	}
32	32
33	33
34	34	public function testCreateControllerInvalidName()
35	35	{
36		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
37		- \Aimeos\Controller\Frontend\Order\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
	36	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	37	+ \Aimeos\Controller\Frontend\Order\Factory::createController(\TestHelperFrontend::getContext(), '%^');
38	38	}
39	39
40	40
41	41	public function testCreateControllerNotExisting()
42	42	{
43		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
44		- \Aimeos\Controller\Frontend\Order\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
	43	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	44	+ \Aimeos\Controller\Frontend\Order\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
45	45	}
46	46	}

		@@ -20,76 +20,76 @@ discard block
		block discarded – undo
20	20	{
21	21	$this->context = \TestHelperFrontend::getContext();
22	22
23		- $this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Standard' )
	23	+ $this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Standard')
24	24	->disableOriginalConstructor()
25	25	->getMock();
26	26
27		- $this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
28		- ->setConstructorArgs( [$this->stub, $this->context] )
	27	+ $this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
	28	+ ->setConstructorArgs([$this->stub, $this->context])
29	29	->getMockForAbstractClass();
30	30	}
31	31
32	32
33	33	protected function tearDown()
34	34	{
35		- unset( $this->context, $this->object, $this->stub );
	35	+ unset($this->context, $this->object, $this->stub);
36	36	}
37	37
38	38
39	39	public function testConstructException()
40	40	{
41		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
	41	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
42	42
43		- $this->setExpectedException( '\Aimeos\MW\Common\Exception' );
	43	+ $this->setExpectedException('\Aimeos\MW\Common\Exception');
44	44
45		- $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
46		- ->setConstructorArgs( [$stub, $this->context] )
	45	+ $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
	46	+ ->setConstructorArgs([$stub, $this->context])
47	47	->getMockForAbstractClass();
48	48	}
49	49
50	50
51	51	public function testCall()
52	52	{
53		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Standard' )
	53	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Standard')
54	54	->disableOriginalConstructor()
55		- ->setMethods( ['invalid'] )
	55	+ ->setMethods(['invalid'])
56	56	->getMock();
57	57
58		- $object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
59		- ->setConstructorArgs( [$stub, $this->context] )
	58	+ $object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
	59	+ ->setConstructorArgs([$stub, $this->context])
60	60	->getMockForAbstractClass();
61	61
62		- $stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
	62	+ $stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
63	63
64		- $this->assertTrue( $object->invalid() );
	64	+ $this->assertTrue($object->invalid());
65	65	}
66	66
67	67
68	68	public function testAddItem()
69	69	{
70		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
	70	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
71	71
72		- $this->stub->expects( $this->once() )->method( 'addItem' )
73		- ->will( $this->returnValue( $item ) );
	72	+ $this->stub->expects($this->once())->method('addItem')
	73	+ ->will($this->returnValue($item));
74	74
75		- $this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->addItem( [] ) );
	75	+ $this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->addItem([]));
76	76	}
77	77
78	78
79	79	public function testCreateItem()
80	80	{
81		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
	81	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
82	82
83		- $this->stub->expects( $this->once() )->method( 'createItem' )
84		- ->will( $this->returnValue( $item ) );
	83	+ $this->stub->expects($this->once())->method('createItem')
	84	+ ->will($this->returnValue($item));
85	85
86		- $this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->createItem() );
	86	+ $this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->createItem());
87	87	}
88	88
89	89
90	90	public function testDeleteItem()
91	91	{
92		- $this->stub->expects( $this->once() )->method( 'deleteItem' );
	92	+ $this->stub->expects($this->once())->method('deleteItem');
93	93
94	94	$this->object->deleteItem( -1 );
95	95	}
		@@ -97,61 +97,61 @@ discard block
		block discarded – undo
97	97
98	98	public function testEditItem()
99	99	{
100		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
	100	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
101	101
102		- $this->stub->expects( $this->once() )->method( 'editItem' )
103		- ->will( $this->returnValue( $item ) );
	102	+ $this->stub->expects($this->once())->method('editItem')
	103	+ ->will($this->returnValue($item));
104	104
105		- $this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->editItem( -1, [] ) );
	105	+ $this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->editItem( -1, [] ));
106	106	}
107	107
108	108
109	109	public function testGetItem()
110	110	{
111		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
	111	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
112	112
113		- $this->stub->expects( $this->once() )->method( 'getItem' )
114		- ->will( $this->returnValue( $item ) );
	113	+ $this->stub->expects($this->once())->method('getItem')
	114	+ ->will($this->returnValue($item));
115	115
116		- $this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->getItem( -1 ) );
	116	+ $this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->getItem( -1 ));
117	117	}
118	118
119	119
120	120	public function testFindItem()
121	121	{
122		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
	122	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
123	123
124		- $this->stub->expects( $this->once() )->method( 'findItem' )
125		- ->will( $this->returnValue( $item ) );
	124	+ $this->stub->expects($this->once())->method('findItem')
	125	+ ->will($this->returnValue($item));
126	126
127		- $this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->findItem( 'test' ) );
	127	+ $this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->findItem('test'));
128	128	}
129	129
130	130
131	131	public function testSaveItem()
132	132	{
133		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
	133	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
134	134
135		- $this->stub->expects( $this->once() )->method( 'saveItem' );
	135	+ $this->stub->expects($this->once())->method('saveItem');
136	136
137		- $this->object->saveItem( $item );
	137	+ $this->object->saveItem($item);
138	138	}
139	139
140	140
141	141	public function testCreateAddressItem()
142	142	{
143		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
	143	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
144	144
145		- $this->stub->expects( $this->once() )->method( 'createAddressItem' )
146		- ->will( $this->returnValue( $item ) );
	145	+ $this->stub->expects($this->once())->method('createAddressItem')
	146	+ ->will($this->returnValue($item));
147	147
148		- $this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->createAddressItem() );
	148	+ $this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->createAddressItem());
149	149	}
150	150
151	151
152	152	public function testDeleteAddressItem()
153	153	{
154		- $this->stub->expects( $this->once() )->method( 'deleteAddressItem' );
	154	+ $this->stub->expects($this->once())->method('deleteAddressItem');
155	155
156	156	$this->object->deleteAddressItem( -1 );
157	157	}
		@@ -159,49 +159,49 @@ discard block
		block discarded – undo
159	159
160	160	public function testEditAddressItem()
161	161	{
162		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
	162	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
163	163
164		- $this->stub->expects( $this->once() )->method( 'editAddressItem' )
165		- ->will( $this->returnValue( $item ) );
	164	+ $this->stub->expects($this->once())->method('editAddressItem')
	165	+ ->will($this->returnValue($item));
166	166
167		- $this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->editAddressItem( -1, [] ) );
	167	+ $this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->editAddressItem( -1, [] ));
168	168	}
169	169
170	170
171	171	public function testGetAddressItem()
172	172	{
173		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
	173	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
174	174
175		- $this->stub->expects( $this->once() )->method( 'getAddressItem' )
176		- ->will( $this->returnValue( $item ) );
	175	+ $this->stub->expects($this->once())->method('getAddressItem')
	176	+ ->will($this->returnValue($item));
177	177
178		- $this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->getAddressItem( -1 ) );
	178	+ $this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->getAddressItem( -1 ));
179	179	}
180	180
181	181
182	182	public function testSaveAddressItem()
183	183	{
184		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
	184	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
185	185
186		- $this->stub->expects( $this->once() )->method( 'saveAddressItem' );
	186	+ $this->stub->expects($this->once())->method('saveAddressItem');
187	187
188		- $this->object->saveAddressItem( $item );
	188	+ $this->object->saveAddressItem($item);
189	189	}
190	190
191	191
192	192	public function testGetController()
193	193	{
194		- $result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
	194	+ $result = $this->access('getController')->invokeArgs($this->object, []);
195	195
196		- $this->assertSame( $this->stub, $result );
	196	+ $this->assertSame($this->stub, $result);
197	197	}
198	198
199	199
200		- protected function access( $name )
	200	+ protected function access($name)
201	201	{
202		- $class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' );
203		- $method = $class->getMethod( $name );
204		- $method->setAccessible( true );
	202	+ $class = new \ReflectionClass('\Aimeos\Controller\Frontend\Customer\Decorator\Base');
	203	+ $method = $class->getMethod($name);
	204	+ $method->setAccessible(true);
205	205
206	206	return $method;
207	207	}

aimeos / ai-controller-frontend

Push — master ( 0c1242...d48b9a )

Status

Category

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +46 added lines, -46 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +41 added lines, -41 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +60 added lines, -60 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +40 added lines, -40 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch