Conditions | 4 |
Paths | 6 |
Total Lines | 125 |
Code Lines | 9 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
32 | public static function create( \Aimeos\MShop\Context\Item\Iface $context, $name = null ) |
||
33 | { |
||
34 | /** controller/frontend/catalog/name |
||
35 | * Class name of the used catalog frontend controller implementation |
||
36 | * |
||
37 | * Each default frontend controller can be replace by an alternative imlementation. |
||
38 | * To use this implementation, you have to set the last part of the class |
||
39 | * name as configuration value so the controller factory knows which class it |
||
40 | * has to instantiate. |
||
41 | * |
||
42 | * For example, if the name of the default class is |
||
43 | * |
||
44 | * \Aimeos\Controller\Frontend\Catalog\Standard |
||
45 | * |
||
46 | * and you want to replace it with your own version named |
||
47 | * |
||
48 | * \Aimeos\Controller\Frontend\Catalog\Mycatalog |
||
49 | * |
||
50 | * then you have to set the this configuration option: |
||
51 | * |
||
52 | * controller/jobs/frontend/catalog/name = Mycatalog |
||
53 | * |
||
54 | * The value is the last part of your own class name and it's case sensitive, |
||
55 | * so take care that the configuration value is exactly named like the last |
||
56 | * part of the class name. |
||
57 | * |
||
58 | * The allowed characters of the class name are A-Z, a-z and 0-9. No other |
||
59 | * characters are possible! You should always start the last part of the class |
||
60 | * name with an upper case character and continue only with lower case characters |
||
61 | * or numbers. Avoid chamel case names like "MyCatalog"! |
||
62 | * |
||
63 | * @param string Last part of the class name |
||
64 | * @since 2014.03 |
||
65 | * @category Developer |
||
66 | */ |
||
67 | if( $name === null ) { |
||
68 | $name = $context->getConfig()->get( 'controller/frontend/catalog/name', 'Standard' ); |
||
69 | } |
||
70 | |||
71 | if( ctype_alnum( $name ) === false ) |
||
72 | { |
||
73 | $classname = is_string( $name ) ? '\\Aimeos\\Controller\\Frontend\\Catalog\\' . $name : '<not a string>'; |
||
74 | throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) ); |
||
75 | } |
||
76 | |||
77 | $iface = '\\Aimeos\\Controller\\Frontend\\Catalog\\Iface'; |
||
78 | $classname = '\\Aimeos\\Controller\\Frontend\\Catalog\\' . $name; |
||
79 | |||
80 | $manager = self::createController( $context, $classname, $iface ); |
||
81 | |||
82 | /** controller/frontend/catalog/decorators/excludes |
||
83 | * Excludes decorators added by the "common" option from the catalog frontend controllers |
||
84 | * |
||
85 | * Decorators extend the functionality of a class by adding new aspects |
||
86 | * (e.g. log what is currently done), executing the methods of the underlying |
||
87 | * class only in certain conditions (e.g. only for logged in users) or |
||
88 | * modify what is returned to the caller. |
||
89 | * |
||
90 | * This option allows you to remove a decorator added via |
||
91 | * "controller/frontend/common/decorators/default" before they are wrapped |
||
92 | * around the frontend controller. |
||
93 | * |
||
94 | * controller/frontend/catalog/decorators/excludes = array( 'decorator1' ) |
||
95 | * |
||
96 | * This would remove the decorator named "decorator1" from the list of |
||
97 | * common decorators ("\Aimeos\Controller\Frontend\Common\Decorator\*") added via |
||
98 | * "controller/frontend/common/decorators/default" for the catalog frontend controller. |
||
99 | * |
||
100 | * @param array List of decorator names |
||
101 | * @since 2014.03 |
||
102 | * @category Developers |
||
103 | * @see controller/frontend/common/decorators/default |
||
104 | * @see controller/frontend/catalog/decorators/global |
||
105 | * @see controller/frontend/catalog/decorators/local |
||
106 | */ |
||
107 | |||
108 | /** controller/frontend/catalog/decorators/global |
||
109 | * Adds a list of globally available decorators only to the catalog frontend controllers |
||
110 | * |
||
111 | * Decorators extend the functionality of a class by adding new aspects |
||
112 | * (e.g. log what is currently done), executing the methods of the underlying |
||
113 | * class only in certain conditions (e.g. only for logged in users) or |
||
114 | * modify what is returned to the caller. |
||
115 | * |
||
116 | * This option allows you to wrap global decorators |
||
117 | * ("\Aimeos\Controller\Frontend\Common\Decorator\*") around the frontend controller. |
||
118 | * |
||
119 | * controller/frontend/catalog/decorators/global = array( 'decorator1' ) |
||
120 | * |
||
121 | * This would add the decorator named "decorator1" defined by |
||
122 | * "\Aimeos\Controller\Frontend\Common\Decorator\Decorator1" only to the frontend controller. |
||
123 | * |
||
124 | * @param array List of decorator names |
||
125 | * @since 2014.03 |
||
126 | * @category Developers |
||
127 | * @see controller/frontend/common/decorators/default |
||
128 | * @see controller/frontend/catalog/decorators/excludes |
||
129 | * @see controller/frontend/catalog/decorators/local |
||
130 | */ |
||
131 | |||
132 | /** controller/frontend/catalog/decorators/local |
||
133 | * Adds a list of local decorators only to the catalog frontend controllers |
||
134 | * |
||
135 | * Decorators extend the functionality of a class by adding new aspects |
||
136 | * (e.g. log what is currently done), executing the methods of the underlying |
||
137 | * class only in certain conditions (e.g. only for logged in users) or |
||
138 | * modify what is returned to the caller. |
||
139 | * |
||
140 | * This option allows you to wrap local decorators |
||
141 | * ("\Aimeos\Controller\Frontend\Catalog\Decorator\*") around the frontend controller. |
||
142 | * |
||
143 | * controller/frontend/catalog/decorators/local = array( 'decorator2' ) |
||
144 | * |
||
145 | * This would add the decorator named "decorator2" defined by |
||
146 | * "\Aimeos\Controller\Frontend\Catalog\Decorator\Decorator2" only to the frontend |
||
147 | * controller. |
||
148 | * |
||
149 | * @param array List of decorator names |
||
150 | * @since 2014.03 |
||
151 | * @category Developers |
||
152 | * @see controller/frontend/common/decorators/default |
||
153 | * @see controller/frontend/catalog/decorators/excludes |
||
154 | * @see controller/frontend/catalog/decorators/global |
||
155 | */ |
||
156 | return self::addControllerDecorators( $context, $manager, 'catalog' ); |
||
157 | } |
||
160 |