Total Complexity | 65 |
Total Lines | 521 |
Duplicated Lines | 0 % |
Changes | 0 |
Complex classes like Base often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Base, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
21 | abstract class Base extends \Aimeos\Controller\Frontend\Base implements Iface |
||
22 | { |
||
23 | private $listTypeItems = []; |
||
24 | |||
25 | |||
26 | /** |
||
27 | * Calculates and returns the current price for the given order product and product prices. |
||
28 | * |
||
29 | * @param \Aimeos\MShop\Order\Item\Base\Product\Iface $product Ordered product item |
||
30 | * @param \Aimeos\MShop\Price\Item\Iface[] $prices List of price items |
||
31 | * @param integer $quantity New product quantity |
||
32 | * @return \Aimeos\MShop\Price\Item\Iface Price item with calculated price |
||
33 | */ |
||
34 | protected function calcPrice( \Aimeos\MShop\Order\Item\Base\Product\Iface $product, array $prices, $quantity ) |
||
35 | { |
||
36 | $context = $this->getContext(); |
||
37 | |||
38 | if( empty( $prices ) ) |
||
39 | { |
||
40 | $manager = \Aimeos\MShop::create( $context, 'product' ); |
||
41 | $prices = $manager->getItem( $product->getProductId(), array( 'price' ) )->getRefItems( 'price', 'default' ); |
||
1 ignored issue
–
show
|
|||
42 | } |
||
43 | |||
44 | |||
45 | $priceManager = \Aimeos\MShop::create( $context, 'price' ); |
||
46 | $price = $priceManager->getLowestPrice( $prices, $quantity ); |
||
1 ignored issue
–
show
|
|||
47 | |||
48 | // customers can pay what they would like to pay |
||
49 | if( ( $attr = $product->getAttributeItem( 'price', 'custom' ) ) !== null ) |
||
50 | { |
||
51 | $amount = $attr->getValue(); |
||
52 | |||
53 | if( preg_match( '/^[0-9]*(\.[0-9]+)?$/', $amount ) !== 1 || ((double) $amount) < 0.01 ) |
||
54 | { |
||
55 | $msg = $context->getI18n()->dt( 'controller/frontend', 'Invalid price value "%1$s"' ); |
||
56 | throw new \Aimeos\Controller\Frontend\Basket\Exception( sprintf( $msg, $amount ) ); |
||
57 | } |
||
58 | |||
59 | $price->setValue( $amount ); |
||
60 | } |
||
61 | |||
62 | $orderAttributes = $product->getAttributeItems(); |
||
63 | $attrItems = $this->getAttributeItems( $orderAttributes ); |
||
64 | |||
65 | // add prices of (optional) attributes |
||
66 | foreach( $orderAttributes as $orderAttrItem ) |
||
67 | { |
||
68 | $attrId = $orderAttrItem->getAttributeId(); |
||
69 | |||
70 | if( isset( $attrItems[$attrId] ) |
||
71 | && ( $prices = $attrItems[$attrId]->getRefItems( 'price', 'default' ) ) !== [] |
||
72 | ) { |
||
73 | $attrPrice = $priceManager->getLowestPrice( $prices, $orderAttrItem->getQuantity() ); |
||
74 | $price->addItem( $attrPrice, $orderAttrItem->getQuantity() ); |
||
75 | } |
||
76 | } |
||
77 | |||
78 | // remove product rebate of original price in favor to rebates granted for the order |
||
79 | $price->setRebate( '0.00' ); |
||
80 | |||
81 | return $price; |
||
82 | } |
||
83 | |||
84 | |||
85 | /** |
||
86 | * Checks if the reference IDs are really associated to the product |
||
87 | * |
||
88 | * @param string|array $prodId Unique ID of the product or list of product IDs |
||
89 | * @param string $domain Domain the references must be of |
||
90 | * @param array $refMap Associative list of list type codes as keys and lists of reference IDs as values |
||
91 | * @throws \Aimeos\Controller\Frontend\Basket\Exception If one or more of the IDs are not associated |
||
92 | */ |
||
93 | protected function checkListRef( $prodId, $domain, array $refMap ) |
||
94 | { |
||
95 | if( empty( $refMap ) ) { |
||
96 | return; |
||
97 | } |
||
98 | |||
99 | $context = $this->getContext(); |
||
100 | $productManager = \Aimeos\MShop::create( $context, 'product' ); |
||
101 | $search = $productManager->createSearch( true ); |
||
102 | |||
103 | $expr = array( |
||
104 | $search->compare( '==', 'product.id', $prodId ), |
||
105 | $search->getConditions(), |
||
106 | ); |
||
107 | |||
108 | foreach( $refMap as $listType => $refIds ) |
||
109 | { |
||
110 | foreach( $refIds as $key => $refId ) |
||
111 | { |
||
112 | $cmpfunc = $search->createFunction( 'product:has', [$domain, $listType, (string) $refId] ); |
||
113 | $expr[] = $search->compare( '!=', $cmpfunc, null ); |
||
114 | } |
||
115 | } |
||
116 | |||
117 | $search->setConditions( $search->combine( '&&', $expr ) ); |
||
118 | |||
119 | if( count( $productManager->searchItems( $search, [] ) ) === 0 ) |
||
120 | { |
||
121 | $msg = $context->getI18n()->dt( 'controller/frontend', 'Invalid "%1$s" references for product with ID %2$s' ); |
||
122 | throw new \Aimeos\Controller\Frontend\Basket\Exception( sprintf( $msg, $domain, json_encode( $prodId ) ) ); |
||
123 | } |
||
124 | } |
||
125 | |||
126 | |||
127 | /** |
||
128 | * Checks for a locale mismatch and migrates the products to the new basket if necessary. |
||
129 | * |
||
130 | * @param \Aimeos\MShop\Locale\Item\Iface $locale Locale object from current basket |
||
131 | * @param string $type Basket type |
||
132 | */ |
||
133 | protected function checkLocale( \Aimeos\MShop\Locale\Item\Iface $locale, $type ) |
||
167 | } |
||
168 | |||
169 | |||
170 | /** |
||
171 | * Migrates the addresses from the old basket to the current one. |
||
172 | * |
||
173 | * @param \Aimeos\MShop\Order\Item\Base\Iface $basket Basket object |
||
174 | * @param array $errors Associative list of previous errors |
||
175 | * @param string $localeKey Unique identifier of the site, language and currency |
||
176 | * @return array Associative list of errors occured |
||
177 | */ |
||
178 | protected function copyAddresses( \Aimeos\MShop\Order\Item\Base\Iface $basket, array $errors, $localeKey ) |
||
179 | { |
||
180 | foreach( $basket->getAddresses() as $type => $item ) |
||
181 | { |
||
182 | try |
||
183 | { |
||
184 | $this->setAddress( $type, $item->toArray() ); |
||
185 | $basket->deleteAddress( $type ); |
||
186 | } |
||
187 | catch( \Exception $e ) |
||
188 | { |
||
189 | $logger = $this->getContext()->getLogger(); |
||
190 | $errors['address'][$type] = $e->getMessage(); |
||
191 | |||
192 | $str = 'Error migrating address with type "%1$s" in basket to locale "%2$s": %3$s'; |
||
193 | $logger->log( sprintf( $str, $type, $localeKey, $e->getMessage() ), \Aimeos\MW\Logger\Base::INFO ); |
||
194 | } |
||
195 | } |
||
196 | |||
197 | return $errors; |
||
198 | } |
||
199 | |||
200 | |||
201 | /** |
||
202 | * Migrates the coupons from the old basket to the current one. |
||
203 | * |
||
204 | * @param \Aimeos\MShop\Order\Item\Base\Iface $basket Basket object |
||
205 | * @param array $errors Associative list of previous errors |
||
206 | * @param string $localeKey Unique identifier of the site, language and currency |
||
207 | * @return array Associative list of errors occured |
||
208 | */ |
||
209 | protected function copyCoupons( \Aimeos\MShop\Order\Item\Base\Iface $basket, array $errors, $localeKey ) |
||
210 | { |
||
211 | foreach( $basket->getCoupons() as $code => $list ) |
||
212 | { |
||
213 | try |
||
214 | { |
||
215 | $this->addCoupon( $code ); |
||
216 | $basket->deleteCoupon( $code, true ); |
||
217 | } |
||
218 | catch( \Exception $e ) |
||
219 | { |
||
220 | $logger = $this->getContext()->getLogger(); |
||
221 | $errors['coupon'][$code] = $e->getMessage(); |
||
222 | |||
223 | $str = 'Error migrating coupon with code "%1$s" in basket to locale "%2$s": %3$s'; |
||
224 | $logger->log( sprintf( $str, $code, $localeKey, $e->getMessage() ), \Aimeos\MW\Logger\Base::INFO ); |
||
225 | } |
||
226 | } |
||
227 | |||
228 | return $errors; |
||
229 | } |
||
230 | |||
231 | |||
232 | /** |
||
233 | * Migrates the products from the old basket to the current one. |
||
234 | * |
||
235 | * @param \Aimeos\MShop\Order\Item\Base\Iface $basket Basket object |
||
236 | * @param array $errors Associative list of previous errors |
||
237 | * @param string $localeKey Unique identifier of the site, language and currency |
||
238 | * @return array Associative list of errors occured |
||
239 | */ |
||
240 | protected function copyProducts( \Aimeos\MShop\Order\Item\Base\Iface $basket, array $errors, $localeKey ) |
||
241 | { |
||
242 | foreach( $basket->getProducts() as $pos => $product ) |
||
243 | { |
||
244 | if( $product->getFlags() & \Aimeos\MShop\Order\Item\Base\Product\Base::FLAG_IMMUTABLE ) { |
||
245 | continue; |
||
246 | } |
||
247 | |||
248 | try |
||
249 | { |
||
250 | $variantIds = $configIds = $customIds = []; |
||
251 | |||
252 | foreach( $product->getAttributeItems() as $attrItem ) |
||
253 | { |
||
254 | switch( $attrItem->getType() ) |
||
255 | { |
||
256 | case 'variant': $variantIds[] = $attrItem->getAttributeId(); break; |
||
257 | case 'config': $configIds[$attrItem->getAttributeId()] = $attrItem->getQuantity(); break; |
||
258 | case 'custom': $customIds[$attrItem->getAttributeId()] = $attrItem->getValue(); break; |
||
259 | } |
||
260 | } |
||
261 | |||
262 | $this->addProduct( |
||
263 | $product->getProductId(), $product->getQuantity(), $product->getStockType(), |
||
264 | $variantIds, $configIds, [], $customIds |
||
265 | ); |
||
266 | |||
267 | $basket->deleteProduct( $pos ); |
||
268 | } |
||
269 | catch( \Exception $e ) |
||
270 | { |
||
271 | $code = $product->getProductCode(); |
||
272 | $logger = $this->getContext()->getLogger(); |
||
273 | $errors['product'][$pos] = $e->getMessage(); |
||
274 | |||
275 | $str = 'Error migrating product with code "%1$s" in basket to locale "%2$s": %3$s'; |
||
276 | $logger->log( sprintf( $str, $code, $localeKey, $e->getMessage() ), \Aimeos\MW\Logger\Base::INFO ); |
||
277 | } |
||
278 | } |
||
279 | |||
280 | return $errors; |
||
281 | } |
||
282 | |||
283 | |||
284 | /** |
||
285 | * Migrates the services from the old basket to the current one. |
||
286 | * |
||
287 | * @param \Aimeos\MShop\Order\Item\Base\Iface $basket Basket object |
||
288 | * @param array $errors Associative list of previous errors |
||
289 | * @return array Associative list of errors occured |
||
290 | */ |
||
291 | protected function copyServices( \Aimeos\MShop\Order\Item\Base\Iface $basket, array $errors ) |
||
313 | } |
||
314 | |||
315 | |||
316 | /** |
||
317 | * Creates the subscription entries for the ordered products with interval attributes |
||
318 | * |
||
319 | * @param \Aimeos\MShop\Order\Item\Base\Iface $basket Basket object |
||
320 | */ |
||
321 | protected function createSubscriptions( \Aimeos\MShop\Order\Item\Base\Iface $basket ) |
||
322 | { |
||
323 | $manager = \Aimeos\MShop::create( $this->getContext(), 'subscription' ); |
||
324 | |||
325 | foreach( $basket->getProducts() as $orderProduct ) |
||
326 | { |
||
327 | if( ( $interval = $orderProduct->getAttribute( 'interval', 'config' ) ) !== null ) |
||
328 | { |
||
329 | $item = $manager->createItem(); |
||
330 | $item->setOrderBaseId( $basket->getId() ); |
||
331 | $item->setOrderProductId( $orderProduct->getId() ); |
||
332 | $item->setInterval( $interval ); |
||
333 | $item->setStatus( 1 ); |
||
334 | |||
335 | if( ( $end = $orderProduct->getAttribute( 'intervalend', 'custom' ) ) !== null |
||
336 | || ( $end = $orderProduct->getAttribute( 'intervalend', 'config' ) ) !== null |
||
337 | || ( $end = $orderProduct->getAttribute( 'intervalend', 'hidden' ) ) !== null |
||
338 | ) { |
||
339 | $item->setDateEnd( $end ); |
||
340 | } |
||
341 | |||
342 | $manager->saveItem( $item, false ); |
||
343 | } |
||
344 | } |
||
345 | } |
||
346 | |||
347 | |||
348 | /** |
||
349 | * Returns the attribute items for the given attribute IDs. |
||
350 | * |
||
351 | * @param array $attributeIds List of attribute IDs |
||
352 | * @param string[] $domains Names of the domain items that should be fetched too |
||
353 | * @return array List of items implementing \Aimeos\MShop\Attribute\Item\Iface |
||
354 | * @throws \Aimeos\Controller\Frontend\Basket\Exception If the actual attribute number doesn't match the expected one |
||
355 | */ |
||
356 | protected function getAttributes( array $attributeIds, array $domains = array( 'price', 'text' ) ) |
||
357 | { |
||
358 | if( empty( $attributeIds ) ) { |
||
359 | return []; |
||
360 | } |
||
361 | |||
362 | $attributeManager = \Aimeos\MShop::create( $this->getContext(), 'attribute' ); |
||
363 | |||
364 | $search = $attributeManager->createSearch( true ); |
||
365 | $expr = array( |
||
366 | $search->compare( '==', 'attribute.id', $attributeIds ), |
||
367 | $search->getConditions(), |
||
368 | ); |
||
369 | $search->setConditions( $search->combine( '&&', $expr ) ); |
||
370 | $search->setSlice( 0, count( $attributeIds ) ); |
||
371 | |||
372 | $attrItems = $attributeManager->searchItems( $search, $domains ); |
||
373 | |||
374 | if( count( $attrItems ) !== count( $attributeIds ) ) |
||
375 | { |
||
376 | $i18n = $this->getContext()->getI18n(); |
||
377 | $expected = implode( ',', $attributeIds ); |
||
378 | $actual = implode( ',', array_keys( $attrItems ) ); |
||
379 | $msg = $i18n->dt( 'controller/frontend', 'Available attribute IDs "%1$s" do not match the given attribute IDs "%2$s"' ); |
||
380 | |||
381 | throw new \Aimeos\Controller\Frontend\Basket\Exception( sprintf( $msg, $actual, $expected ) ); |
||
382 | } |
||
383 | |||
384 | return $attrItems; |
||
385 | } |
||
386 | |||
387 | |||
388 | /** |
||
389 | * Returns the attribute items using the given order attribute items. |
||
390 | * |
||
391 | * @param \Aimeos\MShop\Order\Item\Base\Product\Attribute\Item[] $orderAttributes List of order product attribute items |
||
392 | * @return \Aimeos\MShop\Attribute\Item\Iface[] Associative list of attribute IDs as key and attribute items as values |
||
393 | */ |
||
394 | protected function getAttributeItems( array $orderAttributes ) |
||
395 | { |
||
396 | if( empty( $orderAttributes ) ) { |
||
397 | return []; |
||
398 | } |
||
399 | |||
400 | $attributeManager = \Aimeos\MShop::create( $this->getContext(), 'attribute' ); |
||
401 | $search = $attributeManager->createSearch( true ); |
||
402 | $expr = []; |
||
403 | |||
404 | foreach( $orderAttributes as $item ) |
||
405 | { |
||
406 | $tmp = array( |
||
407 | $search->compare( '==', 'attribute.domain', 'product' ), |
||
408 | $search->compare( '==', 'attribute.code', $item->getValue() ), |
||
409 | $search->compare( '==', 'attribute.type', $item->getCode() ), |
||
410 | $search->compare( '>', 'attribute.status', 0 ), |
||
411 | $search->getConditions(), |
||
412 | ); |
||
413 | $expr[] = $search->combine( '&&', $tmp ); |
||
414 | } |
||
415 | |||
416 | $search->setConditions( $search->combine( '||', $expr ) ); |
||
417 | return $attributeManager->searchItems( $search, array( 'price' ) ); |
||
418 | } |
||
419 | |||
420 | |||
421 | /** |
||
422 | * Returns the order product attribute items for the given IDs and values |
||
423 | * |
||
424 | * @param string $type Attribute type code |
||
425 | * @param array $ids List of attributes IDs of the given type |
||
426 | * @param array $values Associative list of attribute IDs as keys and their codes as values |
||
427 | * @param array $quantities Associative list of attribute IDs as keys and their quantities as values |
||
428 | * @return array List of items implementing \Aimeos\MShop\Order\Item\Product\Attribute\Iface |
||
429 | */ |
||
430 | protected function getOrderProductAttributes( $type, array $ids, array $values = [], array $quantities = [] ) |
||
454 | } |
||
455 | |||
456 | |||
457 | /** |
||
458 | * Returns the list type item for the given domain and code. |
||
459 | * |
||
460 | * @param string $domain Domain name of the list type |
||
461 | * @param string $code Code of the list type |
||
462 | * @return \Aimeos\MShop\Common\Item\Type\Iface List type item |
||
463 | */ |
||
464 | protected function getProductListTypeItem( $domain, $code ) |
||
465 | { |
||
466 | $context = $this->getContext(); |
||
467 | |||
468 | if( empty( $this->listTypeItems ) ) |
||
469 | { |
||
470 | $manager = \Aimeos\MShop::create( $context, 'product/lists/type' ); |
||
471 | |||
472 | foreach( $manager->searchItems( $manager->createSearch( true ) ) as $item ) { |
||
473 | $this->listTypeItems[ $item->getDomain() ][ $item->getCode() ] = $item; |
||
2 ignored issues
–
show
|
|||
474 | } |
||
475 | } |
||
476 | |||
477 | if( !isset( $this->listTypeItems[$domain][$code] ) ) |
||
478 | { |
||
479 | $msg = $context->getI18n()->dt( 'controller/frontend', 'List type for domain "%1$s" and code "%2$s" not found' ); |
||
480 | throw new \Aimeos\Controller\Frontend\Basket\Exception( sprintf( $msg, $domain, $code ) ); |
||
481 | } |
||
482 | |||
483 | return $this->listTypeItems[$domain][$code]; |
||
484 | } |
||
485 | |||
486 | |||
487 | /** |
||
488 | * Returns the product variants of a selection product that match the given attributes. |
||
489 | * |
||
490 | * @param \Aimeos\MShop\Product\Item\Iface $productItem Product item including sub-products |
||
491 | * @param array $variantAttributeIds IDs for the variant-building attributes |
||
492 | * @param array $domains Names of the domain items that should be fetched too |
||
493 | * @return array List of products matching the given attributes |
||
494 | */ |
||
495 | protected function getProductVariants( \Aimeos\MShop\Product\Item\Iface $productItem, array $variantAttributeIds, |
||
524 | } |
||
525 | |||
526 | |||
527 | /** |
||
528 | * Returns the value of an array or the default value if it's not available. |
||
529 | * |
||
530 | * @param array $values Associative list of key/value pairs |
||
531 | * @param string $name Name of the key to return the value for |
||
532 | * @param mixed $default Default value if no value is available for the given name |
||
533 | * @return mixed Value from the array or default value |
||
534 | */ |
||
535 | protected function getValue( array $values, $name, $default = null ) |
||
542 | } |
||
543 | } |
||
544 |