Inspection of "Pass provider type explicitely to getProvider()" - aimeos/ai-controller-frontend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 87706b...b447e5 )

by Aimeos

created 2017-11-09 12:31 UTC

Status

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -18,31 +18,31 @@
 block discarded – undo
 	{
 		$context = \TestHelperFrontend::getContext();
 
-		$this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Base' )
-			->setConstructorArgs( [$context] )
+		$this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Base')
+			->setConstructorArgs([$context])
 			->getMockForAbstractClass();
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->object );
+		unset($this->object);
 	}
 
 
 	public function testGetContext()
 	{
-		$result = $this->access( 'getContext' )->invokeArgs( $this->object, [] );
+		$result = $this->access('getContext')->invokeArgs($this->object, []);
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Context\Item\Iface', $result );
+		$this->assertInstanceOf('\Aimeos\MShop\Context\Item\Iface', $result);
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Base' );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Base');
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}

Please login to merge, or discard this patch.

frontend/tests/Controller/Frontend/Product/Decorator/BaseTest.php 1 patch

Spacing +51 added lines, -51 removed lines patch added patch discarded remove patch

@@ -20,150 +20,150 @@
 block discarded – undo
 	{
 		$this->context = \TestHelperFrontend::getContext();
 
-		$this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Product\Standard' )
+		$this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Product\Standard')
 			->disableOriginalConstructor()
 			->getMock();
 
-		$this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Product\Decorator\Base' )
-			->setConstructorArgs( [$this->stub, $this->context] )
+		$this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Product\Decorator\Base')
+			->setConstructorArgs([$this->stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->context, $this->object, $this->stub );
+		unset($this->context, $this->object, $this->stub);
 	}
 
 
 	public function testConstructException()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
 
-		$this->setExpectedException( '\Aimeos\Controller\Frontend\Exception' );
+		$this->setExpectedException('\Aimeos\Controller\Frontend\Exception');
 
-		$this->getMockBuilder( '\Aimeos\Controller\Frontend\Product\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$this->getMockBuilder('\Aimeos\Controller\Frontend\Product\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	public function testCall()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Product\Standard' )
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Product\Standard')
 			->disableOriginalConstructor()
-			->setMethods( ['invalid'] )
+			->setMethods(['invalid'])
 			->getMock();
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Product\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Product\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 
-		$stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
+		$stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
 
-		$this->assertTrue( $object->invalid() );
+		$this->assertTrue($object->invalid());
 	}
 
 
 	public function testAddFilterAttribute()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'addFilterAttribute' )
-			->will( $this->returnArgument( 0 ) );
+		$this->stub->expects($this->once())->method('addFilterAttribute')
+			->will($this->returnArgument(0));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterAttribute( $search, [], [], [] ) );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterAttribute($search, [], [], []));
 	}
 
 
 	public function testAddFilterCategory()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'addFilterCategory' )
-			->will( $this->returnArgument( 0 ) );
+		$this->stub->expects($this->once())->method('addFilterCategory')
+			->will($this->returnArgument(0));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterCategory( $search, -1 ) );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterCategory($search, -1));
 	}
 
 
 	public function testAddFilterText()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'addFilterText' )
-			->will( $this->returnArgument( 0 ) );
+		$this->stub->expects($this->once())->method('addFilterText')
+			->will($this->returnArgument(0));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterText( $search, 'test' ) );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterText($search, 'test'));
 	}
 
 
 	public function testAggregate()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'aggregate' )
-			->will( $this->returnValue( [] ) );
+		$this->stub->expects($this->once())->method('aggregate')
+			->will($this->returnValue([]));
 
-		$this->assertEquals( [], $this->object->aggregate( $search, 'test' ) );
+		$this->assertEquals([], $this->object->aggregate($search, 'test'));
 	}
 
 
 	public function testCreateFilter()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'createFilter' )
-			->will( $this->returnValue( $search ) );
+		$this->stub->expects($this->once())->method('createFilter')
+			->will($this->returnValue($search));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->createFilter() );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->createFilter());
 	}
 
 
 	public function testGetItem()
 	{
-		$prodItem = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createItem();
+		$prodItem = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'getItem' )
-			->will( $this->returnValue( $prodItem ) );
+		$this->stub->expects($this->once())->method('getItem')
+			->will($this->returnValue($prodItem));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Product\Item\Iface', $this->object->getItem( -1 ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Product\Item\Iface', $this->object->getItem( -1 ));
 	}
 
 
 	public function testGetItems()
 	{
-		$this->stub->expects( $this->once() )->method( 'getItems' )
-			->will( $this->returnValue( [] ) );
+		$this->stub->expects($this->once())->method('getItems')
+			->will($this->returnValue([]));
 
-		$this->assertEquals( [], $this->object->getItems( [-1] ) );
+		$this->assertEquals([], $this->object->getItems([-1]));
 	}
 
 
 	public function testSearchItems()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( [] ) );
+		$this->stub->expects($this->once())->method('searchItems')
+			->will($this->returnValue([]));
 
-		$this->assertEquals( [], $this->object->searchItems( $search ) );
+		$this->assertEquals([], $this->object->searchItems($search));
 	}
 
 
 	public function testGetController()
 	{
-		$result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
+		$result = $this->access('getController')->invokeArgs($this->object, []);
 
-		$this->assertSame( $this->stub, $result );
+		$this->assertSame($this->stub, $result);
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Product\Decorator\Base' );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Product\Decorator\Base');
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/Stock/Decorator/BaseTest.php 1 patch

Spacing +40 added lines, -40 removed lines patch added patch discarded remove patch

@@ -20,119 +20,119 @@
 block discarded – undo
 	{
 		$this->context = \TestHelperFrontend::getContext();
 
-		$this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Standard' )
+		$this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Standard')
 			->disableOriginalConstructor()
 			->getMock();
 
-		$this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
-			->setConstructorArgs( [$this->stub, $this->context] )
+		$this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
+			->setConstructorArgs([$this->stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->context, $this->object, $this->stub );
+		unset($this->context, $this->object, $this->stub);
 	}
 
 
 	public function testConstructException()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
 
-		$this->setExpectedException( '\Aimeos\Controller\Frontend\Exception' );
+		$this->setExpectedException('\Aimeos\Controller\Frontend\Exception');
 
-		$this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	public function testCall()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Standard' )
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Standard')
 			->disableOriginalConstructor()
-			->setMethods( ['invalid'] )
+			->setMethods(['invalid'])
 			->getMock();
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 
-		$stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
+		$stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
 
-		$this->assertTrue( $object->invalid() );
+		$this->assertTrue($object->invalid());
 	}
 
 
 	public function testAddFilterCodes()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'addFilterCodes' )
-			->will( $this->returnArgument( 0 ) );
+		$this->stub->expects($this->once())->method('addFilterCodes')
+			->will($this->returnArgument(0));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterCodes( $search, [] ) );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterCodes($search, []));
 	}
 
 
 	public function testAddFilterTypes()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'addFilterTypes' )
-			->will( $this->returnArgument( 0 ) );
+		$this->stub->expects($this->once())->method('addFilterTypes')
+			->will($this->returnArgument(0));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes( $search, [] ) );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes($search, []));
 	}
 
 
 	public function testCreateFilter()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'createFilter' )
-			->will( $this->returnValue( $search ) );
+		$this->stub->expects($this->once())->method('createFilter')
+			->will($this->returnValue($search));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->createFilter() );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->createFilter());
 	}
 
 
 	public function testGetItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'getItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('getItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Stock\Item\Iface', $this->object->getItem( -1 ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Stock\Item\Iface', $this->object->getItem( -1 ));
 	}
 
 
 	public function testSearchItems()
 	{
-		$filter = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
+		$filter = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( [] ) );
+		$this->stub->expects($this->once())->method('searchItems')
+			->will($this->returnValue([]));
 
-		$this->assertEquals( [], $this->object->searchItems( $filter ) );
+		$this->assertEquals([], $this->object->searchItems($filter));
 	}
 
 
 	public function testGetController()
 	{
-		$result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
+		$result = $this->access('getController')->invokeArgs($this->object, []);
 
-		$this->assertSame( $this->stub, $result );
+		$this->assertSame($this->stub, $result);
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Stock\Decorator\Base');
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}

Please login to merge, or discard this patch.

controller/frontend/src/Controller/Frontend/Attribute/Iface.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes );
+	public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes);
 
 
 	/**
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Attribute\Item\Iface Attribute item including the referenced domains items
 	 * @since 2017.03
 	 */
-	public function getItem( $id, array $domains = array( 'media', 'price', 'text' ) );
+	public function getItem($id, array $domains = array('media', 'price', 'text'));
 
 
 	/**
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Attribute\Item\Iface[] Associative list of attribute item including the referenced domains items
 	 * @since 2017.03
 	 */
-	public function getItems( array $ids, array $domains = array( 'media', 'price', 'text' ) );
+	public function getItems(array $ids, array $domains = array('media', 'price', 'text'));
 
 
 	/**
@@ -70,5 +70,5 @@  discard block
 block discarded – undo
 	 * @return array Ordered list of attribute items implementing \Aimeos\MShop\Attribute\Item\Iface
 	 * @since 2017.03
 	 */
-	public function searchItems( \Aimeos\MW\Criteria\Iface $filter, array $domains = array( 'media', 'price', 'text' ), &$total = null );
+	public function searchItems(\Aimeos\MW\Criteria\Iface $filter, array $domains = array('media', 'price', 'text'), &$total = null);
 }

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/Attribute/StandardTest.php 1 patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

@@ -16,13 +16,13 @@  discard block
 block discarded – undo
 
 	protected function setUp()
 	{
-		$this->object = new \Aimeos\Controller\Frontend\Attribute\Standard( \TestHelperFrontend::getContext() );
+		$this->object = new \Aimeos\Controller\Frontend\Attribute\Standard(\TestHelperFrontend::getContext());
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->object );
+		unset($this->object);
 	}
 
 
@@ -30,57 +30,57 @@  discard block
 block discarded – undo
 	{
 		$filter = $this->object->createFilter();
 
-		$this->assertInstanceOf( '\\Aimeos\\MW\\Criteria\\Iface', $filter );
-		$this->assertEquals( 1, count( $filter->getSortations() ) );
-		$this->assertEquals( 0, $filter->getSliceStart() );
-		$this->assertEquals( 100, $filter->getSliceSize() );
+		$this->assertInstanceOf('\\Aimeos\\MW\\Criteria\\Iface', $filter);
+		$this->assertEquals(1, count($filter->getSortations()));
+		$this->assertEquals(0, $filter->getSliceStart());
+		$this->assertEquals(100, $filter->getSliceSize());
 	}
 
 
 	public function testAddFilterTypes()
 	{
 		$filter = $this->object->createFilter();
-		$filter = $this->object->addFilterTypes( $filter, ['size'] );
+		$filter = $this->object->addFilterTypes($filter, ['size']);
 
 		$list = $filter->getConditions()->getExpressions();
 
-		if( !isset( $list[0] ) || !( $list[0] instanceof \Aimeos\MW\Criteria\Expression\Compare\Iface ) ) {
-			throw new \RuntimeException( 'Wrong expression' );
+		if (!isset($list[0]) || !($list[0] instanceof \Aimeos\MW\Criteria\Expression\Compare\Iface)) {
+			throw new \RuntimeException('Wrong expression');
 		}
 
-		$this->assertEquals( 'attribute.type.code', $list[0]->getName() );
-		$this->assertEquals( 1, count( $list[0]->getValue() ) );
+		$this->assertEquals('attribute.type.code', $list[0]->getName());
+		$this->assertEquals(1, count($list[0]->getValue()));
 	}
 
 
 	public function testGetItem()
 	{
 		$context = \TestHelperFrontend::getContext();
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'attribute' );
-		$id = $manager->findItem( 'xs', [], 'product', 'size' )->getId();
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'attribute');
+		$id = $manager->findItem('xs', [], 'product', 'size')->getId();
 
-		$result = $this->object->getItem( $id, ['text'] );
+		$result = $this->object->getItem($id, ['text']);
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Attribute\Item\Iface', $result );
-		$this->assertEquals( 3, count( $result->getRefItems( 'text' ) ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Attribute\Item\Iface', $result);
+		$this->assertEquals(3, count($result->getRefItems('text')));
 	}
 
 
 	public function testGetItems()
 	{
 		$context = \TestHelperFrontend::getContext();
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'attribute' );
-		$id = $manager->findItem( 'xs', [], 'product', 'size' )->getId();
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'attribute');
+		$id = $manager->findItem('xs', [], 'product', 'size')->getId();
 
-		$result = $this->object->getItems( [$id], ['text'] );
+		$result = $this->object->getItems([$id], ['text']);
 
-		$this->assertInternalType( 'array', $result );
-		$this->assertEquals( 1, count( $result ) );
+		$this->assertInternalType('array', $result);
+		$this->assertEquals(1, count($result));
 
-		foreach( $result as $attrItem )
+		foreach ($result as $attrItem)
 		{
-			$this->assertInstanceOf( '\Aimeos\MShop\Attribute\Item\Iface', $attrItem );
-			$this->assertEquals( 3, count( $attrItem->getRefItems( 'text' ) ) );
+			$this->assertInstanceOf('\Aimeos\MShop\Attribute\Item\Iface', $attrItem);
+			$this->assertEquals(3, count($attrItem->getRefItems('text')));
 		}
 	}
 
@@ -88,12 +88,12 @@  discard block
 block discarded – undo
 	public function testSearchItems()
 	{
 		$filter = $this->object->createFilter();
-		$filter = $this->object->addFilterTypes( $filter, ['size'] );
+		$filter = $this->object->addFilterTypes($filter, ['size']);
 
 		$total = 0;
-		$results = $this->object->searchItems( $filter, ['text'], $total );
+		$results = $this->object->searchItems($filter, ['text'], $total);
 
-		$this->assertEquals( 6, $total );
-		$this->assertEquals( 6, count( $results ) );
+		$this->assertEquals(6, $total);
+		$this->assertEquals(6, count($results));
 	}
 }

Please login to merge, or discard this patch.

frontend/tests/Controller/Frontend/Attribute/Decorator/BaseTest.php 1 patch

Spacing +39 added lines, -39 removed lines patch added patch discarded remove patch

@@ -20,117 +20,117 @@
 block discarded – undo
 	{
 		$this->context = \TestHelperFrontend::getContext();
 
-		$this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Attribute\Standard' )
+		$this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Attribute\Standard')
 			->disableOriginalConstructor()
 			->getMock();
 
-		$this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Attribute\Decorator\Base' )
-			->setConstructorArgs( [$this->stub, $this->context] )
+		$this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Attribute\Decorator\Base')
+			->setConstructorArgs([$this->stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->context, $this->object, $this->stub );
+		unset($this->context, $this->object, $this->stub);
 	}
 
 
 	public function testConstructException()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
 
-		$this->setExpectedException( '\Aimeos\Controller\Frontend\Exception' );
+		$this->setExpectedException('\Aimeos\Controller\Frontend\Exception');
 
-		$this->getMockBuilder( '\Aimeos\Controller\Frontend\Attribute\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$this->getMockBuilder('\Aimeos\Controller\Frontend\Attribute\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	public function testCall()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Attribute\Standard' )
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Attribute\Standard')
 			->disableOriginalConstructor()
-			->setMethods( ['invalid'] )
+			->setMethods(['invalid'])
 			->getMock();
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Attribute\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Attribute\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 
-		$stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
+		$stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
 
-		$this->assertTrue( $object->invalid() );
+		$this->assertTrue($object->invalid());
 	}
 
 
 	public function testAddFilterTypes()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'attribute' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'attribute')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'addFilterTypes' )
-			->will( $this->returnArgument( 0 ) );
+		$this->stub->expects($this->once())->method('addFilterTypes')
+			->will($this->returnArgument(0));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes( $search, [] ) );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes($search, []));
 	}
 
 
 	public function testCreateFilter()
 	{
-		$search = \Aimeos\MShop\Factory::createManager( $this->context, 'attribute' )->createSearch();
+		$search = \Aimeos\MShop\Factory::createManager($this->context, 'attribute')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'createFilter' )
-			->will( $this->returnValue( $search ) );
+		$this->stub->expects($this->once())->method('createFilter')
+			->will($this->returnValue($search));
 
-		$this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->createFilter() );
+		$this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->createFilter());
 	}
 
 
 	public function testGetItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'attribute' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'attribute')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'getItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('getItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Attribute\Item\Iface', $this->object->getItem( -1 ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Attribute\Item\Iface', $this->object->getItem( -1 ));
 	}
 
 
 	public function testGetItems()
 	{
-		$this->stub->expects( $this->once() )->method( 'getItems' )
-			->will( $this->returnValue( [] ) );
+		$this->stub->expects($this->once())->method('getItems')
+			->will($this->returnValue([]));
 
-		$this->assertEquals( [], $this->object->getItems( [-1], ['media'] ) );
+		$this->assertEquals([], $this->object->getItems([-1], ['media']));
 	}
 
 
 	public function testSearchItems()
 	{
-		$filter = \Aimeos\MShop\Factory::createManager( $this->context, 'attribute' )->createSearch();
+		$filter = \Aimeos\MShop\Factory::createManager($this->context, 'attribute')->createSearch();
 
-		$this->stub->expects( $this->once() )->method( 'searchItems' )
-			->will( $this->returnValue( [] ) );
+		$this->stub->expects($this->once())->method('searchItems')
+			->will($this->returnValue([]));
 
-		$this->assertEquals( [], $this->object->searchItems( $filter, ['media'] ) );
+		$this->assertEquals([], $this->object->searchItems($filter, ['media']));
 	}
 
 
 	public function testGetController()
 	{
-		$result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
+		$result = $this->access('getController')->invokeArgs($this->object, []);
 
-		$this->assertSame( $this->stub, $result );
+		$this->assertSame($this->stub, $result);
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Attribute\Decorator\Base' );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Attribute\Decorator\Base');
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/FactoryTest.php 1 patch

Spacing +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -14,92 +14,92 @@
 block discarded – undo
 {
 	public function testCreateController()
 	{
-		$controller = \Aimeos\Controller\Frontend\Factory::createController( \TestHelperFrontend::getContext(), 'basket' );
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Frontend\\Iface', $controller );
+		$controller = \Aimeos\Controller\Frontend\Factory::createController(\TestHelperFrontend::getContext(), 'basket');
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Frontend\\Iface', $controller);
 	}
 
 
 	public function testCreateControllerEmpty()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Factory::createController( \TestHelperFrontend::getContext(), '' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Factory::createController(\TestHelperFrontend::getContext(), '');
 	}
 
 
 	public function testCreateControllerInvalidName()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Factory::createController(\TestHelperFrontend::getContext(), '%^');
 	}
 
 
 	public function testCreateControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
 	}
 
 
 	public function testCreateSubControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Factory::createController( \TestHelperFrontend::getContext(), 'basket/notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Factory::createController(\TestHelperFrontend::getContext(), 'basket/notexist');
 	}
 
 
 	public function testClear()
 	{
-		$cache = \Aimeos\Controller\Frontend\Factory::setCache( true );
+		$cache = \Aimeos\Controller\Frontend\Factory::setCache(true);
 
 		$context = \TestHelperFrontend::getContext();
 
-		$controller1 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
+		$controller1 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
 		\Aimeos\Controller\Frontend\Factory::clear();
-		$controller2 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
+		$controller2 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
 
-		\Aimeos\Controller\Frontend\Factory::setCache( $cache );
+		\Aimeos\Controller\Frontend\Factory::setCache($cache);
 
-		$this->assertNotSame( $controller1, $controller2 );
+		$this->assertNotSame($controller1, $controller2);
 	}
 
 
 	public function testClearSite()
 	{
-		$cache = \Aimeos\Controller\Frontend\Factory::setCache( true );
+		$cache = \Aimeos\Controller\Frontend\Factory::setCache(true);
 
 		$context = \TestHelperFrontend::getContext();
 
-		$basket1 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
-		$catalog1 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'catalog' );
-		\Aimeos\Controller\Frontend\Factory::clear( (string) $context );
+		$basket1 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
+		$catalog1 = \Aimeos\Controller\Frontend\Factory::createController($context, 'catalog');
+		\Aimeos\Controller\Frontend\Factory::clear((string) $context);
 
-		$basket2 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
-		$catalog2 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'catalog' );
+		$basket2 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
+		$catalog2 = \Aimeos\Controller\Frontend\Factory::createController($context, 'catalog');
 
-		\Aimeos\Controller\Frontend\Factory::setCache( $cache );
+		\Aimeos\Controller\Frontend\Factory::setCache($cache);
 
-		$this->assertNotSame( $basket1, $basket2 );
-		$this->assertNotSame( $catalog1, $catalog2 );
+		$this->assertNotSame($basket1, $basket2);
+		$this->assertNotSame($catalog1, $catalog2);
 	}
 
 
 	public function testClearSpecific()
 	{
-		$cache = \Aimeos\Controller\Frontend\Factory::setCache( true );
+		$cache = \Aimeos\Controller\Frontend\Factory::setCache(true);
 
 		$context = \TestHelperFrontend::getContext();
 
-		$basket1 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
-		$catalog1 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'catalog' );
-		\Aimeos\Controller\Frontend\Factory::clear( (string) $context, 'basket' );
+		$basket1 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
+		$catalog1 = \Aimeos\Controller\Frontend\Factory::createController($context, 'catalog');
+		\Aimeos\Controller\Frontend\Factory::clear((string) $context, 'basket');
 
-		$basket2 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
-		$catalog2 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'catalog' );
+		$basket2 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
+		$catalog2 = \Aimeos\Controller\Frontend\Factory::createController($context, 'catalog');
 
-		\Aimeos\Controller\Frontend\Factory::setCache( $cache );
+		\Aimeos\Controller\Frontend\Factory::setCache($cache);
 
-		$this->assertNotSame( $basket1, $basket2 );
-		$this->assertSame( $catalog1, $catalog2 );
+		$this->assertNotSame($basket1, $basket2);
+		$this->assertSame($catalog1, $catalog2);
 	}
 
 }
\ No newline at end of file

Please login to merge, or discard this patch.

controller/frontend/src/Controller/Frontend/Locale/Decorator/Base.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -104,7 +104,7 @@
 block discarded – undo
 	/**
 	 * Returns the frontend controller
 	 *
-	 * @return \Aimeos\Controller\Frontend\Locale\Iface Frontend controller object
+	 * @return \Aimeos\Controller\Frontend\Iface Frontend controller object
 	 */
 	protected function getController()
 	{

Please login to merge, or discard this patch.

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -30,18 +30,18 @@  discard block
 block discarded – undo
 	 * @param \Aimeos\Controller\Frontend\Iface $controller Controller object
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
 	 */
-	public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
+	public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
 	{
 		$iface = '\Aimeos\Controller\Frontend\Locale\Iface';
-		if( !( $controller instanceof $iface ) )
+		if (!($controller instanceof $iface))
 		{
-			$msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
-			throw new \Aimeos\Controller\Frontend\Exception( $msg );
+			$msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
+			throw new \Aimeos\Controller\Frontend\Exception($msg);
 		}
 
 		$this->controller = $controller;
 
-		parent::__construct( $context );
+		parent::__construct($context);
 	}
 
 
@@ -53,9 +53,9 @@  discard block
 block discarded – undo
 	 * @return mixed Returns the value of the called method
 	 * @throws \Aimeos\Controller\Frontend\Exception If method call failed
 	 */
-	public function __call( $name, array $param )
+	public function __call($name, array $param)
 	{
-		return @call_user_func_array( array( $this->controller, $name ), $param );
+		return @call_user_func_array(array($this->controller, $name), $param);
 	}
 
 
@@ -80,9 +80,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Locale\Item\Iface Locale item including the referenced domains items
 	 * @since 2017.03
 	 */
-	public function getItem( $id, array $domains = [] )
+	public function getItem($id, array $domains = [])
 	{
-		return $this->controller->getItem( $id, $domains );
+		return $this->controller->getItem($id, $domains);
 	}
 
 
@@ -95,9 +95,9 @@  discard block
 block discarded – undo
 	 * @return array Ordered list of locale items implementing \Aimeos\MShop\Locale\Item\Iface
 	 * @since 2017.03
 	 */
-	public function searchItems( \Aimeos\MW\Criteria\Iface $filter, array $domains = [], &$total = null )
+	public function searchItems(\Aimeos\MW\Criteria\Iface $filter, array $domains = [], &$total = null)
 	{
-		return $this->controller->searchItems( $filter, $domains, $total );
+		return $this->controller->searchItems($filter, $domains, $total);
 	}
 
 

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/Locale/FactoryTest.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -15,31 +15,31 @@
 block discarded – undo
 	{
 		$target = '\\Aimeos\\Controller\\Frontend\\Locale\\Iface';
 
-		$controller = \Aimeos\Controller\Frontend\Locale\Factory::createController( \TestHelperFrontend::getContext() );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Locale\Factory::createController(\TestHelperFrontend::getContext());
+		$this->assertInstanceOf($target, $controller);
 
-		$controller = \Aimeos\Controller\Frontend\Locale\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Locale\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
+		$this->assertInstanceOf($target, $controller);
 	}
 
 
 	public function testCreateControllerInvalidImplementation()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Locale\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Locale\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
 	}
 
 
 	public function testCreateControllerInvalidName()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Locale\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Locale\Factory::createController(\TestHelperFrontend::getContext(), '%^');
 	}
 
 
 	public function testCreateControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Locale\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Locale\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
 	}
 }

Please login to merge, or discard this patch.

		@@ -20,119 +20,119 @@
		block discarded – undo
20	20	{
21	21	$this->context = \TestHelperFrontend::getContext();
22	22
23		- $this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Standard' )
	23	+ $this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Standard')
24	24	->disableOriginalConstructor()
25	25	->getMock();
26	26
27		- $this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
28		- ->setConstructorArgs( [$this->stub, $this->context] )
	27	+ $this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
	28	+ ->setConstructorArgs([$this->stub, $this->context])
29	29	->getMockForAbstractClass();
30	30	}
31	31
32	32
33	33	protected function tearDown()
34	34	{
35		- unset( $this->context, $this->object, $this->stub );
	35	+ unset($this->context, $this->object, $this->stub);
36	36	}
37	37
38	38
39	39	public function testConstructException()
40	40	{
41		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
	41	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
42	42
43		- $this->setExpectedException( '\Aimeos\Controller\Frontend\Exception' );
	43	+ $this->setExpectedException('\Aimeos\Controller\Frontend\Exception');
44	44
45		- $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
46		- ->setConstructorArgs( [$stub, $this->context] )
	45	+ $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
	46	+ ->setConstructorArgs([$stub, $this->context])
47	47	->getMockForAbstractClass();
48	48	}
49	49
50	50
51	51	public function testCall()
52	52	{
53		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Standard' )
	53	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Standard')
54	54	->disableOriginalConstructor()
55		- ->setMethods( ['invalid'] )
	55	+ ->setMethods(['invalid'])
56	56	->getMock();
57	57
58		- $object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' )
59		- ->setConstructorArgs( [$stub, $this->context] )
	58	+ $object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Stock\Decorator\Base')
	59	+ ->setConstructorArgs([$stub, $this->context])
60	60	->getMockForAbstractClass();
61	61
62		- $stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
	62	+ $stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
63	63
64		- $this->assertTrue( $object->invalid() );
	64	+ $this->assertTrue($object->invalid());
65	65	}
66	66
67	67
68	68	public function testAddFilterCodes()
69	69	{
70		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
	70	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
71	71
72		- $this->stub->expects( $this->once() )->method( 'addFilterCodes' )
73		- ->will( $this->returnArgument( 0 ) );
	72	+ $this->stub->expects($this->once())->method('addFilterCodes')
	73	+ ->will($this->returnArgument(0));
74	74
75		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterCodes( $search, [] ) );
	75	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterCodes($search, []));
76	76	}
77	77
78	78
79	79	public function testAddFilterTypes()
80	80	{
81		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
	81	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
82	82
83		- $this->stub->expects( $this->once() )->method( 'addFilterTypes' )
84		- ->will( $this->returnArgument( 0 ) );
	83	+ $this->stub->expects($this->once())->method('addFilterTypes')
	84	+ ->will($this->returnArgument(0));
85	85
86		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes( $search, [] ) );
	86	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes($search, []));
87	87	}
88	88
89	89
90	90	public function testCreateFilter()
91	91	{
92		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
	92	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
93	93
94		- $this->stub->expects( $this->once() )->method( 'createFilter' )
95		- ->will( $this->returnValue( $search ) );
	94	+ $this->stub->expects($this->once())->method('createFilter')
	95	+ ->will($this->returnValue($search));
96	96
97		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->createFilter() );
	97	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->createFilter());
98	98	}
99	99
100	100
101	101	public function testGetItem()
102	102	{
103		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createItem();
	103	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createItem();
104	104
105		- $this->stub->expects( $this->once() )->method( 'getItem' )
106		- ->will( $this->returnValue( $item ) );
	105	+ $this->stub->expects($this->once())->method('getItem')
	106	+ ->will($this->returnValue($item));
107	107
108		- $this->assertInstanceOf( '\Aimeos\MShop\Stock\Item\Iface', $this->object->getItem( -1 ) );
	108	+ $this->assertInstanceOf('\Aimeos\MShop\Stock\Item\Iface', $this->object->getItem( -1 ));
109	109	}
110	110
111	111
112	112	public function testSearchItems()
113	113	{
114		- $filter = \Aimeos\MShop\Factory::createManager( $this->context, 'stock' )->createSearch();
	114	+ $filter = \Aimeos\MShop\Factory::createManager($this->context, 'stock')->createSearch();
115	115
116		- $this->stub->expects( $this->once() )->method( 'searchItems' )
117		- ->will( $this->returnValue( [] ) );
	116	+ $this->stub->expects($this->once())->method('searchItems')
	117	+ ->will($this->returnValue([]));
118	118
119		- $this->assertEquals( [], $this->object->searchItems( $filter ) );
	119	+ $this->assertEquals([], $this->object->searchItems($filter));
120	120	}
121	121
122	122
123	123	public function testGetController()
124	124	{
125		- $result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
	125	+ $result = $this->access('getController')->invokeArgs($this->object, []);
126	126
127		- $this->assertSame( $this->stub, $result );
	127	+ $this->assertSame($this->stub, $result);
128	128	}
129	129
130	130
131		- protected function access( $name )
	131	+ protected function access($name)
132	132	{
133		- $class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Stock\Decorator\Base' );
134		- $method = $class->getMethod( $name );
135		- $method->setAccessible( true );
	133	+ $class = new \ReflectionClass('\Aimeos\Controller\Frontend\Stock\Decorator\Base');
	134	+ $method = $class->getMethod($name);
	135	+ $method->setAccessible(true);
136	136
137	137	return $method;
138	138	}

		@@ -20,117 +20,117 @@
		block discarded – undo
20	20	{
21	21	$this->context = \TestHelperFrontend::getContext();
22	22
23		- $this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Attribute\Standard' )
	23	+ $this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Attribute\Standard')
24	24	->disableOriginalConstructor()
25	25	->getMock();
26	26
27		- $this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Attribute\Decorator\Base' )
28		- ->setConstructorArgs( [$this->stub, $this->context] )
	27	+ $this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Attribute\Decorator\Base')
	28	+ ->setConstructorArgs([$this->stub, $this->context])
29	29	->getMockForAbstractClass();
30	30	}
31	31
32	32
33	33	protected function tearDown()
34	34	{
35		- unset( $this->context, $this->object, $this->stub );
	35	+ unset($this->context, $this->object, $this->stub);
36	36	}
37	37
38	38
39	39	public function testConstructException()
40	40	{
41		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
	41	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
42	42
43		- $this->setExpectedException( '\Aimeos\Controller\Frontend\Exception' );
	43	+ $this->setExpectedException('\Aimeos\Controller\Frontend\Exception');
44	44
45		- $this->getMockBuilder( '\Aimeos\Controller\Frontend\Attribute\Decorator\Base' )
46		- ->setConstructorArgs( [$stub, $this->context] )
	45	+ $this->getMockBuilder('\Aimeos\Controller\Frontend\Attribute\Decorator\Base')
	46	+ ->setConstructorArgs([$stub, $this->context])
47	47	->getMockForAbstractClass();
48	48	}
49	49
50	50
51	51	public function testCall()
52	52	{
53		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Attribute\Standard' )
	53	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Attribute\Standard')
54	54	->disableOriginalConstructor()
55		- ->setMethods( ['invalid'] )
	55	+ ->setMethods(['invalid'])
56	56	->getMock();
57	57
58		- $object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Attribute\Decorator\Base' )
59		- ->setConstructorArgs( [$stub, $this->context] )
	58	+ $object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Attribute\Decorator\Base')
	59	+ ->setConstructorArgs([$stub, $this->context])
60	60	->getMockForAbstractClass();
61	61
62		- $stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
	62	+ $stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
63	63
64		- $this->assertTrue( $object->invalid() );
	64	+ $this->assertTrue($object->invalid());
65	65	}
66	66
67	67
68	68	public function testAddFilterTypes()
69	69	{
70		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'attribute' )->createSearch();
	70	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'attribute')->createSearch();
71	71
72		- $this->stub->expects( $this->once() )->method( 'addFilterTypes' )
73		- ->will( $this->returnArgument( 0 ) );
	72	+ $this->stub->expects($this->once())->method('addFilterTypes')
	73	+ ->will($this->returnArgument(0));
74	74
75		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes( $search, [] ) );
	75	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterTypes($search, []));
76	76	}
77	77
78	78
79	79	public function testCreateFilter()
80	80	{
81		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'attribute' )->createSearch();
	81	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'attribute')->createSearch();
82	82
83		- $this->stub->expects( $this->once() )->method( 'createFilter' )
84		- ->will( $this->returnValue( $search ) );
	83	+ $this->stub->expects($this->once())->method('createFilter')
	84	+ ->will($this->returnValue($search));
85	85
86		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->createFilter() );
	86	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->createFilter());
87	87	}
88	88
89	89
90	90	public function testGetItem()
91	91	{
92		- $item = \Aimeos\MShop\Factory::createManager( $this->context, 'attribute' )->createItem();
	92	+ $item = \Aimeos\MShop\Factory::createManager($this->context, 'attribute')->createItem();
93	93
94		- $this->stub->expects( $this->once() )->method( 'getItem' )
95		- ->will( $this->returnValue( $item ) );
	94	+ $this->stub->expects($this->once())->method('getItem')
	95	+ ->will($this->returnValue($item));
96	96
97		- $this->assertInstanceOf( '\Aimeos\MShop\Attribute\Item\Iface', $this->object->getItem( -1 ) );
	97	+ $this->assertInstanceOf('\Aimeos\MShop\Attribute\Item\Iface', $this->object->getItem( -1 ));
98	98	}
99	99
100	100
101	101	public function testGetItems()
102	102	{
103		- $this->stub->expects( $this->once() )->method( 'getItems' )
104		- ->will( $this->returnValue( [] ) );
	103	+ $this->stub->expects($this->once())->method('getItems')
	104	+ ->will($this->returnValue([]));
105	105
106		- $this->assertEquals( [], $this->object->getItems( [-1], ['media'] ) );
	106	+ $this->assertEquals([], $this->object->getItems([-1], ['media']));
107	107	}
108	108
109	109
110	110	public function testSearchItems()
111	111	{
112		- $filter = \Aimeos\MShop\Factory::createManager( $this->context, 'attribute' )->createSearch();
	112	+ $filter = \Aimeos\MShop\Factory::createManager($this->context, 'attribute')->createSearch();
113	113
114		- $this->stub->expects( $this->once() )->method( 'searchItems' )
115		- ->will( $this->returnValue( [] ) );
	114	+ $this->stub->expects($this->once())->method('searchItems')
	115	+ ->will($this->returnValue([]));
116	116
117		- $this->assertEquals( [], $this->object->searchItems( $filter, ['media'] ) );
	117	+ $this->assertEquals([], $this->object->searchItems($filter, ['media']));
118	118	}
119	119
120	120
121	121	public function testGetController()
122	122	{
123		- $result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
	123	+ $result = $this->access('getController')->invokeArgs($this->object, []);
124	124
125		- $this->assertSame( $this->stub, $result );
	125	+ $this->assertSame($this->stub, $result);
126	126	}
127	127
128	128
129		- protected function access( $name )
	129	+ protected function access($name)
130	130	{
131		- $class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Attribute\Decorator\Base' );
132		- $method = $class->getMethod( $name );
133		- $method->setAccessible( true );
	131	+ $class = new \ReflectionClass('\Aimeos\Controller\Frontend\Attribute\Decorator\Base');
	132	+ $method = $class->getMethod($name);
	133	+ $method->setAccessible(true);
134	134
135	135	return $method;
136	136	}

		@@ -104,7 +104,7 @@
		block discarded – undo
104	104	/**
105	105	* Returns the frontend controller
106	106	*
107		- * @return \Aimeos\Controller\Frontend\Locale\Iface Frontend controller object
	107	+ * @return \Aimeos\Controller\Frontend\Iface Frontend controller object
108	108	*/
109	109	protected function getController()
110	110	{

		@@ -18,31 +18,31 @@
		block discarded – undo
18	18	{
19	19	$context = \TestHelperFrontend::getContext();
20	20
21		- $this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Base' )
22		- ->setConstructorArgs( [$context] )
	21	+ $this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Base')
	22	+ ->setConstructorArgs([$context])
23	23	->getMockForAbstractClass();
24	24	}
25	25
26	26
27	27	protected function tearDown()
28	28	{
29		- unset( $this->object );
	29	+ unset($this->object);
30	30	}
31	31
32	32
33	33	public function testGetContext()
34	34	{
35		- $result = $this->access( 'getContext' )->invokeArgs( $this->object, [] );
	35	+ $result = $this->access('getContext')->invokeArgs($this->object, []);
36	36
37		- $this->assertInstanceOf( '\Aimeos\MShop\Context\Item\Iface', $result );
	37	+ $this->assertInstanceOf('\Aimeos\MShop\Context\Item\Iface', $result);
38	38	}
39	39
40	40
41		- protected function access( $name )
	41	+ protected function access($name)
42	42	{
43		- $class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Base' );
44		- $method = $class->getMethod( $name );
45		- $method->setAccessible( true );
	43	+ $class = new \ReflectionClass('\Aimeos\Controller\Frontend\Base');
	44	+ $method = $class->getMethod($name);
	45	+ $method->setAccessible(true);
46	46
47	47	return $method;
48	48	}

		@@ -20,150 +20,150 @@
		block discarded – undo
20	20	{
21	21	$this->context = \TestHelperFrontend::getContext();
22	22
23		- $this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Product\Standard' )
	23	+ $this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Product\Standard')
24	24	->disableOriginalConstructor()
25	25	->getMock();
26	26
27		- $this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Product\Decorator\Base' )
28		- ->setConstructorArgs( [$this->stub, $this->context] )
	27	+ $this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Product\Decorator\Base')
	28	+ ->setConstructorArgs([$this->stub, $this->context])
29	29	->getMockForAbstractClass();
30	30	}
31	31
32	32
33	33	protected function tearDown()
34	34	{
35		- unset( $this->context, $this->object, $this->stub );
	35	+ unset($this->context, $this->object, $this->stub);
36	36	}
37	37
38	38
39	39	public function testConstructException()
40	40	{
41		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
	41	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
42	42
43		- $this->setExpectedException( '\Aimeos\Controller\Frontend\Exception' );
	43	+ $this->setExpectedException('\Aimeos\Controller\Frontend\Exception');
44	44
45		- $this->getMockBuilder( '\Aimeos\Controller\Frontend\Product\Decorator\Base' )
46		- ->setConstructorArgs( [$stub, $this->context] )
	45	+ $this->getMockBuilder('\Aimeos\Controller\Frontend\Product\Decorator\Base')
	46	+ ->setConstructorArgs([$stub, $this->context])
47	47	->getMockForAbstractClass();
48	48	}
49	49
50	50
51	51	public function testCall()
52	52	{
53		- $stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Product\Standard' )
	53	+ $stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Product\Standard')
54	54	->disableOriginalConstructor()
55		- ->setMethods( ['invalid'] )
	55	+ ->setMethods(['invalid'])
56	56	->getMock();
57	57
58		- $object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Product\Decorator\Base' )
59		- ->setConstructorArgs( [$stub, $this->context] )
	58	+ $object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Product\Decorator\Base')
	59	+ ->setConstructorArgs([$stub, $this->context])
60	60	->getMockForAbstractClass();
61	61
62		- $stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
	62	+ $stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
63	63
64		- $this->assertTrue( $object->invalid() );
	64	+ $this->assertTrue($object->invalid());
65	65	}
66	66
67	67
68	68	public function testAddFilterAttribute()
69	69	{
70		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
	70	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
71	71
72		- $this->stub->expects( $this->once() )->method( 'addFilterAttribute' )
73		- ->will( $this->returnArgument( 0 ) );
	72	+ $this->stub->expects($this->once())->method('addFilterAttribute')
	73	+ ->will($this->returnArgument(0));
74	74
75		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterAttribute( $search, [], [], [] ) );
	75	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterAttribute($search, [], [], []));
76	76	}
77	77
78	78
79	79	public function testAddFilterCategory()
80	80	{
81		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
	81	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
82	82
83		- $this->stub->expects( $this->once() )->method( 'addFilterCategory' )
84		- ->will( $this->returnArgument( 0 ) );
	83	+ $this->stub->expects($this->once())->method('addFilterCategory')
	84	+ ->will($this->returnArgument(0));
85	85
86		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterCategory( $search, -1 ) );
	86	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterCategory($search, -1));
87	87	}
88	88
89	89
90	90	public function testAddFilterText()
91	91	{
92		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
	92	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
93	93
94		- $this->stub->expects( $this->once() )->method( 'addFilterText' )
95		- ->will( $this->returnArgument( 0 ) );
	94	+ $this->stub->expects($this->once())->method('addFilterText')
	95	+ ->will($this->returnArgument(0));
96	96
97		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->addFilterText( $search, 'test' ) );
	97	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->addFilterText($search, 'test'));
98	98	}
99	99
100	100
101	101	public function testAggregate()
102	102	{
103		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
	103	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
104	104
105		- $this->stub->expects( $this->once() )->method( 'aggregate' )
106		- ->will( $this->returnValue( [] ) );
	105	+ $this->stub->expects($this->once())->method('aggregate')
	106	+ ->will($this->returnValue([]));
107	107
108		- $this->assertEquals( [], $this->object->aggregate( $search, 'test' ) );
	108	+ $this->assertEquals([], $this->object->aggregate($search, 'test'));
109	109	}
110	110
111	111
112	112	public function testCreateFilter()
113	113	{
114		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
	114	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
115	115
116		- $this->stub->expects( $this->once() )->method( 'createFilter' )
117		- ->will( $this->returnValue( $search ) );
	116	+ $this->stub->expects($this->once())->method('createFilter')
	117	+ ->will($this->returnValue($search));
118	118
119		- $this->assertInstanceOf( '\Aimeos\MW\Criteria\Iface', $this->object->createFilter() );
	119	+ $this->assertInstanceOf('\Aimeos\MW\Criteria\Iface', $this->object->createFilter());
120	120	}
121	121
122	122
123	123	public function testGetItem()
124	124	{
125		- $prodItem = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createItem();
	125	+ $prodItem = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createItem();
126	126
127		- $this->stub->expects( $this->once() )->method( 'getItem' )
128		- ->will( $this->returnValue( $prodItem ) );
	127	+ $this->stub->expects($this->once())->method('getItem')
	128	+ ->will($this->returnValue($prodItem));
129	129
130		- $this->assertInstanceOf( '\Aimeos\MShop\Product\Item\Iface', $this->object->getItem( -1 ) );
	130	+ $this->assertInstanceOf('\Aimeos\MShop\Product\Item\Iface', $this->object->getItem( -1 ));
131	131	}
132	132
133	133
134	134	public function testGetItems()
135	135	{
136		- $this->stub->expects( $this->once() )->method( 'getItems' )
137		- ->will( $this->returnValue( [] ) );
	136	+ $this->stub->expects($this->once())->method('getItems')
	137	+ ->will($this->returnValue([]));
138	138
139		- $this->assertEquals( [], $this->object->getItems( [-1] ) );
	139	+ $this->assertEquals([], $this->object->getItems([-1]));
140	140	}
141	141
142	142
143	143	public function testSearchItems()
144	144	{
145		- $search = \Aimeos\MShop\Factory::createManager( $this->context, 'index' )->createSearch();
	145	+ $search = \Aimeos\MShop\Factory::createManager($this->context, 'index')->createSearch();
146	146
147		- $this->stub->expects( $this->once() )->method( 'searchItems' )
148		- ->will( $this->returnValue( [] ) );
	147	+ $this->stub->expects($this->once())->method('searchItems')
	148	+ ->will($this->returnValue([]));
149	149
150		- $this->assertEquals( [], $this->object->searchItems( $search ) );
	150	+ $this->assertEquals([], $this->object->searchItems($search));
151	151	}
152	152
153	153
154	154	public function testGetController()
155	155	{
156		- $result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
	156	+ $result = $this->access('getController')->invokeArgs($this->object, []);
157	157
158		- $this->assertSame( $this->stub, $result );
	158	+ $this->assertSame($this->stub, $result);
159	159	}
160	160
161	161
162		- protected function access( $name )
	162	+ protected function access($name)
163	163	{
164		- $class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Product\Decorator\Base' );
165		- $method = $class->getMethod( $name );
166		- $method->setAccessible( true );
	164	+ $class = new \ReflectionClass('\Aimeos\Controller\Frontend\Product\Decorator\Base');
	165	+ $method = $class->getMethod($name);
	166	+ $method->setAccessible(true);
167	167
168	168	return $method;
169	169	}

		@@ -27,7 +27,7 @@ discard block
		block discarded – undo
27	27	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
28	28	* @since 2017.03
29	29	*/
30		- public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes );
	30	+ public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes);
31	31
32	32
33	33	/**
		@@ -47,7 +47,7 @@ discard block
		block discarded – undo
47	47	* @return \Aimeos\MShop\Attribute\Item\Iface Attribute item including the referenced domains items
48	48	* @since 2017.03
49	49	*/
50		- public function getItem( $id, array $domains = array( 'media', 'price', 'text' ) );
	50	+ public function getItem($id, array $domains = array('media', 'price', 'text'));
51	51
52	52
53	53	/**
		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58	* @return \Aimeos\MShop\Attribute\Item\Iface[] Associative list of attribute item including the referenced domains items
59	59	* @since 2017.03
60	60	*/
61		- public function getItems( array $ids, array $domains = array( 'media', 'price', 'text' ) );
	61	+ public function getItems(array $ids, array $domains = array('media', 'price', 'text'));
62	62
63	63
64	64	/**
		@@ -70,5 +70,5 @@ discard block
		block discarded – undo
70	70	* @return array Ordered list of attribute items implementing \Aimeos\MShop\Attribute\Item\Iface
71	71	* @since 2017.03
72	72	*/
73		- public function searchItems( \Aimeos\MW\Criteria\Iface $filter, array $domains = array( 'media', 'price', 'text' ), &$total = null );
	73	+ public function searchItems(\Aimeos\MW\Criteria\Iface $filter, array $domains = array('media', 'price', 'text'), &$total = null);
74	74	}

		@@ -16,13 +16,13 @@ discard block
		block discarded – undo
16	16
17	17	protected function setUp()
18	18	{
19		- $this->object = new \Aimeos\Controller\Frontend\Attribute\Standard( \TestHelperFrontend::getContext() );
	19	+ $this->object = new \Aimeos\Controller\Frontend\Attribute\Standard(\TestHelperFrontend::getContext());
20	20	}
21	21
22	22
23	23	protected function tearDown()
24	24	{
25		- unset( $this->object );
	25	+ unset($this->object);
26	26	}
27	27
28	28
		@@ -30,57 +30,57 @@ discard block
		block discarded – undo
30	30	{
31	31	$filter = $this->object->createFilter();
32	32
33		- $this->assertInstanceOf( '\\Aimeos\\MW\\Criteria\\Iface', $filter );
34		- $this->assertEquals( 1, count( $filter->getSortations() ) );
35		- $this->assertEquals( 0, $filter->getSliceStart() );
36		- $this->assertEquals( 100, $filter->getSliceSize() );
	33	+ $this->assertInstanceOf('\\Aimeos\\MW\\Criteria\\Iface', $filter);
	34	+ $this->assertEquals(1, count($filter->getSortations()));
	35	+ $this->assertEquals(0, $filter->getSliceStart());
	36	+ $this->assertEquals(100, $filter->getSliceSize());
37	37	}
38	38
39	39
40	40	public function testAddFilterTypes()
41	41	{
42	42	$filter = $this->object->createFilter();
43		- $filter = $this->object->addFilterTypes( $filter, ['size'] );
	43	+ $filter = $this->object->addFilterTypes($filter, ['size']);
44	44
45	45	$list = $filter->getConditions()->getExpressions();
46	46
47		- if( !isset( $list[0] ) \|\| !( $list[0] instanceof \Aimeos\MW\Criteria\Expression\Compare\Iface ) ) {
48		- throw new \RuntimeException( 'Wrong expression' );
	47	+ if (!isset($list[0]) \|\| !($list[0] instanceof \Aimeos\MW\Criteria\Expression\Compare\Iface)) {
	48	+ throw new \RuntimeException('Wrong expression');
49	49	}
50	50
51		- $this->assertEquals( 'attribute.type.code', $list[0]->getName() );
52		- $this->assertEquals( 1, count( $list[0]->getValue() ) );
	51	+ $this->assertEquals('attribute.type.code', $list[0]->getName());
	52	+ $this->assertEquals(1, count($list[0]->getValue()));
53	53	}
54	54
55	55
56	56	public function testGetItem()
57	57	{
58	58	$context = \TestHelperFrontend::getContext();
59		- $manager = \Aimeos\MShop\Factory::createManager( $context, 'attribute' );
60		- $id = $manager->findItem( 'xs', [], 'product', 'size' )->getId();
	59	+ $manager = \Aimeos\MShop\Factory::createManager($context, 'attribute');
	60	+ $id = $manager->findItem('xs', [], 'product', 'size')->getId();
61	61
62		- $result = $this->object->getItem( $id, ['text'] );
	62	+ $result = $this->object->getItem($id, ['text']);
63	63
64		- $this->assertInstanceOf( '\Aimeos\MShop\Attribute\Item\Iface', $result );
65		- $this->assertEquals( 3, count( $result->getRefItems( 'text' ) ) );
	64	+ $this->assertInstanceOf('\Aimeos\MShop\Attribute\Item\Iface', $result);
	65	+ $this->assertEquals(3, count($result->getRefItems('text')));
66	66	}
67	67
68	68
69	69	public function testGetItems()
70	70	{
71	71	$context = \TestHelperFrontend::getContext();
72		- $manager = \Aimeos\MShop\Factory::createManager( $context, 'attribute' );
73		- $id = $manager->findItem( 'xs', [], 'product', 'size' )->getId();
	72	+ $manager = \Aimeos\MShop\Factory::createManager($context, 'attribute');
	73	+ $id = $manager->findItem('xs', [], 'product', 'size')->getId();
74	74
75		- $result = $this->object->getItems( [$id], ['text'] );
	75	+ $result = $this->object->getItems([$id], ['text']);
76	76
77		- $this->assertInternalType( 'array', $result );
78		- $this->assertEquals( 1, count( $result ) );
	77	+ $this->assertInternalType('array', $result);
	78	+ $this->assertEquals(1, count($result));
79	79
80		- foreach( $result as $attrItem )
	80	+ foreach ($result as $attrItem)
81	81	{
82		- $this->assertInstanceOf( '\Aimeos\MShop\Attribute\Item\Iface', $attrItem );
83		- $this->assertEquals( 3, count( $attrItem->getRefItems( 'text' ) ) );
	82	+ $this->assertInstanceOf('\Aimeos\MShop\Attribute\Item\Iface', $attrItem);
	83	+ $this->assertEquals(3, count($attrItem->getRefItems('text')));
84	84	}
85	85	}
86	86
		@@ -88,12 +88,12 @@ discard block
		block discarded – undo
88	88	public function testSearchItems()
89	89	{
90	90	$filter = $this->object->createFilter();
91		- $filter = $this->object->addFilterTypes( $filter, ['size'] );
	91	+ $filter = $this->object->addFilterTypes($filter, ['size']);
92	92
93	93	$total = 0;
94		- $results = $this->object->searchItems( $filter, ['text'], $total );
	94	+ $results = $this->object->searchItems($filter, ['text'], $total);
95	95
96		- $this->assertEquals( 6, $total );
97		- $this->assertEquals( 6, count( $results ) );
	96	+ $this->assertEquals(6, $total);
	97	+ $this->assertEquals(6, count($results));
98	98	}
99	99	}

		@@ -14,92 +14,92 @@
		block discarded – undo
14	14	{
15	15	public function testCreateController()
16	16	{
17		- $controller = \Aimeos\Controller\Frontend\Factory::createController( \TestHelperFrontend::getContext(), 'basket' );
18		- $this->assertInstanceOf( '\\Aimeos\\Controller\\Frontend\\Iface', $controller );
	17	+ $controller = \Aimeos\Controller\Frontend\Factory::createController(\TestHelperFrontend::getContext(), 'basket');
	18	+ $this->assertInstanceOf('\\Aimeos\\Controller\\Frontend\\Iface', $controller);
19	19	}
20	20
21	21
22	22	public function testCreateControllerEmpty()
23	23	{
24		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
25		- \Aimeos\Controller\Frontend\Factory::createController( \TestHelperFrontend::getContext(), '' );
	24	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	25	+ \Aimeos\Controller\Frontend\Factory::createController(\TestHelperFrontend::getContext(), '');
26	26	}
27	27
28	28
29	29	public function testCreateControllerInvalidName()
30	30	{
31		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
32		- \Aimeos\Controller\Frontend\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
	31	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	32	+ \Aimeos\Controller\Frontend\Factory::createController(\TestHelperFrontend::getContext(), '%^');
33	33	}
34	34
35	35
36	36	public function testCreateControllerNotExisting()
37	37	{
38		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
39		- \Aimeos\Controller\Frontend\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
	38	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	39	+ \Aimeos\Controller\Frontend\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
40	40	}
41	41
42	42
43	43	public function testCreateSubControllerNotExisting()
44	44	{
45		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
46		- \Aimeos\Controller\Frontend\Factory::createController( \TestHelperFrontend::getContext(), 'basket/notexist' );
	45	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	46	+ \Aimeos\Controller\Frontend\Factory::createController(\TestHelperFrontend::getContext(), 'basket/notexist');
47	47	}
48	48
49	49
50	50	public function testClear()
51	51	{
52		- $cache = \Aimeos\Controller\Frontend\Factory::setCache( true );
	52	+ $cache = \Aimeos\Controller\Frontend\Factory::setCache(true);
53	53
54	54	$context = \TestHelperFrontend::getContext();
55	55
56		- $controller1 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
	56	+ $controller1 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
57	57	\Aimeos\Controller\Frontend\Factory::clear();
58		- $controller2 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
	58	+ $controller2 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
59	59
60		- \Aimeos\Controller\Frontend\Factory::setCache( $cache );
	60	+ \Aimeos\Controller\Frontend\Factory::setCache($cache);
61	61
62		- $this->assertNotSame( $controller1, $controller2 );
	62	+ $this->assertNotSame($controller1, $controller2);
63	63	}
64	64
65	65
66	66	public function testClearSite()
67	67	{
68		- $cache = \Aimeos\Controller\Frontend\Factory::setCache( true );
	68	+ $cache = \Aimeos\Controller\Frontend\Factory::setCache(true);
69	69
70	70	$context = \TestHelperFrontend::getContext();
71	71
72		- $basket1 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
73		- $catalog1 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'catalog' );
74		- \Aimeos\Controller\Frontend\Factory::clear( (string) $context );
	72	+ $basket1 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
	73	+ $catalog1 = \Aimeos\Controller\Frontend\Factory::createController($context, 'catalog');
	74	+ \Aimeos\Controller\Frontend\Factory::clear((string) $context);
75	75
76		- $basket2 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
77		- $catalog2 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'catalog' );
	76	+ $basket2 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
	77	+ $catalog2 = \Aimeos\Controller\Frontend\Factory::createController($context, 'catalog');
78	78
79		- \Aimeos\Controller\Frontend\Factory::setCache( $cache );
	79	+ \Aimeos\Controller\Frontend\Factory::setCache($cache);
80	80
81		- $this->assertNotSame( $basket1, $basket2 );
82		- $this->assertNotSame( $catalog1, $catalog2 );
	81	+ $this->assertNotSame($basket1, $basket2);
	82	+ $this->assertNotSame($catalog1, $catalog2);
83	83	}
84	84
85	85
86	86	public function testClearSpecific()
87	87	{
88		- $cache = \Aimeos\Controller\Frontend\Factory::setCache( true );
	88	+ $cache = \Aimeos\Controller\Frontend\Factory::setCache(true);
89	89
90	90	$context = \TestHelperFrontend::getContext();
91	91
92		- $basket1 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
93		- $catalog1 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'catalog' );
94		- \Aimeos\Controller\Frontend\Factory::clear( (string) $context, 'basket' );
	92	+ $basket1 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
	93	+ $catalog1 = \Aimeos\Controller\Frontend\Factory::createController($context, 'catalog');
	94	+ \Aimeos\Controller\Frontend\Factory::clear((string) $context, 'basket');
95	95
96		- $basket2 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'basket' );
97		- $catalog2 = \Aimeos\Controller\Frontend\Factory::createController( $context, 'catalog' );
	96	+ $basket2 = \Aimeos\Controller\Frontend\Factory::createController($context, 'basket');
	97	+ $catalog2 = \Aimeos\Controller\Frontend\Factory::createController($context, 'catalog');
98	98
99		- \Aimeos\Controller\Frontend\Factory::setCache( $cache );
	99	+ \Aimeos\Controller\Frontend\Factory::setCache($cache);
100	100
101		- $this->assertNotSame( $basket1, $basket2 );
102		- $this->assertSame( $catalog1, $catalog2 );
	101	+ $this->assertNotSame($basket1, $basket2);
	102	+ $this->assertSame($catalog1, $catalog2);
103	103	}
104	104
105	105	}
106	106	\ No newline at end of file

		@@ -30,18 +30,18 @@ discard block
		block discarded – undo
30	30	* @param \Aimeos\Controller\Frontend\Iface $controller Controller object
31	31	* @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
32	32	*/
33		- public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
	33	+ public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
34	34	{
35	35	$iface = '\Aimeos\Controller\Frontend\Locale\Iface';
36		- if( !( $controller instanceof $iface ) )
	36	+ if (!($controller instanceof $iface))
37	37	{
38		- $msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
39		- throw new \Aimeos\Controller\Frontend\Exception( $msg );
	38	+ $msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
	39	+ throw new \Aimeos\Controller\Frontend\Exception($msg);
40	40	}
41	41
42	42	$this->controller = $controller;
43	43
44		- parent::__construct( $context );
	44	+ parent::__construct($context);
45	45	}
46	46
47	47
		@@ -53,9 +53,9 @@ discard block
		block discarded – undo
53	53	* @return mixed Returns the value of the called method
54	54	* @throws \Aimeos\Controller\Frontend\Exception If method call failed
55	55	*/
56		- public function __call( $name, array $param )
	56	+ public function __call($name, array $param)
57	57	{
58		- return @call_user_func_array( array( $this->controller, $name ), $param );
	58	+ return @call_user_func_array(array($this->controller, $name), $param);
59	59	}
60	60
61	61
		@@ -80,9 +80,9 @@ discard block
		block discarded – undo
80	80	* @return \Aimeos\MShop\Locale\Item\Iface Locale item including the referenced domains items
81	81	* @since 2017.03
82	82	*/
83		- public function getItem( $id, array $domains = [] )
	83	+ public function getItem($id, array $domains = [])
84	84	{
85		- return $this->controller->getItem( $id, $domains );
	85	+ return $this->controller->getItem($id, $domains);
86	86	}
87	87
88	88
		@@ -95,9 +95,9 @@ discard block
		block discarded – undo
95	95	* @return array Ordered list of locale items implementing \Aimeos\MShop\Locale\Item\Iface
96	96	* @since 2017.03
97	97	*/
98		- public function searchItems( \Aimeos\MW\Criteria\Iface $filter, array $domains = [], &$total = null )
	98	+ public function searchItems(\Aimeos\MW\Criteria\Iface $filter, array $domains = [], &$total = null)
99	99	{
100		- return $this->controller->searchItems( $filter, $domains, $total );
	100	+ return $this->controller->searchItems($filter, $domains, $total);
101	101	}
102	102
103	103

		@@ -15,31 +15,31 @@
		block discarded – undo
15	15	{
16	16	$target = '\\Aimeos\\Controller\\Frontend\\Locale\\Iface';
17	17
18		- $controller = \Aimeos\Controller\Frontend\Locale\Factory::createController( \TestHelperFrontend::getContext() );
19		- $this->assertInstanceOf( $target, $controller );
	18	+ $controller = \Aimeos\Controller\Frontend\Locale\Factory::createController(\TestHelperFrontend::getContext());
	19	+ $this->assertInstanceOf($target, $controller);
20	20
21		- $controller = \Aimeos\Controller\Frontend\Locale\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
22		- $this->assertInstanceOf( $target, $controller );
	21	+ $controller = \Aimeos\Controller\Frontend\Locale\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
	22	+ $this->assertInstanceOf($target, $controller);
23	23	}
24	24
25	25
26	26	public function testCreateControllerInvalidImplementation()
27	27	{
28		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
29		- \Aimeos\Controller\Frontend\Locale\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
	28	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	29	+ \Aimeos\Controller\Frontend\Locale\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
30	30	}
31	31
32	32
33	33	public function testCreateControllerInvalidName()
34	34	{
35		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
36		- \Aimeos\Controller\Frontend\Locale\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
	35	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	36	+ \Aimeos\Controller\Frontend\Locale\Factory::createController(\TestHelperFrontend::getContext(), '%^');
37	37	}
38	38
39	39
40	40	public function testCreateControllerNotExisting()
41	41	{
42		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
43		- \Aimeos\Controller\Frontend\Locale\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
	42	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	43	+ \Aimeos\Controller\Frontend\Locale\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
44	44	}
45	45	}

aimeos / ai-controller-frontend

Push — master ( 87706b...b447e5 )

Status

Category

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +51 added lines, -51 removed lines patch added patch discarded remove patch

Spacing +40 added lines, -40 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

Spacing +39 added lines, -39 removed lines patch added patch discarded remove patch

Spacing +33 added lines, -33 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch