Base - Code Metrics - Inspection of "Added attribute frontend controller and tests" - aimeos/ai-controller-frontend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a4e8a9...31faa3 )

by Aimeos

created 2017-02-26 09:40 UTC

Base A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	1
dl	0
loc	118
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	__construct()	12	2
A	__call()	4	1
A	addFilterTypes()	4	1
A	createFilter()	4	1
A	getItem()	4	1
A	searchItems()	4	1
A	getContext()	4	1
A	getController()	4	1

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Aimeos (aimeos.org), 2017
 * @package Controller
 * @subpackage Frontend
 */


namespace Aimeos\Controller\Frontend\Attribute\Decorator;


/**
 * Base for attribute frontend controller decorators
 *
 * @package Controller
 * @subpackage Frontend
 */
abstract class Base
	implements \Aimeos\Controller\Frontend\Common\Decorator\Iface

{
	private $context;
	private $controller;


	/**
	 * Initializes the controller decorator.
	 *
	 * @param \Aimeos\Controller\Frontend\Iface $controller Controller object
	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
	 */
	public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
	{
		$iface = '\Aimeos\Controller\Frontend\Attribute\Iface';
		if( !( $controller instanceof $iface ) )
		{
			$msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
			throw new \Aimeos\Controller\Frontend\Exception( $msg );
		}

		$this->context = $context;
		$this->controller = $controller;
	}


	/**
	 * Passes unknown methods to wrapped objects.
	 *
	 * @param string $name Name of the method
	 * @param array $param List of method parameter
	 * @return mixed Returns the value of the called method
	 * @throws \Aimeos\Controller\Frontend\Exception If method call failed
	 */
	public function __call( $name, array $param )
	{
		return @call_user_func_array( array( $this->controller, $name ), $param );
	}


	/**
	 * Returns the given search filter with the conditions attached for filtering by type code
	 *
	 * @param \Aimeos\MW\Criteria\Iface $filter Criteria object used for attribute search
	 * @param array $codes List of attribute type codes
	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
	 * @since 2017.03
	 */
	public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
	{
		return $this->controller->addFilterTypes( $filter, $codes );
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}


	/**
	 * Returns the default attribute filter
	 *
	 * @param boolean True to add default criteria
	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
	 * @since 2017.03
	 */
	public function createFilter()
	{
		return $this->controller->createFilter();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}


	/**
	 * Returns the attribute item for the given attribute ID
	 *
	 * @param string $id Unique attribute ID
	 * @param string[] $domains Domain names of items that are associated with the attributes and that should be fetched too
	 * @return \Aimeos\MShop\Attribute\Item\Iface Attribute item including the referenced domains items
	 * @since 2017.03
	 */
	public function getItem( $id, array $domains = array( 'media', 'price', 'text' ) )
	{
		return $this->controller->getItem( $id, $domains );
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}


	/**
	 * Returns the attributes filtered by the given criteria object
	 *
	 * @param \Aimeos\MW\Criteria\Iface $filter Critera object which contains the filter conditions
	 * @param string[] $domains Domain names of items that are associated with the attributes and that should be fetched too
	 * @param integer &$total Parameter where the total number of found attributes will be stored in
	 * @return array Ordered list of attribute items implementing \Aimeos\MShop\Attribute\Item\Iface
	 * @since 2017.03
	 */
	public function searchItems( \Aimeos\MW\Criteria\Iface $filter, array $domains = array( 'media', 'price', 'text' ), &$total = null )
	{
		return $this->controller->searchItems( $filter, $domains, $total );
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}


	/**
	 * Returns the context item
	 *
	 * @return \Aimeos\MShop\Context\Item\Iface Context item object
	 */
	protected function getContext()
	{
		return $this->context;
	}


	/**
	 * Returns the frontend controller
	 *
	 * @return \Aimeos\Controller\Frontend\Attribute\Iface Frontend controller object
	 */
	protected function getController()
	{
		return $this->controller;
	}
}


1			<?php
2
3			/**
4			* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5			* @copyright Aimeos (aimeos.org), 2017
6			* @package Controller
7			* @subpackage Frontend
8			*/
9
10
11			namespace Aimeos\Controller\Frontend\Attribute\Decorator;
12
13
14			/**
15			* Base for attribute frontend controller decorators
16			*
17			* @package Controller
18			* @subpackage Frontend
19			*/
20			abstract class Base
21			implements \Aimeos\Controller\Frontend\Common\Decorator\Iface
			1 ignored issue – show Coding Style introduced 2017-02-26 09:42 UTC by Report Bug Copy Issue Report The implements keyword must be on the same line as the class name Loading history...
22			{
23			private $context;
24			private $controller;
25
26
27			/**
28			* Initializes the controller decorator.
29			*
30			* @param \Aimeos\Controller\Frontend\Iface $controller Controller object
31			* @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
32			*/
33			public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
34			{
35			$iface = '\Aimeos\Controller\Frontend\Attribute\Iface';
36			if( !( $controller instanceof $iface ) )
37			{
38			$msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
39			throw new \Aimeos\Controller\Frontend\Exception( $msg );
40			}
41
42			$this->context = $context;
43			$this->controller = $controller;
44			}
45
46
47			/**
48			* Passes unknown methods to wrapped objects.
49			*
50			* @param string $name Name of the method
51			* @param array $param List of method parameter
52			* @return mixed Returns the value of the called method
53			* @throws \Aimeos\Controller\Frontend\Exception If method call failed
54			*/
55			public function __call( $name, array $param )
56			{
57			return @call_user_func_array( array( $this->controller, $name ), $param );
58			}
59
60
61			/**
62			* Returns the given search filter with the conditions attached for filtering by type code
63			*
64			* @param \Aimeos\MW\Criteria\Iface $filter Criteria object used for attribute search
65			* @param array $codes List of attribute type codes
66			* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
67			* @since 2017.03
68			*/
69			public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
70			{
71			return $this->controller->addFilterTypes( $filter, $codes );
			1 ignored issue – show Bug introduced 2017-02-26 09:42 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Aimeos\Controller\Frontend\Iface` as the method `addFilterTypes()` does only exist in the following implementations of said interface: `Aimeos\Controller\Fronte...ttribute\Decorator\Base`, `Aimeos\Controller\Frontend\Attribute\Standard`, `Aimeos\Controller\Frontend\Stock\Decorator\Base`, `Aimeos\Controller\Frontend\Stock\Standard`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
72			}
73
74
75			/**
76			* Returns the default attribute filter
77			*
78			* @param boolean True to add default criteria
79			* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
80			* @since 2017.03
81			*/
82			public function createFilter()
83			{
84			return $this->controller->createFilter();
			1 ignored issue – show Bug introduced 2017-02-26 09:42 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Aimeos\Controller\Frontend\Iface` as the method `createFilter()` does only exist in the following implementations of said interface: `Aimeos\Controller\Fronte...ttribute\Decorator\Base`, `Aimeos\Controller\Frontend\Attribute\Standard`, `Aimeos\Controller\Frontend\Catalog\Decorator\Base`, `Aimeos\Controller\Frontend\Catalog\Standard`, `Aimeos\Controller\Frontend\Product\Decorator\Base`, `Aimeos\Controller\Frontend\Product\Standard`, `Aimeos\Controller\Frontend\Stock\Decorator\Base`, `Aimeos\Controller\Frontend\Stock\Standard`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
85			}
86
87
88			/**
89			* Returns the attribute item for the given attribute ID
90			*
91			* @param string $id Unique attribute ID
92			* @param string[] $domains Domain names of items that are associated with the attributes and that should be fetched too
93			* @return \Aimeos\MShop\Attribute\Item\Iface Attribute item including the referenced domains items
94			* @since 2017.03
95			*/
96			public function getItem( $id, array $domains = array( 'media', 'price', 'text' ) )
97			{
98			return $this->controller->getItem( $id, $domains );
			1 ignored issue – show Bug introduced 2017-02-26 09:42 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Aimeos\Controller\Frontend\Iface` as the method `getItem()` does only exist in the following implementations of said interface: `Aimeos\Controller\Fronte...ttribute\Decorator\Base`, `Aimeos\Controller\Frontend\Attribute\Standard`, `Aimeos\Controller\Frontend\Product\Decorator\Base`, `Aimeos\Controller\Frontend\Product\Standard`, `Aimeos\Controller\Frontend\Stock\Decorator\Base`, `Aimeos\Controller\Frontend\Stock\Standard`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
99			}
100
101
102			/**
103			* Returns the attributes filtered by the given criteria object
104			*
105			* @param \Aimeos\MW\Criteria\Iface $filter Critera object which contains the filter conditions
106			* @param string[] $domains Domain names of items that are associated with the attributes and that should be fetched too
107			* @param integer &$total Parameter where the total number of found attributes will be stored in
108			* @return array Ordered list of attribute items implementing \Aimeos\MShop\Attribute\Item\Iface
109			* @since 2017.03
110			*/
111			public function searchItems( \Aimeos\MW\Criteria\Iface $filter, array $domains = array( 'media', 'price', 'text' ), &$total = null )
112			{
113			return $this->controller->searchItems( $filter, $domains, $total );
			1 ignored issue – show Bug introduced 2017-02-26 09:42 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Aimeos\Controller\Frontend\Iface` as the method `searchItems()` does only exist in the following implementations of said interface: `Aimeos\Controller\Fronte...ttribute\Decorator\Base`, `Aimeos\Controller\Frontend\Attribute\Standard`, `Aimeos\Controller\Frontend\Product\Decorator\Base`, `Aimeos\Controller\Frontend\Product\Standard`, `Aimeos\Controller\Frontend\Stock\Decorator\Base`, `Aimeos\Controller\Frontend\Stock\Standard`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
114			}
115
116
117			/**
118			* Returns the context item
119			*
120			* @return \Aimeos\MShop\Context\Item\Iface Context item object
121			*/
122			protected function getContext()
123			{
124			return $this->context;
125			}
126
127
128			/**
129			* Returns the frontend controller
130			*
131			* @return \Aimeos\Controller\Frontend\Attribute\Iface Frontend controller object
132			*/
133			protected function getController()
134			{
135			return $this->controller;
136			}
137			}
138

aimeos / ai-controller-frontend

Push — master ( a4e8a9...31faa3 )

Base A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like