Completed
Push — master ( 9109fd...709bda )
by Aimeos
02:33
created
controller/frontend/tests/Controller/Frontend/Supplier/FactoryTest.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -15,31 +15,31 @@
 block discarded – undo
15 15
 	{
16 16
 		$target = '\\Aimeos\\Controller\\Frontend\\Supplier\\Iface';
17 17
 
18
-		$controller = \Aimeos\Controller\Frontend\Supplier\Factory::create( \TestHelperFrontend::getContext() );
19
-		$this->assertInstanceOf( $target, $controller );
18
+		$controller = \Aimeos\Controller\Frontend\Supplier\Factory::create(\TestHelperFrontend::getContext());
19
+		$this->assertInstanceOf($target, $controller);
20 20
 
21
-		$controller = \Aimeos\Controller\Frontend\Supplier\Factory::create( \TestHelperFrontend::getContext(), 'Standard' );
22
-		$this->assertInstanceOf( $target, $controller );
21
+		$controller = \Aimeos\Controller\Frontend\Supplier\Factory::create(\TestHelperFrontend::getContext(), 'Standard');
22
+		$this->assertInstanceOf($target, $controller);
23 23
 	}
24 24
 
25 25
 
26 26
 	public function testCreateControllerInvalidImplementation()
27 27
 	{
28
-		$this->setExpectedException( '\\Aimeos\\MW\\Common\\Exception' );
29
-		\Aimeos\Controller\Frontend\Supplier\Factory::create( \TestHelperFrontend::getContext(), 'Invalid' );
28
+		$this->setExpectedException('\\Aimeos\\MW\\Common\\Exception');
29
+		\Aimeos\Controller\Frontend\Supplier\Factory::create(\TestHelperFrontend::getContext(), 'Invalid');
30 30
 	}
31 31
 
32 32
 
33 33
 	public function testCreateControllerInvalidName()
34 34
 	{
35
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
36
-		\Aimeos\Controller\Frontend\Supplier\Factory::create( \TestHelperFrontend::getContext(), '%^' );
35
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
36
+		\Aimeos\Controller\Frontend\Supplier\Factory::create(\TestHelperFrontend::getContext(), '%^');
37 37
 	}
38 38
 
39 39
 
40 40
 	public function testCreateControllerNotExisting()
41 41
 	{
42
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
43
-		\Aimeos\Controller\Frontend\Supplier\Factory::create( \TestHelperFrontend::getContext(), 'notexist' );
42
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
43
+		\Aimeos\Controller\Frontend\Supplier\Factory::create(\TestHelperFrontend::getContext(), 'notexist');
44 44
 	}
45 45
 }
Please login to merge, or discard this patch.
controller/frontend/tests/Controller/Frontend/Attribute/FactoryTest.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -15,31 +15,31 @@
 block discarded – undo
15 15
 	{
16 16
 		$target = '\\Aimeos\\Controller\\Frontend\\Attribute\\Iface';
17 17
 
18
-		$controller = \Aimeos\Controller\Frontend\Attribute\Factory::create( \TestHelperFrontend::getContext() );
19
-		$this->assertInstanceOf( $target, $controller );
18
+		$controller = \Aimeos\Controller\Frontend\Attribute\Factory::create(\TestHelperFrontend::getContext());
19
+		$this->assertInstanceOf($target, $controller);
20 20
 
21
-		$controller = \Aimeos\Controller\Frontend\Attribute\Factory::create( \TestHelperFrontend::getContext(), 'Standard' );
22
-		$this->assertInstanceOf( $target, $controller );
21
+		$controller = \Aimeos\Controller\Frontend\Attribute\Factory::create(\TestHelperFrontend::getContext(), 'Standard');
22
+		$this->assertInstanceOf($target, $controller);
23 23
 	}
24 24
 
25 25
 
26 26
 	public function testCreateControllerInvalidImplementation()
27 27
 	{
28
-		$this->setExpectedException( '\\Aimeos\\MW\\Common\\Exception' );
29
-		\Aimeos\Controller\Frontend\Attribute\Factory::create( \TestHelperFrontend::getContext(), 'Invalid' );
28
+		$this->setExpectedException('\\Aimeos\\MW\\Common\\Exception');
29
+		\Aimeos\Controller\Frontend\Attribute\Factory::create(\TestHelperFrontend::getContext(), 'Invalid');
30 30
 	}
31 31
 
32 32
 
33 33
 	public function testCreateControllerInvalidName()
34 34
 	{
35
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
36
-		\Aimeos\Controller\Frontend\Attribute\Factory::create( \TestHelperFrontend::getContext(), '%^' );
35
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
36
+		\Aimeos\Controller\Frontend\Attribute\Factory::create(\TestHelperFrontend::getContext(), '%^');
37 37
 	}
38 38
 
39 39
 
40 40
 	public function testCreateControllerNotExisting()
41 41
 	{
42
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
43
-		\Aimeos\Controller\Frontend\Attribute\Factory::create( \TestHelperFrontend::getContext(), 'notexist' );
42
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
43
+		\Aimeos\Controller\Frontend\Attribute\Factory::create(\TestHelperFrontend::getContext(), 'notexist');
44 44
 	}
45 45
 }
Please login to merge, or discard this patch.
frontend/tests/Controller/Frontend/Product/Decorator/BaseTest.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -229,6 +229,9 @@
 block discarded – undo
229 229
 	}
230 230
 
231 231
 
232
+	/**
233
+	 * @param string $name
234
+	 */
232 235
 	protected function access( $name )
233 236
 	{
234 237
 		$class = new \ReflectionClass( \Aimeos\Controller\Frontend\Product\Decorator\Base::class );
Please login to merge, or discard this patch.
Spacing   +65 added lines, -65 removed lines patch added patch discarded remove patch
@@ -20,57 +20,57 @@  discard block
 block discarded – undo
20 20
 	{
21 21
 		$this->context = \TestHelperFrontend::getContext();
22 22
 
23
-		$this->stub = $this->getMockBuilder( \Aimeos\Controller\Frontend\Product\Standard::class )
23
+		$this->stub = $this->getMockBuilder(\Aimeos\Controller\Frontend\Product\Standard::class)
24 24
 			->disableOriginalConstructor()
25 25
 			->getMock();
26 26
 
27
-		$this->object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Product\Decorator\Base::class )
28
-			->setConstructorArgs( [$this->stub, $this->context] )
27
+		$this->object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Product\Decorator\Base::class)
28
+			->setConstructorArgs([$this->stub, $this->context])
29 29
 			->getMockForAbstractClass();
30 30
 	}
31 31
 
32 32
 
33 33
 	protected function tearDown()
34 34
 	{
35
-		unset( $this->context, $this->object, $this->stub );
35
+		unset($this->context, $this->object, $this->stub);
36 36
 	}
37 37
 
38 38
 
39 39
 	public function testConstructException()
40 40
 	{
41
-		$stub = $this->getMockBuilder( \Aimeos\Controller\Frontend\Iface::class )->getMock();
41
+		$stub = $this->getMockBuilder(\Aimeos\Controller\Frontend\Iface::class)->getMock();
42 42
 
43
-		$this->setExpectedException( \Aimeos\MW\Common\Exception::class );
43
+		$this->setExpectedException(\Aimeos\MW\Common\Exception::class);
44 44
 
45
-		$this->getMockBuilder( \Aimeos\Controller\Frontend\Product\Decorator\Base::class )
46
-			->setConstructorArgs( [$stub, $this->context] )
45
+		$this->getMockBuilder(\Aimeos\Controller\Frontend\Product\Decorator\Base::class)
46
+			->setConstructorArgs([$stub, $this->context])
47 47
 			->getMockForAbstractClass();
48 48
 	}
49 49
 
50 50
 
51 51
 	public function testCall()
52 52
 	{
53
-		$stub = $this->getMockBuilder( \Aimeos\Controller\Frontend\Product\Standard::class )
53
+		$stub = $this->getMockBuilder(\Aimeos\Controller\Frontend\Product\Standard::class)
54 54
 			->disableOriginalConstructor()
55
-			->setMethods( ['invalid'] )
55
+			->setMethods(['invalid'])
56 56
 			->getMock();
57 57
 
58
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Product\Decorator\Base::class )
59
-			->setConstructorArgs( [$stub, $this->context] )
58
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Product\Decorator\Base::class)
59
+			->setConstructorArgs([$stub, $this->context])
60 60
 			->getMockForAbstractClass();
61 61
 
62
-		$stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
62
+		$stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
63 63
 
64
-		$this->assertTrue( $object->invalid() );
64
+		$this->assertTrue($object->invalid());
65 65
 	}
66 66
 
67 67
 
68 68
 	public function testAggregate()
69 69
 	{
70
-		$this->stub->expects( $this->once() )->method( 'aggregate' )
71
-			->will( $this->returnValue( [] ) );
70
+		$this->stub->expects($this->once())->method('aggregate')
71
+			->will($this->returnValue([]));
72 72
 
73
-		$this->assertEquals( [], $this->object->aggregate( 'test' ) );
73
+		$this->assertEquals([], $this->object->aggregate('test'));
74 74
 	}
75 75
 
76 76
 
@@ -78,10 +78,10 @@  discard block
 block discarded – undo
78 78
 	{
79 79
 		$expected = \Aimeos\Controller\Frontend\Product\Iface::class;
80 80
 
81
-		$this->stub->expects( $this->once() )->method( 'allOf' )
82
-			->will( $this->returnValue( $this->stub ) );
81
+		$this->stub->expects($this->once())->method('allOf')
82
+			->will($this->returnValue($this->stub));
83 83
 
84
-		$this->assertInstanceOf( $expected, $this->object->allOf( [1, 2] ) );
84
+		$this->assertInstanceOf($expected, $this->object->allOf([1, 2]));
85 85
 	}
86 86
 
87 87
 
@@ -89,10 +89,10 @@  discard block
 block discarded – undo
89 89
 	{
90 90
 		$expected = \Aimeos\Controller\Frontend\Product\Iface::class;
91 91
 
92
-		$this->stub->expects( $this->once() )->method( 'category' )
93
-			->will( $this->returnValue( $this->stub ) );
92
+		$this->stub->expects($this->once())->method('category')
93
+			->will($this->returnValue($this->stub));
94 94
 
95
-		$this->assertInstanceOf( $expected, $this->object->category( 1, 'default', \Aimeos\MW\Tree\Manager\Base::LEVEL_TREE ) );
95
+		$this->assertInstanceOf($expected, $this->object->category(1, 'default', \Aimeos\MW\Tree\Manager\Base::LEVEL_TREE));
96 96
 	}
97 97
 
98 98
 
@@ -100,34 +100,34 @@  discard block
 block discarded – undo
100 100
 	{
101 101
 		$expected = \Aimeos\Controller\Frontend\Product\Iface::class;
102 102
 
103
-		$this->stub->expects( $this->once() )->method( 'compare' )
104
-			->will( $this->returnValue( $this->stub ) );
103
+		$this->stub->expects($this->once())->method('compare')
104
+			->will($this->returnValue($this->stub));
105 105
 
106
-		$this->assertInstanceOf( $expected, $this->object->compare( '==', 'product.code', 'test' ) );
106
+		$this->assertInstanceOf($expected, $this->object->compare('==', 'product.code', 'test'));
107 107
 	}
108 108
 
109 109
 
110 110
 	public function testGet()
111 111
 	{
112
-		$item = \Aimeos\MShop::create( $this->context, 'product' )->createItem();
112
+		$item = \Aimeos\MShop::create($this->context, 'product')->createItem();
113 113
 		$expected = \Aimeos\MShop\Product\Item\Iface::class;
114 114
 
115
-		$this->stub->expects( $this->once() )->method( 'get' )
116
-			->will( $this->returnValue( $item ) );
115
+		$this->stub->expects($this->once())->method('get')
116
+			->will($this->returnValue($item));
117 117
 
118
-		$this->assertInstanceOf( $expected, $this->object->get( 1, ['text'] ) );
118
+		$this->assertInstanceOf($expected, $this->object->get(1, ['text']));
119 119
 	}
120 120
 
121 121
 
122 122
 	public function testFind()
123 123
 	{
124
-		$item = \Aimeos\MShop::create( $this->context, 'product' )->createItem();
124
+		$item = \Aimeos\MShop::create($this->context, 'product')->createItem();
125 125
 		$expected = \Aimeos\MShop\Product\Item\Iface::class;
126 126
 
127
-		$this->stub->expects( $this->once() )->method( 'find' )
128
-			->will( $this->returnValue( $item ) );
127
+		$this->stub->expects($this->once())->method('find')
128
+			->will($this->returnValue($item));
129 129
 
130
-		$this->assertInstanceOf( $expected, $this->object->find( 'test', ['text'] ) );
130
+		$this->assertInstanceOf($expected, $this->object->find('test', ['text']));
131 131
 	}
132 132
 
133 133
 
@@ -135,10 +135,10 @@  discard block
 block discarded – undo
135 135
 	{
136 136
 		$expected = \Aimeos\Controller\Frontend\Product\Iface::class;
137 137
 
138
-		$this->stub->expects( $this->once() )->method( 'oneOf' )
139
-			->will( $this->returnValue( $this->stub ) );
138
+		$this->stub->expects($this->once())->method('oneOf')
139
+			->will($this->returnValue($this->stub));
140 140
 
141
-		$this->assertInstanceOf( $expected, $this->object->oneOf( [1, 2] ) );
141
+		$this->assertInstanceOf($expected, $this->object->oneOf([1, 2]));
142 142
 	}
143 143
 
144 144
 
@@ -146,10 +146,10 @@  discard block
 block discarded – undo
146 146
 	{
147 147
 		$expected = \Aimeos\Controller\Frontend\Product\Iface::class;
148 148
 
149
-		$this->stub->expects( $this->once() )->method( 'parse' )
150
-			->will( $this->returnValue( $this->stub ) );
149
+		$this->stub->expects($this->once())->method('parse')
150
+			->will($this->returnValue($this->stub));
151 151
 
152
-		$this->assertInstanceOf( $expected, $this->object->parse( [] ) );
152
+		$this->assertInstanceOf($expected, $this->object->parse([]));
153 153
 	}
154 154
 
155 155
 
@@ -157,23 +157,23 @@  discard block
 block discarded – undo
157 157
 	{
158 158
 		$expected = \Aimeos\Controller\Frontend\Product\Iface::class;
159 159
 
160
-		$this->stub->expects( $this->once() )->method( 'product' )
161
-			->will( $this->returnValue( $this->stub ) );
160
+		$this->stub->expects($this->once())->method('product')
161
+			->will($this->returnValue($this->stub));
162 162
 
163
-		$this->assertInstanceOf( $expected, $this->object->product( [1, 3] ) );
163
+		$this->assertInstanceOf($expected, $this->object->product([1, 3]));
164 164
 	}
165 165
 
166 166
 
167 167
 	public function testSearch()
168 168
 	{
169
-		$item = \Aimeos\MShop::create( $this->context, 'product' )->createItem();
169
+		$item = \Aimeos\MShop::create($this->context, 'product')->createItem();
170 170
 		$expected = \Aimeos\MShop\Product\Item\Iface::class;
171 171
 		$total = 0;
172 172
 
173
-		$this->stub->expects( $this->once() )->method( 'search' )
174
-			->will( $this->returnValue( [$item] ) );
173
+		$this->stub->expects($this->once())->method('search')
174
+			->will($this->returnValue([$item]));
175 175
 
176
-		$this->assertEquals( [$item], $this->object->search( ['text'], $total ) );
176
+		$this->assertEquals([$item], $this->object->search(['text'], $total));
177 177
 	}
178 178
 
179 179
 
@@ -181,10 +181,10 @@  discard block
 block discarded – undo
181 181
 	{
182 182
 		$expected = \Aimeos\Controller\Frontend\Product\Iface::class;
183 183
 
184
-		$this->stub->expects( $this->once() )->method( 'slice' )
185
-			->will( $this->returnValue( $this->stub ) );
184
+		$this->stub->expects($this->once())->method('slice')
185
+			->will($this->returnValue($this->stub));
186 186
 
187
-		$this->assertInstanceOf( $expected, $this->object->slice( 0, 100 ) );
187
+		$this->assertInstanceOf($expected, $this->object->slice(0, 100));
188 188
 	}
189 189
 
190 190
 
@@ -192,10 +192,10 @@  discard block
 block discarded – undo
192 192
 	{
193 193
 		$expected = \Aimeos\Controller\Frontend\Product\Iface::class;
194 194
 
195
-		$this->stub->expects( $this->once() )->method( 'sort' )
196
-			->will( $this->returnValue( $this->stub ) );
195
+		$this->stub->expects($this->once())->method('sort')
196
+			->will($this->returnValue($this->stub));
197 197
 
198
-		$this->assertInstanceOf( $expected, $this->object->sort( 'code' ) );
198
+		$this->assertInstanceOf($expected, $this->object->sort('code'));
199 199
 	}
200 200
 
201 201
 
@@ -203,10 +203,10 @@  discard block
 block discarded – undo
203 203
 	{
204 204
 		$expected = \Aimeos\Controller\Frontend\Product\Iface::class;
205 205
 
206
-		$this->stub->expects( $this->once() )->method( 'supplier' )
207
-			->will( $this->returnValue( $this->stub ) );
206
+		$this->stub->expects($this->once())->method('supplier')
207
+			->will($this->returnValue($this->stub));
208 208
 
209
-		$this->assertInstanceOf( $expected, $this->object->supplier( [1], 'default' ) );
209
+		$this->assertInstanceOf($expected, $this->object->supplier([1], 'default'));
210 210
 	}
211 211
 
212 212
 
@@ -214,26 +214,26 @@  discard block
 block discarded – undo
214 214
 	{
215 215
 		$expected = \Aimeos\Controller\Frontend\Product\Iface::class;
216 216
 
217
-		$this->stub->expects( $this->once() )->method( 'text' )
218
-			->will( $this->returnValue( $this->stub ) );
217
+		$this->stub->expects($this->once())->method('text')
218
+			->will($this->returnValue($this->stub));
219 219
 
220
-		$this->assertInstanceOf( $expected, $this->object->text( 'test' ) );
220
+		$this->assertInstanceOf($expected, $this->object->text('test'));
221 221
 	}
222 222
 
223 223
 
224 224
 	public function testGetController()
225 225
 	{
226
-		$result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
226
+		$result = $this->access('getController')->invokeArgs($this->object, []);
227 227
 
228
-		$this->assertSame( $this->stub, $result );
228
+		$this->assertSame($this->stub, $result);
229 229
 	}
230 230
 
231 231
 
232
-	protected function access( $name )
232
+	protected function access($name)
233 233
 	{
234
-		$class = new \ReflectionClass( \Aimeos\Controller\Frontend\Product\Decorator\Base::class );
235
-		$method = $class->getMethod( $name );
236
-		$method->setAccessible( true );
234
+		$class = new \ReflectionClass(\Aimeos\Controller\Frontend\Product\Decorator\Base::class);
235
+		$method = $class->getMethod($name);
236
+		$method->setAccessible(true);
237 237
 
238 238
 		return $method;
239 239
 	}
Please login to merge, or discard this patch.
controller/frontend/src/Controller/Frontend/Product/Factory.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 	 * @param string|null $name Name of the controller implementaton (default: "Standard")
29 29
 	 * @return \Aimeos\Controller\Frontend\Product\Iface Controller object
30 30
 	 */
31
-	public static function create( \Aimeos\MShop\Context\Item\Iface $context, $name = null )
31
+	public static function create(\Aimeos\MShop\Context\Item\Iface $context, $name = null)
32 32
 	{
33 33
 		/** controller/frontend/product/name
34 34
 		 * Class name of the used product frontend controller implementation
@@ -63,20 +63,20 @@  discard block
 block discarded – undo
63 63
 		 * @since 2017.03
64 64
 		 * @category Developer
65 65
 		 */
66
-		if( $name === null ) {
67
-			$name = $context->getConfig()->get( 'controller/frontend/product/name', 'Standard' );
66
+		if ($name === null) {
67
+			$name = $context->getConfig()->get('controller/frontend/product/name', 'Standard');
68 68
 		}
69 69
 
70
-		if( ctype_alnum( $name ) === false )
70
+		if (ctype_alnum($name) === false)
71 71
 		{
72
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Frontend\\Product\\' . $name : '<not a string>';
73
-			throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
72
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Frontend\\Product\\' . $name : '<not a string>';
73
+			throw new \Aimeos\Controller\Frontend\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
74 74
 		}
75 75
 
76 76
 		$iface = '\\Aimeos\\Controller\\Frontend\\Product\\Iface';
77 77
 		$classname = '\\Aimeos\\Controller\\Frontend\\Product\\' . $name;
78 78
 
79
-		$controller = self::createController( $context, $classname, $iface );
79
+		$controller = self::createController($context, $classname, $iface);
80 80
 
81 81
 		/** controller/frontend/product/decorators/excludes
82 82
 		 * Excludes decorators added by the "common" option from the product frontend controllers
@@ -152,6 +152,6 @@  discard block
 block discarded – undo
152 152
 		 * @see controller/frontend/product/decorators/excludes
153 153
 		 * @see controller/frontend/product/decorators/global
154 154
 		 */
155
-		return self::addControllerDecorators( $context, $controller, 'product' );
155
+		return self::addControllerDecorators($context, $controller, 'product');
156 156
 	}
157 157
 }
Please login to merge, or discard this patch.
controller/frontend/src/Controller/Frontend.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 	 * @param boolean $value True to enable caching, false to disable it.
28 28
 	 * @return boolean Previous cache setting
29 29
 	 */
30
-	static public function cache( $value )
30
+	static public function cache($value)
31 31
 	{
32 32
 		self::$cache = (boolean) $value;
33 33
 		self::$objects = [];
@@ -49,26 +49,26 @@  discard block
 block discarded – undo
49 49
 	 * @return \Aimeos\Controller\Frontend\Iface New frontend controller
50 50
 	 * @throws \Aimeos\Controller\Frontend\Exception If the given path is invalid or the manager wasn't found
51 51
 	 */
52
-	static public function create( \Aimeos\MShop\Context\Item\Iface $context, $path )
52
+	static public function create(\Aimeos\MShop\Context\Item\Iface $context, $path)
53 53
 	{
54
-		if( empty( $path ) ) {
55
-			throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Controller path is empty' ) );
54
+		if (empty($path)) {
55
+			throw new \Aimeos\Controller\Frontend\Exception(sprintf('Controller path is empty'));
56 56
 		}
57 57
 
58
-		if( self::$cache === false || !isset( self::$objects[$path] ) )
58
+		if (self::$cache === false || !isset(self::$objects[$path]))
59 59
 		{
60
-			if( ctype_alnum( $path ) === false ) {
61
-				throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Invalid characters in controller name "%1$s"', $path ) );
60
+			if (ctype_alnum($path) === false) {
61
+				throw new \Aimeos\Controller\Frontend\Exception(sprintf('Invalid characters in controller name "%1$s"', $path));
62 62
 			}
63 63
 
64
-			$factory = '\\Aimeos\\Controller\\Frontend\\' . ucfirst( $path ) . '\\Factory';
64
+			$factory = '\\Aimeos\\Controller\\Frontend\\' . ucfirst($path) . '\\Factory';
65 65
 
66
-			if( class_exists( $factory ) === false ) {
67
-				throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Class "%1$s" not available', $factory ) );
66
+			if (class_exists($factory) === false) {
67
+				throw new \Aimeos\Controller\Frontend\Exception(sprintf('Class "%1$s" not available', $factory));
68 68
 			}
69 69
 
70
-			if( ( $controller = call_user_func_array( [$factory, 'create'], [$context] ) ) === false ) {
71
-				throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Invalid factory "%1$s"', $factory ) );
70
+			if (($controller = call_user_func_array([$factory, 'create'], [$context])) === false) {
71
+				throw new \Aimeos\Controller\Frontend\Exception(sprintf('Invalid factory "%1$s"', $factory));
72 72
 			}
73 73
 
74 74
 			self::$objects[$path] = $controller;
Please login to merge, or discard this patch.
controller/frontend/tests/Controller/FrontendTest.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -13,48 +13,48 @@
 block discarded – undo
13 13
 {
14 14
 	public function testCreateController()
15 15
 	{
16
-		$controller = \Aimeos\Controller\Frontend::create( \TestHelperFrontend::getContext(), 'basket' );
17
-		$this->assertInstanceOf( '\\Aimeos\\Controller\\Frontend\\Iface', $controller );
16
+		$controller = \Aimeos\Controller\Frontend::create(\TestHelperFrontend::getContext(), 'basket');
17
+		$this->assertInstanceOf('\\Aimeos\\Controller\\Frontend\\Iface', $controller);
18 18
 	}
19 19
 
20 20
 
21 21
 	public function testCreateControllerEmpty()
22 22
 	{
23
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
24
-		\Aimeos\Controller\Frontend::create( \TestHelperFrontend::getContext(), '' );
23
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
24
+		\Aimeos\Controller\Frontend::create(\TestHelperFrontend::getContext(), '');
25 25
 	}
26 26
 
27 27
 
28 28
 	public function testCreateControllerInvalidName()
29 29
 	{
30
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
31
-		\Aimeos\Controller\Frontend::create( \TestHelperFrontend::getContext(), '%^' );
30
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
31
+		\Aimeos\Controller\Frontend::create(\TestHelperFrontend::getContext(), '%^');
32 32
 	}
33 33
 
34 34
 
35 35
 	public function testCreateControllerNotExisting()
36 36
 	{
37
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
38
-		\Aimeos\Controller\Frontend::create( \TestHelperFrontend::getContext(), 'notexist' );
37
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
38
+		\Aimeos\Controller\Frontend::create(\TestHelperFrontend::getContext(), 'notexist');
39 39
 	}
40 40
 
41 41
 
42 42
 	public function testCreateSubControllerNotExisting()
43 43
 	{
44
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
45
-		\Aimeos\Controller\Frontend::create( \TestHelperFrontend::getContext(), 'basket/notexist' );
44
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
45
+		\Aimeos\Controller\Frontend::create(\TestHelperFrontend::getContext(), 'basket/notexist');
46 46
 	}
47 47
 
48 48
 
49 49
 	public function testCache()
50 50
 	{
51 51
 		$context = \TestHelperFrontend::getContext();
52
-		\Aimeos\Controller\Frontend::cache( true );
52
+		\Aimeos\Controller\Frontend::cache(true);
53 53
 
54
-		$controller1 = \Aimeos\Controller\Frontend::create( $context, 'basket' );
55
-		$controller2 = \Aimeos\Controller\Frontend::create( $context, 'basket' );
54
+		$controller1 = \Aimeos\Controller\Frontend::create($context, 'basket');
55
+		$controller2 = \Aimeos\Controller\Frontend::create($context, 'basket');
56 56
 
57
-		\Aimeos\Controller\Frontend::cache( false );
58
-		$this->assertNotSame( $controller1, $controller2 );
57
+		\Aimeos\Controller\Frontend::cache(false);
58
+		$this->assertNotSame($controller1, $controller2);
59 59
 	}
60 60
 }
61 61
\ No newline at end of file
Please login to merge, or discard this patch.
controller/frontend/tests/TestHelperFrontend.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -18,10 +18,10 @@  discard block
 block discarded – undo
18 18
 	}
19 19
 
20 20
 
21
-	public static function getContext( $site = 'unittest' )
21
+	public static function getContext($site = 'unittest')
22 22
 	{
23
-		if( !isset( self::$context[$site] ) ) {
24
-			self::$context[$site] = self::createContext( $site );
23
+		if (!isset(self::$context[$site])) {
24
+			self::$context[$site] = self::createContext($site);
25 25
 		}
26 26
 
27 27
 		return clone self::$context[$site];
@@ -30,13 +30,13 @@  discard block
 block discarded – undo
30 30
 
31 31
 	private static function getAimeos()
32 32
 	{
33
-		if( !isset( self::$aimeos ) )
33
+		if (!isset(self::$aimeos))
34 34
 		{
35 35
 			require_once 'Bootstrap.php';
36
-			spl_autoload_register( 'Aimeos\\Bootstrap::autoload' );
36
+			spl_autoload_register('Aimeos\\Bootstrap::autoload');
37 37
 
38
-			$extdir = dirname( dirname( dirname( dirname( dirname( __FILE__ ) ) ) ) );
39
-			self::$aimeos = new \Aimeos\Bootstrap( array( $extdir ), true );
38
+			$extdir = dirname(dirname(dirname(dirname(dirname(__FILE__)))));
39
+			self::$aimeos = new \Aimeos\Bootstrap(array($extdir), true);
40 40
 		}
41 41
 
42 42
 		return self::$aimeos;
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 	/**
47 47
 	 * @param string $site
48 48
 	 */
49
-	private static function createContext( $site )
49
+	private static function createContext($site)
50 50
 	{
51 51
 		$ctx = new \Aimeos\MShop\Context\Item\Standard();
52 52
 		$aimeos = self::getAimeos();
@@ -56,38 +56,38 @@  discard block
 block discarded – undo
56 56
 		$paths[] = __DIR__ . DIRECTORY_SEPARATOR . 'config';
57 57
 		$file = __DIR__ . DIRECTORY_SEPARATOR . 'confdoc.ser';
58 58
 
59
-		$conf = new \Aimeos\MW\Config\PHPArray( [], $paths );
60
-		$conf = new \Aimeos\MW\Config\Decorator\Memory( $conf );
61
-		$conf = new \Aimeos\MW\Config\Decorator\Documentor( $conf, $file );
62
-		$ctx->setConfig( $conf );
59
+		$conf = new \Aimeos\MW\Config\PHPArray([], $paths);
60
+		$conf = new \Aimeos\MW\Config\Decorator\Memory($conf);
61
+		$conf = new \Aimeos\MW\Config\Decorator\Documentor($conf, $file);
62
+		$ctx->setConfig($conf);
63 63
 
64 64
 
65
-		$dbm = new \Aimeos\MW\DB\Manager\PDO( $conf );
66
-		$ctx->setDatabaseManager( $dbm );
65
+		$dbm = new \Aimeos\MW\DB\Manager\PDO($conf);
66
+		$ctx->setDatabaseManager($dbm);
67 67
 
68 68
 
69
-		$mq = new \Aimeos\MW\MQueue\Manager\Standard( $conf );
70
-		$ctx->setMessageQueueManager( $mq );
69
+		$mq = new \Aimeos\MW\MQueue\Manager\Standard($conf);
70
+		$ctx->setMessageQueueManager($mq);
71 71
 
72 72
 
73
-		$logger = new \Aimeos\MW\Logger\File( 'unittest.log', \Aimeos\MW\Logger\Base::DEBUG );
74
-		$ctx->setLogger( $logger );
73
+		$logger = new \Aimeos\MW\Logger\File('unittest.log', \Aimeos\MW\Logger\Base::DEBUG);
74
+		$ctx->setLogger($logger);
75 75
 
76 76
 
77
-		$i18n = new \Aimeos\MW\Translation\None( 'de' );
78
-		$ctx->setI18n( array( 'de' => $i18n ) );
77
+		$i18n = new \Aimeos\MW\Translation\None('de');
78
+		$ctx->setI18n(array('de' => $i18n));
79 79
 
80 80
 
81 81
 		$session = new \Aimeos\MW\Session\None();
82
-		$ctx->setSession( $session );
82
+		$ctx->setSession($session);
83 83
 
84 84
 
85
-		$localeManager = \Aimeos\MShop\Locale\Manager\Factory::create( $ctx );
86
-		$locale = $localeManager->bootstrap( $site, '', '', false );
87
-		$ctx->setLocale( $locale );
85
+		$localeManager = \Aimeos\MShop\Locale\Manager\Factory::create($ctx);
86
+		$locale = $localeManager->bootstrap($site, '', '', false);
87
+		$ctx->setLocale($locale);
88 88
 
89 89
 
90
-		$ctx->setEditor( 'core:controller/frontend' );
90
+		$ctx->setEditor('core:controller/frontend');
91 91
 
92 92
 		return $ctx;
93 93
 	}
Please login to merge, or discard this patch.
controller/frontend/tests/Controller/Frontend/Service/StandardTest.php 1 patch
Spacing   +50 added lines, -50 removed lines patch added patch discarded remove patch
@@ -19,122 +19,122 @@  discard block
 block discarded – undo
19 19
 
20 20
 	protected function setUp()
21 21
 	{
22
-		\Aimeos\MShop::cache( true );
22
+		\Aimeos\MShop::cache(true);
23 23
 
24 24
 		$this->context = \TestHelperFrontend::getContext();
25
-		$this->object = new \Aimeos\Controller\Frontend\Service\Standard( $this->context );
25
+		$this->object = new \Aimeos\Controller\Frontend\Service\Standard($this->context);
26 26
 	}
27 27
 
28 28
 
29 29
 	public static function setUpBeforeClass()
30 30
 	{
31
-		$orderManager = \Aimeos\MShop\Order\Manager\Factory::create( \TestHelperFrontend::getContext() );
32
-		$orderBaseMgr = $orderManager->getSubManager( 'base' );
31
+		$orderManager = \Aimeos\MShop\Order\Manager\Factory::create(\TestHelperFrontend::getContext());
32
+		$orderBaseMgr = $orderManager->getSubManager('base');
33 33
 		self::$basket = $orderBaseMgr->createItem();
34 34
 	}
35 35
 
36 36
 
37 37
 	protected function tearDown()
38 38
 	{
39
-		\Aimeos\MShop::cache( false );
40
-		unset( $this->object, $this->context );
39
+		\Aimeos\MShop::cache(false);
40
+		unset($this->object, $this->context);
41 41
 	}
42 42
 
43 43
 
44 44
 	public function testCheckAttributes()
45 45
 	{
46
-		$attributes = $this->object->checkAttributes( $this->getServiceItem()->getId(), [] );
47
-		$this->assertEquals( [], $attributes );
46
+		$attributes = $this->object->checkAttributes($this->getServiceItem()->getId(), []);
47
+		$this->assertEquals([], $attributes);
48 48
 	}
49 49
 
50 50
 
51 51
 	public function testGetProviders()
52 52
 	{
53
-		$providers = $this->object->getProviders( 'delivery' );
54
-		$this->assertGreaterThan( 0, count( $providers ) );
53
+		$providers = $this->object->getProviders('delivery');
54
+		$this->assertGreaterThan(0, count($providers));
55 55
 
56
-		foreach( $providers as $provider ) {
57
-			$this->assertInstanceOf( '\\Aimeos\\MShop\\Service\\Provider\\Iface', $provider );
56
+		foreach ($providers as $provider) {
57
+			$this->assertInstanceOf('\\Aimeos\\MShop\\Service\\Provider\\Iface', $provider);
58 58
 		}
59 59
 	}
60 60
 
61 61
 
62 62
 	public function testGetProvider()
63 63
 	{
64
-		$provider = $this->object->getProvider( $this->getServiceItem()->getId() );
65
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Service\\Provider\\Iface', $provider );
64
+		$provider = $this->object->getProvider($this->getServiceItem()->getId());
65
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Service\\Provider\\Iface', $provider);
66 66
 	}
67 67
 
68 68
 
69 69
 	public function testProcess()
70 70
 	{
71 71
 		$form = new \Aimeos\MShop\Common\Item\Helper\Form\Standard();
72
-		$item = \Aimeos\MShop::create( $this->context, 'order' )->createItem();
73
-		$serviceId = \Aimeos\MShop::create( $this->context, 'service' )->findItem( 'unitcode' )->getId();
72
+		$item = \Aimeos\MShop::create($this->context, 'order')->createItem();
73
+		$serviceId = \Aimeos\MShop::create($this->context, 'service')->findItem('unitcode')->getId();
74 74
 
75
-		$provider = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Delivery\\Standard' )
75
+		$provider = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Delivery\\Standard')
76 76
 			->disableOriginalConstructor()
77
-			->setMethods( ['process'] )
77
+			->setMethods(['process'])
78 78
 			->getMock();
79 79
 
80
-		$manager = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
81
-			->setConstructorArgs( [$this->context] )
82
-			->setMethods( ['getProvider'] )
80
+		$manager = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
81
+			->setConstructorArgs([$this->context])
82
+			->setMethods(['getProvider'])
83 83
 			->getMock();
84 84
 
85
-		\Aimeos\MShop::inject( 'service', $manager );
85
+		\Aimeos\MShop::inject('service', $manager);
86 86
 
87
-		$provider->expects( $this->once() )->method( 'process' )->will( $this->returnValue( $form ) );
88
-		$manager->expects( $this->once() )->method( 'getProvider' )->will( $this->returnValue( $provider ) );
87
+		$provider->expects($this->once())->method('process')->will($this->returnValue($form));
88
+		$manager->expects($this->once())->method('getProvider')->will($this->returnValue($provider));
89 89
 
90 90
 
91
-		$result = $this->object->process( $item, $serviceId, [], [] );
92
-		$this->assertInstanceOf( \Aimeos\MShop\Common\Item\Helper\Form\Iface::class, $result );
91
+		$result = $this->object->process($item, $serviceId, [], []);
92
+		$this->assertInstanceOf(\Aimeos\MShop\Common\Item\Helper\Form\Iface::class, $result);
93 93
 	}
94 94
 
95 95
 
96 96
 	public function testUpdatePush()
97 97
 	{
98
-		$request = $this->getMockBuilder( \Psr\Http\Message\ServerRequestInterface::class )->getMock();
99
-		$response = $this->getMockBuilder( \Psr\Http\Message\ResponseInterface::class )->getMock();
98
+		$request = $this->getMockBuilder(\Psr\Http\Message\ServerRequestInterface::class)->getMock();
99
+		$response = $this->getMockBuilder(\Psr\Http\Message\ResponseInterface::class)->getMock();
100 100
 
101
-		$response->expects( $this->once() )->method( 'withStatus' )->will( $this->returnValue( $response ) );
101
+		$response->expects($this->once())->method('withStatus')->will($this->returnValue($response));
102 102
 
103
-		$this->assertInstanceOf( \Psr\Http\Message\ResponseInterface::class, $this->object->updatePush( $request, $response, 'unitcode' ) );
103
+		$this->assertInstanceOf(\Psr\Http\Message\ResponseInterface::class, $this->object->updatePush($request, $response, 'unitcode'));
104 104
 	}
105 105
 
106 106
 
107 107
 	public function testUpdateSync()
108 108
 	{
109
-		$item = \Aimeos\MShop::create( $this->context, 'order' )->createItem();
110
-		$request = $this->getMockBuilder( \Psr\Http\Message\ServerRequestInterface::class )->getMock();
109
+		$item = \Aimeos\MShop::create($this->context, 'order')->createItem();
110
+		$request = $this->getMockBuilder(\Psr\Http\Message\ServerRequestInterface::class)->getMock();
111 111
 
112
-		$provider = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Provider\\Delivery\\Standard' )
113
-			->setMethods( ['updateSync', 'query', 'isImplemented'] )
112
+		$provider = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Provider\\Delivery\\Standard')
113
+			->setMethods(['updateSync', 'query', 'isImplemented'])
114 114
 			->disableOriginalConstructor()
115 115
 			->getMock();
116 116
 
117
-		$orderManager = $this->getMockBuilder( '\\Aimeos\\MShop\\Order\\Manager\\Standard' )
118
-			->setConstructorArgs( array( $this->context ) )
119
-			->setMethods( ['getItem'] )
117
+		$orderManager = $this->getMockBuilder('\\Aimeos\\MShop\\Order\\Manager\\Standard')
118
+			->setConstructorArgs(array($this->context))
119
+			->setMethods(['getItem'])
120 120
 			->getMock();
121 121
 
122
-		$serviceManager = $this->getMockBuilder( '\\Aimeos\\MShop\\Service\\Manager\\Standard' )
123
-			->setConstructorArgs( array( $this->context ) )
124
-			->setMethods( ['getProvider'] )
122
+		$serviceManager = $this->getMockBuilder('\\Aimeos\\MShop\\Service\\Manager\\Standard')
123
+			->setConstructorArgs(array($this->context))
124
+			->setMethods(['getProvider'])
125 125
 			->getMock();
126 126
 
127
-		\Aimeos\MShop::inject( 'order', $orderManager );
128
-		\Aimeos\MShop::inject( 'service', $serviceManager );
127
+		\Aimeos\MShop::inject('order', $orderManager);
128
+		\Aimeos\MShop::inject('service', $serviceManager);
129 129
 
130 130
 
131
-		$orderManager->expects( $this->once() )->method( 'getItem' )->will( $this->returnValue( $item ) );
132
-		$serviceManager->expects( $this->once() )->method( 'getProvider' )->will( $this->returnValue( $provider ) );
133
-		$provider->expects( $this->once() )->method( 'updateSync' )->will( $this->returnValue( $item ) );
134
-		$provider->expects( $this->once() )->method( 'isImplemented' )->will( $this->returnValue( true ) );
135
-		$provider->expects( $this->once() )->method( 'query' );
131
+		$orderManager->expects($this->once())->method('getItem')->will($this->returnValue($item));
132
+		$serviceManager->expects($this->once())->method('getProvider')->will($this->returnValue($provider));
133
+		$provider->expects($this->once())->method('updateSync')->will($this->returnValue($item));
134
+		$provider->expects($this->once())->method('isImplemented')->will($this->returnValue(true));
135
+		$provider->expects($this->once())->method('query');
136 136
 
137
-		$this->object->updateSync( $request, 'unitcode', -1 );
137
+		$this->object->updateSync($request, 'unitcode', -1);
138 138
 	}
139 139
 
140 140
 
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 	 */
144 144
 	protected function getServiceItem()
145 145
 	{
146
-		$manager = \Aimeos\MShop\Service\Manager\Factory::create( \TestHelperFrontend::getContext() );
147
-		return $manager->findItem( 'unitcode' );
146
+		$manager = \Aimeos\MShop\Service\Manager\Factory::create(\TestHelperFrontend::getContext());
147
+		return $manager->findItem('unitcode');
148 148
 	}
149 149
 }
Please login to merge, or discard this patch.
controller/frontend/tests/Controller/Frontend/Basket/BaseTest.php 1 patch
Spacing   +138 added lines, -138 removed lines patch added patch discarded remove patch
@@ -16,53 +16,53 @@  discard block
 block discarded – undo
16 16
 	protected function setUp()
17 17
 	{
18 18
 		$this->context = \TestHelperFrontend::getContext();
19
-		\Aimeos\MShop::cache( true );
19
+		\Aimeos\MShop::cache(true);
20 20
 	}
21 21
 
22 22
 
23 23
 	protected function tearDown()
24 24
 	{
25
-		\Aimeos\MShop::cache( false );
26
-		$this->context->getSession()->set( 'aimeos', [] );
25
+		\Aimeos\MShop::cache(false);
26
+		$this->context->getSession()->set('aimeos', []);
27 27
 
28
-		unset( $this->context );
28
+		unset($this->context);
29 29
 	}
30 30
 
31 31
 
32 32
 	public function testCheckLocale()
33 33
 	{
34
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Basket\Standard::class )
35
-			->setConstructorArgs( [$this->context] )
36
-			->setMethods( null )
34
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Basket\Standard::class)
35
+			->setConstructorArgs([$this->context])
36
+			->setMethods(null)
37 37
 			->getMock();
38 38
 
39
-		$this->context->getSession()->set( 'aimeos/basket/locale', 'unittest|en|EUR' );
40
-		$this->access( 'checkLocale' )->invokeArgs( $object, [$this->context->getLocale(), 'unittest'] );
39
+		$this->context->getSession()->set('aimeos/basket/locale', 'unittest|en|EUR');
40
+		$this->access('checkLocale')->invokeArgs($object, [$this->context->getLocale(), 'unittest']);
41 41
 	}
42 42
 
43 43
 
44 44
 	public function testCopyAddresses()
45 45
 	{
46
-		$manager = \Aimeos\MShop::create( \TestHelperFrontend::getContext(), 'order/base' );
46
+		$manager = \Aimeos\MShop::create(\TestHelperFrontend::getContext(), 'order/base');
47 47
 		$ordBaseItem = $manager->createItem();
48 48
 
49
-		$address = $this->getAddress( 'Example company' );
50
-		$ordBaseItem->setAddress( $address, \Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT );
49
+		$address = $this->getAddress('Example company');
50
+		$ordBaseItem->setAddress($address, \Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT);
51 51
 
52 52
 
53
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Basket\Standard::class )
54
-			->setConstructorArgs( [$this->context] )
55
-			->setMethods( null )
53
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Basket\Standard::class)
54
+			->setConstructorArgs([$this->context])
55
+			->setMethods(null)
56 56
 			->getMock();
57 57
 
58
-		$result = $this->access( 'copyAddresses' )->invokeArgs( $object, [$ordBaseItem, ['test'], 'unittest|en|EUR'] );
58
+		$result = $this->access('copyAddresses')->invokeArgs($object, [$ordBaseItem, ['test'], 'unittest|en|EUR']);
59 59
 
60 60
 
61
-		$this->assertEquals( ['test'], $result );
62
-		$this->assertEquals( 1, count( $object->get()->getAddresses() ) );
61
+		$this->assertEquals(['test'], $result);
62
+		$this->assertEquals(1, count($object->get()->getAddresses()));
63 63
 
64
-		$addr = $object->get()->getAddress( \Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT );
65
-		$this->assertInstanceOf( \Aimeos\MShop\Order\Item\Base\Address\Iface::class, $addr );
64
+		$addr = $object->get()->getAddress(\Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT);
65
+		$this->assertInstanceOf(\Aimeos\MShop\Order\Item\Base\Address\Iface::class, $addr);
66 66
 
67 67
 		$object->clear();
68 68
 	}
@@ -70,54 +70,54 @@  discard block
 block discarded – undo
70 70
 
71 71
 	public function testCopyAddressesException()
72 72
 	{
73
-		$manager = \Aimeos\MShop::create( \TestHelperFrontend::getContext(), 'order/base' );
73
+		$manager = \Aimeos\MShop::create(\TestHelperFrontend::getContext(), 'order/base');
74 74
 		$ordBaseItem = $manager->createItem();
75 75
 
76
-		$address = $this->getAddress( 'Example company' );
77
-		$ordBaseItem->setAddress( $address, \Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT );
76
+		$address = $this->getAddress('Example company');
77
+		$ordBaseItem->setAddress($address, \Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT);
78 78
 
79 79
 
80
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Basket\Standard::class )
81
-			->setConstructorArgs( [$this->context] )
82
-			->setMethods( ['setAddress'] )
80
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Basket\Standard::class)
81
+			->setConstructorArgs([$this->context])
82
+			->setMethods(['setAddress'])
83 83
 			->getMock();
84 84
 
85
-		$object->expects( $this->once() )->method( 'setAddress' )->will( $this->throwException( new \Exception() ) );
85
+		$object->expects($this->once())->method('setAddress')->will($this->throwException(new \Exception()));
86 86
 
87
-		$result = $this->access( 'copyAddresses' )->invokeArgs( $object, [$ordBaseItem, [], 'unittest|en|EUR'] );
87
+		$result = $this->access('copyAddresses')->invokeArgs($object, [$ordBaseItem, [], 'unittest|en|EUR']);
88 88
 
89
-		$this->assertEquals( 1, count( $result ) );
90
-		$this->assertArrayHasKey( 'address', $result );
89
+		$this->assertEquals(1, count($result));
90
+		$this->assertArrayHasKey('address', $result);
91 91
 	}
92 92
 
93 93
 
94 94
 	public function testCopyCoupon()
95 95
 	{
96
-		$manager = \Aimeos\MShop::create( \TestHelperFrontend::getContext(), 'order/base' );
96
+		$manager = \Aimeos\MShop::create(\TestHelperFrontend::getContext(), 'order/base');
97 97
 		$ordBaseItem = $manager->createItem();
98 98
 
99
-		$product = \Aimeos\MShop::create( $this->context, 'product' )->findItem( 'CNC', ['price'] );
100
-		$ordProdManager = \Aimeos\MShop::create( $this->context, 'order/base/product' );
101
-		$ordProdItem = $ordProdManager->createItem()->copyFrom( $product );
99
+		$product = \Aimeos\MShop::create($this->context, 'product')->findItem('CNC', ['price']);
100
+		$ordProdManager = \Aimeos\MShop::create($this->context, 'order/base/product');
101
+		$ordProdItem = $ordProdManager->createItem()->copyFrom($product);
102 102
 
103
-		$priceItems = $product->getRefItems( 'price' );
104
-		$ordProdItem->setPrice( reset( $priceItems ) );
103
+		$priceItems = $product->getRefItems('price');
104
+		$ordProdItem->setPrice(reset($priceItems));
105 105
 
106
-		$ordBaseItem->addProduct( $ordProdItem );
107
-		$ordBaseItem->addCoupon( 'OPQR', [] );
106
+		$ordBaseItem->addProduct($ordProdItem);
107
+		$ordBaseItem->addCoupon('OPQR', []);
108 108
 
109 109
 
110
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Basket\Standard::class )
111
-			->setConstructorArgs( [$this->context] )
112
-			->setMethods( null )
110
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Basket\Standard::class)
111
+			->setConstructorArgs([$this->context])
112
+			->setMethods(null)
113 113
 			->getMock();
114 114
 
115
-		$object->addProduct( $product->getId() );
115
+		$object->addProduct($product->getId());
116 116
 
117
-		$result = $this->access( 'copyCoupons' )->invokeArgs( $object, [$ordBaseItem, ['test'], 'unittest|en|EUR'] );
117
+		$result = $this->access('copyCoupons')->invokeArgs($object, [$ordBaseItem, ['test'], 'unittest|en|EUR']);
118 118
 
119 119
 
120
-		$this->assertEquals( ['test'], $result );
120
+		$this->assertEquals(['test'], $result);
121 121
 
122 122
 		$object->clear();
123 123
 	}
@@ -125,48 +125,48 @@  discard block
 block discarded – undo
125 125
 
126 126
 	public function testCopyCouponException()
127 127
 	{
128
-		$manager = \Aimeos\MShop::create( \TestHelperFrontend::getContext(), 'order/base' );
128
+		$manager = \Aimeos\MShop::create(\TestHelperFrontend::getContext(), 'order/base');
129 129
 		$ordBaseItem = $manager->createItem();
130 130
 
131
-		$ordBaseItem->addCoupon( '90AB', [] );
131
+		$ordBaseItem->addCoupon('90AB', []);
132 132
 
133 133
 
134
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Basket\Standard::class )
135
-			->setConstructorArgs( [$this->context] )
136
-			->setMethods( ['addCoupon'] )
134
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Basket\Standard::class)
135
+			->setConstructorArgs([$this->context])
136
+			->setMethods(['addCoupon'])
137 137
 			->getMock();
138 138
 
139
-		$object->expects( $this->once() )->method( 'addCoupon' )->will( $this->throwException( new \Exception() ) );
139
+		$object->expects($this->once())->method('addCoupon')->will($this->throwException(new \Exception()));
140 140
 
141
-		$result = $this->access( 'copyCoupons' )->invokeArgs( $object, [$ordBaseItem, [], 'unittest|en|EUR'] );
141
+		$result = $this->access('copyCoupons')->invokeArgs($object, [$ordBaseItem, [], 'unittest|en|EUR']);
142 142
 
143
-		$this->assertEquals( 1, count( $result ) );
144
-		$this->assertArrayHasKey( 'coupon', $result );
143
+		$this->assertEquals(1, count($result));
144
+		$this->assertArrayHasKey('coupon', $result);
145 145
 	}
146 146
 
147 147
 
148 148
 	public function testCopyProduct()
149 149
 	{
150
-		$manager = \Aimeos\MShop::create( \TestHelperFrontend::getContext(), 'order/base' );
150
+		$manager = \Aimeos\MShop::create(\TestHelperFrontend::getContext(), 'order/base');
151 151
 		$ordBaseItem = $manager->createItem();
152 152
 
153
-		$product = \Aimeos\MShop::create( $this->context, 'product' )->findItem( 'CNC' );
154
-		$ordProdManager = \Aimeos\MShop::create( $this->context, 'order/base/product' );
155
-		$ordProdItem = $ordProdManager->createItem()->copyFrom( $product );
156
-		$ordBaseItem->addProduct( $ordProdItem );
153
+		$product = \Aimeos\MShop::create($this->context, 'product')->findItem('CNC');
154
+		$ordProdManager = \Aimeos\MShop::create($this->context, 'order/base/product');
155
+		$ordProdItem = $ordProdManager->createItem()->copyFrom($product);
156
+		$ordBaseItem->addProduct($ordProdItem);
157 157
 
158 158
 
159
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Basket\Standard::class )
160
-			->setConstructorArgs( [$this->context] )
161
-			->setMethods( null )
159
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Basket\Standard::class)
160
+			->setConstructorArgs([$this->context])
161
+			->setMethods(null)
162 162
 			->getMock();
163 163
 
164
-		$result = $this->access( 'copyProducts' )->invokeArgs( $object, [$ordBaseItem, ['test'], 'unittest|en|EUR'] );
164
+		$result = $this->access('copyProducts')->invokeArgs($object, [$ordBaseItem, ['test'], 'unittest|en|EUR']);
165 165
 
166 166
 
167
-		$this->assertEquals( ['test'], $result );
168
-		$this->assertEquals( 1, count( $object->get()->getProducts() ) );
169
-		$this->assertInstanceOf( \Aimeos\MShop\Order\Item\Base\Product\Iface::class, $object->get()->getProduct( 0 ) );
167
+		$this->assertEquals(['test'], $result);
168
+		$this->assertEquals(1, count($object->get()->getProducts()));
169
+		$this->assertInstanceOf(\Aimeos\MShop\Order\Item\Base\Product\Iface::class, $object->get()->getProduct(0));
170 170
 
171 171
 		$object->clear();
172 172
 	}
@@ -174,58 +174,58 @@  discard block
 block discarded – undo
174 174
 
175 175
 	public function testCopyProductException()
176 176
 	{
177
-		$manager = \Aimeos\MShop::create( \TestHelperFrontend::getContext(), 'order/base' );
177
+		$manager = \Aimeos\MShop::create(\TestHelperFrontend::getContext(), 'order/base');
178 178
 		$ordBaseItem = $manager->createItem();
179 179
 
180
-		$product = \Aimeos\MShop::create( $this->context, 'product' )->findItem( 'CNC' );
181
-		$ordProdManager = \Aimeos\MShop::create( $this->context, 'order/base/product' );
182
-		$ordProdItem = $ordProdManager->createItem()->copyFrom( $product );
183
-		$ordBaseItem->addProduct( $ordProdItem );
180
+		$product = \Aimeos\MShop::create($this->context, 'product')->findItem('CNC');
181
+		$ordProdManager = \Aimeos\MShop::create($this->context, 'order/base/product');
182
+		$ordProdItem = $ordProdManager->createItem()->copyFrom($product);
183
+		$ordBaseItem->addProduct($ordProdItem);
184 184
 
185 185
 
186
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Basket\Standard::class )
187
-			->setConstructorArgs( [$this->context] )
188
-			->setMethods( ['addProduct'] )
186
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Basket\Standard::class)
187
+			->setConstructorArgs([$this->context])
188
+			->setMethods(['addProduct'])
189 189
 			->getMock();
190 190
 
191
-		$object->expects( $this->once() )->method( 'addProduct' )->will( $this->throwException( new \Exception() ) );
191
+		$object->expects($this->once())->method('addProduct')->will($this->throwException(new \Exception()));
192 192
 
193
-		$result = $this->access( 'copyProducts' )->invokeArgs( $object, [$ordBaseItem, [], 'unittest|en|EUR'] );
193
+		$result = $this->access('copyProducts')->invokeArgs($object, [$ordBaseItem, [], 'unittest|en|EUR']);
194 194
 
195
-		$this->assertEquals( 1, count( $result ) );
196
-		$this->assertArrayHasKey( 'product', $result );
195
+		$this->assertEquals(1, count($result));
196
+		$this->assertArrayHasKey('product', $result);
197 197
 	}
198 198
 
199 199
 
200 200
 	public function testCopyServices()
201 201
 	{
202
-		$manager = \Aimeos\MShop::create( \TestHelperFrontend::getContext(), 'order/base' );
202
+		$manager = \Aimeos\MShop::create(\TestHelperFrontend::getContext(), 'order/base');
203 203
 		$ordBaseItem = $manager->createItem();
204 204
 
205
-		$serviceManager = \Aimeos\MShop::create( $this->context, 'service' );
206
-		$ordServManager = \Aimeos\MShop::create( $this->context, 'order/base/service' );
205
+		$serviceManager = \Aimeos\MShop::create($this->context, 'service');
206
+		$ordServManager = \Aimeos\MShop::create($this->context, 'order/base/service');
207 207
 
208
-		$serviceItem = $serviceManager->findItem( 'unitcode', [], 'service', 'delivery' );
209
-		$ordServItem = $ordServManager->createItem()->copyFrom( $serviceItem );
208
+		$serviceItem = $serviceManager->findItem('unitcode', [], 'service', 'delivery');
209
+		$ordServItem = $ordServManager->createItem()->copyFrom($serviceItem);
210 210
 
211
-		$ordBaseItem->addService( $ordServItem, \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY );
211
+		$ordBaseItem->addService($ordServItem, \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY);
212 212
 
213 213
 
214
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Basket\Standard::class )
215
-			->setConstructorArgs( [$this->context] )
216
-			->setMethods( null )
214
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Basket\Standard::class)
215
+			->setConstructorArgs([$this->context])
216
+			->setMethods(null)
217 217
 			->getMock();
218 218
 
219
-		$result = $this->access( 'copyServices' )->invokeArgs( $object, [$ordBaseItem, ['test'], 'unittest|en|EUR'] );
219
+		$result = $this->access('copyServices')->invokeArgs($object, [$ordBaseItem, ['test'], 'unittest|en|EUR']);
220 220
 
221 221
 
222
-		$this->assertEquals( ['test'], $result );
223
-		$this->assertEquals( 1, count( $object->get()->getServices() ) );
222
+		$this->assertEquals(['test'], $result);
223
+		$this->assertEquals(1, count($object->get()->getServices()));
224 224
 
225
-		$services = $object->get()->getService( \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY );
225
+		$services = $object->get()->getService(\Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY);
226 226
 
227
-		foreach( $services as $service ) {
228
-			$this->assertInstanceOf( \Aimeos\MShop\Order\Item\Base\Service\Iface::class, $service );
227
+		foreach ($services as $service) {
228
+			$this->assertInstanceOf(\Aimeos\MShop\Order\Item\Base\Service\Iface::class, $service);
229 229
 		}
230 230
 
231 231
 		$object->clear();
@@ -234,106 +234,106 @@  discard block
 block discarded – undo
234 234
 
235 235
 	public function testCopyServicesException()
236 236
 	{
237
-		$manager = \Aimeos\MShop::create( \TestHelperFrontend::getContext(), 'order/base' );
237
+		$manager = \Aimeos\MShop::create(\TestHelperFrontend::getContext(), 'order/base');
238 238
 		$ordBaseItem = $manager->createItem();
239 239
 
240
-		$serviceManager = \Aimeos\MShop::create( $this->context, 'service' );
241
-		$ordServManager = \Aimeos\MShop::create( $this->context, 'order/base/service' );
240
+		$serviceManager = \Aimeos\MShop::create($this->context, 'service');
241
+		$ordServManager = \Aimeos\MShop::create($this->context, 'order/base/service');
242 242
 
243
-		$serviceItem = $serviceManager->findItem( 'unitcode', [], 'service', 'delivery' );
244
-		$ordServItem = $ordServManager->createItem()->copyFrom( $serviceItem );
243
+		$serviceItem = $serviceManager->findItem('unitcode', [], 'service', 'delivery');
244
+		$ordServItem = $ordServManager->createItem()->copyFrom($serviceItem);
245 245
 
246
-		$ordBaseItem->addService( $ordServItem, \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY );
246
+		$ordBaseItem->addService($ordServItem, \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY);
247 247
 
248 248
 
249
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Basket\Standard::class )
250
-			->setConstructorArgs( [$this->context] )
251
-			->setMethods( ['addService'] )
249
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Basket\Standard::class)
250
+			->setConstructorArgs([$this->context])
251
+			->setMethods(['addService'])
252 252
 			->getMock();
253 253
 
254
-		$object->expects( $this->once() )->method( 'addService' )->will( $this->throwException( new \Exception() ) );
254
+		$object->expects($this->once())->method('addService')->will($this->throwException(new \Exception()));
255 255
 
256
-		$result = $this->access( 'copyServices' )->invokeArgs( $object, [$ordBaseItem, [], 'unittest|en|EUR'] );
256
+		$result = $this->access('copyServices')->invokeArgs($object, [$ordBaseItem, [], 'unittest|en|EUR']);
257 257
 
258
-		$this->assertEquals( 0, count( $result ) );
258
+		$this->assertEquals(0, count($result));
259 259
 	}
260 260
 
261 261
 
262 262
 	public function testCreateSubscriptions()
263 263
 	{
264
-		$baseManager = \Aimeos\MShop::create( $this->context, 'order/base' );
264
+		$baseManager = \Aimeos\MShop::create($this->context, 'order/base');
265 265
 
266 266
 		$search = $baseManager->createSearch();
267
-		$search->setConditions( $search->compare( '==', 'order.base.price', '53.50' ) );
267
+		$search->setConditions($search->compare('==', 'order.base.price', '53.50'));
268 268
 
269
-		$items = $baseManager->searchItems( $search, ['order/base/product'] );
269
+		$items = $baseManager->searchItems($search, ['order/base/product']);
270 270
 
271
-		if( ( $basket = reset( $items ) ) === false ) {
272
-			throw new \Exception( sprintf( 'No order base item found for price "%1$s"', '53,50' ) );
271
+		if (($basket = reset($items)) === false) {
272
+			throw new \Exception(sprintf('No order base item found for price "%1$s"', '53,50'));
273 273
 		}
274 274
 
275
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Basket\Standard::class )
276
-			->setConstructorArgs( [$this->context] )
277
-			->setMethods( ['getAttributes'] )
275
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Basket\Standard::class)
276
+			->setConstructorArgs([$this->context])
277
+			->setMethods(['getAttributes'])
278 278
 			->getMock();
279 279
 
280
-		$stub = $this->getMockBuilder( \Aimeos\MShop\Subscription\Manager\Standard::class )
281
-			->setConstructorArgs( [$this->context] )
282
-			->setMethods( ['saveItem'] )
280
+		$stub = $this->getMockBuilder(\Aimeos\MShop\Subscription\Manager\Standard::class)
281
+			->setConstructorArgs([$this->context])
282
+			->setMethods(['saveItem'])
283 283
 			->getMock();
284 284
 
285
-		\Aimeos\MShop::inject( 'subscription', $stub );
285
+		\Aimeos\MShop::inject('subscription', $stub);
286 286
 
287
-		$stub->expects( $this->exactly( 2 ) )->method( 'saveItem' );
287
+		$stub->expects($this->exactly(2))->method('saveItem');
288 288
 
289
-		$this->access( 'createSubscriptions' )->invokeArgs( $object, [$basket] );
289
+		$this->access('createSubscriptions')->invokeArgs($object, [$basket]);
290 290
 	}
291 291
 
292 292
 
293 293
 	public function testGetOrderProductAttributes()
294 294
 	{
295
-		$object = $this->getMockBuilder( \Aimeos\Controller\Frontend\Basket\Standard::class )
296
-			->setConstructorArgs( [$this->context] )
297
-			->setMethods( ['getAttributes'] )
295
+		$object = $this->getMockBuilder(\Aimeos\Controller\Frontend\Basket\Standard::class)
296
+			->setConstructorArgs([$this->context])
297
+			->setMethods(['getAttributes'])
298 298
 			->getMock();
299 299
 
300
-		$list = [1 => new \Aimeos\MShop\Attribute\Item\Standard( ['attribute.code' => 'special_instructions'] )];
301
-		$object->expects( $this->once() )->method( 'getAttributes' )->will( $this->returnValue( $list ) );
300
+		$list = [1 => new \Aimeos\MShop\Attribute\Item\Standard(['attribute.code' => 'special_instructions'])];
301
+		$object->expects($this->once())->method('getAttributes')->will($this->returnValue($list));
302 302
 
303
-		$result = $this->access( 'getOrderProductAttributes' )->invokeArgs( $object, ['test', ['1'], ['1' => 'test']] );
303
+		$result = $this->access('getOrderProductAttributes')->invokeArgs($object, ['test', ['1'], ['1' => 'test']]);
304 304
 
305
-		$this->assertEquals( 1, count( $result ) );
306
-		$this->assertEquals( 'test', $result[0]->getValue() );
305
+		$this->assertEquals(1, count($result));
306
+		$this->assertEquals('test', $result[0]->getValue());
307 307
 	}
308 308
 
309 309
 
310 310
 	/**
311 311
 	 * @param string $company
312 312
 	 */
313
-	protected function getAddress( $company )
313
+	protected function getAddress($company)
314 314
 	{
315
-		$manager = \Aimeos\MShop::create( \TestHelperFrontend::getContext(), 'customer/address' );
315
+		$manager = \Aimeos\MShop::create(\TestHelperFrontend::getContext(), 'customer/address');
316 316
 
317 317
 		$search = $manager->createSearch();
318
-		$search->setConditions( $search->compare( '==', 'customer.address.company', $company ) );
319
-		$items = $manager->searchItems( $search );
318
+		$search->setConditions($search->compare('==', 'customer.address.company', $company));
319
+		$items = $manager->searchItems($search);
320 320
 
321
-		if( ( $item = reset( $items ) ) === false ) {
322
-			throw new \RuntimeException( sprintf( 'No address item with company "%1$s" found', $company ) );
321
+		if (($item = reset($items)) === false) {
322
+			throw new \RuntimeException(sprintf('No address item with company "%1$s" found', $company));
323 323
 		}
324 324
 
325
-		$ordAddrManager = \Aimeos\MShop::create( \TestHelperFrontend::getContext(), 'order/base/address' );
326
-		$ordAddrItem = $ordAddrManager->createItem()->copyFrom( $item );
325
+		$ordAddrManager = \Aimeos\MShop::create(\TestHelperFrontend::getContext(), 'order/base/address');
326
+		$ordAddrItem = $ordAddrManager->createItem()->copyFrom($item);
327 327
 
328 328
 		return $ordAddrItem;
329 329
 	}
330 330
 
331 331
 
332
-	protected function access( $name )
332
+	protected function access($name)
333 333
 	{
334
-		$class = new \ReflectionClass( \Aimeos\Controller\Frontend\Basket\Base::class );
335
-		$method = $class->getMethod( $name );
336
-		$method->setAccessible( true );
334
+		$class = new \ReflectionClass(\Aimeos\Controller\Frontend\Basket\Base::class);
335
+		$method = $class->getMethod($name);
336
+		$method->setAccessible(true);
337 337
 
338 338
 		return $method;
339 339
 	}
Please login to merge, or discard this patch.