Inspection of "Sort by type position if possible" - aimeos/ai-controller-frontend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8bf1bf...29627f )

by Aimeos

created 2018-06-16 12:17 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 	 * @param string|null $name Name of the controller implementaton (default: "Standard")
 	 * @return \Aimeos\Controller\Frontend\Product\Iface Controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, $name = null)
 	{
 		/** controller/frontend/product/name
 		 * Class name of the used product frontend controller implementation
@@ -63,20 +63,20 @@  discard block
 block discarded – undo
 		 * @since 2017.03
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/frontend/product/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/frontend/product/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Frontend\\Product\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Frontend\\Product\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Frontend\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Frontend\\Product\\Iface';
 		$classname = '\\Aimeos\\Controller\\Frontend\\Product\\' . $name;
 
-		$manager = self::createControllerBase( $context, $classname, $iface );
+		$manager = self::createControllerBase($context, $classname, $iface);
 
 		/** controller/frontend/product/decorators/excludes
 		 * Excludes decorators added by the "common" option from the product frontend controllers
@@ -152,6 +152,6 @@  discard block
 block discarded – undo
 		 * @see controller/frontend/product/decorators/excludes
 		 * @see controller/frontend/product/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $manager, 'product' );
+		return self::addControllerDecorators($context, $manager, 'product');
 	}
 }

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/Stock/FactoryTest.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -15,31 +15,31 @@
 block discarded – undo
 	{
 		$target = '\\Aimeos\\Controller\\Frontend\\Stock\\Iface';
 
-		$controller = \Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext() );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext());
+		$this->assertInstanceOf($target, $controller);
 
-		$controller = \Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
+		$this->assertInstanceOf($target, $controller);
 	}
 
 
 	public function testCreateControllerInvalidImplementation()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
 	}
 
 
 	public function testCreateControllerInvalidName()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), '%^');
 	}
 
 
 	public function testCreateControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
 	}
 }

Please login to merge, or discard this patch.

controller/frontend/src/Controller/Frontend/Stock/Iface.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterCodes( \Aimeos\MW\Criteria\Iface $filter, array $codes );
+	public function addFilterCodes(\Aimeos\MW\Criteria\Iface $filter, array $codes);
 
 
 	/**
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes );
+	public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes);
 
 
 	/**
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Stock\Item\Iface Stock item including the referenced domains items
 	 * @since 2017.03
 	 */
-	public function getItem( $id );
+	public function getItem($id);
 
 
 	/**
@@ -69,5 +69,5 @@  discard block
 block discarded – undo
 	 * @return array Ordered list of stock items implementing \Aimeos\MShop\Stock\Item\Iface
 	 * @since 2017.03
 	 */
-	public function searchItems( \Aimeos\MW\Criteria\Iface $filter, &$total = null );
+	public function searchItems(\Aimeos\MW\Criteria\Iface $filter, &$total = null);
 }

Please login to merge, or discard this patch.

controller/frontend/src/Controller/Frontend/Stock/Factory.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 	 * @param string|null $name Name of the controller implementaton (default: "Standard")
 	 * @return \Aimeos\Controller\Frontend\Stock\Iface Controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, $name = null)
 	{
 		/** controller/frontend/stock/name
 		 * Class name of the used stock frontend controller implementation
@@ -63,20 +63,20 @@  discard block
 block discarded – undo
 		 * @since 2017.03
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/frontend/stock/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/frontend/stock/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Frontend\\Stock\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Frontend\\Stock\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Frontend\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Frontend\\Stock\\Iface';
 		$classname = '\\Aimeos\\Controller\\Frontend\\Stock\\' . $name;
 
-		$manager = self::createControllerBase( $context, $classname, $iface );
+		$manager = self::createControllerBase($context, $classname, $iface);
 
 		/** controller/frontend/stock/decorators/excludes
 		 * Excludes decorators added by the "common" option from the stock frontend controllers
@@ -152,6 +152,6 @@  discard block
 block discarded – undo
 		 * @see controller/frontend/stock/decorators/excludes
 		 * @see controller/frontend/stock/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $manager, 'stock' );
+		return self::addControllerDecorators($context, $manager, 'stock');
 	}
 }

Please login to merge, or discard this patch.

controller/frontend/src/Controller/Frontend/Attribute/Decorator/Base.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -128,7 +128,7 @@
 block discarded – undo
 	/**
 	 * Returns the frontend controller
 	 *
-	 * @return \Aimeos\Controller\Frontend\Attribute\Iface Frontend controller object
+	 * @return \Aimeos\Controller\Frontend\Iface Frontend controller object
 	 */
 	protected function getController()
 	{

Please login to merge, or discard this patch.

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -30,18 +30,18 @@  discard block
 block discarded – undo
 	 * @param \Aimeos\Controller\Frontend\Iface $controller Controller object
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
 	 */
-	public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
+	public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
 	{
 		$iface = '\Aimeos\Controller\Frontend\Attribute\Iface';
-		if( !( $controller instanceof $iface ) )
+		if (!($controller instanceof $iface))
 		{
-			$msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
-			throw new \Aimeos\Controller\Frontend\Exception( $msg );
+			$msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
+			throw new \Aimeos\Controller\Frontend\Exception($msg);
 		}
 
 		$this->controller = $controller;
 
-		parent::__construct( $context );
+		parent::__construct($context);
 	}
 
 
@@ -53,9 +53,9 @@  discard block
 block discarded – undo
 	 * @return mixed Returns the value of the called method
 	 * @throws \Aimeos\Controller\Frontend\Exception If method call failed
 	 */
-	public function __call( $name, array $param )
+	public function __call($name, array $param)
 	{
-		return @call_user_func_array( array( $this->controller, $name ), $param );
+		return @call_user_func_array(array($this->controller, $name), $param);
 	}
 
 
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
+	public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
 	{
-		return $this->controller->addFilterTypes( $filter, $codes );
+		return $this->controller->addFilterTypes($filter, $codes);
 	}
 
 
@@ -94,9 +94,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Attribute\Item\Iface Attribute item including the referenced domains items
 	 * @since 2017.03
 	 */
-	public function getItem( $id, array $domains = array( 'media', 'price', 'text' ) )
+	public function getItem($id, array $domains = array('media', 'price', 'text'))
 	{
-		return $this->controller->getItem( $id, $domains );
+		return $this->controller->getItem($id, $domains);
 	}
 
 
@@ -108,9 +108,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Attribute\Item\Iface[] Associative list of attribute item including the referenced domains items
 	 * @since 2017.03
 	 */
-	public function getItems( array $ids, array $domains = array( 'media', 'price', 'text' ) )
+	public function getItems(array $ids, array $domains = array('media', 'price', 'text'))
 	{
-		return $this->controller->getItems( $ids, $domains );
+		return $this->controller->getItems($ids, $domains);
 	}
 
 
@@ -123,9 +123,9 @@  discard block
 block discarded – undo
 	 * @return array Ordered list of attribute items implementing \Aimeos\MShop\Attribute\Item\Iface
 	 * @since 2017.03
 	 */
-	public function searchItems( \Aimeos\MW\Criteria\Iface $filter, array $domains = array( 'media', 'price', 'text' ), &$total = null )
+	public function searchItems(\Aimeos\MW\Criteria\Iface $filter, array $domains = array('media', 'price', 'text'), &$total = null)
 	{
-		return $this->controller->searchItems( $filter, $domains, $total );
+		return $this->controller->searchItems($filter, $domains, $total);
 	}
 
 

Please login to merge, or discard this patch.

controller/frontend/src/Controller/Frontend/Stock/Decorator/Base.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -140,7 +140,7 @@
 block discarded – undo
 	/**
 	 * Returns the frontend controller
 	 *
-	 * @return \Aimeos\Controller\Frontend\Stock\Iface Frontend controller object
+	 * @return \Aimeos\Controller\Frontend\Iface Frontend controller object
 	 */
 	protected function getController()
 	{

Please login to merge, or discard this patch.

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -30,18 +30,18 @@  discard block
 block discarded – undo
 	 * @param \Aimeos\Controller\Frontend\Iface $controller Controller object
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
 	 */
-	public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
+	public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
 	{
 		$iface = '\Aimeos\Controller\Frontend\Stock\Iface';
-		if( !( $controller instanceof $iface ) )
+		if (!($controller instanceof $iface))
 		{
-			$msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
-			throw new \Aimeos\Controller\Frontend\Exception( $msg );
+			$msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
+			throw new \Aimeos\Controller\Frontend\Exception($msg);
 		}
 
 		$this->controller = $controller;
 
-		parent::__construct( $context );
+		parent::__construct($context);
 	}
 
 
@@ -53,9 +53,9 @@  discard block
 block discarded – undo
 	 * @return mixed Returns the value of the called method
 	 * @throws \Aimeos\Controller\Frontend\Exception If method call failed
 	 */
-	public function __call( $name, array $param )
+	public function __call($name, array $param)
 	{
-		return @call_user_func_array( array( $this->controller, $name ), $param );
+		return @call_user_func_array(array($this->controller, $name), $param);
 	}
 
 
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterCodes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
+	public function addFilterCodes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
 	{
-		return $this->controller->addFilterCodes( $filter, $codes );
+		return $this->controller->addFilterCodes($filter, $codes);
 	}
 
 
@@ -81,9 +81,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
+	public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
 	{
-		return $this->controller->addFilterTypes( $filter, $codes );
+		return $this->controller->addFilterTypes($filter, $codes);
 	}
 
 
@@ -107,9 +107,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Stock\Item\Iface Stock item including the referenced domains items
 	 * @since 2017.03
 	 */
-	public function getItem( $id )
+	public function getItem($id)
 	{
-		return $this->controller->getItem( $id );
+		return $this->controller->getItem($id);
 	}
 
 
@@ -121,9 +121,9 @@  discard block
 block discarded – undo
 	 * @return array Ordered list of stock items implementing \Aimeos\MShop\Stock\Item\Iface
 	 * @since 2017.03
 	 */
-	public function searchItems( \Aimeos\MW\Criteria\Iface $filter, &$total = null )
+	public function searchItems(\Aimeos\MW\Criteria\Iface $filter, &$total = null)
 	{
-		return $this->controller->searchItems( $filter, $total );
+		return $this->controller->searchItems($filter, $total);
 	}
 
 

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/Attribute/FactoryTest.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -15,31 +15,31 @@
 block discarded – undo
 	{
 		$target = '\\Aimeos\\Controller\\Frontend\\Attribute\\Iface';
 
-		$controller = \Aimeos\Controller\Frontend\Attribute\Factory::createController( \TestHelperFrontend::getContext() );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Attribute\Factory::createController(\TestHelperFrontend::getContext());
+		$this->assertInstanceOf($target, $controller);
 
-		$controller = \Aimeos\Controller\Frontend\Attribute\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Attribute\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
+		$this->assertInstanceOf($target, $controller);
 	}
 
 
 	public function testCreateControllerInvalidImplementation()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Attribute\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Attribute\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
 	}
 
 
 	public function testCreateControllerInvalidName()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Attribute\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Attribute\Factory::createController(\TestHelperFrontend::getContext(), '%^');
 	}
 
 
 	public function testCreateControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Attribute\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Attribute\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
 	}
 }

Please login to merge, or discard this patch.

controller/frontend/src/Controller/Frontend/Attribute/Factory.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 	 * @param string|null $name Name of the controller implementaton (default: "Standard")
 	 * @return \Aimeos\Controller\Frontend\Attribute\Iface Controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, $name = null)
 	{
 		/** controller/frontend/attribute/name
 		 * Class name of the used attribute frontend controller implementation
@@ -63,20 +63,20 @@  discard block
 block discarded – undo
 		 * @since 2014.03
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/frontend/attribute/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/frontend/attribute/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Frontend\\Attribute\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Frontend\\Attribute\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Frontend\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Frontend\\Attribute\\Iface';
 		$classname = '\\Aimeos\\Controller\\Frontend\\Attribute\\' . $name;
 
-		$manager = self::createControllerBase( $context, $classname, $iface );
+		$manager = self::createControllerBase($context, $classname, $iface);
 
 		/** controller/frontend/attribute/decorators/excludes
 		 * Excludes decorators added by the "common" option from the attribute frontend controllers
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
 		 * @see controller/frontend/attribute/decorators/excludes
 		 * @see controller/frontend/attribute/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $manager, 'attribute' );
+		return self::addControllerDecorators($context, $manager, 'attribute');
 	}
 
 }

Please login to merge, or discard this patch.

controller/frontend/tests/Controller/Frontend/BaseTest.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -18,31 +18,31 @@
 block discarded – undo
 	{
 		$context = \TestHelperFrontend::getContext();
 
-		$this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Base' )
-			->setConstructorArgs( [$context] )
+		$this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Base')
+			->setConstructorArgs([$context])
 			->getMockForAbstractClass();
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->object );
+		unset($this->object);
 	}
 
 
 	public function testGetContext()
 	{
-		$result = $this->access( 'getContext' )->invokeArgs( $this->object, [] );
+		$result = $this->access('getContext')->invokeArgs($this->object, []);
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Context\Item\Iface', $result );
+		$this->assertInstanceOf('\Aimeos\MShop\Context\Item\Iface', $result);
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Base' );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Base');
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}

Please login to merge, or discard this patch.

		@@ -128,7 +128,7 @@
		block discarded – undo
128	128	/**
129	129	* Returns the frontend controller
130	130	*
131		- * @return \Aimeos\Controller\Frontend\Attribute\Iface Frontend controller object
	131	+ * @return \Aimeos\Controller\Frontend\Iface Frontend controller object
132	132	*/
133	133	protected function getController()
134	134	{

		@@ -30,18 +30,18 @@ discard block
		block discarded – undo
30	30	* @param \Aimeos\Controller\Frontend\Iface $controller Controller object
31	31	* @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
32	32	*/
33		- public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
	33	+ public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
34	34	{
35	35	$iface = '\Aimeos\Controller\Frontend\Attribute\Iface';
36		- if( !( $controller instanceof $iface ) )
	36	+ if (!($controller instanceof $iface))
37	37	{
38		- $msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
39		- throw new \Aimeos\Controller\Frontend\Exception( $msg );
	38	+ $msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
	39	+ throw new \Aimeos\Controller\Frontend\Exception($msg);
40	40	}
41	41
42	42	$this->controller = $controller;
43	43
44		- parent::__construct( $context );
	44	+ parent::__construct($context);
45	45	}
46	46
47	47
		@@ -53,9 +53,9 @@ discard block
		block discarded – undo
53	53	* @return mixed Returns the value of the called method
54	54	* @throws \Aimeos\Controller\Frontend\Exception If method call failed
55	55	*/
56		- public function __call( $name, array $param )
	56	+ public function __call($name, array $param)
57	57	{
58		- return @call_user_func_array( array( $this->controller, $name ), $param );
	58	+ return @call_user_func_array(array($this->controller, $name), $param);
59	59	}
60	60
61	61
		@@ -67,9 +67,9 @@ discard block
		block discarded – undo
67	67	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
68	68	* @since 2017.03
69	69	*/
70		- public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
	70	+ public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
71	71	{
72		- return $this->controller->addFilterTypes( $filter, $codes );
	72	+ return $this->controller->addFilterTypes($filter, $codes);
73	73	}
74	74
75	75
		@@ -94,9 +94,9 @@ discard block
		block discarded – undo
94	94	* @return \Aimeos\MShop\Attribute\Item\Iface Attribute item including the referenced domains items
95	95	* @since 2017.03
96	96	*/
97		- public function getItem( $id, array $domains = array( 'media', 'price', 'text' ) )
	97	+ public function getItem($id, array $domains = array('media', 'price', 'text'))
98	98	{
99		- return $this->controller->getItem( $id, $domains );
	99	+ return $this->controller->getItem($id, $domains);
100	100	}
101	101
102	102
		@@ -108,9 +108,9 @@ discard block
		block discarded – undo
108	108	* @return \Aimeos\MShop\Attribute\Item\Iface[] Associative list of attribute item including the referenced domains items
109	109	* @since 2017.03
110	110	*/
111		- public function getItems( array $ids, array $domains = array( 'media', 'price', 'text' ) )
	111	+ public function getItems(array $ids, array $domains = array('media', 'price', 'text'))
112	112	{
113		- return $this->controller->getItems( $ids, $domains );
	113	+ return $this->controller->getItems($ids, $domains);
114	114	}
115	115
116	116
		@@ -123,9 +123,9 @@ discard block
		block discarded – undo
123	123	* @return array Ordered list of attribute items implementing \Aimeos\MShop\Attribute\Item\Iface
124	124	* @since 2017.03
125	125	*/
126		- public function searchItems( \Aimeos\MW\Criteria\Iface $filter, array $domains = array( 'media', 'price', 'text' ), &$total = null )
	126	+ public function searchItems(\Aimeos\MW\Criteria\Iface $filter, array $domains = array('media', 'price', 'text'), &$total = null)
127	127	{
128		- return $this->controller->searchItems( $filter, $domains, $total );
	128	+ return $this->controller->searchItems($filter, $domains, $total);
129	129	}
130	130
131	131

		@@ -140,7 +140,7 @@
		block discarded – undo
140	140	/**
141	141	* Returns the frontend controller
142	142	*
143		- * @return \Aimeos\Controller\Frontend\Stock\Iface Frontend controller object
	143	+ * @return \Aimeos\Controller\Frontend\Iface Frontend controller object
144	144	*/
145	145	protected function getController()
146	146	{

		@@ -30,18 +30,18 @@ discard block
		block discarded – undo
30	30	* @param \Aimeos\Controller\Frontend\Iface $controller Controller object
31	31	* @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
32	32	*/
33		- public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
	33	+ public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
34	34	{
35	35	$iface = '\Aimeos\Controller\Frontend\Stock\Iface';
36		- if( !( $controller instanceof $iface ) )
	36	+ if (!($controller instanceof $iface))
37	37	{
38		- $msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
39		- throw new \Aimeos\Controller\Frontend\Exception( $msg );
	38	+ $msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
	39	+ throw new \Aimeos\Controller\Frontend\Exception($msg);
40	40	}
41	41
42	42	$this->controller = $controller;
43	43
44		- parent::__construct( $context );
	44	+ parent::__construct($context);
45	45	}
46	46
47	47
		@@ -53,9 +53,9 @@ discard block
		block discarded – undo
53	53	* @return mixed Returns the value of the called method
54	54	* @throws \Aimeos\Controller\Frontend\Exception If method call failed
55	55	*/
56		- public function __call( $name, array $param )
	56	+ public function __call($name, array $param)
57	57	{
58		- return @call_user_func_array( array( $this->controller, $name ), $param );
	58	+ return @call_user_func_array(array($this->controller, $name), $param);
59	59	}
60	60
61	61
		@@ -67,9 +67,9 @@ discard block
		block discarded – undo
67	67	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
68	68	* @since 2017.03
69	69	*/
70		- public function addFilterCodes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
	70	+ public function addFilterCodes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
71	71	{
72		- return $this->controller->addFilterCodes( $filter, $codes );
	72	+ return $this->controller->addFilterCodes($filter, $codes);
73	73	}
74	74
75	75
		@@ -81,9 +81,9 @@ discard block
		block discarded – undo
81	81	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
82	82	* @since 2017.03
83	83	*/
84		- public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
	84	+ public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
85	85	{
86		- return $this->controller->addFilterTypes( $filter, $codes );
	86	+ return $this->controller->addFilterTypes($filter, $codes);
87	87	}
88	88
89	89
		@@ -107,9 +107,9 @@ discard block
		block discarded – undo
107	107	* @return \Aimeos\MShop\Stock\Item\Iface Stock item including the referenced domains items
108	108	* @since 2017.03
109	109	*/
110		- public function getItem( $id )
	110	+ public function getItem($id)
111	111	{
112		- return $this->controller->getItem( $id );
	112	+ return $this->controller->getItem($id);
113	113	}
114	114
115	115
		@@ -121,9 +121,9 @@ discard block
		block discarded – undo
121	121	* @return array Ordered list of stock items implementing \Aimeos\MShop\Stock\Item\Iface
122	122	* @since 2017.03
123	123	*/
124		- public function searchItems( \Aimeos\MW\Criteria\Iface $filter, &$total = null )
	124	+ public function searchItems(\Aimeos\MW\Criteria\Iface $filter, &$total = null)
125	125	{
126		- return $this->controller->searchItems( $filter, $total );
	126	+ return $this->controller->searchItems($filter, $total);
127	127	}
128	128
129	129

		@@ -28,7 +28,7 @@ discard block
		block discarded – undo
28	28	* @param string\|null $name Name of the controller implementaton (default: "Standard")
29	29	* @return \Aimeos\Controller\Frontend\Product\Iface Controller object
30	30	*/
31		- public static function createController( \Aimeos\MShop\Context\Item\Iface $context, $name = null )
	31	+ public static function createController(\Aimeos\MShop\Context\Item\Iface $context, $name = null)
32	32	{
33	33	/** controller/frontend/product/name
34	34	* Class name of the used product frontend controller implementation
		@@ -63,20 +63,20 @@ discard block
		block discarded – undo
63	63	* @since 2017.03
64	64	* @category Developer
65	65	*/
66		- if( $name === null ) {
67		- $name = $context->getConfig()->get( 'controller/frontend/product/name', 'Standard' );
	66	+ if ($name === null) {
	67	+ $name = $context->getConfig()->get('controller/frontend/product/name', 'Standard');
68	68	}
69	69
70		- if( ctype_alnum( $name ) === false )
	70	+ if (ctype_alnum($name) === false)
71	71	{
72		- $classname = is_string( $name ) ? '\\Aimeos\\Controller\\Frontend\\Product\\' . $name : '<not a string>';
73		- throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
	72	+ $classname = is_string($name) ? '\\Aimeos\\Controller\\Frontend\\Product\\' . $name : '<not a string>';
	73	+ throw new \Aimeos\Controller\Frontend\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
74	74	}
75	75
76	76	$iface = '\\Aimeos\\Controller\\Frontend\\Product\\Iface';
77	77	$classname = '\\Aimeos\\Controller\\Frontend\\Product\\' . $name;
78	78
79		- $manager = self::createControllerBase( $context, $classname, $iface );
	79	+ $manager = self::createControllerBase($context, $classname, $iface);
80	80
81	81	/** controller/frontend/product/decorators/excludes
82	82	* Excludes decorators added by the "common" option from the product frontend controllers
		@@ -152,6 +152,6 @@ discard block
		block discarded – undo
152	152	* @see controller/frontend/product/decorators/excludes
153	153	* @see controller/frontend/product/decorators/global
154	154	*/
155		- return self::addControllerDecorators( $context, $manager, 'product' );
	155	+ return self::addControllerDecorators($context, $manager, 'product');
156	156	}
157	157	}

		@@ -15,31 +15,31 @@
		block discarded – undo
15	15	{
16	16	$target = '\\Aimeos\\Controller\\Frontend\\Stock\\Iface';
17	17
18		- $controller = \Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext() );
19		- $this->assertInstanceOf( $target, $controller );
	18	+ $controller = \Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext());
	19	+ $this->assertInstanceOf($target, $controller);
20	20
21		- $controller = \Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
22		- $this->assertInstanceOf( $target, $controller );
	21	+ $controller = \Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
	22	+ $this->assertInstanceOf($target, $controller);
23	23	}
24	24
25	25
26	26	public function testCreateControllerInvalidImplementation()
27	27	{
28		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
29		- \Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
	28	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	29	+ \Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
30	30	}
31	31
32	32
33	33	public function testCreateControllerInvalidName()
34	34	{
35		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
36		- \Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
	35	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	36	+ \Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), '%^');
37	37	}
38	38
39	39
40	40	public function testCreateControllerNotExisting()
41	41	{
42		- $this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
43		- \Aimeos\Controller\Frontend\Stock\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
	42	+ $this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
	43	+ \Aimeos\Controller\Frontend\Stock\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
44	44	}
45	45	}

		@@ -27,7 +27,7 @@ discard block
		block discarded – undo
27	27	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
28	28	* @since 2017.03
29	29	*/
30		- public function addFilterCodes( \Aimeos\MW\Criteria\Iface $filter, array $codes );
	30	+ public function addFilterCodes(\Aimeos\MW\Criteria\Iface $filter, array $codes);
31	31
32	32
33	33	/**
		@@ -38,7 +38,7 @@ discard block
		block discarded – undo
38	38	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
39	39	* @since 2017.03
40	40	*/
41		- public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes );
	41	+ public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes);
42	42
43	43
44	44	/**
		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58	* @return \Aimeos\MShop\Stock\Item\Iface Stock item including the referenced domains items
59	59	* @since 2017.03
60	60	*/
61		- public function getItem( $id );
	61	+ public function getItem($id);
62	62
63	63
64	64	/**
		@@ -69,5 +69,5 @@ discard block
		block discarded – undo
69	69	* @return array Ordered list of stock items implementing \Aimeos\MShop\Stock\Item\Iface
70	70	* @since 2017.03
71	71	*/
72		- public function searchItems( \Aimeos\MW\Criteria\Iface $filter, &$total = null );
	72	+ public function searchItems(\Aimeos\MW\Criteria\Iface $filter, &$total = null);
73	73	}

		@@ -18,31 +18,31 @@
		block discarded – undo
18	18	{
19	19	$context = \TestHelperFrontend::getContext();
20	20
21		- $this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Base' )
22		- ->setConstructorArgs( [$context] )
	21	+ $this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Base')
	22	+ ->setConstructorArgs([$context])
23	23	->getMockForAbstractClass();
24	24	}
25	25
26	26
27	27	protected function tearDown()
28	28	{
29		- unset( $this->object );
	29	+ unset($this->object);
30	30	}
31	31
32	32
33	33	public function testGetContext()
34	34	{
35		- $result = $this->access( 'getContext' )->invokeArgs( $this->object, [] );
	35	+ $result = $this->access('getContext')->invokeArgs($this->object, []);
36	36
37		- $this->assertInstanceOf( '\Aimeos\MShop\Context\Item\Iface', $result );
	37	+ $this->assertInstanceOf('\Aimeos\MShop\Context\Item\Iface', $result);
38	38	}
39	39
40	40
41		- protected function access( $name )
	41	+ protected function access($name)
42	42	{
43		- $class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Base' );
44		- $method = $class->getMethod( $name );
45		- $method->setAccessible( true );
	43	+ $class = new \ReflectionClass('\Aimeos\Controller\Frontend\Base');
	44	+ $method = $class->getMethod($name);
	45	+ $method->setAccessible(true);
46	46
47	47	return $method;
48	48	}

aimeos / ai-controller-frontend

Push — master ( 8bf1bf...29627f )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch