Inspection of "Improved code coverage" - aimeos/ai-controller-frontend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 31faa3...626087 )

by Aimeos

created 2017-02-26 10:26 UTC

Status

Spacing +24 added lines, -24 removed lines patch added patch discarded remove patch

@@ -30,18 +30,18 @@  discard block
 block discarded – undo
 	 * @param \Aimeos\Controller\Frontend\Iface $controller Controller object
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
 	 */
-	public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
+	public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
 	{
 		$iface = '\Aimeos\Controller\Frontend\Product\Iface';
-		if( !( $controller instanceof $iface ) )
+		if (!($controller instanceof $iface))
 		{
-			$msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
-			throw new \Aimeos\Controller\Frontend\Exception( $msg );
+			$msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
+			throw new \Aimeos\Controller\Frontend\Exception($msg);
 		}
 
 		$this->controller = $controller;
 
-		parent::__construct( $context );
+		parent::__construct($context);
 	}
 
 
@@ -53,9 +53,9 @@  discard block
 block discarded – undo
 	 * @return mixed Returns the value of the called method
 	 * @throws \Aimeos\Controller\Frontend\Exception If method call failed
 	 */
-	public function __call( $name, array $param )
+	public function __call($name, array $param)
 	{
-		return @call_user_func_array( array( $this->controller, $name ), $param );
+		return @call_user_func_array(array($this->controller, $name), $param);
 	}
 
 
@@ -69,9 +69,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterAttribute( \Aimeos\MW\Criteria\Iface $filter, array $attrIds, array $optIds, array $oneIds )
+	public function addFilterAttribute(\Aimeos\MW\Criteria\Iface $filter, array $attrIds, array $optIds, array $oneIds)
 	{
-		return $this->controller->addFilterAttribute( $filter, $attrIds, $optIds, $oneIds );
+		return $this->controller->addFilterAttribute($filter, $attrIds, $optIds, $oneIds);
 	}
 
 
@@ -87,10 +87,10 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterCategory( \Aimeos\MW\Criteria\Iface $filter, $catId,
-		$level = \Aimeos\MW\Tree\Manager\Base::LEVEL_ONE, $sort = null, $direction = '+', $listtype = 'default' )
+	public function addFilterCategory(\Aimeos\MW\Criteria\Iface $filter, $catId,
+		$level = \Aimeos\MW\Tree\Manager\Base::LEVEL_ONE, $sort = null, $direction = '+', $listtype = 'default')
 	{
-		return $this->controller->addFilterCategory( $filter, $catId, $level, $sort, $direction, $listtype );
+		return $this->controller->addFilterCategory($filter, $catId, $level, $sort, $direction, $listtype);
 	}
 
 
@@ -105,9 +105,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterText( \Aimeos\MW\Criteria\Iface $filter, $input, $sort = null, $direction = '+', $listtype = 'default' )
+	public function addFilterText(\Aimeos\MW\Criteria\Iface $filter, $input, $sort = null, $direction = '+', $listtype = 'default')
 	{
-		return $this->controller->addFilterText( $filter, $input, $sort, $direction, $listtype );
+		return $this->controller->addFilterText($filter, $input, $sort, $direction, $listtype);
 	}
 
 
@@ -119,9 +119,9 @@  discard block
 block discarded – undo
 	 * @return array Associative list of key values as key and the product count for this key as value
 	 * @since 2015.08
 	 */
-	public function aggregate( \Aimeos\MW\Criteria\Iface $filter, $key )
+	public function aggregate(\Aimeos\MW\Criteria\Iface $filter, $key)
 	{
-		return $this->controller->aggregate( $filter, $key );
+		return $this->controller->aggregate($filter, $key);
 	}
 
 
@@ -136,9 +136,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2015.08
 	 */
-	public function createFilter( $sort = null, $direction = '+', $start = 0, $size = 100, $listtype = 'default' )
+	public function createFilter($sort = null, $direction = '+', $start = 0, $size = 100, $listtype = 'default')
 	{
-		return $this->controller->createFilter( $sort, $direction, $start, $size, $listtype );
+		return $this->controller->createFilter($sort, $direction, $start, $size, $listtype);
 	}
 
 
@@ -150,9 +150,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Product\Item\Iface Product item including the referenced domains items
 	 * @since 2017.03
 	 */
-	public function getItem( $productId, array $domains = array( 'attribute', 'media', 'price', 'product', 'product/property', 'text' ) )
+	public function getItem($productId, array $domains = array('attribute', 'media', 'price', 'product', 'product/property', 'text'))
 	{
-		return $this->controller->getItem( $productId, $domains );
+		return $this->controller->getItem($productId, $domains);
 	}
 
 
@@ -164,9 +164,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Product\Item\Iface[] Associative list of product IDs as keys and product items as values
 	 * @since 2017.03
 	 */
-	public function getItems( array $productIds, array $domains = array( 'media', 'price', 'text' ) )
+	public function getItems(array $productIds, array $domains = array('media', 'price', 'text'))
 	{
-		return $this->controller->getItems( $productIds, $domains );
+		return $this->controller->getItems($productIds, $domains);
 	}
 
 
@@ -179,9 +179,9 @@  discard block
 block discarded – undo
 	 * @return array Ordered list of product items implementing \Aimeos\MShop\Product\Item\Iface
 	 * @since 2015.08
 	 */
-	public function searchItems( \Aimeos\MW\Criteria\Iface $filter, array $domains = array( 'media', 'price', 'text' ), &$total = null )
+	public function searchItems(\Aimeos\MW\Criteria\Iface $filter, array $domains = array('media', 'price', 'text'), &$total = null)
 	{
-		return $this->controller->searchItems( $filter, $domains, $total );
+		return $this->controller->searchItems($filter, $domains, $total);
 	}
 
 

Please login to merge, or discard this patch.

controller/frontend/src/Controller/Frontend/Stock/Decorator/Base.php 1 patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -30,18 +30,18 @@  discard block
 block discarded – undo
 	 * @param \Aimeos\Controller\Frontend\Iface $controller Controller object
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
 	 */
-	public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
+	public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
 	{
 		$iface = '\Aimeos\Controller\Frontend\Stock\Iface';
-		if( !( $controller instanceof $iface ) )
+		if (!($controller instanceof $iface))
 		{
-			$msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
-			throw new \Aimeos\Controller\Frontend\Exception( $msg );
+			$msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
+			throw new \Aimeos\Controller\Frontend\Exception($msg);
 		}
 
 		$this->controller = $controller;
 
-		parent::__construct( $context );
+		parent::__construct($context);
 	}
 
 
@@ -53,9 +53,9 @@  discard block
 block discarded – undo
 	 * @return mixed Returns the value of the called method
 	 * @throws \Aimeos\Controller\Frontend\Exception If method call failed
 	 */
-	public function __call( $name, array $param )
+	public function __call($name, array $param)
 	{
-		return @call_user_func_array( array( $this->controller, $name ), $param );
+		return @call_user_func_array(array($this->controller, $name), $param);
 	}
 
 
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterCodes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
+	public function addFilterCodes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
 	{
-		return $this->controller->addFilterCodes( $filter, $codes );
+		return $this->controller->addFilterCodes($filter, $codes);
 	}
 
 
@@ -81,9 +81,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
+	public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
 	{
-		return $this->controller->addFilterTypes( $filter, $codes );
+		return $this->controller->addFilterTypes($filter, $codes);
 	}
 
 
@@ -107,9 +107,9 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\MShop\Stock\Item\Iface Stock item including the referenced domains items
 	 * @since 2017.03
 	 */
-	public function getItem( $id )
+	public function getItem($id)
 	{
-		return $this->controller->getItem( $id );
+		return $this->controller->getItem($id);
 	}
 
 
@@ -121,9 +121,9 @@  discard block
 block discarded – undo
 	 * @return array Ordered list of stock items implementing \Aimeos\MShop\Stock\Item\Iface
 	 * @since 2017.03
 	 */
-	public function searchItems( \Aimeos\MW\Criteria\Iface $filter, &$total = null )
+	public function searchItems(\Aimeos\MW\Criteria\Iface $filter, &$total = null)
 	{
-		return $this->controller->searchItems( $filter, $total );
+		return $this->controller->searchItems($filter, $total);
 	}
 
 

Please login to merge, or discard this patch.

		@@ -30,18 +30,18 @@ discard block
		block discarded – undo
30	30	* @param \Aimeos\Controller\Frontend\Iface $controller Controller object
31	31	* @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
32	32	*/
33		- public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
	33	+ public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
34	34	{
35	35	$iface = '\Aimeos\Controller\Frontend\Product\Iface';
36		- if( !( $controller instanceof $iface ) )
	36	+ if (!($controller instanceof $iface))
37	37	{
38		- $msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
39		- throw new \Aimeos\Controller\Frontend\Exception( $msg );
	38	+ $msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
	39	+ throw new \Aimeos\Controller\Frontend\Exception($msg);
40	40	}
41	41
42	42	$this->controller = $controller;
43	43
44		- parent::__construct( $context );
	44	+ parent::__construct($context);
45	45	}
46	46
47	47
		@@ -53,9 +53,9 @@ discard block
		block discarded – undo
53	53	* @return mixed Returns the value of the called method
54	54	* @throws \Aimeos\Controller\Frontend\Exception If method call failed
55	55	*/
56		- public function __call( $name, array $param )
	56	+ public function __call($name, array $param)
57	57	{
58		- return @call_user_func_array( array( $this->controller, $name ), $param );
	58	+ return @call_user_func_array(array($this->controller, $name), $param);
59	59	}
60	60
61	61
		@@ -69,9 +69,9 @@ discard block
		block discarded – undo
69	69	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
70	70	* @since 2017.03
71	71	*/
72		- public function addFilterAttribute( \Aimeos\MW\Criteria\Iface $filter, array $attrIds, array $optIds, array $oneIds )
	72	+ public function addFilterAttribute(\Aimeos\MW\Criteria\Iface $filter, array $attrIds, array $optIds, array $oneIds)
73	73	{
74		- return $this->controller->addFilterAttribute( $filter, $attrIds, $optIds, $oneIds );
	74	+ return $this->controller->addFilterAttribute($filter, $attrIds, $optIds, $oneIds);
75	75	}
76	76
77	77
		@@ -87,10 +87,10 @@ discard block
		block discarded – undo
87	87	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
88	88	* @since 2017.03
89	89	*/
90		- public function addFilterCategory( \Aimeos\MW\Criteria\Iface $filter, $catId,
91		- $level = \Aimeos\MW\Tree\Manager\Base::LEVEL_ONE, $sort = null, $direction = '+', $listtype = 'default' )
	90	+ public function addFilterCategory(\Aimeos\MW\Criteria\Iface $filter, $catId,
	91	+ $level = \Aimeos\MW\Tree\Manager\Base::LEVEL_ONE, $sort = null, $direction = '+', $listtype = 'default')
92	92	{
93		- return $this->controller->addFilterCategory( $filter, $catId, $level, $sort, $direction, $listtype );
	93	+ return $this->controller->addFilterCategory($filter, $catId, $level, $sort, $direction, $listtype);
94	94	}
95	95
96	96
		@@ -105,9 +105,9 @@ discard block
		block discarded – undo
105	105	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
106	106	* @since 2017.03
107	107	*/
108		- public function addFilterText( \Aimeos\MW\Criteria\Iface $filter, $input, $sort = null, $direction = '+', $listtype = 'default' )
	108	+ public function addFilterText(\Aimeos\MW\Criteria\Iface $filter, $input, $sort = null, $direction = '+', $listtype = 'default')
109	109	{
110		- return $this->controller->addFilterText( $filter, $input, $sort, $direction, $listtype );
	110	+ return $this->controller->addFilterText($filter, $input, $sort, $direction, $listtype);
111	111	}
112	112
113	113
		@@ -119,9 +119,9 @@ discard block
		block discarded – undo
119	119	* @return array Associative list of key values as key and the product count for this key as value
120	120	* @since 2015.08
121	121	*/
122		- public function aggregate( \Aimeos\MW\Criteria\Iface $filter, $key )
	122	+ public function aggregate(\Aimeos\MW\Criteria\Iface $filter, $key)
123	123	{
124		- return $this->controller->aggregate( $filter, $key );
	124	+ return $this->controller->aggregate($filter, $key);
125	125	}
126	126
127	127
		@@ -136,9 +136,9 @@ discard block
		block discarded – undo
136	136	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
137	137	* @since 2015.08
138	138	*/
139		- public function createFilter( $sort = null, $direction = '+', $start = 0, $size = 100, $listtype = 'default' )
	139	+ public function createFilter($sort = null, $direction = '+', $start = 0, $size = 100, $listtype = 'default')
140	140	{
141		- return $this->controller->createFilter( $sort, $direction, $start, $size, $listtype );
	141	+ return $this->controller->createFilter($sort, $direction, $start, $size, $listtype);
142	142	}
143	143
144	144
		@@ -150,9 +150,9 @@ discard block
		block discarded – undo
150	150	* @return \Aimeos\MShop\Product\Item\Iface Product item including the referenced domains items
151	151	* @since 2017.03
152	152	*/
153		- public function getItem( $productId, array $domains = array( 'attribute', 'media', 'price', 'product', 'product/property', 'text' ) )
	153	+ public function getItem($productId, array $domains = array('attribute', 'media', 'price', 'product', 'product/property', 'text'))
154	154	{
155		- return $this->controller->getItem( $productId, $domains );
	155	+ return $this->controller->getItem($productId, $domains);
156	156	}
157	157
158	158
		@@ -164,9 +164,9 @@ discard block
		block discarded – undo
164	164	* @return \Aimeos\MShop\Product\Item\Iface[] Associative list of product IDs as keys and product items as values
165	165	* @since 2017.03
166	166	*/
167		- public function getItems( array $productIds, array $domains = array( 'media', 'price', 'text' ) )
	167	+ public function getItems(array $productIds, array $domains = array('media', 'price', 'text'))
168	168	{
169		- return $this->controller->getItems( $productIds, $domains );
	169	+ return $this->controller->getItems($productIds, $domains);
170	170	}
171	171
172	172
		@@ -179,9 +179,9 @@ discard block
		block discarded – undo
179	179	* @return array Ordered list of product items implementing \Aimeos\MShop\Product\Item\Iface
180	180	* @since 2015.08
181	181	*/
182		- public function searchItems( \Aimeos\MW\Criteria\Iface $filter, array $domains = array( 'media', 'price', 'text' ), &$total = null )
	182	+ public function searchItems(\Aimeos\MW\Criteria\Iface $filter, array $domains = array('media', 'price', 'text'), &$total = null)
183	183	{
184		- return $this->controller->searchItems( $filter, $domains, $total );
	184	+ return $this->controller->searchItems($filter, $domains, $total);
185	185	}
186	186
187	187

		@@ -30,18 +30,18 @@ discard block
		block discarded – undo
30	30	* @param \Aimeos\Controller\Frontend\Iface $controller Controller object
31	31	* @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
32	32	*/
33		- public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
	33	+ public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
34	34	{
35	35	$iface = '\Aimeos\Controller\Frontend\Stock\Iface';
36		- if( !( $controller instanceof $iface ) )
	36	+ if (!($controller instanceof $iface))
37	37	{
38		- $msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
39		- throw new \Aimeos\Controller\Frontend\Exception( $msg );
	38	+ $msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
	39	+ throw new \Aimeos\Controller\Frontend\Exception($msg);
40	40	}
41	41
42	42	$this->controller = $controller;
43	43
44		- parent::__construct( $context );
	44	+ parent::__construct($context);
45	45	}
46	46
47	47
		@@ -53,9 +53,9 @@ discard block
		block discarded – undo
53	53	* @return mixed Returns the value of the called method
54	54	* @throws \Aimeos\Controller\Frontend\Exception If method call failed
55	55	*/
56		- public function __call( $name, array $param )
	56	+ public function __call($name, array $param)
57	57	{
58		- return @call_user_func_array( array( $this->controller, $name ), $param );
	58	+ return @call_user_func_array(array($this->controller, $name), $param);
59	59	}
60	60
61	61
		@@ -67,9 +67,9 @@ discard block
		block discarded – undo
67	67	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
68	68	* @since 2017.03
69	69	*/
70		- public function addFilterCodes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
	70	+ public function addFilterCodes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
71	71	{
72		- return $this->controller->addFilterCodes( $filter, $codes );
	72	+ return $this->controller->addFilterCodes($filter, $codes);
73	73	}
74	74
75	75
		@@ -81,9 +81,9 @@ discard block
		block discarded – undo
81	81	* @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
82	82	* @since 2017.03
83	83	*/
84		- public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
	84	+ public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
85	85	{
86		- return $this->controller->addFilterTypes( $filter, $codes );
	86	+ return $this->controller->addFilterTypes($filter, $codes);
87	87	}
88	88
89	89
		@@ -107,9 +107,9 @@ discard block
		block discarded – undo
107	107	* @return \Aimeos\MShop\Stock\Item\Iface Stock item including the referenced domains items
108	108	* @since 2017.03
109	109	*/
110		- public function getItem( $id )
	110	+ public function getItem($id)
111	111	{
112		- return $this->controller->getItem( $id );
	112	+ return $this->controller->getItem($id);
113	113	}
114	114
115	115
		@@ -121,9 +121,9 @@ discard block
		block discarded – undo
121	121	* @return array Ordered list of stock items implementing \Aimeos\MShop\Stock\Item\Iface
122	122	* @since 2017.03
123	123	*/
124		- public function searchItems( \Aimeos\MW\Criteria\Iface $filter, &$total = null )
	124	+ public function searchItems(\Aimeos\MW\Criteria\Iface $filter, &$total = null)
125	125	{
126		- return $this->controller->searchItems( $filter, $total );
	126	+ return $this->controller->searchItems($filter, $total);
127	127	}
128	128
129	129

aimeos / ai-controller-frontend

Push — master ( 31faa3...626087 )

Status

Category

Spacing +24 added lines, -24 removed lines patch added patch discarded remove patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch