aimeos / ai-controller-frontend

controller/frontend/tests/Controller/Frontend/Basket/BaseTest.php

Doc Comments +3 added lines

@@ -276,6 +276,9 @@
 	}
 
 
+	/**
+	 * @param string $name
+	 */
 	protected function access( $name )
 	{
 		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Basket\Base' );

Spacing +138 added lines, -138 removed lines

@@ -16,53 +16,53 @@ 
 	protected function setUp()
 	{
 		$this->context = \TestHelperFrontend::getContext();
-		\Aimeos\MShop\Factory::setCache( true );
+		\Aimeos\MShop\Factory::setCache(true);
 	}
 
 
 	protected function tearDown()
 	{
-		\Aimeos\MShop\Factory::setCache( false );
-		$this->context->getSession()->set( 'aimeos', [] );
+		\Aimeos\MShop\Factory::setCache(false);
+		$this->context->getSession()->set('aimeos', []);
 
-		unset( $this->context );
+		unset($this->context);
 	}
 
 
 	public function testCheckLocale()
 	{
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Basket\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( null )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Basket\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(null)
 			->getMock();
 
-		$this->context->getSession()->set( 'aimeos/basket/locale', 'unittest|en|EUR' );
-		$this->access( 'checkLocale' )->invokeArgs( $object, [$this->context->getLocale(), 'unittest'] );
+		$this->context->getSession()->set('aimeos/basket/locale', 'unittest|en|EUR');
+		$this->access('checkLocale')->invokeArgs($object, [$this->context->getLocale(), 'unittest']);
 	}
 
 
 	public function testCopyAddresses()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'order/base' );
+		$manager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'order/base');
 		$ordBaseItem = $manager->createItem();
 
-		$address = $this->getAddress( 'Example company' );
-		$ordBaseItem->setAddress( $address, \Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT );
+		$address = $this->getAddress('Example company');
+		$ordBaseItem->setAddress($address, \Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT);
 
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Basket\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( null )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Basket\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(null)
 			->getMock();
 
-		$result = $this->access( 'copyAddresses' )->invokeArgs( $object, [$ordBaseItem, ['test'], 'unittest|en|EUR'] );
+		$result = $this->access('copyAddresses')->invokeArgs($object, [$ordBaseItem, ['test'], 'unittest|en|EUR']);
 
 
-		$this->assertEquals( ['test'], $result );
-		$this->assertEquals( 1, count( $object->get()->getAddresses() ) );
+		$this->assertEquals(['test'], $result);
+		$this->assertEquals(1, count($object->get()->getAddresses()));
 
-		$addr = $object->get()->getAddress( \Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT );
-		$this->assertInstanceOf( '\Aimeos\MShop\Order\Item\Base\Address\Iface', $addr );
+		$addr = $object->get()->getAddress(\Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT);
+		$this->assertInstanceOf('\Aimeos\MShop\Order\Item\Base\Address\Iface', $addr);
 
 		$object->clear();
 	}
@@ -70,54 +70,54 @@ 
 
 	public function testCopyAddressesException()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'order/base' );
+		$manager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'order/base');
 		$ordBaseItem = $manager->createItem();
 
-		$address = $this->getAddress( 'Example company' );
-		$ordBaseItem->setAddress( $address, \Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT );
+		$address = $this->getAddress('Example company');
+		$ordBaseItem->setAddress($address, \Aimeos\MShop\Order\Item\Base\Address\Base::TYPE_PAYMENT);
 
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Basket\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['setAddress'] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Basket\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['setAddress'])
 			->getMock();
 
-		$object->expects( $this->once() )->method( 'setAddress' )->will( $this->throwException( new \Exception() ) );
+		$object->expects($this->once())->method('setAddress')->will($this->throwException(new \Exception()));
 
-		$result = $this->access( 'copyAddresses' )->invokeArgs( $object, [$ordBaseItem, [], 'unittest|en|EUR'] );
+		$result = $this->access('copyAddresses')->invokeArgs($object, [$ordBaseItem, [], 'unittest|en|EUR']);
 
-		$this->assertEquals( 1, count( $result ) );
-		$this->assertArrayHasKey( 'address', $result );
+		$this->assertEquals(1, count($result));
+		$this->assertArrayHasKey('address', $result);
 	}
 
 
 	public function testCopyCoupon()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'order/base' );
+		$manager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'order/base');
 		$ordBaseItem = $manager->createItem();
 
-		$product = \Aimeos\MShop\Factory::createManager( $this->context, 'product' )->findItem( 'CNC', ['price'] );
-		$ordProdManager = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base/product' );
-		$ordProdItem = $ordProdManager->createItem()->copyFrom( $product );
+		$product = \Aimeos\MShop\Factory::createManager($this->context, 'product')->findItem('CNC', ['price']);
+		$ordProdManager = \Aimeos\MShop\Factory::createManager($this->context, 'order/base/product');
+		$ordProdItem = $ordProdManager->createItem()->copyFrom($product);
 
-		$priceItems = $product->getRefItems( 'price' );
-		$ordProdItem->setPrice( reset( $priceItems ) );
+		$priceItems = $product->getRefItems('price');
+		$ordProdItem->setPrice(reset($priceItems));
 
-		$ordBaseItem->addProduct( $ordProdItem );
-		$ordBaseItem->addCoupon( 'OPQR', [] );
+		$ordBaseItem->addProduct($ordProdItem);
+		$ordBaseItem->addCoupon('OPQR', []);
 
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Basket\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( null )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Basket\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(null)
 			->getMock();
 
-		$object->addProduct( $product->getId() );
+		$object->addProduct($product->getId());
 
-		$result = $this->access( 'copyCoupons' )->invokeArgs( $object, [$ordBaseItem, ['test'], 'unittest|en|EUR'] );
+		$result = $this->access('copyCoupons')->invokeArgs($object, [$ordBaseItem, ['test'], 'unittest|en|EUR']);
 
 
-		$this->assertEquals( ['test'], $result );
+		$this->assertEquals(['test'], $result);
 
 		$object->clear();
 	}
@@ -125,48 +125,48 @@ 
 
 	public function testCopyCouponException()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'order/base' );
+		$manager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'order/base');
 		$ordBaseItem = $manager->createItem();
 
-		$ordBaseItem->addCoupon( '90AB', [] );
+		$ordBaseItem->addCoupon('90AB', []);
 
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Basket\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['addCoupon'] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Basket\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['addCoupon'])
 			->getMock();
 
-		$object->expects( $this->once() )->method( 'addCoupon' )->will( $this->throwException( new \Exception() ) );
+		$object->expects($this->once())->method('addCoupon')->will($this->throwException(new \Exception()));
 
-		$result = $this->access( 'copyCoupons' )->invokeArgs( $object, [$ordBaseItem, [], 'unittest|en|EUR'] );
+		$result = $this->access('copyCoupons')->invokeArgs($object, [$ordBaseItem, [], 'unittest|en|EUR']);
 
-		$this->assertEquals( 1, count( $result ) );
-		$this->assertArrayHasKey( 'coupon', $result );
+		$this->assertEquals(1, count($result));
+		$this->assertArrayHasKey('coupon', $result);
 	}
 
 
 	public function testCopyProduct()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'order/base' );
+		$manager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'order/base');
 		$ordBaseItem = $manager->createItem();
 
-		$product = \Aimeos\MShop\Factory::createManager( $this->context, 'product' )->findItem( 'CNC' );
-		$ordProdManager = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base/product' );
-		$ordProdItem = $ordProdManager->createItem()->copyFrom( $product );
-		$ordBaseItem->addProduct( $ordProdItem );
+		$product = \Aimeos\MShop\Factory::createManager($this->context, 'product')->findItem('CNC');
+		$ordProdManager = \Aimeos\MShop\Factory::createManager($this->context, 'order/base/product');
+		$ordProdItem = $ordProdManager->createItem()->copyFrom($product);
+		$ordBaseItem->addProduct($ordProdItem);
 
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Basket\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( null )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Basket\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(null)
 			->getMock();
 
-		$result = $this->access( 'copyProducts' )->invokeArgs( $object, [$ordBaseItem, ['test'], 'unittest|en|EUR'] );
+		$result = $this->access('copyProducts')->invokeArgs($object, [$ordBaseItem, ['test'], 'unittest|en|EUR']);
 
 
-		$this->assertEquals( ['test'], $result );
-		$this->assertEquals( 1, count( $object->get()->getProducts() ) );
-		$this->assertInstanceOf( '\Aimeos\MShop\Order\Item\Base\Product\Iface', $object->get()->getProduct( 0 ) );
+		$this->assertEquals(['test'], $result);
+		$this->assertEquals(1, count($object->get()->getProducts()));
+		$this->assertInstanceOf('\Aimeos\MShop\Order\Item\Base\Product\Iface', $object->get()->getProduct(0));
 
 		$object->clear();
 	}
@@ -174,58 +174,58 @@ 
 
 	public function testCopyProductException()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'order/base' );
+		$manager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'order/base');
 		$ordBaseItem = $manager->createItem();
 
-		$product = \Aimeos\MShop\Factory::createManager( $this->context, 'product' )->findItem( 'CNC' );
-		$ordProdManager = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base/product' );
-		$ordProdItem = $ordProdManager->createItem()->copyFrom( $product );
-		$ordBaseItem->addProduct( $ordProdItem );
+		$product = \Aimeos\MShop\Factory::createManager($this->context, 'product')->findItem('CNC');
+		$ordProdManager = \Aimeos\MShop\Factory::createManager($this->context, 'order/base/product');
+		$ordProdItem = $ordProdManager->createItem()->copyFrom($product);
+		$ordBaseItem->addProduct($ordProdItem);
 
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Basket\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['addProduct'] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Basket\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['addProduct'])
 			->getMock();
 
-		$object->expects( $this->once() )->method( 'addProduct' )->will( $this->throwException( new \Exception() ) );
+		$object->expects($this->once())->method('addProduct')->will($this->throwException(new \Exception()));
 
-		$result = $this->access( 'copyProducts' )->invokeArgs( $object, [$ordBaseItem, [], 'unittest|en|EUR'] );
+		$result = $this->access('copyProducts')->invokeArgs($object, [$ordBaseItem, [], 'unittest|en|EUR']);
 
-		$this->assertEquals( 1, count( $result ) );
-		$this->assertArrayHasKey( 'product', $result );
+		$this->assertEquals(1, count($result));
+		$this->assertArrayHasKey('product', $result);
 	}
 
 
 	public function testCopyServices()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'order/base' );
+		$manager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'order/base');
 		$ordBaseItem = $manager->createItem();
 
-		$serviceManager = \Aimeos\MShop\Factory::createManager( $this->context, 'service' );
-		$ordServManager = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base/service' );
+		$serviceManager = \Aimeos\MShop\Factory::createManager($this->context, 'service');
+		$ordServManager = \Aimeos\MShop\Factory::createManager($this->context, 'order/base/service');
 
-		$serviceItem = $serviceManager->findItem( 'unitcode', [], 'service', 'delivery' );
-		$ordServItem = $ordServManager->createItem()->copyFrom( $serviceItem );
+		$serviceItem = $serviceManager->findItem('unitcode', [], 'service', 'delivery');
+		$ordServItem = $ordServManager->createItem()->copyFrom($serviceItem);
 
-		$ordBaseItem->addService( $ordServItem, \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY );
+		$ordBaseItem->addService($ordServItem, \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY);
 
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Basket\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( null )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Basket\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(null)
 			->getMock();
 
-		$result = $this->access( 'copyServices' )->invokeArgs( $object, [$ordBaseItem, ['test'], 'unittest|en|EUR'] );
+		$result = $this->access('copyServices')->invokeArgs($object, [$ordBaseItem, ['test'], 'unittest|en|EUR']);
 
 
-		$this->assertEquals( ['test'], $result );
-		$this->assertEquals( 1, count( $object->get()->getServices() ) );
+		$this->assertEquals(['test'], $result);
+		$this->assertEquals(1, count($object->get()->getServices()));
 
-		$services = $object->get()->getService( \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY );
+		$services = $object->get()->getService(\Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY);
 
-		foreach( $services as $service ) {
-			$this->assertInstanceOf( '\Aimeos\MShop\Order\Item\Base\Service\Iface', $service );
+		foreach ($services as $service) {
+			$this->assertInstanceOf('\Aimeos\MShop\Order\Item\Base\Service\Iface', $service);
 		}
 
 		$object->clear();
@@ -234,106 +234,106 @@ 
 
 	public function testCopyServicesException()
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'order/base' );
+		$manager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'order/base');
 		$ordBaseItem = $manager->createItem();
 
-		$serviceManager = \Aimeos\MShop\Factory::createManager( $this->context, 'service' );
-		$ordServManager = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base/service' );
+		$serviceManager = \Aimeos\MShop\Factory::createManager($this->context, 'service');
+		$ordServManager = \Aimeos\MShop\Factory::createManager($this->context, 'order/base/service');
 
-		$serviceItem = $serviceManager->findItem( 'unitcode', [], 'service', 'delivery' );
-		$ordServItem = $ordServManager->createItem()->copyFrom( $serviceItem );
+		$serviceItem = $serviceManager->findItem('unitcode', [], 'service', 'delivery');
+		$ordServItem = $ordServManager->createItem()->copyFrom($serviceItem);
 
-		$ordBaseItem->addService( $ordServItem, \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY );
+		$ordBaseItem->addService($ordServItem, \Aimeos\MShop\Order\Item\Base\Service\Base::TYPE_DELIVERY);
 
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Basket\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['addService'] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Basket\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['addService'])
 			->getMock();
 
-		$object->expects( $this->once() )->method( 'addService' )->will( $this->throwException( new \Exception() ) );
+		$object->expects($this->once())->method('addService')->will($this->throwException(new \Exception()));
 
-		$result = $this->access( 'copyServices' )->invokeArgs( $object, [$ordBaseItem, [], 'unittest|en|EUR'] );
+		$result = $this->access('copyServices')->invokeArgs($object, [$ordBaseItem, [], 'unittest|en|EUR']);
 
-		$this->assertEquals( 0, count( $result ) );
+		$this->assertEquals(0, count($result));
 	}
 
 
 	public function testCreateSubscriptions()
 	{
-		$baseManager = \Aimeos\MShop\Factory::createManager( $this->context, 'order/base' );
+		$baseManager = \Aimeos\MShop\Factory::createManager($this->context, 'order/base');
 
 		$search = $baseManager->createSearch();
-		$search->setConditions( $search->compare( '==', 'order.base.price', '53.50' ) );
+		$search->setConditions($search->compare('==', 'order.base.price', '53.50'));
 
-		$items = $baseManager->searchItems( $search, ['order/base/product'] );
+		$items = $baseManager->searchItems($search, ['order/base/product']);
 
-		if( ( $basket = reset( $items ) ) === false ) {
-			throw new \Exception( sprintf( 'No order base item found for price "%1$s"', '53,50' ) );
+		if (($basket = reset($items)) === false) {
+			throw new \Exception(sprintf('No order base item found for price "%1$s"', '53,50'));
 		}
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Basket\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['getAttributes'] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Basket\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['getAttributes'])
 			->getMock();
 
-		$stub = $this->getMockBuilder( '\Aimeos\MShop\Subscription\Manager\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['saveItem'] )
+		$stub = $this->getMockBuilder('\Aimeos\MShop\Subscription\Manager\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['saveItem'])
 			->getMock();
 
-		\Aimeos\MShop\Factory::injectManager( $this->context, 'subscription', $stub );
+		\Aimeos\MShop\Factory::injectManager($this->context, 'subscription', $stub);
 
-		$stub->expects( $this->exactly( 2 ) )->method( 'saveItem' );
+		$stub->expects($this->exactly(2))->method('saveItem');
 
-		$this->access( 'createSubscriptions' )->invokeArgs( $object, [$basket] );
+		$this->access('createSubscriptions')->invokeArgs($object, [$basket]);
 	}
 
 
 	public function testGetOrderProductAttributes()
 	{
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Basket\Standard' )
-			->setConstructorArgs( [$this->context] )
-			->setMethods( ['getAttributes'] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Basket\Standard')
+			->setConstructorArgs([$this->context])
+			->setMethods(['getAttributes'])
 			->getMock();
 
-		$list = [1 => new \Aimeos\MShop\Attribute\Item\Standard( ['attribute.code' => 'special_instructions'] )];
-		$object->expects( $this->once() )->method( 'getAttributes' )->will( $this->returnValue( $list ) );
+		$list = [1 => new \Aimeos\MShop\Attribute\Item\Standard(['attribute.code' => 'special_instructions'])];
+		$object->expects($this->once())->method('getAttributes')->will($this->returnValue($list));
 
-		$result = $this->access( 'getOrderProductAttributes' )->invokeArgs( $object, ['test', ['1'], ['1' => 'test']] );
+		$result = $this->access('getOrderProductAttributes')->invokeArgs($object, ['test', ['1'], ['1' => 'test']]);
 
-		$this->assertEquals( 1, count( $result ) );
-		$this->assertEquals( 'test', $result[0]->getValue() );
+		$this->assertEquals(1, count($result));
+		$this->assertEquals('test', $result[0]->getValue());
 	}
 
 
 	/**
 	 * @param string $company
 	 */
-	protected function getAddress( $company )
+	protected function getAddress($company)
 	{
-		$manager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'customer/address' );
+		$manager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'customer/address');
 
 		$search = $manager->createSearch();
-		$search->setConditions( $search->compare( '==', 'customer.address.company', $company ) );
-		$items = $manager->searchItems( $search );
+		$search->setConditions($search->compare('==', 'customer.address.company', $company));
+		$items = $manager->searchItems($search);
 
-		if( ( $item = reset( $items ) ) === false ) {
-			throw new \RuntimeException( sprintf( 'No address item with company "%1$s" found', $company ) );
+		if (($item = reset($items)) === false) {
+			throw new \RuntimeException(sprintf('No address item with company "%1$s" found', $company));
 		}
 
-		$ordAddrManager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'order/base/address' );
-		$ordAddrItem = $ordAddrManager->createItem()->copyFrom( $item );
+		$ordAddrManager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'order/base/address');
+		$ordAddrItem = $ordAddrManager->createItem()->copyFrom($item);
 
 		return $ordAddrItem;
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Basket\Base' );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Basket\Base');
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}

controller/frontend/src/Controller/Frontend/Stock/Standard.php

Spacing +12 added lines, -12 removed lines

@@ -29,13 +29,13 @@ 
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterCodes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
+	public function addFilterCodes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
 	{
 		$expr = [
-			$filter->compare( '==', 'stock.productcode', $codes ),
+			$filter->compare('==', 'stock.productcode', $codes),
 			$filter->getConditions(),
 		];
-		$filter->setConditions( $filter->combine( '&&', $expr ) );
+		$filter->setConditions($filter->combine('&&', $expr));
 
 		return $filter;
 	}
@@ -49,15 +49,15 @@ 
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
 	 * @since 2017.03
 	 */
-	public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
+	public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
 	{
-		if( !empty( $codes ) )
+		if (!empty($codes))
 		{
 			$expr = [
-				$filter->compare( '==', 'stock.type.code', $codes ),
+				$filter->compare('==', 'stock.type.code', $codes),
 				$filter->getConditions(),
 			];
-			$filter->setConditions( $filter->combine( '&&', $expr ) );
+			$filter->setConditions($filter->combine('&&', $expr));
 		}
 
 		return $filter;
@@ -73,7 +73,7 @@ 
 	 */
 	public function createFilter()
 	{
-		return \Aimeos\MShop\Factory::createManager( $this->getContext(), 'stock' )->createSearch( true );
+		return \Aimeos\MShop\Factory::createManager($this->getContext(), 'stock')->createSearch(true);
 	}
 
 
@@ -84,9 +84,9 @@ 
 	 * @return \Aimeos\MShop\Stock\Item\Iface Stock item including the referenced domains items
 	 * @since 2017.03
 	 */
-	public function getItem( $id )
+	public function getItem($id)
 	{
-		return \Aimeos\MShop\Factory::createManager( $this->getContext(), 'stock' )->getItem( $id, [], true );
+		return \Aimeos\MShop\Factory::createManager($this->getContext(), 'stock')->getItem($id, [], true);
 	}
 
 
@@ -98,8 +98,8 @@ 
 	 * @return array Ordered list of stock items implementing \Aimeos\MShop\Stock\Item\Iface
 	 * @since 2017.03
 	 */
-	public function searchItems( \Aimeos\MW\Criteria\Iface $filter, &$total = null )
+	public function searchItems(\Aimeos\MW\Criteria\Iface $filter, &$total = null)
 	{
-		return \Aimeos\MShop\Factory::createManager( $this->getContext(), 'stock' )->searchItems( $filter, [], $total );
+		return \Aimeos\MShop\Factory::createManager($this->getContext(), 'stock')->searchItems($filter, [], $total);
 	}
 }

controller/frontend/tests/Controller/Frontend/Locale/StandardTest.php

Spacing +19 added lines, -19 removed lines

@@ -16,13 +16,13 @@ 
 
 	protected function setUp()
 	{
-		$this->object = new \Aimeos\Controller\Frontend\Locale\Standard( \TestHelperFrontend::getContext() );
+		$this->object = new \Aimeos\Controller\Frontend\Locale\Standard(\TestHelperFrontend::getContext());
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->object );
+		unset($this->object);
 	}
 
 
@@ -30,29 +30,29 @@ 
 	{
 		$filter = $this->object->createFilter();
 
-		$this->assertInstanceOf( '\\Aimeos\\MW\\Criteria\\Iface', $filter );
-		$this->assertEquals( 1, count( $filter->getSortations() ) );
-		$this->assertEquals( 0, $filter->getSliceStart() );
-		$this->assertEquals( 100, $filter->getSliceSize() );
+		$this->assertInstanceOf('\\Aimeos\\MW\\Criteria\\Iface', $filter);
+		$this->assertEquals(1, count($filter->getSortations()));
+		$this->assertEquals(0, $filter->getSliceStart());
+		$this->assertEquals(100, $filter->getSliceSize());
 	}
 
 
 	public function testGetItem()
 	{
-		$localeManager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'locale' );
-		$search = $localeManager->createSearch( true );
-		$search->setSortations( [$search->sort( '+', 'locale.position' )] );
-		$search->setSlice( 0, 1 );
-		$localeItems = $localeManager->searchItems( $search );
-
-		if( ( $localeItem = reset( $localeItems ) ) === false ) {
-			throw new \Exception( 'No locale item found' );
+		$localeManager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'locale');
+		$search = $localeManager->createSearch(true);
+		$search->setSortations([$search->sort('+', 'locale.position')]);
+		$search->setSlice(0, 1);
+		$localeItems = $localeManager->searchItems($search);
+
+		if (($localeItem = reset($localeItems)) === false) {
+			throw new \Exception('No locale item found');
 		}
 
 
-		$result = $this->object->getItem( $localeItem->getId() );
+		$result = $this->object->getItem($localeItem->getId());
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Locale\Item\Iface', $result );
+		$this->assertInstanceOf('\Aimeos\MShop\Locale\Item\Iface', $result);
 	}
 
 
@@ -60,9 +60,9 @@ 
 	{
 		$total = 0;
 		$filter = $this->object->createFilter();
-		$results = $this->object->searchItems( $filter, [], $total );
+		$results = $this->object->searchItems($filter, [], $total);
 
-		$this->assertEquals( 1, $total );
-		$this->assertEquals( 1, count( $results ) );
+		$this->assertEquals(1, $total);
+		$this->assertEquals(1, count($results));
 	}
 }

controller/frontend/src/Controller/Frontend/Customer/Decorator/Base.php

Doc Comments +1 added lines, -1 removed lines

@@ -231,7 +231,7 @@
 	/**
 	 * Returns the frontend controller
 	 *
-	 * @return \Aimeos\Controller\Frontend\Customer\Iface Frontend controller object
+	 * @return \Aimeos\Controller\Frontend\Iface Frontend controller object
 	 * @since 2017.04
 	 */
 	protected function getController()

Spacing +33 added lines, -33 removed lines

@@ -30,18 +30,18 @@ 
 	 * @param \Aimeos\Controller\Frontend\Iface $controller Controller object
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
 	 */
-	public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
+	public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
 	{
 		$iface = '\Aimeos\Controller\Frontend\Customer\Iface';
-		if( !( $controller instanceof $iface ) )
+		if (!($controller instanceof $iface))
 		{
-			$msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
-			throw new \Aimeos\Controller\Frontend\Exception( $msg );
+			$msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
+			throw new \Aimeos\Controller\Frontend\Exception($msg);
 		}
 
 		$this->controller = $controller;
 
-		parent::__construct( $context );
+		parent::__construct($context);
 	}
 
 
@@ -53,9 +53,9 @@ 
 	 * @return mixed Returns the value of the called method
 	 * @throws \Aimeos\Controller\Frontend\Exception If method call failed
 	 */
-	public function __call( $name, array $param )
+	public function __call($name, array $param)
 	{
-		return @call_user_func_array( array( $this->controller, $name ), $param );
+		return @call_user_func_array(array($this->controller, $name), $param);
 	}
 
 
@@ -66,9 +66,9 @@ 
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
 	 * @since 2017.04
 	 */
-	public function addItem( array $values )
+	public function addItem(array $values)
 	{
-		return $this->controller->addItem( $values );
+		return $this->controller->addItem($values);
 	}
 
 
@@ -78,9 +78,9 @@ 
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
 	 * @since 2017.04
 	 */
-	public function createItem( array $values = [] )
+	public function createItem(array $values = [])
 	{
-		return $this->controller->createItem( $values );
+		return $this->controller->createItem($values);
 	}
 
 
@@ -90,9 +90,9 @@ 
 	 * @param string $id Unique customer ID
 	 * @since 2017.04
 	 */
-	public function deleteItem( $id )
+	public function deleteItem($id)
 	{
-		return $this->controller->deleteItem( $id );
+		return $this->controller->deleteItem($id);
 	}
 
 
@@ -104,9 +104,9 @@ 
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
 	 * @since 2017.04
 	 */
-	public function editItem( $id, array $values )
+	public function editItem($id, array $values)
 	{
-		return $this->controller->editItem( $id, $values );
+		return $this->controller->editItem($id, $values);
 	}
 
 
@@ -118,9 +118,9 @@ 
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item including the referenced domains items
 	 * @since 2017.04
 	 */
-	public function getItem( $id = null, array $domains = [] )
+	public function getItem($id = null, array $domains = [])
 	{
-		return $this->controller->getItem( $id, $domains );
+		return $this->controller->getItem($id, $domains);
 	}
 
 
@@ -134,9 +134,9 @@ 
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item including the referenced domains items
 	 * @since 2017.04
 	 */
-	public function findItem( $code, array $domains = [] )
+	public function findItem($code, array $domains = [])
 	{
-		return $this->controller->findItem( $code, $domains );
+		return $this->controller->findItem($code, $domains);
 	}
 
 
@@ -146,9 +146,9 @@ 
 	 * @param \Aimeos\MShop\Customer\Item\Iface Customer item
 	 * @since 2017.04
 	 */
-	public function saveItem( \Aimeos\MShop\Customer\Item\Iface $item )
+	public function saveItem(\Aimeos\MShop\Customer\Item\Iface $item)
 	{
-		return $this->controller->saveItem( $item );
+		return $this->controller->saveItem($item);
 	}
 
 
@@ -159,9 +159,9 @@ 
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer address item
 	 * @since 2017.04
 	 */
-	public function addAddressItem( array $values )
+	public function addAddressItem(array $values)
 	{
-		return $this->controller->addAddressItem( $values );
+		return $this->controller->addAddressItem($values);
 	}
 
 
@@ -171,9 +171,9 @@ 
 	 * @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
 	 * @since 2017.04
 	 */
-	public function createAddressItem( array $values = [] )
+	public function createAddressItem(array $values = [])
 	{
-		return $this->controller->createAddressItem( $values );
+		return $this->controller->createAddressItem($values);
 	}
 
 
@@ -183,9 +183,9 @@ 
 	 * @param string $id Unique customer address ID
 	 * @since 2017.04
 	 */
-	public function deleteAddressItem( $id )
+	public function deleteAddressItem($id)
 	{
-		$this->controller->deleteAddressItem( $id );
+		$this->controller->deleteAddressItem($id);
 	}
 
 
@@ -197,9 +197,9 @@ 
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer address item
 	 * @since 2017.04
 	 */
-	public function editAddressItem( $id, array $values )
+	public function editAddressItem($id, array $values)
 	{
-		return $this->controller->editAddressItem( $id, $values );
+		return $this->controller->editAddressItem($id, $values);
 	}
 
 
@@ -210,9 +210,9 @@ 
 	 * @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
 	 * @since 2017.04
 	 */
-	public function getAddressItem( $id )
+	public function getAddressItem($id)
 	{
-		return $this->controller->getAddressItem( $id );
+		return $this->controller->getAddressItem($id);
 	}
 
 
@@ -222,9 +222,9 @@ 
 	 * @param \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
 	 * @since 2017.04
 	 */
-	public function saveAddressItem( \Aimeos\MShop\Customer\Item\Address\Iface $item )
+	public function saveAddressItem(\Aimeos\MShop\Customer\Item\Address\Iface $item)
 	{
-		$this->controller->saveAddressItem( $item );
+		$this->controller->saveAddressItem($item);
 	}
 
 

controller/frontend/src/Controller/Frontend/Customer/Factory.php

Spacing +8 added lines, -8 removed lines

@@ -28,7 +28,7 @@ 
 	 * @param string|null $name Name of the controller implementaton (default: "Standard")
 	 * @return \Aimeos\Controller\Frontend\Customer\Iface Controller object
 	 */
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, $name = null )
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, $name = null)
 	{
 		/** controller/frontend/customer/name
 		 * Class name of the used customer frontend controller implementation
@@ -63,20 +63,20 @@ 
 		 * @since 2014.03
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'controller/frontend/customer/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('controller/frontend/customer/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Frontend\\Customer\\' . $name : '<not a string>';
-			throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Frontend\\Customer\\' . $name : '<not a string>';
+			throw new \Aimeos\Controller\Frontend\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Controller\\Frontend\\Customer\\Iface';
 		$classname = '\\Aimeos\\Controller\\Frontend\\Customer\\' . $name;
 
-		$manager = self::createControllerBase( $context, $classname, $iface );
+		$manager = self::createControllerBase($context, $classname, $iface);
 
 		/** controller/frontend/customer/decorators/excludes
 		 * Excludes decorators added by the "common" option from the customer frontend controllers
@@ -152,7 +152,7 @@ 
 		 * @see controller/frontend/customer/decorators/excludes
 		 * @see controller/frontend/customer/decorators/global
 		 */
-		return self::addControllerDecorators( $context, $manager, 'customer' );
+		return self::addControllerDecorators($context, $manager, 'customer');
 	}
 
 }

controller/frontend/tests/Controller/Frontend/Customer/FactoryTest.php

Spacing +10 added lines, -10 removed lines

@@ -15,31 +15,31 @@
 	{
 		$target = '\\Aimeos\\Controller\\Frontend\\Customer\\Iface';
 
-		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext() );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext());
+		$this->assertInstanceOf($target, $controller);
 
-		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
+		$this->assertInstanceOf($target, $controller);
 	}
 
 
 	public function testCreateControllerInvalidImplementation()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
 	}
 
 
 	public function testCreateControllerInvalidName()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), '%^');
 	}
 
 
 	public function testCreateControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
 	}
 }

controller/frontend/tests/Controller/Frontend/Customer/Decorator/BaseTest.php

Spacing +60 added lines, -60 removed lines

@@ -20,76 +20,76 @@ 
 	{
 		$this->context = \TestHelperFrontend::getContext();
 
-		$this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Standard' )
+		$this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Standard')
 			->disableOriginalConstructor()
 			->getMock();
 
-		$this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
-			->setConstructorArgs( [$this->stub, $this->context] )
+		$this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
+			->setConstructorArgs([$this->stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->context, $this->object, $this->stub );
+		unset($this->context, $this->object, $this->stub);
 	}
 
 
 	public function testConstructException()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
 
-		$this->setExpectedException( '\Aimeos\Controller\Frontend\Exception' );
+		$this->setExpectedException('\Aimeos\Controller\Frontend\Exception');
 
-		$this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 	}
 
 
 	public function testCall()
 	{
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Standard' )
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Standard')
 			->disableOriginalConstructor()
-			->setMethods( ['invalid'] )
+			->setMethods(['invalid'])
 			->getMock();
 
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
-			->setConstructorArgs( [$stub, $this->context] )
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
+			->setConstructorArgs([$stub, $this->context])
 			->getMockForAbstractClass();
 
-		$stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
+		$stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
 
-		$this->assertTrue( $object->invalid() );
+		$this->assertTrue($object->invalid());
 	}
 
 
 	public function testAddItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'addItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('addItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->addItem( [] ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->addItem([]));
 	}
 
 
 	public function testCreateItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'createItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('createItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->createItem() );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->createItem());
 	}
 
 
 	public function testDeleteItem()
 	{
-		$this->stub->expects( $this->once() )->method( 'deleteItem' );
+		$this->stub->expects($this->once())->method('deleteItem');
 
 		$this->object->deleteItem( -1 );
 	}
@@ -97,61 +97,61 @@ 
 
 	public function testEditItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'editItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('editItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->editItem( -1, [] ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->editItem( -1, [] ));
 	}
 
 
 	public function testGetItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'getItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('getItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->getItem( -1 ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->getItem( -1 ));
 	}
 
 
 	public function testFindItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'findItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('findItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->findItem( 'test' ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->findItem('test'));
 	}
 
 
 	public function testSaveItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'saveItem' );
+		$this->stub->expects($this->once())->method('saveItem');
 
-		$this->object->saveItem( $item );
+		$this->object->saveItem($item);
 	}
 
 
 	public function testCreateAddressItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'createAddressItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('createAddressItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->createAddressItem() );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->createAddressItem());
 	}
 
 
 	public function testDeleteAddressItem()
 	{
-		$this->stub->expects( $this->once() )->method( 'deleteAddressItem' );
+		$this->stub->expects($this->once())->method('deleteAddressItem');
 
 		$this->object->deleteAddressItem( -1 );
 	}
@@ -159,49 +159,49 @@ 
 
 	public function testEditAddressItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'editAddressItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('editAddressItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->editAddressItem( -1, [] ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->editAddressItem( -1, [] ));
 	}
 
 
 	public function testGetAddressItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'getAddressItem' )
-			->will( $this->returnValue( $item ) );
+		$this->stub->expects($this->once())->method('getAddressItem')
+			->will($this->returnValue($item));
 
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->getAddressItem( -1 ) );
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->getAddressItem( -1 ));
 	}
 
 
 	public function testSaveAddressItem()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
 
-		$this->stub->expects( $this->once() )->method( 'saveAddressItem' );
+		$this->stub->expects($this->once())->method('saveAddressItem');
 
-		$this->object->saveAddressItem( $item );
+		$this->object->saveAddressItem($item);
 	}
 
 
 	public function testGetController()
 	{
-		$result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
+		$result = $this->access('getController')->invokeArgs($this->object, []);
 
-		$this->assertSame( $this->stub, $result );
+		$this->assertSame($this->stub, $result);
 	}
 
 
-	protected function access( $name )
+	protected function access($name)
 	{
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' );
-		$method = $class->getMethod( $name );
-		$method->setAccessible( true );
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Customer\Decorator\Base');
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
 
 		return $method;
 	}

controller/frontend/tests/Controller/Frontend/Service/FactoryTest.php

Spacing +10 added lines, -10 removed lines

@@ -15,31 +15,31 @@
 	{
 		$target = '\\Aimeos\\Controller\\Frontend\\Service\\Iface';
 
-		$controller = \Aimeos\Controller\Frontend\Service\Factory::createController( \TestHelperFrontend::getContext() );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Service\Factory::createController(\TestHelperFrontend::getContext());
+		$this->assertInstanceOf($target, $controller);
 
-		$controller = \Aimeos\Controller\Frontend\Service\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
-		$this->assertInstanceOf( $target, $controller );
+		$controller = \Aimeos\Controller\Frontend\Service\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
+		$this->assertInstanceOf($target, $controller);
 	}
 
 
 	public function testCreateControllerInvalidImplementation()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Service\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Service\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
 	}
 
 
 	public function testCreateControllerInvalidName()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Service\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Service\Factory::createController(\TestHelperFrontend::getContext(), '%^');
 	}
 
 
 	public function testCreateControllerNotExisting()
 	{
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
-		\Aimeos\Controller\Frontend\Service\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
+		\Aimeos\Controller\Frontend\Service\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
 	}
 }

controller/frontend/tests/Controller/Frontend/Basket/Decorator/BundleTest.php

Spacing +14 added lines, -14 removed lines

@@ -18,40 +18,40 @@
 	protected function setUp()
 	{
 		$this->context = \TestHelperFrontend::getContext();
-		$object = new \Aimeos\Controller\Frontend\Basket\Standard( $this->context );
-		$this->object = new \Aimeos\Controller\Frontend\Basket\Decorator\Bundle( $object, $this->context );
+		$object = new \Aimeos\Controller\Frontend\Basket\Standard($this->context);
+		$this->object = new \Aimeos\Controller\Frontend\Basket\Decorator\Bundle($object, $this->context);
 	}
 
 
 	protected function tearDown()
 	{
 		$this->object->clear();
-		$this->context->getSession()->set( 'aimeos', [] );
+		$this->context->getSession()->set('aimeos', []);
 
-		unset( $this->object );
+		unset($this->object);
 	}
 
 
 	public function testAddProductBundle()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'product' )->findItem( 'U:BUNDLE' );
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'product')->findItem('U:BUNDLE');
 
-		$this->object->addProduct( $item->getId(), 1 );
+		$this->object->addProduct($item->getId(), 1);
 
-		$this->assertEquals( 1, count( $this->object->get()->getProducts() ) );
-		$this->assertEquals( 'U:BUNDLE', $this->object->get()->getProduct( 0 )->getProductCode() );
-		$this->assertEquals( 2, count( $this->object->get()->getProduct( 0 )->getProducts() ) );
+		$this->assertEquals(1, count($this->object->get()->getProducts()));
+		$this->assertEquals('U:BUNDLE', $this->object->get()->getProduct(0)->getProductCode());
+		$this->assertEquals(2, count($this->object->get()->getProduct(0)->getProducts()));
 	}
 
 
 	public function testAddProductNoBundle()
 	{
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'product' )->findItem( 'CNC' );
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'product')->findItem('CNC');
 
-		$this->object->addProduct( $item->getId(), 1 );
+		$this->object->addProduct($item->getId(), 1);
 
-		$this->assertEquals( 1, count( $this->object->get()->getProducts() ) );
-		$this->assertEquals( 'CNC', $this->object->get()->getProduct( 0 )->getProductCode() );
-		$this->assertEquals( 0, count( $this->object->get()->getProduct( 0 )->getProducts() ) );
+		$this->assertEquals(1, count($this->object->get()->getProducts()));
+		$this->assertEquals('CNC', $this->object->get()->getProduct(0)->getProductCode());
+		$this->assertEquals(0, count($this->object->get()->getProduct(0)->getProducts()));
 	}
 }