Completed
Push — master ( f23e00...1d5010 )
by Aimeos
02:31
created
controller/frontend/src/Controller/Frontend/Basket/Iface.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -150,7 +150,6 @@
 block discarded – undo
150 150
 	 * Sets the delivery/payment service item based on the service ID.
151 151
 	 *
152 152
 	 * @param string $type Service type code like 'payment' or 'delivery'
153
-	 * @param string $id|null Unique ID of the service item or null to remove it
154 153
 	 * @param array $attributes Associative list of key/value pairs containing the attributes selected or
155 154
 	 * 	entered by the customer when choosing one of the delivery or payment options
156 155
 	 * @throws \Aimeos\Controller\Frontend\Basket\Exception If there is no price to the service item attached
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 	 * @param string $type Basket type
51 51
 	 * @return \Aimeos\Controller\Frontend\Basket\Iface Basket frontend object
52 52
 	 */
53
-	public function setType( $type );
53
+	public function setType($type);
54 54
 
55 55
 
56 56
 	/**
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 	 * @param boolean $default True to add default criteria (user logged in), false if not
70 70
 	 * @return \Aimeos\MShop\Order\Item\Base\Iface Order base object including the given parts
71 71
 	 */
72
-	public function load( $id, $parts = \Aimeos\MShop\Order\Manager\Base\Base::PARTS_ALL, $default = true );
72
+	public function load($id, $parts = \Aimeos\MShop\Order\Manager\Base\Base::PARTS_ALL, $default = true);
73 73
 
74 74
 
75 75
 	/**
@@ -89,9 +89,9 @@  discard block
 block discarded – undo
89 89
 	 * @throws \Aimeos\Controller\Frontend\Basket\Exception If the product isn't available
90 90
 	 * @return void
91 91
 	 */
92
-	public function addProduct( $prodid, $quantity = 1, array $options = [], array $variantAttributeIds = [],
92
+	public function addProduct($prodid, $quantity = 1, array $options = [], array $variantAttributeIds = [],
93 93
 		array $configAttributeIds = [], array $hiddenAttributeIds = [], array $customAttributeValues = [],
94
-		$stocktype = 'default' );
94
+		$stocktype = 'default');
95 95
 
96 96
 
97 97
 	/**
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 	 * @param integer $position Position number (key) of the order product item
101 101
 	 * @return void
102 102
 	 */
103
-	public function deleteProduct( $position );
103
+	public function deleteProduct($position);
104 104
 
105 105
 
106 106
 	/**
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	 * @param array $configAttributeCodes Codes of the product config attributes that should be REMOVED
112 112
 	 * @return void
113 113
 	 */
114
-	public function editProduct( $position, $quantity, array $configAttributeCodes = [] );
114
+	public function editProduct($position, $quantity, array $configAttributeCodes = []);
115 115
 
116 116
 
117 117
 	/**
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	 * @throws \Aimeos\Controller\Frontend\Basket\Exception if the coupon code is invalid or not allowed
122 122
 	 * @return void
123 123
 	 */
124
-	public function addCoupon( $code );
124
+	public function addCoupon($code);
125 125
 
126 126
 
127 127
 	/**
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 	 * @throws \Aimeos\Controller\Frontend\Basket\Exception if the coupon code is invalid
132 132
 	 * @return void
133 133
 	 */
134
-	public function deleteCoupon( $code );
134
+	public function deleteCoupon($code);
135 135
 
136 136
 
137 137
 	/**
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 	 * 	if one of the keys is invalid when using an array with key/value pairs
144 144
 	 * @return void
145 145
 	 */
146
-	public function setAddress( $type, $value );
146
+	public function setAddress($type, $value);
147 147
 
148 148
 
149 149
 	/**
@@ -156,5 +156,5 @@  discard block
 block discarded – undo
156 156
 	 * @throws \Aimeos\Controller\Frontend\Basket\Exception If there is no price to the service item attached
157 157
 	 * @return void
158 158
 	 */
159
-	public function setService( $type, $id, array $attributes = [] );
159
+	public function setService($type, $id, array $attributes = []);
160 160
 }
Please login to merge, or discard this patch.
controller/frontend/src/Controller/Frontend/Stock/Standard.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -29,13 +29,13 @@  discard block
 block discarded – undo
29 29
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
30 30
 	 * @since 2017.03
31 31
 	 */
32
-	public function addFilterCodes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
32
+	public function addFilterCodes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
33 33
 	{
34 34
 		$expr = [
35
-			$filter->compare( '==', 'stock.productcode', $codes ),
35
+			$filter->compare('==', 'stock.productcode', $codes),
36 36
 			$filter->getConditions(),
37 37
 		];
38
-		$filter->setConditions( $filter->combine( '&&', $expr ) );
38
+		$filter->setConditions($filter->combine('&&', $expr));
39 39
 
40 40
 		return $filter;
41 41
 	}
@@ -49,15 +49,15 @@  discard block
 block discarded – undo
49 49
 	 * @return \Aimeos\MW\Criteria\Iface Criteria object containing the conditions for searching
50 50
 	 * @since 2017.03
51 51
 	 */
52
-	public function addFilterTypes( \Aimeos\MW\Criteria\Iface $filter, array $codes )
52
+	public function addFilterTypes(\Aimeos\MW\Criteria\Iface $filter, array $codes)
53 53
 	{
54
-		if( !empty( $codes ) )
54
+		if (!empty($codes))
55 55
 		{
56 56
 			$expr = [
57
-				$filter->compare( '==', 'stock.type.code', $codes ),
57
+				$filter->compare('==', 'stock.type.code', $codes),
58 58
 				$filter->getConditions(),
59 59
 			];
60
-			$filter->setConditions( $filter->combine( '&&', $expr ) );
60
+			$filter->setConditions($filter->combine('&&', $expr));
61 61
 		}
62 62
 
63 63
 		return $filter;
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	 */
74 74
 	public function createFilter()
75 75
 	{
76
-		return \Aimeos\MShop\Factory::createManager( $this->getContext(), 'stock' )->createSearch( true );
76
+		return \Aimeos\MShop\Factory::createManager($this->getContext(), 'stock')->createSearch(true);
77 77
 	}
78 78
 
79 79
 
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
 	 * @return \Aimeos\MShop\Stock\Item\Iface Stock item including the referenced domains items
85 85
 	 * @since 2017.03
86 86
 	 */
87
-	public function getItem( $id )
87
+	public function getItem($id)
88 88
 	{
89
-		return \Aimeos\MShop\Factory::createManager( $this->getContext(), 'stock' )->getItem( $id, [], true );
89
+		return \Aimeos\MShop\Factory::createManager($this->getContext(), 'stock')->getItem($id, [], true);
90 90
 	}
91 91
 
92 92
 
@@ -98,8 +98,8 @@  discard block
 block discarded – undo
98 98
 	 * @return array Ordered list of stock items implementing \Aimeos\MShop\Stock\Item\Iface
99 99
 	 * @since 2017.03
100 100
 	 */
101
-	public function searchItems( \Aimeos\MW\Criteria\Iface $filter, &$total = null )
101
+	public function searchItems(\Aimeos\MW\Criteria\Iface $filter, &$total = null)
102 102
 	{
103
-		return \Aimeos\MShop\Factory::createManager( $this->getContext(), 'stock' )->searchItems( $filter, [], $total );
103
+		return \Aimeos\MShop\Factory::createManager($this->getContext(), 'stock')->searchItems($filter, [], $total);
104 104
 	}
105 105
 }
Please login to merge, or discard this patch.
controller/frontend/tests/Controller/Frontend/Locale/StandardTest.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -16,13 +16,13 @@  discard block
 block discarded – undo
16 16
 
17 17
 	protected function setUp()
18 18
 	{
19
-		$this->object = new \Aimeos\Controller\Frontend\Locale\Standard( \TestHelperFrontend::getContext() );
19
+		$this->object = new \Aimeos\Controller\Frontend\Locale\Standard(\TestHelperFrontend::getContext());
20 20
 	}
21 21
 
22 22
 
23 23
 	protected function tearDown()
24 24
 	{
25
-		unset( $this->object );
25
+		unset($this->object);
26 26
 	}
27 27
 
28 28
 
@@ -30,29 +30,29 @@  discard block
 block discarded – undo
30 30
 	{
31 31
 		$filter = $this->object->createFilter();
32 32
 
33
-		$this->assertInstanceOf( '\\Aimeos\\MW\\Criteria\\Iface', $filter );
34
-		$this->assertEquals( 1, count( $filter->getSortations() ) );
35
-		$this->assertEquals( 0, $filter->getSliceStart() );
36
-		$this->assertEquals( 100, $filter->getSliceSize() );
33
+		$this->assertInstanceOf('\\Aimeos\\MW\\Criteria\\Iface', $filter);
34
+		$this->assertEquals(1, count($filter->getSortations()));
35
+		$this->assertEquals(0, $filter->getSliceStart());
36
+		$this->assertEquals(100, $filter->getSliceSize());
37 37
 	}
38 38
 
39 39
 
40 40
 	public function testGetItem()
41 41
 	{
42
-		$localeManager = \Aimeos\MShop\Factory::createManager( \TestHelperFrontend::getContext(), 'locale' );
43
-		$search = $localeManager->createSearch( true );
44
-		$search->setSortations( [$search->sort( '+', 'locale.position' )] );
45
-		$search->setSlice( 0, 1 );
46
-		$localeItems = $localeManager->searchItems( $search );
47
-
48
-		if( ( $localeItem = reset( $localeItems ) ) === false ) {
49
-			throw new \Exception( 'No locale item found' );
42
+		$localeManager = \Aimeos\MShop\Factory::createManager(\TestHelperFrontend::getContext(), 'locale');
43
+		$search = $localeManager->createSearch(true);
44
+		$search->setSortations([$search->sort('+', 'locale.position')]);
45
+		$search->setSlice(0, 1);
46
+		$localeItems = $localeManager->searchItems($search);
47
+
48
+		if (($localeItem = reset($localeItems)) === false) {
49
+			throw new \Exception('No locale item found');
50 50
 		}
51 51
 
52 52
 
53
-		$result = $this->object->getItem( $localeItem->getId() );
53
+		$result = $this->object->getItem($localeItem->getId());
54 54
 
55
-		$this->assertInstanceOf( '\Aimeos\MShop\Locale\Item\Iface', $result );
55
+		$this->assertInstanceOf('\Aimeos\MShop\Locale\Item\Iface', $result);
56 56
 	}
57 57
 
58 58
 
@@ -60,9 +60,9 @@  discard block
 block discarded – undo
60 60
 	{
61 61
 		$total = 0;
62 62
 		$filter = $this->object->createFilter();
63
-		$results = $this->object->searchItems( $filter, [], $total );
63
+		$results = $this->object->searchItems($filter, [], $total);
64 64
 
65
-		$this->assertEquals( 1, $total );
66
-		$this->assertEquals( 1, count( $results ) );
65
+		$this->assertEquals(1, $total);
66
+		$this->assertEquals(1, count($results));
67 67
 	}
68 68
 }
Please login to merge, or discard this patch.
controller/frontend/src/Controller/Frontend/Customer/Decorator/Base.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -231,7 +231,7 @@
 block discarded – undo
231 231
 	/**
232 232
 	 * Returns the frontend controller
233 233
 	 *
234
-	 * @return \Aimeos\Controller\Frontend\Customer\Iface Frontend controller object
234
+	 * @return \Aimeos\Controller\Frontend\Iface Frontend controller object
235 235
 	 * @since 2017.04
236 236
 	 */
237 237
 	protected function getController()
Please login to merge, or discard this patch.
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -30,18 +30,18 @@  discard block
 block discarded – undo
30 30
 	 * @param \Aimeos\Controller\Frontend\Iface $controller Controller object
31 31
 	 * @param \Aimeos\MShop\Context\Item\Iface $context Context object with required objects
32 32
 	 */
33
-	public function __construct( \Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context )
33
+	public function __construct(\Aimeos\Controller\Frontend\Iface $controller, \Aimeos\MShop\Context\Item\Iface $context)
34 34
 	{
35 35
 		$iface = '\Aimeos\Controller\Frontend\Customer\Iface';
36
-		if( !( $controller instanceof $iface ) )
36
+		if (!($controller instanceof $iface))
37 37
 		{
38
-			$msg = sprintf( 'Class "%1$s" does not implement interface "%2$s"', get_class( $controller ), $iface );
39
-			throw new \Aimeos\Controller\Frontend\Exception( $msg );
38
+			$msg = sprintf('Class "%1$s" does not implement interface "%2$s"', get_class($controller), $iface);
39
+			throw new \Aimeos\Controller\Frontend\Exception($msg);
40 40
 		}
41 41
 
42 42
 		$this->controller = $controller;
43 43
 
44
-		parent::__construct( $context );
44
+		parent::__construct($context);
45 45
 	}
46 46
 
47 47
 
@@ -53,9 +53,9 @@  discard block
 block discarded – undo
53 53
 	 * @return mixed Returns the value of the called method
54 54
 	 * @throws \Aimeos\Controller\Frontend\Exception If method call failed
55 55
 	 */
56
-	public function __call( $name, array $param )
56
+	public function __call($name, array $param)
57 57
 	{
58
-		return @call_user_func_array( array( $this->controller, $name ), $param );
58
+		return @call_user_func_array(array($this->controller, $name), $param);
59 59
 	}
60 60
 
61 61
 
@@ -66,9 +66,9 @@  discard block
 block discarded – undo
66 66
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
67 67
 	 * @since 2017.04
68 68
 	 */
69
-	public function addItem( array $values )
69
+	public function addItem(array $values)
70 70
 	{
71
-		return $this->controller->addItem( $values );
71
+		return $this->controller->addItem($values);
72 72
 	}
73 73
 
74 74
 
@@ -78,9 +78,9 @@  discard block
 block discarded – undo
78 78
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
79 79
 	 * @since 2017.04
80 80
 	 */
81
-	public function createItem( array $values = [] )
81
+	public function createItem(array $values = [])
82 82
 	{
83
-		return $this->controller->createItem( $values );
83
+		return $this->controller->createItem($values);
84 84
 	}
85 85
 
86 86
 
@@ -90,9 +90,9 @@  discard block
 block discarded – undo
90 90
 	 * @param string $id Unique customer ID
91 91
 	 * @since 2017.04
92 92
 	 */
93
-	public function deleteItem( $id )
93
+	public function deleteItem($id)
94 94
 	{
95
-		return $this->controller->deleteItem( $id );
95
+		return $this->controller->deleteItem($id);
96 96
 	}
97 97
 
98 98
 
@@ -104,9 +104,9 @@  discard block
 block discarded – undo
104 104
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
105 105
 	 * @since 2017.04
106 106
 	 */
107
-	public function editItem( $id, array $values )
107
+	public function editItem($id, array $values)
108 108
 	{
109
-		return $this->controller->editItem( $id, $values );
109
+		return $this->controller->editItem($id, $values);
110 110
 	}
111 111
 
112 112
 
@@ -118,9 +118,9 @@  discard block
 block discarded – undo
118 118
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item including the referenced domains items
119 119
 	 * @since 2017.04
120 120
 	 */
121
-	public function getItem( $id = null, array $domains = [] )
121
+	public function getItem($id = null, array $domains = [])
122 122
 	{
123
-		return $this->controller->getItem( $id, $domains );
123
+		return $this->controller->getItem($id, $domains);
124 124
 	}
125 125
 
126 126
 
@@ -134,9 +134,9 @@  discard block
 block discarded – undo
134 134
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item including the referenced domains items
135 135
 	 * @since 2017.04
136 136
 	 */
137
-	public function findItem( $code, array $domains = [] )
137
+	public function findItem($code, array $domains = [])
138 138
 	{
139
-		return $this->controller->findItem( $code, $domains );
139
+		return $this->controller->findItem($code, $domains);
140 140
 	}
141 141
 
142 142
 
@@ -146,9 +146,9 @@  discard block
 block discarded – undo
146 146
 	 * @param \Aimeos\MShop\Customer\Item\Iface Customer item
147 147
 	 * @since 2017.04
148 148
 	 */
149
-	public function saveItem( \Aimeos\MShop\Customer\Item\Iface $item )
149
+	public function saveItem(\Aimeos\MShop\Customer\Item\Iface $item)
150 150
 	{
151
-		return $this->controller->saveItem( $item );
151
+		return $this->controller->saveItem($item);
152 152
 	}
153 153
 
154 154
 
@@ -159,9 +159,9 @@  discard block
 block discarded – undo
159 159
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer address item
160 160
 	 * @since 2017.04
161 161
 	 */
162
-	public function addAddressItem( array $values )
162
+	public function addAddressItem(array $values)
163 163
 	{
164
-		return $this->controller->addAddressItem( $values );
164
+		return $this->controller->addAddressItem($values);
165 165
 	}
166 166
 
167 167
 
@@ -171,9 +171,9 @@  discard block
 block discarded – undo
171 171
 	 * @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
172 172
 	 * @since 2017.04
173 173
 	 */
174
-	public function createAddressItem( array $values = [] )
174
+	public function createAddressItem(array $values = [])
175 175
 	{
176
-		return $this->controller->createAddressItem( $values );
176
+		return $this->controller->createAddressItem($values);
177 177
 	}
178 178
 
179 179
 
@@ -183,9 +183,9 @@  discard block
 block discarded – undo
183 183
 	 * @param string $id Unique customer address ID
184 184
 	 * @since 2017.04
185 185
 	 */
186
-	public function deleteAddressItem( $id )
186
+	public function deleteAddressItem($id)
187 187
 	{
188
-		$this->controller->deleteAddressItem( $id );
188
+		$this->controller->deleteAddressItem($id);
189 189
 	}
190 190
 
191 191
 
@@ -197,9 +197,9 @@  discard block
 block discarded – undo
197 197
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer address item
198 198
 	 * @since 2017.04
199 199
 	 */
200
-	public function editAddressItem( $id, array $values )
200
+	public function editAddressItem($id, array $values)
201 201
 	{
202
-		return $this->controller->editAddressItem( $id, $values );
202
+		return $this->controller->editAddressItem($id, $values);
203 203
 	}
204 204
 
205 205
 
@@ -210,9 +210,9 @@  discard block
 block discarded – undo
210 210
 	 * @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
211 211
 	 * @since 2017.04
212 212
 	 */
213
-	public function getAddressItem( $id )
213
+	public function getAddressItem($id)
214 214
 	{
215
-		return $this->controller->getAddressItem( $id );
215
+		return $this->controller->getAddressItem($id);
216 216
 	}
217 217
 
218 218
 
@@ -222,9 +222,9 @@  discard block
 block discarded – undo
222 222
 	 * @param \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
223 223
 	 * @since 2017.04
224 224
 	 */
225
-	public function saveAddressItem( \Aimeos\MShop\Customer\Item\Address\Iface $item )
225
+	public function saveAddressItem(\Aimeos\MShop\Customer\Item\Address\Iface $item)
226 226
 	{
227
-		$this->controller->saveAddressItem( $item );
227
+		$this->controller->saveAddressItem($item);
228 228
 	}
229 229
 
230 230
 
Please login to merge, or discard this patch.
controller/frontend/src/Controller/Frontend/Customer/Factory.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 	 * @param string|null $name Name of the controller implementaton (default: "Standard")
29 29
 	 * @return \Aimeos\Controller\Frontend\Customer\Iface Controller object
30 30
 	 */
31
-	public static function createController( \Aimeos\MShop\Context\Item\Iface $context, $name = null )
31
+	public static function createController(\Aimeos\MShop\Context\Item\Iface $context, $name = null)
32 32
 	{
33 33
 		/** controller/frontend/customer/name
34 34
 		 * Class name of the used customer frontend controller implementation
@@ -63,20 +63,20 @@  discard block
 block discarded – undo
63 63
 		 * @since 2014.03
64 64
 		 * @category Developer
65 65
 		 */
66
-		if( $name === null ) {
67
-			$name = $context->getConfig()->get( 'controller/frontend/customer/name', 'Standard' );
66
+		if ($name === null) {
67
+			$name = $context->getConfig()->get('controller/frontend/customer/name', 'Standard');
68 68
 		}
69 69
 
70
-		if( ctype_alnum( $name ) === false )
70
+		if (ctype_alnum($name) === false)
71 71
 		{
72
-			$classname = is_string( $name ) ? '\\Aimeos\\Controller\\Frontend\\Customer\\' . $name : '<not a string>';
73
-			throw new \Aimeos\Controller\Frontend\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
72
+			$classname = is_string($name) ? '\\Aimeos\\Controller\\Frontend\\Customer\\' . $name : '<not a string>';
73
+			throw new \Aimeos\Controller\Frontend\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
74 74
 		}
75 75
 
76 76
 		$iface = '\\Aimeos\\Controller\\Frontend\\Customer\\Iface';
77 77
 		$classname = '\\Aimeos\\Controller\\Frontend\\Customer\\' . $name;
78 78
 
79
-		$manager = self::createControllerBase( $context, $classname, $iface );
79
+		$manager = self::createControllerBase($context, $classname, $iface);
80 80
 
81 81
 		/** controller/frontend/customer/decorators/excludes
82 82
 		 * Excludes decorators added by the "common" option from the customer frontend controllers
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 		 * @see controller/frontend/customer/decorators/excludes
153 153
 		 * @see controller/frontend/customer/decorators/global
154 154
 		 */
155
-		return self::addControllerDecorators( $context, $manager, 'customer' );
155
+		return self::addControllerDecorators($context, $manager, 'customer');
156 156
 	}
157 157
 
158 158
 }
Please login to merge, or discard this patch.
controller/frontend/src/Controller/Frontend/Customer/Iface.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
27 27
 	 * @since 2017.04
28 28
 	 */
29
-	public function addItem( array $values );
29
+	public function addItem(array $values);
30 30
 
31 31
 
32 32
 	/**
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
36 36
 	 * @since 2017.04
37 37
 	 */
38
-	public function createItem( array $values = [] );
38
+	public function createItem(array $values = []);
39 39
 
40 40
 
41 41
 	/**
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	 * @param string $id Unique customer ID
45 45
 	 * @since 2017.04
46 46
 	 */
47
-	public function deleteItem( $id );
47
+	public function deleteItem($id);
48 48
 
49 49
 
50 50
 	/**
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item
56 56
 	 * @since 2017.04
57 57
 	 */
58
-	public function editItem( $id, array $values );
58
+	public function editItem($id, array $values);
59 59
 
60 60
 
61 61
 	/**
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item including the referenced domains items
67 67
 	 * @since 2017.04
68 68
 	 */
69
-	public function getItem( $id = null, array $domains = [] );
69
+	public function getItem($id = null, array $domains = []);
70 70
 
71 71
 
72 72
 	/**
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer item including the referenced domains items
80 80
 	 * @since 2017.04
81 81
 	 */
82
-	public function findItem( $code, array $domains = [] );
82
+	public function findItem($code, array $domains = []);
83 83
 
84 84
 
85 85
 	/**
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 	 * @param \Aimeos\MShop\Customer\Item\Iface Customer item
89 89
 	 * @since 2017.04
90 90
 	 */
91
-	public function saveItem( \Aimeos\MShop\Customer\Item\Iface $item );
91
+	public function saveItem(\Aimeos\MShop\Customer\Item\Iface $item);
92 92
 
93 93
 
94 94
 	/**
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer address item
99 99
 	 * @since 2017.04
100 100
 	 */
101
-	public function addAddressItem( array $values );
101
+	public function addAddressItem(array $values);
102 102
 
103 103
 
104 104
 	/**
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 	 * @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
108 108
 	 * @since 2017.04
109 109
 	 */
110
-	public function createAddressItem( array $values = [] );
110
+	public function createAddressItem(array $values = []);
111 111
 
112 112
 
113 113
 	/**
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 	 * @param string $id Unique customer address ID
117 117
 	 * @since 2017.04
118 118
 	 */
119
-	public function deleteAddressItem( $id );
119
+	public function deleteAddressItem($id);
120 120
 
121 121
 
122 122
 	/**
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 	 * @return \Aimeos\MShop\Customer\Item\Iface Customer address item
128 128
 	 * @since 2017.04
129 129
 	 */
130
-	public function editAddressItem( $id, array $values );
130
+	public function editAddressItem($id, array $values);
131 131
 
132 132
 
133 133
 	/**
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 	 * @return \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
138 138
 	 * @since 2017.04
139 139
 	 */
140
-	public function getAddressItem( $id );
140
+	public function getAddressItem($id);
141 141
 
142 142
 
143 143
 	/**
@@ -146,5 +146,5 @@  discard block
 block discarded – undo
146 146
 	 * @param \Aimeos\MShop\Customer\Item\Address\Iface Customer address item
147 147
 	 * @since 2017.04
148 148
 	 */
149
-	public function saveAddressItem( \Aimeos\MShop\Customer\Item\Address\Iface $item );
149
+	public function saveAddressItem(\Aimeos\MShop\Customer\Item\Address\Iface $item);
150 150
 }
Please login to merge, or discard this patch.
controller/frontend/tests/Controller/Frontend/Customer/FactoryTest.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -15,31 +15,31 @@
 block discarded – undo
15 15
 	{
16 16
 		$target = '\\Aimeos\\Controller\\Frontend\\Customer\\Iface';
17 17
 
18
-		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext() );
19
-		$this->assertInstanceOf( $target, $controller );
18
+		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext());
19
+		$this->assertInstanceOf($target, $controller);
20 20
 
21
-		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), 'Standard' );
22
-		$this->assertInstanceOf( $target, $controller );
21
+		$controller = \Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), 'Standard');
22
+		$this->assertInstanceOf($target, $controller);
23 23
 	}
24 24
 
25 25
 
26 26
 	public function testCreateControllerInvalidImplementation()
27 27
 	{
28
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
29
-		\Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), 'Invalid' );
28
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
29
+		\Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), 'Invalid');
30 30
 	}
31 31
 
32 32
 
33 33
 	public function testCreateControllerInvalidName()
34 34
 	{
35
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
36
-		\Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), '%^' );
35
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
36
+		\Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), '%^');
37 37
 	}
38 38
 
39 39
 
40 40
 	public function testCreateControllerNotExisting()
41 41
 	{
42
-		$this->setExpectedException( '\\Aimeos\\Controller\\Frontend\\Exception' );
43
-		\Aimeos\Controller\Frontend\Customer\Factory::createController( \TestHelperFrontend::getContext(), 'notexist' );
42
+		$this->setExpectedException('\\Aimeos\\Controller\\Frontend\\Exception');
43
+		\Aimeos\Controller\Frontend\Customer\Factory::createController(\TestHelperFrontend::getContext(), 'notexist');
44 44
 	}
45 45
 }
Please login to merge, or discard this patch.
frontend/tests/Controller/Frontend/Customer/Decorator/BaseTest.php 1 patch
Spacing   +60 added lines, -60 removed lines patch added patch discarded remove patch
@@ -20,76 +20,76 @@  discard block
 block discarded – undo
20 20
 	{
21 21
 		$this->context = \TestHelperFrontend::getContext();
22 22
 
23
-		$this->stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Standard' )
23
+		$this->stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Standard')
24 24
 			->disableOriginalConstructor()
25 25
 			->getMock();
26 26
 
27
-		$this->object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
28
-			->setConstructorArgs( [$this->stub, $this->context] )
27
+		$this->object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
28
+			->setConstructorArgs([$this->stub, $this->context])
29 29
 			->getMockForAbstractClass();
30 30
 	}
31 31
 
32 32
 
33 33
 	protected function tearDown()
34 34
 	{
35
-		unset( $this->context, $this->object, $this->stub );
35
+		unset($this->context, $this->object, $this->stub);
36 36
 	}
37 37
 
38 38
 
39 39
 	public function testConstructException()
40 40
 	{
41
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Iface' )->getMock();
41
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Iface')->getMock();
42 42
 
43
-		$this->setExpectedException( '\Aimeos\Controller\Frontend\Exception' );
43
+		$this->setExpectedException('\Aimeos\Controller\Frontend\Exception');
44 44
 
45
-		$this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
46
-			->setConstructorArgs( [$stub, $this->context] )
45
+		$this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
46
+			->setConstructorArgs([$stub, $this->context])
47 47
 			->getMockForAbstractClass();
48 48
 	}
49 49
 
50 50
 
51 51
 	public function testCall()
52 52
 	{
53
-		$stub = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Standard' )
53
+		$stub = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Standard')
54 54
 			->disableOriginalConstructor()
55
-			->setMethods( ['invalid'] )
55
+			->setMethods(['invalid'])
56 56
 			->getMock();
57 57
 
58
-		$object = $this->getMockBuilder( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' )
59
-			->setConstructorArgs( [$stub, $this->context] )
58
+		$object = $this->getMockBuilder('\Aimeos\Controller\Frontend\Customer\Decorator\Base')
59
+			->setConstructorArgs([$stub, $this->context])
60 60
 			->getMockForAbstractClass();
61 61
 
62
-		$stub->expects( $this->once() )->method( 'invalid' )->will( $this->returnValue( true ) );
62
+		$stub->expects($this->once())->method('invalid')->will($this->returnValue(true));
63 63
 
64
-		$this->assertTrue( $object->invalid() );
64
+		$this->assertTrue($object->invalid());
65 65
 	}
66 66
 
67 67
 
68 68
 	public function testAddItem()
69 69
 	{
70
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
70
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
71 71
 
72
-		$this->stub->expects( $this->once() )->method( 'addItem' )
73
-			->will( $this->returnValue( $item ) );
72
+		$this->stub->expects($this->once())->method('addItem')
73
+			->will($this->returnValue($item));
74 74
 
75
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->addItem( [] ) );
75
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->addItem([]));
76 76
 	}
77 77
 
78 78
 
79 79
 	public function testCreateItem()
80 80
 	{
81
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
81
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
82 82
 
83
-		$this->stub->expects( $this->once() )->method( 'createItem' )
84
-			->will( $this->returnValue( $item ) );
83
+		$this->stub->expects($this->once())->method('createItem')
84
+			->will($this->returnValue($item));
85 85
 
86
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->createItem() );
86
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->createItem());
87 87
 	}
88 88
 
89 89
 
90 90
 	public function testDeleteItem()
91 91
 	{
92
-		$this->stub->expects( $this->once() )->method( 'deleteItem' );
92
+		$this->stub->expects($this->once())->method('deleteItem');
93 93
 
94 94
 		$this->object->deleteItem( -1 );
95 95
 	}
@@ -97,61 +97,61 @@  discard block
 block discarded – undo
97 97
 
98 98
 	public function testEditItem()
99 99
 	{
100
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
100
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
101 101
 
102
-		$this->stub->expects( $this->once() )->method( 'editItem' )
103
-			->will( $this->returnValue( $item ) );
102
+		$this->stub->expects($this->once())->method('editItem')
103
+			->will($this->returnValue($item));
104 104
 
105
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->editItem( -1, [] ) );
105
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->editItem( -1, [] ));
106 106
 	}
107 107
 
108 108
 
109 109
 	public function testGetItem()
110 110
 	{
111
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
111
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
112 112
 
113
-		$this->stub->expects( $this->once() )->method( 'getItem' )
114
-			->will( $this->returnValue( $item ) );
113
+		$this->stub->expects($this->once())->method('getItem')
114
+			->will($this->returnValue($item));
115 115
 
116
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->getItem( -1 ) );
116
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->getItem( -1 ));
117 117
 	}
118 118
 
119 119
 
120 120
 	public function testFindItem()
121 121
 	{
122
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
122
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
123 123
 
124
-		$this->stub->expects( $this->once() )->method( 'findItem' )
125
-			->will( $this->returnValue( $item ) );
124
+		$this->stub->expects($this->once())->method('findItem')
125
+			->will($this->returnValue($item));
126 126
 
127
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Iface', $this->object->findItem( 'test' ) );
127
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Iface', $this->object->findItem('test'));
128 128
 	}
129 129
 
130 130
 
131 131
 	public function testSaveItem()
132 132
 	{
133
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer' )->createItem();
133
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer')->createItem();
134 134
 
135
-		$this->stub->expects( $this->once() )->method( 'saveItem' );
135
+		$this->stub->expects($this->once())->method('saveItem');
136 136
 
137
-		$this->object->saveItem( $item );
137
+		$this->object->saveItem($item);
138 138
 	}
139 139
 
140 140
 
141 141
 	public function testCreateAddressItem()
142 142
 	{
143
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
143
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
144 144
 
145
-		$this->stub->expects( $this->once() )->method( 'createAddressItem' )
146
-			->will( $this->returnValue( $item ) );
145
+		$this->stub->expects($this->once())->method('createAddressItem')
146
+			->will($this->returnValue($item));
147 147
 
148
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->createAddressItem() );
148
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->createAddressItem());
149 149
 	}
150 150
 
151 151
 
152 152
 	public function testDeleteAddressItem()
153 153
 	{
154
-		$this->stub->expects( $this->once() )->method( 'deleteAddressItem' );
154
+		$this->stub->expects($this->once())->method('deleteAddressItem');
155 155
 
156 156
 		$this->object->deleteAddressItem( -1 );
157 157
 	}
@@ -159,49 +159,49 @@  discard block
 block discarded – undo
159 159
 
160 160
 	public function testEditAddressItem()
161 161
 	{
162
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
162
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
163 163
 
164
-		$this->stub->expects( $this->once() )->method( 'editAddressItem' )
165
-			->will( $this->returnValue( $item ) );
164
+		$this->stub->expects($this->once())->method('editAddressItem')
165
+			->will($this->returnValue($item));
166 166
 
167
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->editAddressItem( -1, [] ) );
167
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->editAddressItem( -1, [] ));
168 168
 	}
169 169
 
170 170
 
171 171
 	public function testGetAddressItem()
172 172
 	{
173
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
173
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
174 174
 
175
-		$this->stub->expects( $this->once() )->method( 'getAddressItem' )
176
-			->will( $this->returnValue( $item ) );
175
+		$this->stub->expects($this->once())->method('getAddressItem')
176
+			->will($this->returnValue($item));
177 177
 
178
-		$this->assertInstanceOf( '\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->getAddressItem( -1 ) );
178
+		$this->assertInstanceOf('\Aimeos\MShop\Customer\Item\Address\Iface', $this->object->getAddressItem( -1 ));
179 179
 	}
180 180
 
181 181
 
182 182
 	public function testSaveAddressItem()
183 183
 	{
184
-		$item = \Aimeos\MShop\Factory::createManager( $this->context, 'customer/address' )->createItem();
184
+		$item = \Aimeos\MShop\Factory::createManager($this->context, 'customer/address')->createItem();
185 185
 
186
-		$this->stub->expects( $this->once() )->method( 'saveAddressItem' );
186
+		$this->stub->expects($this->once())->method('saveAddressItem');
187 187
 
188
-		$this->object->saveAddressItem( $item );
188
+		$this->object->saveAddressItem($item);
189 189
 	}
190 190
 
191 191
 
192 192
 	public function testGetController()
193 193
 	{
194
-		$result = $this->access( 'getController' )->invokeArgs( $this->object, [] );
194
+		$result = $this->access('getController')->invokeArgs($this->object, []);
195 195
 
196
-		$this->assertSame( $this->stub, $result );
196
+		$this->assertSame($this->stub, $result);
197 197
 	}
198 198
 
199 199
 
200
-	protected function access( $name )
200
+	protected function access($name)
201 201
 	{
202
-		$class = new \ReflectionClass( '\Aimeos\Controller\Frontend\Customer\Decorator\Base' );
203
-		$method = $class->getMethod( $name );
204
-		$method->setAccessible( true );
202
+		$class = new \ReflectionClass('\Aimeos\Controller\Frontend\Customer\Decorator\Base');
203
+		$method = $class->getMethod($name);
204
+		$method->setAccessible(true);
205 205
 
206 206
 		return $method;
207 207
 	}
Please login to merge, or discard this patch.
controller/frontend/src/Controller/Frontend/Service/Standard.php 2 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -121,8 +121,7 @@
 block discarded – undo
121 121
 				} else {
122 122
 					unset( $items[$id] );
123 123
 				}
124
-			}
125
-			catch( \Aimeos\MShop\Service\Exception $e )
124
+			} catch( \Aimeos\MShop\Service\Exception $e )
126 125
 			{
127 126
 				$msg = sprintf( 'Unable to create provider "%1$s" for service with ID "%2$s"', $service->getCode(), $id );
128 127
 				$this->getContext()->getLogger()->log( $msg, \Aimeos\MW\Logger\Base::WARN );
Please login to merge, or discard this patch.
Spacing   +68 added lines, -68 removed lines patch added patch discarded remove patch
@@ -35,12 +35,12 @@  discard block
 block discarded – undo
35 35
 	 * @param string[] $attributes List of attribute codes as keys and strings entered by the customer as value
36 36
 	 * @return string[] List of attributes codes as keys and error messages as values for invalid or missing values
37 37
 	 */
38
-	public function checkAttributes( $serviceId, array $attributes )
38
+	public function checkAttributes($serviceId, array $attributes)
39 39
 	{
40
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'service' );
41
-		$provider = $manager->getProvider( $manager->getItem( $serviceId, [], true ) );
40
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'service');
41
+		$provider = $manager->getProvider($manager->getItem($serviceId, [], true));
42 42
 
43
-		return array_filter( $provider->checkConfigFE( $attributes ) );
43
+		return array_filter($provider->checkConfigFE($attributes));
44 44
 	}
45 45
 
46 46
 
@@ -51,10 +51,10 @@  discard block
 block discarded – undo
51 51
 	 * @param string[] $ref List of domain names whose items should be fetched too
52 52
 	 * @return \Aimeos\MShop\Service\Provider\Iface Service provider object
53 53
 	 */
54
-	public function getProvider( $serviceId, $ref = ['media', 'price', 'text'] )
54
+	public function getProvider($serviceId, $ref = ['media', 'price', 'text'])
55 55
 	{
56
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'service' );
57
-		return $manager->getProvider( $manager->getItem( $serviceId, $ref, true ) );
56
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'service');
57
+		return $manager->getProvider($manager->getItem($serviceId, $ref, true));
58 58
 	}
59 59
 
60 60
 
@@ -65,26 +65,26 @@  discard block
 block discarded – undo
65 65
 	 * @param string[] $ref List of domain names whose items should be fetched too
66 66
 	 * @return \Aimeos\MShop\Service\Provider\Iface[] List of service IDs as keys and service provider objects as values
67 67
 	 */
68
-	public function getProviders( $type = null, $ref = ['media', 'price', 'text'] )
68
+	public function getProviders($type = null, $ref = ['media', 'price', 'text'])
69 69
 	{
70 70
 		$list = [];
71
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'service' );
71
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'service');
72 72
 
73
-		$search = $manager->createSearch( true );
74
-		$search->setSortations( array( $search->sort( '+', 'service.position' ) ) );
73
+		$search = $manager->createSearch(true);
74
+		$search->setSortations(array($search->sort('+', 'service.position')));
75 75
 
76
-		if( $type != null )
76
+		if ($type != null)
77 77
 		{
78 78
 			$expr = array(
79 79
 				$search->getConditions(),
80
-				$search->compare( '==', 'service.type.code', $type ),
81
-				$search->compare( '==', 'service.type.domain', 'service' ),
80
+				$search->compare('==', 'service.type.code', $type),
81
+				$search->compare('==', 'service.type.domain', 'service'),
82 82
 			);
83
-			$search->setConditions( $search->combine( '&&', $expr ) );
83
+			$search->setConditions($search->combine('&&', $expr));
84 84
 		}
85 85
 
86
-		foreach( $manager->searchItems( $search, $ref ) as $id => $item ) {
87
-			$list[$id] = $manager->getProvider( $item );
86
+		foreach ($manager->searchItems($search, $ref) as $id => $item) {
87
+			$list[$id] = $manager->getProvider($item);
88 88
 		}
89 89
 
90 90
 		return $list;
@@ -102,14 +102,14 @@  discard block
 block discarded – undo
102 102
 	 * @return \Aimeos\MShop\Common\Item\Helper\Form\Iface|null Form object with URL, parameters, etc.
103 103
 	 * 	or null if no form data is required
104 104
 	 */
105
-	public function process( \Aimeos\MShop\Order\Item\Iface $orderItem, $serviceId, array $urls, array $params )
105
+	public function process(\Aimeos\MShop\Order\Item\Iface $orderItem, $serviceId, array $urls, array $params)
106 106
 	{
107
-		$manager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'service' );
107
+		$manager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'service');
108 108
 
109
-		$provider = $manager->getProvider( $manager->getItem( $serviceId, [], true ) );
110
-		$provider->injectGlobalConfigBE( $urls );
109
+		$provider = $manager->getProvider($manager->getItem($serviceId, [], true));
110
+		$provider->injectGlobalConfigBE($urls);
111 111
 
112
-		return $provider->process( $orderItem, $params );
112
+		return $provider->process($orderItem, $params);
113 113
 	}
114 114
 
115 115
 
@@ -122,34 +122,34 @@  discard block
 block discarded – undo
122 122
 	 * 	(keys are <type>.url-self, <type>.url-success, <type>.url-update where type can be "delivery" or "payment")
123 123
 	 * @return \Aimeos\MShop\Order\Item\Iface $orderItem Order item that has been updated
124 124
 	 */
125
-	public function updateSync( ServerRequestInterface $request, ResponseInterface $response, array $urls )
125
+	public function updateSync(ServerRequestInterface $request, ResponseInterface $response, array $urls)
126 126
 	{
127 127
 		$params = (array) $request->getAttributes() + (array) $request->getParsedBody() + (array) $request->getQueryParams();
128 128
 
129
-		if( !isset( $params['code'] ) ) {
129
+		if (!isset($params['code'])) {
130 130
 			return;
131 131
 		}
132 132
 
133 133
 		$context = $this->getContext();
134
-		$manager = \Aimeos\MShop\Factory::createManager( $context, 'service' );
134
+		$manager = \Aimeos\MShop\Factory::createManager($context, 'service');
135 135
 
136
-		$provider = $manager->getProvider( $manager->findItem( $params['code'] ) );
137
-		$provider->injectGlobalConfigBE( $urls );
136
+		$provider = $manager->getProvider($manager->findItem($params['code']));
137
+		$provider->injectGlobalConfigBE($urls);
138 138
 
139 139
 		$body = (string) $request->getBody();
140 140
 		$response = null;
141 141
 		$headers = [];
142 142
 
143
-		if( ( $orderItem = $provider->updateSync( $params, $body, $response, $headers ) ) !== null )
143
+		if (($orderItem = $provider->updateSync($params, $body, $response, $headers)) !== null)
144 144
 		{
145
-			if( $orderItem->getPaymentStatus() === \Aimeos\MShop\Order\Item\Base::PAY_UNFINISHED
146
-				&& $provider->isImplemented( \Aimeos\MShop\Service\Provider\Payment\Base::FEAT_QUERY )
145
+			if ($orderItem->getPaymentStatus() === \Aimeos\MShop\Order\Item\Base::PAY_UNFINISHED
146
+				&& $provider->isImplemented(\Aimeos\MShop\Service\Provider\Payment\Base::FEAT_QUERY)
147 147
 			) {
148
-				$provider->query( $orderItem );
148
+				$provider->query($orderItem);
149 149
 			}
150 150
 
151 151
 			// update stock, coupons, etc.
152
-			\Aimeos\Controller\Frontend\Factory::createController( $context, 'order' )->update( $orderItem );
152
+			\Aimeos\Controller\Frontend\Factory::createController($context, 'order')->update($orderItem);
153 153
 		}
154 154
 
155 155
 		return $orderItem;
@@ -166,38 +166,38 @@  discard block
 block discarded – undo
166 166
 	 * @throws \Exception If an error occurs
167 167
 	 * @deprecated Use getProviders() instead
168 168
 	 */
169
-	public function getServices( $type, \Aimeos\MShop\Order\Item\Base\Iface $basket, $ref = ['media', 'price', 'text'] )
169
+	public function getServices($type, \Aimeos\MShop\Order\Item\Base\Iface $basket, $ref = ['media', 'price', 'text'])
170 170
 	{
171
-		$serviceManager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'service' );
171
+		$serviceManager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'service');
172 172
 
173
-		$search = $serviceManager->createSearch( true );
173
+		$search = $serviceManager->createSearch(true);
174 174
 		$expr = array(
175 175
 			$search->getConditions(),
176
-			$search->compare( '==', 'service.type.domain', 'service' ),
177
-			$search->compare( '==', 'service.type.code', $type ),
176
+			$search->compare('==', 'service.type.domain', 'service'),
177
+			$search->compare('==', 'service.type.code', $type),
178 178
 		);
179
-		$search->setConditions( $search->combine( '&&', $expr ) );
180
-		$search->setSortations( array( $search->sort( '+', 'service.position' ) ) );
179
+		$search->setConditions($search->combine('&&', $expr));
180
+		$search->setSortations(array($search->sort('+', 'service.position')));
181 181
 
182
-		$items = $serviceManager->searchItems( $search, $ref );
182
+		$items = $serviceManager->searchItems($search, $ref);
183 183
 
184 184
 
185
-		foreach( $items as $id => $service )
185
+		foreach ($items as $id => $service)
186 186
 		{
187 187
 			try
188 188
 			{
189
-				$provider = $serviceManager->getProvider( $service );
189
+				$provider = $serviceManager->getProvider($service);
190 190
 
191
-				if( $provider->isAvailable( $basket ) ) {
191
+				if ($provider->isAvailable($basket)) {
192 192
 					$this->providers[$type][$id] = $provider;
193 193
 				} else {
194
-					unset( $items[$id] );
194
+					unset($items[$id]);
195 195
 				}
196 196
 			}
197
-			catch( \Aimeos\MShop\Service\Exception $e )
197
+			catch (\Aimeos\MShop\Service\Exception $e)
198 198
 			{
199
-				$msg = sprintf( 'Unable to create provider "%1$s" for service with ID "%2$s"', $service->getCode(), $id );
200
-				$this->getContext()->getLogger()->log( $msg, \Aimeos\MW\Logger\Base::WARN );
199
+				$msg = sprintf('Unable to create provider "%1$s" for service with ID "%2$s"', $service->getCode(), $id);
200
+				$this->getContext()->getLogger()->log($msg, \Aimeos\MW\Logger\Base::WARN);
201 201
 			}
202 202
 		}
203 203
 
@@ -218,16 +218,16 @@  discard block
 block discarded – undo
218 218
 	 * @throws \Exception If an error occurs
219 219
 	 * @deprecated Use getProvider() instead
220 220
 	 */
221
-	public function getServiceAttributes( $type, $serviceId, \Aimeos\MShop\Order\Item\Base\Iface $basket )
221
+	public function getServiceAttributes($type, $serviceId, \Aimeos\MShop\Order\Item\Base\Iface $basket)
222 222
 	{
223
-		if( isset( $this->providers[$type][$serviceId] ) ) {
224
-			return $this->providers[$type][$serviceId]->getConfigFE( $basket );
223
+		if (isset($this->providers[$type][$serviceId])) {
224
+			return $this->providers[$type][$serviceId]->getConfigFE($basket);
225 225
 		}
226 226
 
227
-		$serviceManager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'service' );
228
-		$item = $serviceManager->getItem( $serviceId, ['price'], true );
227
+		$serviceManager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'service');
228
+		$item = $serviceManager->getItem($serviceId, ['price'], true);
229 229
 
230
-		return $serviceManager->getProvider( $item )->getConfigFE( $basket );
230
+		return $serviceManager->getProvider($item)->getConfigFE($basket);
231 231
 	}
232 232
 
233 233
 
@@ -243,16 +243,16 @@  discard block
 block discarded – undo
243 243
 	 * @throws \Exception If an error occurs
244 244
 	 * @deprecated Use getProvider() instead
245 245
 	 */
246
-	public function getServicePrice( $type, $serviceId, \Aimeos\MShop\Order\Item\Base\Iface $basket )
246
+	public function getServicePrice($type, $serviceId, \Aimeos\MShop\Order\Item\Base\Iface $basket)
247 247
 	{
248
-		if( isset( $this->providers[$type][$serviceId] ) ) {
249
-			return $this->providers[$type][$serviceId]->calcPrice( $basket );
248
+		if (isset($this->providers[$type][$serviceId])) {
249
+			return $this->providers[$type][$serviceId]->calcPrice($basket);
250 250
 		}
251 251
 
252
-		$serviceManager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'service' );
253
-		$item = $serviceManager->getItem( $serviceId, ['price'], true );
252
+		$serviceManager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'service');
253
+		$item = $serviceManager->getItem($serviceId, ['price'], true);
254 254
 
255
-		return $serviceManager->getProvider( $item )->calcPrice( $basket );
255
+		return $serviceManager->getProvider($item)->calcPrice($basket);
256 256
 	}
257 257
 
258 258
 
@@ -268,22 +268,22 @@  discard block
 block discarded – undo
268 268
 	 * @throws \Aimeos\Controller\Frontend\Service\Exception If no active service provider for this ID is available
269 269
 	 * @deprecated Use checkAttributes() instead
270 270
 	 */
271
-	public function checkServiceAttributes( $type, $serviceId, array $attributes )
271
+	public function checkServiceAttributes($type, $serviceId, array $attributes)
272 272
 	{
273
-		if( !isset( $this->providers[$type][$serviceId] ) )
273
+		if (!isset($this->providers[$type][$serviceId]))
274 274
 		{
275
-			$serviceManager = \Aimeos\MShop\Factory::createManager( $this->getContext(), 'service' );
276
-			$item = $serviceManager->getItem( $serviceId, ['price'], true );
275
+			$serviceManager = \Aimeos\MShop\Factory::createManager($this->getContext(), 'service');
276
+			$item = $serviceManager->getItem($serviceId, ['price'], true);
277 277
 
278
-			$this->providers[$type][$serviceId] = $serviceManager->getProvider( $item );
278
+			$this->providers[$type][$serviceId] = $serviceManager->getProvider($item);
279 279
 		}
280 280
 
281
-		$errors = $this->providers[$type][$serviceId]->checkConfigFE( $attributes );
281
+		$errors = $this->providers[$type][$serviceId]->checkConfigFE($attributes);
282 282
 
283
-		foreach( $errors as $key => $msg )
283
+		foreach ($errors as $key => $msg)
284 284
 		{
285
-			if( $msg === null ) {
286
-				unset( $errors[$key] );
285
+			if ($msg === null) {
286
+				unset($errors[$key]);
287 287
 			}
288 288
 		}
289 289
 
Please login to merge, or discard this patch.