aimeos / ai-client-jsonapi

client/jsonapi/tests/Client/JsonApi/Locale/StandardTest.php

Spacing +60 added lines, -60 removed lines

@@ -22,20 +22,20 @@ 
 		$templatePaths = \TestHelperJapi::getTemplatePaths();
 		$this->view = $this->context->getView();
 
-		$this->object = new \Aimeos\Client\JsonApi\Locale\Standard( $this->context, $this->view, $templatePaths, 'locale' );
+		$this->object = new \Aimeos\Client\JsonApi\Locale\Standard($this->context, $this->view, $templatePaths, 'locale');
 	}
 
 
 	public function testGetItem()
 	{
-		$localeManager = \Aimeos\MShop\Factory::createManager( $this->context, 'locale' );
+		$localeManager = \Aimeos\MShop\Factory::createManager($this->context, 'locale');
 		$search = $localeManager->createSearch();
-		$search->setSortations( [$search->sort( '+', 'locale.position' )] );
-		$search->setSlice( 0, 1 );
-		$localeItems = $localeManager->searchItems( $search );
+		$search->setSortations([$search->sort('+', 'locale.position')]);
+		$search->setSlice(0, 1);
+		$localeItems = $localeManager->searchItems($search);
 
-		if( ( $localeItem = reset( $localeItems ) ) === false ) {
-			throw new \Exception( 'No locale item found' );
+		if (($localeItem = reset($localeItems)) === false) {
+			throw new \Exception('No locale item found');
 		}
 
 
@@ -46,24 +46,24 @@ 
 			)
 		);
 
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
-		$response = $this->object->get( $this->view->request(), $this->view->response() );
-		$result = json_decode( (string) $response->getBody(), true );
+		$response = $this->object->get($this->view->request(), $this->view->response());
+		$result = json_decode((string) $response->getBody(), true);
 
 
-		$this->assertEquals( 200, $response->getStatusCode() );
-		$this->assertEquals( 1, count( $response->getHeader( 'Allow' ) ) );
-		$this->assertEquals( 1, count( $response->getHeader( 'Content-Type' ) ) );
+		$this->assertEquals(200, $response->getStatusCode());
+		$this->assertEquals(1, count($response->getHeader('Allow')));
+		$this->assertEquals(1, count($response->getHeader('Content-Type')));
 
-		$this->assertEquals( 1, $result['meta']['total'] );
-		$this->assertEquals( 'locale', $result['data']['type'] );
-		$this->assertGreaterThan( 0, $result['data']['attributes']['locale.id'] );
-		$this->assertEquals( 'de', $result['data']['attributes']['locale.languageid'] );
-		$this->assertEquals( 'EUR', $result['data']['attributes']['locale.currencyid'] );
+		$this->assertEquals(1, $result['meta']['total']);
+		$this->assertEquals('locale', $result['data']['type']);
+		$this->assertGreaterThan(0, $result['data']['attributes']['locale.id']);
+		$this->assertEquals('de', $result['data']['attributes']['locale.languageid']);
+		$this->assertEquals('EUR', $result['data']['attributes']['locale.currencyid']);
 
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 
 
@@ -75,25 +75,25 @@ 
 			),
 			'sort' => 'locale.position',
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
-		$response = $this->object->get( $this->view->request(), $this->view->response() );
-		$result = json_decode( (string) $response->getBody(), true );
+		$response = $this->object->get($this->view->request(), $this->view->response());
+		$result = json_decode((string) $response->getBody(), true);
 
 
-		$this->assertEquals( 200, $response->getStatusCode() );
-		$this->assertEquals( 1, count( $response->getHeader( 'Allow' ) ) );
-		$this->assertEquals( 1, count( $response->getHeader( 'Content-Type' ) ) );
+		$this->assertEquals(200, $response->getStatusCode());
+		$this->assertEquals(1, count($response->getHeader('Allow')));
+		$this->assertEquals(1, count($response->getHeader('Content-Type')));
 
-		$this->assertEquals( 1, $result['meta']['total'] );
-		$this->assertEquals( 1, count( $result['data'] ) );
-		$this->assertEquals( 'locale', $result['data'][0]['type'] );
-		$this->assertEquals( 3, count( $result['data'][0]['attributes'] ) );
-		$this->assertEquals( 'en', $result['data'][0]['attributes']['locale.languageid'] );
-		$this->assertEquals( 'EUR', $result['data'][0]['attributes']['locale.currencyid'] );
+		$this->assertEquals(1, $result['meta']['total']);
+		$this->assertEquals(1, count($result['data']));
+		$this->assertEquals('locale', $result['data'][0]['type']);
+		$this->assertEquals(3, count($result['data'][0]['attributes']));
+		$this->assertEquals('en', $result['data'][0]['attributes']['locale.languageid']);
+		$this->assertEquals('EUR', $result['data'][0]['attributes']['locale.currencyid']);
 
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 
 
@@ -101,20 +101,20 @@ 
 	{
 		$params = array(
 			'filter' => array(
-				'>=' => array( 'locale.position' => 0 ),
+				'>=' => array('locale.position' => 0),
 			),
 			'sort' => '-locale.position',
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
-		$response = $this->object->get( $this->view->request(), $this->view->response() );
-		$result = json_decode( (string) $response->getBody(), true );
+		$response = $this->object->get($this->view->request(), $this->view->response());
+		$result = json_decode((string) $response->getBody(), true);
 
 
-		$this->assertEquals( 200, $response->getStatusCode() );
-		$this->assertEquals( 1, $result['meta']['total'] );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$this->assertEquals(200, $response->getStatusCode());
+		$this->assertEquals(1, $result['meta']['total']);
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 
 
@@ -122,21 +122,21 @@ 
 	{
 		$templatePaths = \TestHelperJapi::getTemplatePaths();
 
-		$object = $this->getMockBuilder( '\Aimeos\Client\JsonApi\Locale\Standard' )
-			->setConstructorArgs( [$this->context, $this->view, $templatePaths, 'locale'] )
-			->setMethods( ['getItems'] )
+		$object = $this->getMockBuilder('\Aimeos\Client\JsonApi\Locale\Standard')
+			->setConstructorArgs([$this->context, $this->view, $templatePaths, 'locale'])
+			->setMethods(['getItems'])
 			->getMock();
 
-		$object->expects( $this->once() )->method( 'getItems' )
-			->will( $this->throwException( new \Aimeos\MShop\Exception() ) );
+		$object->expects($this->once())->method('getItems')
+			->will($this->throwException(new \Aimeos\MShop\Exception()));
 
 
-		$response = $object->get( $this->view->request(), $this->view->response() );
-		$result = json_decode( (string) $response->getBody(), true );
+		$response = $object->get($this->view->request(), $this->view->response());
+		$result = json_decode((string) $response->getBody(), true);
 
 
-		$this->assertEquals( 404, $response->getStatusCode() );
-		$this->assertArrayHasKey( 'errors', $result );
+		$this->assertEquals(404, $response->getStatusCode());
+		$this->assertArrayHasKey('errors', $result);
 	}
 
 
@@ -144,20 +144,20 @@ 
 	{
 		$templatePaths = \TestHelperJapi::getTemplatePaths();
 
-		$object = $this->getMockBuilder( '\Aimeos\Client\JsonApi\Locale\Standard' )
-			->setConstructorArgs( [$this->context, $this->view, $templatePaths, 'locale'] )
-			->setMethods( ['getItems'] )
+		$object = $this->getMockBuilder('\Aimeos\Client\JsonApi\Locale\Standard')
+			->setConstructorArgs([$this->context, $this->view, $templatePaths, 'locale'])
+			->setMethods(['getItems'])
 			->getMock();
 
-		$object->expects( $this->once() )->method( 'getItems' )
-			->will( $this->throwException( new \Exception() ) );
+		$object->expects($this->once())->method('getItems')
+			->will($this->throwException(new \Exception()));
 
 
-		$response = $object->get( $this->view->request(), $this->view->response() );
-		$result = json_decode( (string) $response->getBody(), true );
+		$response = $object->get($this->view->request(), $this->view->response());
+		$result = json_decode((string) $response->getBody(), true);
 
 
-		$this->assertEquals( 500, $response->getStatusCode() );
-		$this->assertArrayHasKey( 'errors', $result );
+		$this->assertEquals(500, $response->getStatusCode());
+		$this->assertArrayHasKey('errors', $result);
 	}
 }
\ No newline at end of file

client/jsonapi/src/Client/JsonApi/Common/Factory/Base.php

Spacing +38 added lines, -38 removed lines

@@ -31,7 +31,7 @@ 
 	 * @param string $classname Full name of the class for which the object should be returned
 	 * @param \Aimeos\Client\JsonApi\Iface|null $client JSON API client object
 	 */
-	public static function injectClient( $classname, \Aimeos\Client\JsonApi\Iface $client = null )
+	public static function injectClient($classname, \Aimeos\Client\JsonApi\Iface $client = null)
 	{
 		self::$objects[$classname] = $client;
 	}
@@ -47,8 +47,8 @@ 
 	 * @param string $path Name of the client, e.g "product"
 	 * @return \Aimeos\Client\JsonApi\Iface Client object
 	 */
-	protected static function addClientDecorators( \Aimeos\Client\JsonApi\Iface $client,
-		\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MW\View\Iface $view, array $templatePaths, $path )
+	protected static function addClientDecorators(\Aimeos\Client\JsonApi\Iface $client,
+		\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MW\View\Iface $view, array $templatePaths, $path)
 	{
 		$config = $context->getConfig();
 
@@ -74,38 +74,38 @@ 
 		 * @since 2015.12
 		 * @category Developer
 		 */
-		$decorators = $config->get( 'client/jsonapi/common/decorators/default', array() );
+		$decorators = $config->get('client/jsonapi/common/decorators/default', array());
 
-		if( $path !== null && is_string( $path ) )
+		if ($path !== null && is_string($path))
 		{
-			$dpath = trim( $path, '/' );
-			$dpath = ( $dpath !== '' ? $dpath . '/' : $dpath );
+			$dpath = trim($path, '/');
+			$dpath = ($dpath !== '' ? $dpath . '/' : $dpath);
 
-			$excludes = $config->get( 'client/jsonapi/' . $dpath . 'decorators/excludes', array() );
-			$localClass = str_replace( ' ', '\\', ucwords( str_replace( '/', ' ', $path ) ) );
+			$excludes = $config->get('client/jsonapi/' . $dpath . 'decorators/excludes', array());
+			$localClass = str_replace(' ', '\\', ucwords(str_replace('/', ' ', $path)));
 
-			foreach( $decorators as $key => $name )
+			foreach ($decorators as $key => $name)
 			{
-				if( in_array( $name, $excludes ) ) {
-					unset( $decorators[$key] );
+				if (in_array($name, $excludes)) {
+					unset($decorators[$key]);
 				}
 			}
 
 			$classprefix = '\\Aimeos\\Client\\JsonApi\\Common\\Decorator\\';
-			$decorators = $config->get( 'client/jsonapi/' . $dpath . 'decorators/global', array() );
-			$client = self::addDecorators( $client, $decorators, $classprefix, $context, $view, $templatePaths, $path );
+			$decorators = $config->get('client/jsonapi/' . $dpath . 'decorators/global', array());
+			$client = self::addDecorators($client, $decorators, $classprefix, $context, $view, $templatePaths, $path);
 
-			if( !empty( $path ) )
+			if (!empty($path))
 			{
-				$classprefix = '\\Aimeos\\Client\\JsonApi\\' . ucfirst( $localClass ) . '\\Decorator\\';
-				$decorators = $config->get( 'client/jsonapi/' . $dpath . 'decorators/local', array() );
-				$client = self::addDecorators( $client, $decorators, $classprefix, $context, $view, $templatePaths, $path );
+				$classprefix = '\\Aimeos\\Client\\JsonApi\\' . ucfirst($localClass) . '\\Decorator\\';
+				$decorators = $config->get('client/jsonapi/' . $dpath . 'decorators/local', array());
+				$client = self::addDecorators($client, $decorators, $classprefix, $context, $view, $templatePaths, $path);
 			}
 		}
 		else
 		{
 			$classprefix = '\\Aimeos\\Client\\JsonApi\\Common\\Decorator\\';
-			$client = self::addDecorators( $client, $decorators, $classprefix, $context, $view, $templatePaths, $path );
+			$client = self::addDecorators($client, $decorators, $classprefix, $context, $view, $templatePaths, $path);
 		}
 
 		return $client;
@@ -124,29 +124,29 @@ 
 	 * @param string $path Name of the client, e.g "product"
 	 * @return \Aimeos\Client\JsonApi\Iface Client object
 	 */
-	protected static function addDecorators( \Aimeos\Client\JsonApi\Iface $client, array $decorators, $classprefix,
-			\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MW\View\Iface $view, $templatePaths, $path )
+	protected static function addDecorators(\Aimeos\Client\JsonApi\Iface $client, array $decorators, $classprefix,
+			\Aimeos\MShop\Context\Item\Iface $context, \Aimeos\MW\View\Iface $view, $templatePaths, $path)
 	{
 		$iface = '\\Aimeos\\Client\\JsonApi\\Common\\Decorator\\Iface';
 
-		foreach( $decorators as $name )
+		foreach ($decorators as $name)
 		{
-			if( ctype_alnum( $name ) === false )
+			if (ctype_alnum($name) === false)
 			{
-				$classname = is_string( $name ) ? $classprefix . $name : '<not a string>';
-				throw new \Aimeos\Client\JsonApi\Exception( sprintf( 'Invalid class name "%1$s"', $classname ), 404 );
+				$classname = is_string($name) ? $classprefix . $name : '<not a string>';
+				throw new \Aimeos\Client\JsonApi\Exception(sprintf('Invalid class name "%1$s"', $classname), 404);
 			}
 
 			$classname = $classprefix . $name;
 
-			if( class_exists( $classname ) === false ) {
-				throw new \Aimeos\Client\JsonApi\Exception( sprintf( 'Class "%1$s" not found', $classname ), 404 );
+			if (class_exists($classname) === false) {
+				throw new \Aimeos\Client\JsonApi\Exception(sprintf('Class "%1$s" not found', $classname), 404);
 			}
 
-			$client = new $classname( $client, $context, $view, $templatePaths, $path );
+			$client = new $classname($client, $context, $view, $templatePaths, $path);
 
-			if( !( $client instanceof $iface ) ) {
-				throw new \Aimeos\Client\JsonApi\Exception( sprintf( 'Class "%1$s" does not implement "%2$s"', $classname, $iface ), 404 );
+			if (!($client instanceof $iface)) {
+				throw new \Aimeos\Client\JsonApi\Exception(sprintf('Class "%1$s" does not implement "%2$s"', $classname, $iface), 404);
 			}
 		}
 
@@ -165,21 +165,21 @@ 
 	 * @param string $path Name of the client, e.g "product"
 	 * @return \Aimeos\Client\JsonApi\Iface Client object
 	 */
-	protected static function createClientBase( $classname, $interface, \Aimeos\MShop\Context\Item\Iface $context,
-		\Aimeos\MW\View\Iface $view, array $templatePaths, $path )
+	protected static function createClientBase($classname, $interface, \Aimeos\MShop\Context\Item\Iface $context,
+		\Aimeos\MW\View\Iface $view, array $templatePaths, $path)
 	{
-		if( isset( self::$objects[$classname] ) ) {
+		if (isset(self::$objects[$classname])) {
 			return self::$objects[$classname];
 		}
 
-		if( class_exists( $classname ) === false ) {
-			throw new \Aimeos\Client\JsonApi\Exception( sprintf( 'Class "%1$s" not found', $classname ), 404 );
+		if (class_exists($classname) === false) {
+			throw new \Aimeos\Client\JsonApi\Exception(sprintf('Class "%1$s" not found', $classname), 404);
 		}
 
-		$client = new $classname( $context, $view, $templatePaths, $path );
+		$client = new $classname($context, $view, $templatePaths, $path);
 
-		if( !( $client instanceof $interface ) ) {
-			throw new \Aimeos\Client\JsonApi\Exception( sprintf( 'Class "%1$s" does not implement "%2$s"', $classname, $interface ), 500 );
+		if (!($client instanceof $interface)) {
+			throw new \Aimeos\Client\JsonApi\Exception(sprintf('Class "%1$s" does not implement "%2$s"', $classname, $interface), 500);
 		}
 
 		return $client;

client/jsonapi/src/Client/JsonApi/Common/Factory/Iface.php

Spacing +1 added lines, -1 removed lines

@@ -28,5 +28,5 @@
 	 * @param string|null $name Name of the client implementation ("Standard" if null)
 	 * @return \Aimeos\Client\JsonApi\Iface Client Interface
 	 */
-	public static function createClient( \Aimeos\MShop\Context\Item\Iface $context, array $templatePaths, $path, $name = null );
+	public static function createClient(\Aimeos\MShop\Context\Item\Iface $context, array $templatePaths, $path, $name = null);
 }