Inspection of "Adapt tests" - aimeos/ai-client-jsonapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 61c665...5e15bb )

by Aimeos

created 2017-04-08 01:09 UTC

Status

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -39,16 +39,14 @@
 block discarded – undo
 		{
 			$response = $this->getItem( $view, $request, $response );
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(

Please login to merge, or discard this patch.

client/jsonapi/src/Client/JsonApi/Stock/Standard.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -44,16 +44,14 @@
 block discarded – undo
 			}
 
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(

Please login to merge, or discard this patch.

client/jsonapi/src/Client/JsonApi/Standard.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -60,8 +60,7 @@
 block discarded – undo
 			$view->resources = (array) $resources;
 			$view->prefix = $prefix;
 			$status = 200;
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(

Please login to merge, or discard this patch.

client/jsonapi/src/Client/JsonApi/Factory.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -136,8 +136,7 @@
 block discarded – undo
 			if( ( $client = @call_user_func_array( array( $factory, 'createClient' ), $args ) ) === false ) {
 				throw new \Aimeos\Client\JsonApi\Exception( sprintf( 'Invalid factory "%1$s"', $factory ), 400 );
 			}
-		}
-		else
+		} else
 		{
 			$client = self::createClientRoot( $context, $view, $templatePaths, $path, $name );
 		}

Please login to merge, or discard this patch.

client/jsonapi/src/Client/JsonApi/Attribute/Standard.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -44,16 +44,14 @@
 block discarded – undo
 			}
 
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(

Please login to merge, or discard this patch.

client/jsonapi/src/Client/JsonApi/Locale/Standard.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -44,16 +44,14 @@
 block discarded – undo
 			}
 
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(

Please login to merge, or discard this patch.

client/jsonapi/src/Client/JsonApi/Basket/Address/Standard.php 1 patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

@@ -78,8 +78,7 @@  discard block
 block discarded – undo
 
 					$this->controller->setAddress( $entry->id, null );
 				}
-			}
-			else
+			} else
 			{
 				$this->controller->setAddress( $relId, null );
 			}
@@ -87,16 +86,14 @@  discard block
 block discarded – undo
 
 			$view->item = $this->controller->get();
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(
@@ -145,16 +142,14 @@  discard block
 block discarded – undo
 
 			$view->item = $this->controller->get();
 			$status = 201;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(

Please login to merge, or discard this patch.

client/jsonapi/src/Client/JsonApi/Basket/Product/Standard.php 1 patch

Braces +7 added lines, -14 removed lines patch added patch discarded remove patch

@@ -78,8 +78,7 @@  discard block
 block discarded – undo
 
 					$this->controller->deleteProduct( $entry->id );
 				}
-			}
-			else
+			} else
 			{
 				$this->controller->deleteProduct( $relId );
 			}
@@ -87,16 +86,14 @@  discard block
 block discarded – undo
 
 			$view->item = $this->controller->get();
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(
@@ -152,16 +149,14 @@  discard block
 block discarded – undo
 
 			$view->item = $this->controller->get();
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(
@@ -218,16 +213,14 @@  discard block
 block discarded – undo
 
 			$view->item = $this->controller->get();
 			$status = 201;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(

Please login to merge, or discard this patch.

client/jsonapi/src/Client/JsonApi/Basket/Service/Standard.php 1 patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

@@ -78,8 +78,7 @@  discard block
 block discarded – undo
 
 					$this->controller->setService( $entry->id, null );
 				}
-			}
-			else
+			} else
 			{
 				$this->controller->setService( $relId, null );
 			}
@@ -87,16 +86,14 @@  discard block
 block discarded – undo
 
 			$view->item = $this->controller->get();
 			$status = 200;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(
@@ -156,16 +153,14 @@  discard block
 block discarded – undo
 
 			$view->item = $this->controller->get();
 			$status = 201;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$status = 404;
 			$view->errors = array( array(
 				'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
 				'detail' => $e->getTraceAsString(),
 			) );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$status = 500;
 			$view->errors = array( array(

Please login to merge, or discard this patch.

		@@ -78,8 +78,7 @@ discard block
		block discarded – undo
78	78
79	79	$this->controller->setAddress( $entry->id, null );
80	80	}
81		- }
82		- else
	81	+ } else
83	82	{
84	83	$this->controller->setAddress( $relId, null );
85	84	}
		@@ -87,16 +86,14 @@ discard block
		block discarded – undo
87	86
88	87	$view->item = $this->controller->get();
89	88	$status = 200;
90		- }
91		- catch( \Aimeos\MShop\Exception $e )
	89	+ } catch( \Aimeos\MShop\Exception $e )
92	90	{
93	91	$status = 404;
94	92	$view->errors = array( array(
95	93	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
96	94	'detail' => $e->getTraceAsString(),
97	95	) );
98		- }
99		- catch( \Exception $e )
	96	+ } catch( \Exception $e )
100	97	{
101	98	$status = 500;
102	99	$view->errors = array( array(
		@@ -145,16 +142,14 @@ discard block
		block discarded – undo
145	142
146	143	$view->item = $this->controller->get();
147	144	$status = 201;
148		- }
149		- catch( \Aimeos\MShop\Exception $e )
	145	+ } catch( \Aimeos\MShop\Exception $e )
150	146	{
151	147	$status = 404;
152	148	$view->errors = array( array(
153	149	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
154	150	'detail' => $e->getTraceAsString(),
155	151	) );
156		- }
157		- catch( \Exception $e )
	152	+ } catch( \Exception $e )
158	153	{
159	154	$status = 500;
160	155	$view->errors = array( array(

		@@ -78,8 +78,7 @@ discard block
		block discarded – undo
78	78
79	79	$this->controller->deleteProduct( $entry->id );
80	80	}
81		- }
82		- else
	81	+ } else
83	82	{
84	83	$this->controller->deleteProduct( $relId );
85	84	}
		@@ -87,16 +86,14 @@ discard block
		block discarded – undo
87	86
88	87	$view->item = $this->controller->get();
89	88	$status = 200;
90		- }
91		- catch( \Aimeos\MShop\Exception $e )
	89	+ } catch( \Aimeos\MShop\Exception $e )
92	90	{
93	91	$status = 404;
94	92	$view->errors = array( array(
95	93	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
96	94	'detail' => $e->getTraceAsString(),
97	95	) );
98		- }
99		- catch( \Exception $e )
	96	+ } catch( \Exception $e )
100	97	{
101	98	$status = 500;
102	99	$view->errors = array( array(
		@@ -152,16 +149,14 @@ discard block
		block discarded – undo
152	149
153	150	$view->item = $this->controller->get();
154	151	$status = 200;
155		- }
156		- catch( \Aimeos\MShop\Exception $e )
	152	+ } catch( \Aimeos\MShop\Exception $e )
157	153	{
158	154	$status = 404;
159	155	$view->errors = array( array(
160	156	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
161	157	'detail' => $e->getTraceAsString(),
162	158	) );
163		- }
164		- catch( \Exception $e )
	159	+ } catch( \Exception $e )
165	160	{
166	161	$status = 500;
167	162	$view->errors = array( array(
		@@ -218,16 +213,14 @@ discard block
		block discarded – undo
218	213
219	214	$view->item = $this->controller->get();
220	215	$status = 201;
221		- }
222		- catch( \Aimeos\MShop\Exception $e )
	216	+ } catch( \Aimeos\MShop\Exception $e )
223	217	{
224	218	$status = 404;
225	219	$view->errors = array( array(
226	220	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
227	221	'detail' => $e->getTraceAsString(),
228	222	) );
229		- }
230		- catch( \Exception $e )
	223	+ } catch( \Exception $e )
231	224	{
232	225	$status = 500;
233	226	$view->errors = array( array(

		@@ -78,8 +78,7 @@ discard block
		block discarded – undo
78	78
79	79	$this->controller->setService( $entry->id, null );
80	80	}
81		- }
82		- else
	81	+ } else
83	82	{
84	83	$this->controller->setService( $relId, null );
85	84	}
		@@ -87,16 +86,14 @@ discard block
		block discarded – undo
87	86
88	87	$view->item = $this->controller->get();
89	88	$status = 200;
90		- }
91		- catch( \Aimeos\MShop\Exception $e )
	89	+ } catch( \Aimeos\MShop\Exception $e )
92	90	{
93	91	$status = 404;
94	92	$view->errors = array( array(
95	93	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
96	94	'detail' => $e->getTraceAsString(),
97	95	) );
98		- }
99		- catch( \Exception $e )
	96	+ } catch( \Exception $e )
100	97	{
101	98	$status = 500;
102	99	$view->errors = array( array(
		@@ -156,16 +153,14 @@ discard block
		block discarded – undo
156	153
157	154	$view->item = $this->controller->get();
158	155	$status = 201;
159		- }
160		- catch( \Aimeos\MShop\Exception $e )
	156	+ } catch( \Aimeos\MShop\Exception $e )
161	157	{
162	158	$status = 404;
163	159	$view->errors = array( array(
164	160	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
165	161	'detail' => $e->getTraceAsString(),
166	162	) );
167		- }
168		- catch( \Exception $e )
	163	+ } catch( \Exception $e )
169	164	{
170	165	$status = 500;
171	166	$view->errors = array( array(

		@@ -39,16 +39,14 @@
		block discarded – undo
39	39	{
40	40	$response = $this->getItem( $view, $request, $response );
41	41	$status = 200;
42		- }
43		- catch( \Aimeos\MShop\Exception $e )
	42	+ } catch( \Aimeos\MShop\Exception $e )
44	43	{
45	44	$status = 404;
46	45	$view->errors = array( array(
47	46	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
48	47	'detail' => $e->getTraceAsString(),
49	48	) );
50		- }
51		- catch( \Exception $e )
	49	+ } catch( \Exception $e )
52	50	{
53	51	$status = 500;
54	52	$view->errors = array( array(

		@@ -44,16 +44,14 @@
		block discarded – undo
44	44	}
45	45
46	46	$status = 200;
47		- }
48		- catch( \Aimeos\MShop\Exception $e )
	47	+ } catch( \Aimeos\MShop\Exception $e )
49	48	{
50	49	$status = 404;
51	50	$view->errors = array( array(
52	51	'title' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ),
53	52	'detail' => $e->getTraceAsString(),
54	53	) );
55		- }
56		- catch( \Exception $e )
	54	+ } catch( \Exception $e )
57	55	{
58	56	$status = 500;
59	57	$view->errors = array( array(

		@@ -60,8 +60,7 @@
		block discarded – undo
60	60	$view->resources = (array) $resources;
61	61	$view->prefix = $prefix;
62	62	$status = 200;
63		- }
64		- catch( \Exception $e )
	63	+ } catch( \Exception $e )
65	64	{
66	65	$status = 500;
67	66	$view->errors = array( array(

		@@ -136,8 +136,7 @@
		block discarded – undo
136	136	if( ( $client = @call_user_func_array( array( $factory, 'createClient' ), $args ) ) === false ) {
137	137	throw new \Aimeos\Client\JsonApi\Exception( sprintf( 'Invalid factory "%1$s"', $factory ), 400 );
138	138	}
139		- }
140		- else
	139	+ } else
141	140	{
142	141	$client = self::createClientRoot( $context, $view, $templatePaths, $path, $name );
143	142	}

aimeos / ai-client-jsonapi

Push — master ( 61c665...5e15bb )

Status

Category

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch

Braces +7 added lines, -14 removed lines patch added patch discarded remove patch

Braces +5 added lines, -10 removed lines patch added patch discarded remove patch