Standard::get() - Code Metrics - Inspection of "Return HTTP response codes instead of 500 if possi..." - aimeos/ai-client-jsonapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 270945...1cb1eb )

by Aimeos

created 2020-08-12 10:20 UTC

Standard::get() B

↳ Parent: Standard

Complexity

Conditions	6
Paths	17

Size

Total Lines	54
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
eloc	21
c	4
b	0
f	0
dl	0
loc	54
rs	8.9617
cc	6
nc	17
nop	2

How to fix Long Method

<?php

/**
 * @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
 * @copyright Aimeos (aimeos.org), 2017-2020
 * @package Client
 * @subpackage JsonApi
 */


namespace Aimeos\Client\JsonApi\Stock;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;


/**
 * JSON API standard client
 *
 * @package Client
 * @subpackage JsonApi
 */
class Standard
	extends \Aimeos\Client\JsonApi\Base
	implements \Aimeos\Client\JsonApi\Iface
{
	/**
	 * Returns the resource or the resource list
	 *
	 * @param \Psr\Http\Message\ServerRequestInterface $request Request object
	 * @param \Psr\Http\Message\ResponseInterface $response Response object
	 * @return \Psr\Http\Message\ResponseInterface Modified response object
	 */
	public function get( ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface
	{
		$view = $this->getView();

		try
		{
			if( $view->param( 'id' ) != '' ) {
				$response = $this->getItem( $view, $request, $response );
			} else {
				$response = $this->getItems( $view, $request, $response );
			}

			$status = 200;
		}
		catch( \Aimeos\MShop\Exception $e )
		{
			$status = 404;
			$view->errors = $this->getErrorDetails( $e, 'mshop' );
		}
		catch( \Exception $e )
		{
			$status = $e->getCode() >= 100 && $e->getCode() < 600 ? $e->getCode() : 500;
			$view->errors = $this->getErrorDetails( $e );
		}

		/** client/jsonapi/stock/standard/template
		 * Relative path to the catalog lists JSON API template
		 *
		 * The template file contains the code and processing instructions
		 * to generate the result shown in the JSON API body. The
		 * configuration string is the path to the template file relative
		 * to the templates directory (usually in client/jsonapi/templates).
		 *
		 * You can overwrite the template file configuration in extensions and
		 * provide alternative templates. These alternative templates should be
		 * named like the default one but with the string "default" replaced by
		 * an unique name. You may use the name of your project for this. If
		 * you've implemented an alternative client class as well, "standard"
		 * should be replaced by the name of the new class.
		 *
		 * @param string Relative path to the template creating the body for the GET method of the JSON API
		 * @since 2017.03
		 * @category Developer
		 */
		$tplconf = 'client/jsonapi/stock/standard/template';
		$default = 'stock/standard';

		$body = $view->render( $view->config( $tplconf, $default ) );

		return $response->withHeader( 'Allow', 'GET,OPTIONS' )
			->withHeader( 'Cache-Control', 'no-cache, private' )
			->withHeader( 'Content-Type', 'application/vnd.api+json' )
			->withBody( $view->response()->createStreamFromString( $body ) )
			->withStatus( $status );
	}


	/**
	 * Returns the available REST verbs and the available parameters
	 *
	 * @param \Psr\Http\Message\ServerRequestInterface $request Request object
	 * @param \Psr\Http\Message\ResponseInterface $response Response object
	 * @return \Psr\Http\Message\ResponseInterface Modified response object
	 */
	public function options( ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface
	{
		$view = $this->getView();

		$view->filter = [
			's_prodcode' => [
				'label' => 'List of product codes for which the stock level should be returned',
				'type' => 'array', 'default' => '[]', 'required' => false,
			],
			's_typecode' => [
				'label' => 'List of warehouse/location codes (stock type)',
				'type' => 'array', 'default' => '[]', 'required' => false,
			],
		];

		$tplconf = 'client/jsonapi/standard/template-options';
		$default = 'options-standard';

		$body = $view->render( $view->config( $tplconf, $default ) );

		return $response->withHeader( 'Allow', 'GET,OPTIONS' )
			->withHeader( 'Cache-Control', 'max-age=300' )
			->withHeader( 'Content-Type', 'application/vnd.api+json' )
			->withBody( $view->response()->createStreamFromString( $body ) )
			->withStatus( 200 );
	}


	/**
	 * Retrieves the item and adds the data to the view
	 *
	 * @param \Aimeos\MW\View\Iface $view View instance
	 * @param \Psr\Http\Message\ServerRequestInterface $request Request object
	 * @param \Psr\Http\Message\ResponseInterface $response Response object
	 * @return \Psr\Http\Message\ResponseInterface Modified response object
	 */
	protected function getItem( \Aimeos\MW\View\Iface $view, ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface
	{
		$view->items = \Aimeos\Controller\Frontend::create( $this->getContext(), 'stock' )->get( $view->param( 'id' ) );
		$view->total = 1;

		return $response;
	}


	/**
	 * Retrieves the items and adds the data to the view
	 *
	 * @param \Aimeos\MW\View\Iface $view View instance
	 * @param \Psr\Http\Message\ServerRequestInterface $request Request object
	 * @param \Psr\Http\Message\ResponseInterface $response Response object
	 * @return \Psr\Http\Message\ResponseInterface Modified response object
	 */
	protected function getItems( \Aimeos\MW\View\Iface $view, ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface
	{
		$total = 0;
		$params = $view->param( 'filter', [] );
		unset( $params['s_prodcode'], $params['s_typecode'] );

		$items = \Aimeos\Controller\Frontend::create( $this->getContext(), 'stock' )
			->code( $view->param( 'filter/s_prodcode' ) )->type( $view->param( 'filter/s_typecode' ) )
			->slice( $view->param( 'page/offset', 0 ), $view->param( 'page/limit', 100 ) )
			->sort( $view->param( 'sort' ) )->parse( $params )
			->search( $total );

		$view->items = $items;
		$view->total = $total;

		return $response;
	}
}


1			<?php
2
3			/**
4			* @license LGPLv3, http://opensource.org/licenses/LGPL-3.0
5			* @copyright Aimeos (aimeos.org), 2017-2020
6			* @package Client
7			* @subpackage JsonApi
8			*/
9
10
11			namespace Aimeos\Client\JsonApi\Stock;
12
13			use Psr\Http\Message\ResponseInterface;
14			use Psr\Http\Message\ServerRequestInterface;
15
16
17			/**
18			* JSON API standard client
19			*
20			* @package Client
21			* @subpackage JsonApi
22			*/
23			class Standard
24			extends \Aimeos\Client\JsonApi\Base
25			implements \Aimeos\Client\JsonApi\Iface
26			{
27			/**
28			* Returns the resource or the resource list
29			*
30			* @param \Psr\Http\Message\ServerRequestInterface $request Request object
31			* @param \Psr\Http\Message\ResponseInterface $response Response object
32			* @return \Psr\Http\Message\ResponseInterface Modified response object
33			*/
34			public function get( ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface
35			{
36			$view = $this->getView();
37
38			try
39			{
40			if( $view->param( 'id' ) != '' ) {
41			$response = $this->getItem( $view, $request, $response );
42			} else {
43			$response = $this->getItems( $view, $request, $response );
44			}
45
46			$status = 200;
47			}
48			catch( \Aimeos\MShop\Exception $e )
49			{
50			$status = 404;
51			$view->errors = $this->getErrorDetails( $e, 'mshop' );
52			}
53			catch( \Exception $e )
54			{
55			$status = $e->getCode() >= 100 && $e->getCode() < 600 ? $e->getCode() : 500;
56			$view->errors = $this->getErrorDetails( $e );
57			}
58
59			/** client/jsonapi/stock/standard/template
60			* Relative path to the catalog lists JSON API template
61			*
62			* The template file contains the code and processing instructions
63			* to generate the result shown in the JSON API body. The
64			* configuration string is the path to the template file relative
65			* to the templates directory (usually in client/jsonapi/templates).
66			*
67			* You can overwrite the template file configuration in extensions and
68			* provide alternative templates. These alternative templates should be
69			* named like the default one but with the string "default" replaced by
70			* an unique name. You may use the name of your project for this. If
71			* you've implemented an alternative client class as well, "standard"
72			* should be replaced by the name of the new class.
73			*
74			* @param string Relative path to the template creating the body for the GET method of the JSON API
75			* @since 2017.03
76			* @category Developer
77			*/
78			$tplconf = 'client/jsonapi/stock/standard/template';
79			$default = 'stock/standard';
80
81			$body = $view->render( $view->config( $tplconf, $default ) );
82
83			return $response->withHeader( 'Allow', 'GET,OPTIONS' )
84			->withHeader( 'Cache-Control', 'no-cache, private' )
85			->withHeader( 'Content-Type', 'application/vnd.api+json' )
86			->withBody( $view->response()->createStreamFromString( $body ) )
87			->withStatus( $status );
88			}
89
90
91			/**
92			* Returns the available REST verbs and the available parameters
93			*
94			* @param \Psr\Http\Message\ServerRequestInterface $request Request object
95			* @param \Psr\Http\Message\ResponseInterface $response Response object
96			* @return \Psr\Http\Message\ResponseInterface Modified response object
97			*/
98			public function options( ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface
99			{
100			$view = $this->getView();
101
102			$view->filter = [
103			's_prodcode' => [
104			'label' => 'List of product codes for which the stock level should be returned',
105			'type' => 'array', 'default' => '[]', 'required' => false,
106			],
107			's_typecode' => [
108			'label' => 'List of warehouse/location codes (stock type)',
109			'type' => 'array', 'default' => '[]', 'required' => false,
110			],
111			];
112
113			$tplconf = 'client/jsonapi/standard/template-options';
114			$default = 'options-standard';
115
116			$body = $view->render( $view->config( $tplconf, $default ) );
117
118			return $response->withHeader( 'Allow', 'GET,OPTIONS' )
119			->withHeader( 'Cache-Control', 'max-age=300' )
120			->withHeader( 'Content-Type', 'application/vnd.api+json' )
121			->withBody( $view->response()->createStreamFromString( $body ) )
122			->withStatus( 200 );
123			}
124
125
126			/**
127			* Retrieves the item and adds the data to the view
128			*
129			* @param \Aimeos\MW\View\Iface $view View instance
130			* @param \Psr\Http\Message\ServerRequestInterface $request Request object
131			* @param \Psr\Http\Message\ResponseInterface $response Response object
132			* @return \Psr\Http\Message\ResponseInterface Modified response object
133			*/
134			protected function getItem( \Aimeos\MW\View\Iface $view, ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface
135			{
136			$view->items = \Aimeos\Controller\Frontend::create( $this->getContext(), 'stock' )->get( $view->param( 'id' ) );
137			$view->total = 1;
138
139			return $response;
140			}
141
142
143			/**
144			* Retrieves the items and adds the data to the view
145			*
146			* @param \Aimeos\MW\View\Iface $view View instance
147			* @param \Psr\Http\Message\ServerRequestInterface $request Request object
148			* @param \Psr\Http\Message\ResponseInterface $response Response object
149			* @return \Psr\Http\Message\ResponseInterface Modified response object
150			*/
151			protected function getItems( \Aimeos\MW\View\Iface $view, ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface
152			{
153			$total = 0;
154			$params = $view->param( 'filter', [] );
155			unset( $params['s_prodcode'], $params['s_typecode'] );
156
157			$items = \Aimeos\Controller\Frontend::create( $this->getContext(), 'stock' )
158			->code( $view->param( 'filter/s_prodcode' ) )->type( $view->param( 'filter/s_typecode' ) )
159			->slice( $view->param( 'page/offset', 0 ), $view->param( 'page/limit', 100 ) )
160			->sort( $view->param( 'sort' ) )->parse( $params )
161			->search( $total );
162
163			$view->items = $items;
164			$view->total = $total;
165
166			return $response;
167			}
168			}
169

aimeos / ai-client-jsonapi

Push — master ( 270945...1cb1eb )

Standard::get() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like