aimeos /
ai-client-jsonapi
| Total Complexity | 43 |
| Total Lines | 399 |
| Duplicated Lines | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 1 |
Complex classes like Standard often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Standard, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class Standard |
||
| 24 | extends \Aimeos\Client\JsonApi\Basket\Base |
||
| 25 | implements \Aimeos\Client\JsonApi\Iface |
||
| 26 | { |
||
| 27 | /** client/jsonapi/basket/service/name |
||
| 28 | * Class name of the used basket/service client implementation |
||
| 29 | * |
||
| 30 | * Each default JSON API client can be replace by an alternative imlementation. |
||
| 31 | * To use this implementation, you have to set the last part of the class |
||
| 32 | * name as configuration value so the client factory knows which class it |
||
| 33 | * has to instantiate. |
||
| 34 | * |
||
| 35 | * For example, if the name of the default class is |
||
| 36 | * |
||
| 37 | * \Aimeos\Client\JsonApi\Basket\Service\Standard |
||
| 38 | * |
||
| 39 | * and you want to replace it with your own version named |
||
| 40 | * |
||
| 41 | * \Aimeos\Client\JsonApi\Basket\Service\Mybasket/service |
||
| 42 | * |
||
| 43 | * then you have to set the this configuration option: |
||
| 44 | * |
||
| 45 | * client/jsonapi/basket/service/name = Mybasket/service |
||
| 46 | * |
||
| 47 | * The value is the last part of your own class name and it's case sensitive, |
||
| 48 | * so take care that the configuration value is exactly named like the last |
||
| 49 | * part of the class name. |
||
| 50 | * |
||
| 51 | * The allowed characters of the class name are A-Z, a-z and 0-9. No other |
||
| 52 | * characters are possible! You should always start the last part of the class |
||
| 53 | * name with an upper case character and continue only with lower case characters |
||
| 54 | * or numbers. Avoid chamel case names like "MyService"! |
||
| 55 | * |
||
| 56 | * @param string Last part of the class name |
||
| 57 | * @since 2017.03 |
||
| 58 | * @category Developer |
||
| 59 | */ |
||
| 60 | |||
| 61 | /** client/jsonapi/basket/service/decorators/excludes |
||
| 62 | * Excludes decorators added by the "common" option from the JSON API clients |
||
| 63 | * |
||
| 64 | * Decorators extend the functionality of a class by adding new aspects |
||
| 65 | * (e.g. log what is currently done), executing the methods of the underlying |
||
| 66 | * class only in certain conditions (e.g. only for logged in users) or |
||
| 67 | * modify what is returned to the caller. |
||
| 68 | * |
||
| 69 | * This option allows you to remove a decorator added via |
||
| 70 | * "client/jsonapi/common/decorators/default" before they are wrapped |
||
| 71 | * around the JsonApi client. |
||
| 72 | * |
||
| 73 | * client/jsonapi/decorators/excludes = array( 'decorator1' ) |
||
| 74 | * |
||
| 75 | * This would remove the decorator named "decorator1" from the list of |
||
| 76 | * common decorators ("\Aimeos\Client\JsonApi\Common\Decorator\*") added via |
||
| 77 | * "client/jsonapi/common/decorators/default" for the JSON API client. |
||
| 78 | * |
||
| 79 | * @param array List of decorator names |
||
| 80 | * @since 2017.07 |
||
| 81 | * @category Developer |
||
| 82 | * @see client/jsonapi/common/decorators/default |
||
| 83 | * @see client/jsonapi/basket/service/decorators/global |
||
| 84 | * @see client/jsonapi/basket/service/decorators/local |
||
| 85 | */ |
||
| 86 | |||
| 87 | /** client/jsonapi/basket/service/decorators/global |
||
| 88 | * Adds a list of globally available decorators only to the JsonApi client |
||
| 89 | * |
||
| 90 | * Decorators extend the functionality of a class by adding new aspects |
||
| 91 | * (e.g. log what is currently done), executing the methods of the underlying |
||
| 92 | * class only in certain conditions (e.g. only for logged in users) or |
||
| 93 | * modify what is returned to the caller. |
||
| 94 | * |
||
| 95 | * This option allows you to wrap global decorators |
||
| 96 | * ("\Aimeos\Client\JsonApi\Common\Decorator\*") around the JsonApi |
||
| 97 | * client. |
||
| 98 | * |
||
| 99 | * client/jsonapi/basket/service/decorators/global = array( 'decorator1' ) |
||
| 100 | * |
||
| 101 | * This would add the decorator named "decorator1" defined by |
||
| 102 | * "\Aimeos\Client\JsonApi\Common\Decorator\Decorator1" only to the |
||
| 103 | * "basket" JsonApi client. |
||
| 104 | * |
||
| 105 | * @param array List of decorator names |
||
| 106 | * @since 2017.07 |
||
| 107 | * @category Developer |
||
| 108 | * @see client/jsonapi/common/decorators/default |
||
| 109 | * @see client/jsonapi/basket/service/decorators/excludes |
||
| 110 | * @see client/jsonapi/basket/service/decorators/local |
||
| 111 | */ |
||
| 112 | |||
| 113 | /** client/jsonapi/basket/service/decorators/local |
||
| 114 | * Adds a list of local decorators only to the JsonApi client |
||
| 115 | * |
||
| 116 | * Decorators extend the functionality of a class by adding new aspects |
||
| 117 | * (e.g. log what is currently done), executing the methods of the underlying |
||
| 118 | * class only in certain conditions (e.g. only for logged in users) or |
||
| 119 | * modify what is returned to the caller. |
||
| 120 | * |
||
| 121 | * This option allows you to wrap local decorators |
||
| 122 | * ("\Aimeos\Client\JsonApi\Basket\Service\Decorator\*") around the JsonApi |
||
| 123 | * client. |
||
| 124 | * |
||
| 125 | * client/jsonapi/basket/service/decorators/local = array( 'decorator2' ) |
||
| 126 | * |
||
| 127 | * This would add the decorator named "decorator2" defined by |
||
| 128 | * "\Aimeos\Client\JsonApi\Basket\Service\Decorator\Decorator2" only to the |
||
| 129 | * "basket service" JsonApi client. |
||
| 130 | * |
||
| 131 | * @param array List of decorator names |
||
| 132 | * @since 2017.07 |
||
| 133 | * @category Developer |
||
| 134 | * @see client/jsonapi/common/decorators/default |
||
| 135 | * @see client/jsonapi/basket/service/decorators/excludes |
||
| 136 | * @see client/jsonapi/basket/service/decorators/global |
||
| 137 | */ |
||
| 138 | |||
| 139 | |||
| 140 | private \Aimeos\Controller\Frontend\Basket\Iface $controller; |
||
| 141 | |||
| 142 | |||
| 143 | /** |
||
| 144 | * Initializes the client |
||
| 145 | * |
||
| 146 | * @param \Aimeos\MShop\ContextIface $context MShop context object |
||
| 147 | */ |
||
| 148 | public function __construct( \Aimeos\MShop\ContextIface $context ) |
||
| 153 | } |
||
| 154 | |||
| 155 | |||
| 156 | /** |
||
| 157 | * Deletes the resource or the resource list |
||
| 158 | * |
||
| 159 | * @param \Psr\Http\Message\ServerRequestInterface $request Request object |
||
| 160 | * @param \Psr\Http\Message\ResponseInterface $response Response object |
||
| 161 | * @return \Psr\Http\Message\ResponseInterface Modified response object |
||
| 162 | */ |
||
| 163 | public function delete( ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface |
||
| 164 | { |
||
| 165 | $view = $this->view(); |
||
| 166 | |||
| 167 | try |
||
| 168 | { |
||
| 169 | $this->clearCache(); |
||
| 170 | $this->controller->setType( $view->param( 'id', 'default' ) ); |
||
| 171 | |||
| 172 | $relId = $view->param( 'relatedid' ); |
||
| 173 | $body = (string) $request->getBody(); |
||
| 174 | |||
| 175 | if( $relId === '' || $relId === null ) |
||
| 176 | { |
||
| 177 | if( ( $payload = json_decode( $body ) ) === null || !isset( $payload->data ) ) { |
||
| 178 | throw new \Aimeos\Client\JsonApi\Exception( 'Invalid JSON in body', 400 ); |
||
| 179 | } |
||
| 180 | |||
| 181 | if( !is_array( $payload->data ) ) { |
||
| 182 | $payload->data = [$payload->data]; |
||
| 183 | } |
||
| 184 | |||
| 185 | foreach( $payload->data as $entry ) |
||
| 186 | { |
||
| 187 | if( !isset( $entry->id ) ) { |
||
| 188 | throw new \Aimeos\Client\JsonApi\Exception( 'Type (ID) is missing', 400 ); |
||
| 189 | } |
||
| 190 | |||
| 191 | $this->controller->deleteService( $entry->id ); |
||
| 192 | } |
||
| 193 | } |
||
| 194 | else |
||
| 195 | { |
||
| 196 | $this->controller->deleteService( $relId ); |
||
| 197 | } |
||
| 198 | |||
| 199 | |||
| 200 | $view->item = $this->controller->get(); |
||
| 201 | $status = 200; |
||
| 202 | } |
||
| 203 | catch( \Aimeos\MShop\Plugin\Provider\Exception $e ) |
||
| 204 | { |
||
| 205 | $status = 409; |
||
| 206 | $view->errors = $this->getErrorDetails( $e, 'mshop' ); |
||
| 207 | } |
||
| 208 | catch( \Aimeos\MShop\Exception $e ) |
||
| 209 | { |
||
| 210 | $status = 404; |
||
| 211 | $view->errors = $this->getErrorDetails( $e, 'mshop' ); |
||
| 212 | } |
||
| 213 | catch( \Exception $e ) |
||
| 214 | { |
||
| 215 | $status = $e->getCode() >= 100 && $e->getCode() < 600 ? $e->getCode() : 500; |
||
| 216 | $view->errors = $this->getErrorDetails( $e ); |
||
| 217 | } |
||
| 218 | |||
| 219 | return $this->render( $response, $view, $status ); |
||
| 220 | } |
||
| 221 | |||
| 222 | |||
| 223 | /** |
||
| 224 | * Updates the resource or the resource list partitially |
||
| 225 | * |
||
| 226 | * @param \Psr\Http\Message\ServerRequestInterface $request Request object |
||
| 227 | * @param \Psr\Http\Message\ResponseInterface $response Response object |
||
| 228 | * @return \Psr\Http\Message\ResponseInterface Modified response object |
||
| 229 | */ |
||
| 230 | public function patch( ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface |
||
| 231 | { |
||
| 232 | $view = $this->view(); |
||
| 233 | |||
| 234 | try |
||
| 235 | { |
||
| 236 | $this->clearCache(); |
||
| 237 | $this->controller->setType( $view->param( 'id', 'default' ) ); |
||
| 238 | |||
| 239 | $body = (string) $request->getBody(); |
||
| 240 | |||
| 241 | if( ( $payload = json_decode( $body ) ) === null || !isset( $payload->data ) ) { |
||
| 242 | throw new \Aimeos\Client\JsonApi\Exception( 'Invalid JSON in body', 400 ); |
||
| 243 | } |
||
| 244 | |||
| 245 | if( !is_array( $payload->data ) ) { |
||
| 246 | $payload->data = [$payload->data]; |
||
| 247 | } |
||
| 248 | |||
| 249 | $cntl = \Aimeos\Controller\Frontend::create( $this->context(), 'service' ); |
||
| 250 | |||
| 251 | if( $type = $view->param( 'relatedid' ) ) { |
||
| 252 | $this->controller->deleteService( $type ); |
||
| 253 | } |
||
| 254 | |||
| 255 | foreach( $payload->data as $pos => $entry ) |
||
| 256 | { |
||
| 257 | if( !isset( $entry->id ) ) { |
||
| 258 | throw new \Aimeos\Client\JsonApi\Exception( 'Service type (ID) is missing', 400 ); |
||
| 259 | } |
||
| 260 | |||
| 261 | if( !isset( $entry->attributes ) ) { |
||
| 262 | throw new \Aimeos\Client\JsonApi\Exception( 'Service attributes are missing', 400 ); |
||
| 263 | } |
||
| 264 | |||
| 265 | if( !isset( $entry->attributes->{'service.id'} ) ) { |
||
| 266 | throw new \Aimeos\Client\JsonApi\Exception( 'Service ID in attributes is missing', 400 ); |
||
| 267 | } |
||
| 268 | |||
| 269 | $item = $cntl->uses( ['media', 'price', 'text'] )->get( $entry->attributes->{'service.id'} ); |
||
| 270 | unset( $entry->attributes->{'service.id'} ); |
||
| 271 | |||
| 272 | $this->controller->addService( $item, (array) $entry->attributes, $pos ); |
||
| 273 | } |
||
| 274 | |||
| 275 | |||
| 276 | $view->item = $this->controller->get(); |
||
| 277 | $status = 200; |
||
| 278 | } |
||
| 279 | catch( \Aimeos\MShop\Plugin\Provider\Exception $e ) |
||
| 280 | { |
||
| 281 | $status = 409; |
||
| 282 | $view->errors = $this->getErrorDetails( $e, 'mshop' ); |
||
| 283 | } |
||
| 284 | catch( \Aimeos\MShop\Exception $e ) |
||
| 285 | { |
||
| 286 | $status = 404; |
||
| 287 | $view->errors = $this->getErrorDetails( $e, 'mshop' ); |
||
| 288 | } |
||
| 289 | catch( \Exception $e ) |
||
| 290 | { |
||
| 291 | $status = $e->getCode() >= 100 && $e->getCode() < 600 ? $e->getCode() : 500; |
||
| 292 | $view->errors = $this->getErrorDetails( $e ); |
||
| 293 | } |
||
| 294 | |||
| 295 | return $this->render( $response, $view, $status ); |
||
| 296 | } |
||
| 297 | |||
| 298 | |||
| 299 | /** |
||
| 300 | * Creates or updates the resource or the resource list |
||
| 301 | * |
||
| 302 | * @param \Psr\Http\Message\ServerRequestInterface $request Request object |
||
| 303 | * @param \Psr\Http\Message\ResponseInterface $response Response object |
||
| 304 | * @return \Psr\Http\Message\ResponseInterface Modified response object |
||
| 305 | */ |
||
| 306 | public function post( ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface |
||
| 307 | { |
||
| 308 | $view = $this->view(); |
||
| 309 | |||
| 310 | try |
||
| 311 | { |
||
| 312 | $this->clearCache(); |
||
| 313 | $this->controller->setType( $view->param( 'id', 'default' ) ); |
||
| 314 | |||
| 315 | $body = (string) $request->getBody(); |
||
| 316 | |||
| 317 | if( ( $payload = json_decode( $body ) ) === null || !isset( $payload->data ) ) { |
||
| 318 | throw new \Aimeos\Client\JsonApi\Exception( 'Invalid JSON in body', 400 ); |
||
| 319 | } |
||
| 320 | |||
| 321 | if( !is_array( $payload->data ) ) { |
||
| 322 | $payload->data = [$payload->data]; |
||
| 323 | } |
||
| 324 | |||
| 325 | $cntl = \Aimeos\Controller\Frontend::create( $this->context(), 'service' ); |
||
| 326 | |||
| 327 | foreach( $payload->data as $entry ) |
||
| 328 | { |
||
| 329 | if( !isset( $entry->id ) ) { |
||
| 330 | throw new \Aimeos\Client\JsonApi\Exception( 'Service type (ID) is missing', 400 ); |
||
| 331 | } |
||
| 332 | |||
| 333 | if( !isset( $entry->attributes ) ) { |
||
| 334 | throw new \Aimeos\Client\JsonApi\Exception( 'Service attributes are missing', 400 ); |
||
| 335 | } |
||
| 336 | |||
| 337 | if( !isset( $entry->attributes->{'service.id'} ) ) { |
||
| 338 | throw new \Aimeos\Client\JsonApi\Exception( 'Service ID in attributes is missing', 400 ); |
||
| 339 | } |
||
| 340 | |||
| 341 | $item = $cntl->uses( ['media', 'price', 'text'] )->get( $entry->attributes->{'service.id'} ); |
||
| 342 | unset( $entry->attributes->{'service.id'} ); |
||
| 343 | |||
| 344 | $this->controller->addService( $item, (array) $entry->attributes ); |
||
| 345 | } |
||
| 346 | |||
| 347 | |||
| 348 | $view->item = $this->controller->get(); |
||
| 349 | $status = 201; |
||
| 350 | } |
||
| 351 | catch( \Aimeos\MShop\Plugin\Provider\Exception $e ) |
||
| 352 | { |
||
| 353 | $status = 409; |
||
| 354 | $view->errors = $this->getErrorDetails( $e, 'mshop' ); |
||
| 355 | } |
||
| 356 | catch( \Aimeos\MShop\Exception $e ) |
||
| 357 | { |
||
| 358 | $status = 404; |
||
| 359 | $view->errors = $this->getErrorDetails( $e, 'mshop' ); |
||
| 360 | } |
||
| 361 | catch( \Exception $e ) |
||
| 362 | { |
||
| 363 | $status = $e->getCode() >= 100 && $e->getCode() < 600 ? $e->getCode() : 500; |
||
| 364 | $view->errors = $this->getErrorDetails( $e ); |
||
| 365 | } |
||
| 366 | |||
| 367 | return $this->render( $response, $view, $status ); |
||
| 368 | } |
||
| 369 | |||
| 370 | |||
| 371 | /** |
||
| 372 | * Returns the available REST verbs and the available parameters |
||
| 373 | * |
||
| 374 | * @param \Psr\Http\Message\ServerRequestInterface $request Request object |
||
| 375 | * @param \Psr\Http\Message\ResponseInterface $response Response object |
||
| 376 | * @return \Psr\Http\Message\ResponseInterface Modified response object |
||
| 377 | */ |
||
| 378 | public function options( ServerRequestInterface $request, ResponseInterface $response ) : \Psr\Http\Message\ResponseInterface |
||
| 399 | } |
||
| 400 | |||
| 401 | |||
| 402 | /** |
||
| 403 | * Returns the response object with the rendered header and body |
||
| 404 | * |
||
| 405 | * @param \Psr\Http\Message\ResponseInterface $response Response object |
||
| 406 | * @param \Aimeos\Base\View\Iface $view View instance |
||
| 407 | * @param int $status HTTP status code |
||
| 408 | * @return \Psr\Http\Message\ResponseInterface Modified response object |
||
| 409 | */ |
||
| 410 | protected function render( ResponseInterface $response, \Aimeos\Base\View\Iface $view, int $status ) : \Psr\Http\Message\ResponseInterface |
||
| 422 | } |
||
| 423 | } |
||
| 424 |
Loading history...