Inspection of "Changes for moving stock to own domain" - aimeos/ai-admin-jsonadm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 786415...fa87fb )

by Aimeos

created 2016-12-11 15:26 UTC

Status

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
 		$templatePaths = \TestHelperJadm::getJsonadmPaths();
 		$this->view = $this->context->getView();
 
-		$this->object = new \Aimeos\Admin\JsonAdm\Coupon\Standard( $this->context, $this->view, $templatePaths, 'coupon' );
+		$this->object = new \Aimeos\Admin\JsonAdm\Coupon\Standard($this->context, $this->view, $templatePaths, 'coupon');
 	}
 
 
@@ -30,26 +30,26 @@  discard block
 block discarded – undo
 	{
 		$params = array(
 			'filter' => array(
-				'==' => array( 'coupon.code.code' => '90AB' )
+				'==' => array('coupon.code.code' => '90AB')
 			),
 			'include' => 'coupon/code'
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
 		$header = array();
 		$status = 500;
 
-		$result = json_decode( $this->object->get( '', $header, $status ), true );
+		$result = json_decode($this->object->get('', $header, $status), true);
 
-		$this->assertEquals( 200, $status );
-		$this->assertEquals( 1, count( $header ) );
-		$this->assertEquals( 1, $result['meta']['total'] );
-		$this->assertEquals( 1, count( $result['data'] ) );
-		$this->assertEquals( 'coupon', $result['data'][0]['type'] );
-		$this->assertEquals( 1, count( $result['data'][0]['relationships']['coupon/code'] ) );
-		$this->assertEquals( 1, count( $result['included'] ) );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$this->assertEquals(200, $status);
+		$this->assertEquals(1, count($header));
+		$this->assertEquals(1, $result['meta']['total']);
+		$this->assertEquals(1, count($result['data']));
+		$this->assertEquals('coupon', $result['data'][0]['type']);
+		$this->assertEquals(1, count($result['data'][0]['relationships']['coupon/code']));
+		$this->assertEquals(1, count($result['included']));
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 
 
@@ -62,22 +62,22 @@  discard block
 block discarded – undo
 			'sort' => 'coupon.id',
 			'include' => 'coupon/code'
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
 		$header = array();
 		$status = 500;
 
-		$result = json_decode( $this->object->get( '', $header, $status ), true );
-
-		$this->assertEquals( 200, $status );
-		$this->assertEquals( 1, count( $header ) );
-		$this->assertEquals( 5, $result['meta']['total'] );
-		$this->assertEquals( 5, count( $result['data'] ) );
-		$this->assertEquals( 'coupon', $result['data'][0]['type'] );
-		$this->assertEquals( 2, count( $result['data'][0]['attributes'] ) );
-		$this->assertEquals( 1, count( $result['data'][0]['relationships']['coupon/code'] ) );
-		$this->assertEquals( 5, count( $result['included'] ) );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$result = json_decode($this->object->get('', $header, $status), true);
+
+		$this->assertEquals(200, $status);
+		$this->assertEquals(1, count($header));
+		$this->assertEquals(5, $result['meta']['total']);
+		$this->assertEquals(5, count($result['data']));
+		$this->assertEquals('coupon', $result['data'][0]['type']);
+		$this->assertEquals(2, count($result['data'][0]['attributes']));
+		$this->assertEquals(1, count($result['data'][0]['relationships']['coupon/code']));
+		$this->assertEquals(5, count($result['included']));
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

admin/jsonadm/tests/Admin/JsonAdm/Supplier/StandardTest.php 1 patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
 		$templatePaths = \TestHelperJadm::getJsonadmPaths();
 		$this->view = $this->context->getView();
 
-		$this->object = new \Aimeos\Admin\JsonAdm\Supplier\Standard( $this->context, $this->view, $templatePaths, 'supplier' );
+		$this->object = new \Aimeos\Admin\JsonAdm\Supplier\Standard($this->context, $this->view, $templatePaths, 'supplier');
 	}
 
 
@@ -30,27 +30,27 @@  discard block
 block discarded – undo
 	{
 		$params = array(
 			'filter' => array(
-				'==' => array( 'supplier.code' => 'unitCode001' )
+				'==' => array('supplier.code' => 'unitCode001')
 			),
 			'include' => 'text,supplier/address'
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
 		$header = array();
 		$status = 500;
 
-		$result = json_decode( $this->object->get( '', $header, $status ), true );
-
-		$this->assertEquals( 200, $status );
-		$this->assertEquals( 1, count( $header ) );
-		$this->assertEquals( 1, $result['meta']['total'] );
-		$this->assertEquals( 1, count( $result['data'] ) );
-		$this->assertEquals( 'supplier', $result['data'][0]['type'] );
-		$this->assertEquals( 3, count( $result['data'][0]['relationships']['text'] ) );
-		$this->assertEquals( 1, count( $result['data'][0]['relationships']['supplier/address'] ) );
-		$this->assertEquals( 4, count( $result['included'] ) );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$result = json_decode($this->object->get('', $header, $status), true);
+
+		$this->assertEquals(200, $status);
+		$this->assertEquals(1, count($header));
+		$this->assertEquals(1, $result['meta']['total']);
+		$this->assertEquals(1, count($result['data']));
+		$this->assertEquals('supplier', $result['data'][0]['type']);
+		$this->assertEquals(3, count($result['data'][0]['relationships']['text']));
+		$this->assertEquals(1, count($result['data'][0]['relationships']['supplier/address']));
+		$this->assertEquals(4, count($result['included']));
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 
 
@@ -63,22 +63,22 @@  discard block
 block discarded – undo
 			'sort' => 'supplier.id',
 			'include' => 'supplier/address'
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
 		$header = array();
 		$status = 500;
 
-		$result = json_decode( $this->object->get( '', $header, $status ), true );
-
-		$this->assertEquals( 200, $status );
-		$this->assertEquals( 1, count( $header ) );
-		$this->assertEquals( 3, $result['meta']['total'] );
-		$this->assertEquals( 3, count( $result['data'] ) );
-		$this->assertEquals( 'supplier', $result['data'][0]['type'] );
-		$this->assertEquals( 2, count( $result['data'][0]['attributes'] ) );
-		$this->assertEquals( 1, count( $result['data'][0]['relationships']['supplier/address'] ) );
-		$this->assertEquals( 3, count( $result['included'] ) );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$result = json_decode($this->object->get('', $header, $status), true);
+
+		$this->assertEquals(200, $status);
+		$this->assertEquals(1, count($header));
+		$this->assertEquals(3, $result['meta']['total']);
+		$this->assertEquals(3, count($result['data']));
+		$this->assertEquals('supplier', $result['data'][0]['type']);
+		$this->assertEquals(2, count($result['data'][0]['attributes']));
+		$this->assertEquals(1, count($result['data'][0]['relationships']['supplier/address']));
+		$this->assertEquals(3, count($result['included']));
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

admin/jsonadm/tests/Admin/JsonAdm/Common/Decorator/BaseTest.php 1 patch

Spacing +32 added lines, -32 removed lines patch added patch discarded remove patch

@@ -20,17 +20,17 @@  discard block
 block discarded – undo
 		$context = \TestHelperJadm::getContext();
 		$view = $context->getView();
 
-		$this->stub = $this->getMockBuilder( '\\Aimeos\\Admin\\JsonAdm\\Standard' )
-			->setConstructorArgs( array( $context, $view, array(), 'attribute' ) )
+		$this->stub = $this->getMockBuilder('\\Aimeos\\Admin\\JsonAdm\\Standard')
+			->setConstructorArgs(array($context, $view, array(), 'attribute'))
 			->getMock();
 
-		$this->object = new TestBase( $this->stub, $context, $view, array(), 'attribute' );
+		$this->object = new TestBase($this->stub, $context, $view, array(), 'attribute');
 	}
 
 
 	protected function tearDown()
 	{
-		unset( $this->object, $this->stub );
+		unset($this->object, $this->stub);
 	}
 
 
@@ -39,11 +39,11 @@  discard block
 block discarded – undo
 		$status = 0;
 		$header = array();
 
-		$this->stub->expects( $this->once() )
-			->method( 'delete' )
-			->will( $this->returnValue( 'test' ) );
+		$this->stub->expects($this->once())
+			->method('delete')
+			->will($this->returnValue('test'));
 
-		$this->assertEquals( 'test', $this->object->delete( '', $header, $status ) );
+		$this->assertEquals('test', $this->object->delete('', $header, $status));
 	}
 
 
@@ -52,11 +52,11 @@  discard block
 block discarded – undo
 		$status = 0;
 		$header = array();
 
-		$this->stub->expects( $this->once() )
-			->method( 'get' )
-			->will( $this->returnValue( 'test' ) );
+		$this->stub->expects($this->once())
+			->method('get')
+			->will($this->returnValue('test'));
 
-		$this->assertEquals( 'test', $this->object->get( '', $header, $status ) );
+		$this->assertEquals('test', $this->object->get('', $header, $status));
 	}
 
 
@@ -65,11 +65,11 @@  discard block
 block discarded – undo
 		$status = 0;
 		$header = array();
 
-		$this->stub->expects( $this->once() )
-			->method( 'patch' )
-			->will( $this->returnValue( 'test' ) );
+		$this->stub->expects($this->once())
+			->method('patch')
+			->will($this->returnValue('test'));
 
-		$this->assertEquals( 'test', $this->object->patch( '', $header, $status ) );
+		$this->assertEquals('test', $this->object->patch('', $header, $status));
 	}
 
 
@@ -78,11 +78,11 @@  discard block
 block discarded – undo
 		$status = 0;
 		$header = array();
 
-		$this->stub->expects( $this->once() )
-			->method( 'post' )
-			->will( $this->returnValue( 'test' ) );
+		$this->stub->expects($this->once())
+			->method('post')
+			->will($this->returnValue('test'));
 
-		$this->assertEquals( 'test', $this->object->post( '', $header, $status ) );
+		$this->assertEquals('test', $this->object->post('', $header, $status));
 	}
 
 
@@ -91,11 +91,11 @@  discard block
 block discarded – undo
 		$status = 0;
 		$header = array();
 
-		$this->stub->expects( $this->once() )
-			->method( 'put' )
-			->will( $this->returnValue( 'test' ) );
+		$this->stub->expects($this->once())
+			->method('put')
+			->will($this->returnValue('test'));
 
-		$this->assertEquals( 'test', $this->object->put( '', $header, $status ) );
+		$this->assertEquals('test', $this->object->put('', $header, $status));
 	}
 
 
@@ -104,35 +104,35 @@  discard block
 block discarded – undo
 		$status = 0;
 		$header = array();
 
-		$this->stub->expects( $this->once() )
-			->method( 'options' )
-			->will( $this->returnValue( 'test' ) );
+		$this->stub->expects($this->once())
+			->method('options')
+			->will($this->returnValue('test'));
 
-		$this->assertEquals( 'test', $this->object->options( '', $header, $status ) );
+		$this->assertEquals('test', $this->object->options('', $header, $status));
 	}
 
 
 	public function testGetContext()
 	{
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Context\\Item\\Iface', $this->object->getContextPublic() );
+		$this->assertInstanceOf('\\Aimeos\\MShop\\Context\\Item\\Iface', $this->object->getContextPublic());
 	}
 
 
 	public function testGetTemplatePaths()
 	{
-		$this->assertEquals( array(), $this->object->getTemplatePathsPublic() );
+		$this->assertEquals(array(), $this->object->getTemplatePathsPublic());
 	}
 
 
 	public function testGetPath()
 	{
-		$this->assertEquals( 'attribute', $this->object->getPathPublic() );
+		$this->assertEquals('attribute', $this->object->getPathPublic());
 	}
 
 
 	public function testCall()
 	{
-		$this->markTestIncomplete( 'PHP warning is triggered instead of exception' );
+		$this->markTestIncomplete('PHP warning is triggered instead of exception');
 	}
 
 }

Please login to merge, or discard this patch.

admin/jsonadm/tests/Admin/JsonAdm/Order/Base/StandardTest.php 1 patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
 		$templatePaths = \TestHelperJadm::getJsonadmPaths();
 		$this->view = $this->context->getView();
 
-		$this->object = new \Aimeos\Admin\JsonAdm\Order\Base\Standard( $this->context, $this->view, $templatePaths, 'order/base' );
+		$this->object = new \Aimeos\Admin\JsonAdm\Order\Base\Standard($this->context, $this->view, $templatePaths, 'order/base');
 	}
 
 
@@ -30,27 +30,27 @@  discard block
 block discarded – undo
 	{
 		$params = array(
 			'filter' => array(
-				'==' => array( 'order.base.price' => '4800.00' )
+				'==' => array('order.base.price' => '4800.00')
 			),
 			'include' => 'order/base/address,order/base/product'
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
 		$header = array();
 		$status = 500;
 
-		$result = json_decode( $this->object->get( '', $header, $status ), true );
-
-		$this->assertEquals( 200, $status );
-		$this->assertEquals( 1, count( $header ) );
-		$this->assertEquals( 1, $result['meta']['total'] );
-		$this->assertEquals( 1, count( $result['data'] ) );
-		$this->assertEquals( 'order/base', $result['data'][0]['type'] );
-		$this->assertEquals( 1, count( $result['data'][0]['relationships']['order/base/address'] ) );
-		$this->assertEquals( 6, count( $result['data'][0]['relationships']['order/base/product'] ) );
-		$this->assertEquals( 7, count( $result['included'] ) );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$result = json_decode($this->object->get('', $header, $status), true);
+
+		$this->assertEquals(200, $status);
+		$this->assertEquals(1, count($header));
+		$this->assertEquals(1, $result['meta']['total']);
+		$this->assertEquals(1, count($result['data']));
+		$this->assertEquals('order/base', $result['data'][0]['type']);
+		$this->assertEquals(1, count($result['data'][0]['relationships']['order/base/address']));
+		$this->assertEquals(6, count($result['data'][0]['relationships']['order/base/product']));
+		$this->assertEquals(7, count($result['included']));
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 
 
@@ -63,22 +63,22 @@  discard block
 block discarded – undo
 			'sort' => 'order.base.id',
 			'include' => 'order/base/product'
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
 		$header = array();
 		$status = 500;
 
-		$result = json_decode( $this->object->get( '', $header, $status ), true );
-
-		$this->assertEquals( 200, $status );
-		$this->assertEquals( 1, count( $header ) );
-		$this->assertGreaterThanOrEqual( 4, $result['meta']['total'] );
-		$this->assertGreaterThanOrEqual( 4, count( $result['data'] ) );
-		$this->assertEquals( 'order/base', $result['data'][0]['type'] );
-		$this->assertEquals( 2, count( $result['data'][0]['attributes'] ) );
-		$this->assertGreaterThanOrEqual( 4, count( $result['data'][0]['relationships']['order/base/product'] ) );
-		$this->assertGreaterThanOrEqual( 14, count( $result['included'] ) );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$result = json_decode($this->object->get('', $header, $status), true);
+
+		$this->assertEquals(200, $status);
+		$this->assertEquals(1, count($header));
+		$this->assertGreaterThanOrEqual(4, $result['meta']['total']);
+		$this->assertGreaterThanOrEqual(4, count($result['data']));
+		$this->assertEquals('order/base', $result['data'][0]['type']);
+		$this->assertEquals(2, count($result['data'][0]['attributes']));
+		$this->assertGreaterThanOrEqual(4, count($result['data'][0]['relationships']['order/base/product']));
+		$this->assertGreaterThanOrEqual(14, count($result['included']));
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

admin/jsonadm/tests/Admin/JsonAdm/Text/StandardTest.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
 		$templatePaths = \TestHelperJadm::getJsonadmPaths();
 		$this->view = $this->context->getView();
 
-		$this->object = new \Aimeos\Admin\JsonAdm\Text\Standard( $this->context, $this->view, $templatePaths, 'text' );
+		$this->object = new \Aimeos\Admin\JsonAdm\Text\Standard($this->context, $this->view, $templatePaths, 'text');
 	}
 
 
@@ -30,25 +30,25 @@  discard block
 block discarded – undo
 	{
 		$params = array(
 			'filter' => array(
-				'==' => array( 'text.label' => 'misc_long_desc' )
+				'==' => array('text.label' => 'misc_long_desc')
 			),
 			'include' => 'media'
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
 		$header = array();
 		$status = 500;
 
-		$result = json_decode( $this->object->get( '', $header, $status ), true );
+		$result = json_decode($this->object->get('', $header, $status), true);
 
-		$this->assertEquals( 200, $status );
-		$this->assertEquals( 1, count( $header ) );
-		$this->assertEquals( 1, $result['meta']['total'] );
-		$this->assertEquals( 1, count( $result['data'] ) );
-		$this->assertEquals( 'text', $result['data'][0]['type'] );
-		$this->assertEquals( 4, count( $result['data'][0]['relationships']['media'] ) );
-		$this->assertEquals( 4, count( $result['included'] ) );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$this->assertEquals(200, $status);
+		$this->assertEquals(1, count($header));
+		$this->assertEquals(1, $result['meta']['total']);
+		$this->assertEquals(1, count($result['data']));
+		$this->assertEquals('text', $result['data'][0]['type']);
+		$this->assertEquals(4, count($result['data'][0]['relationships']['media']));
+		$this->assertEquals(4, count($result['included']));
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

admin/jsonadm/tests/Admin/JsonAdm/Price/StandardTest.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
 		$templatePaths = \TestHelperJadm::getJsonadmPaths();
 		$this->view = $this->context->getView();
 
-		$this->object = new \Aimeos\Admin\JsonAdm\Media\Standard( $this->context, $this->view, $templatePaths, 'price' );
+		$this->object = new \Aimeos\Admin\JsonAdm\Media\Standard($this->context, $this->view, $templatePaths, 'price');
 	}
 
 
@@ -30,25 +30,25 @@  discard block
 block discarded – undo
 	{
 		$params = array(
 			'filter' => array(
-				'==' => array( 'price.value' => '12.95' )
+				'==' => array('price.value' => '12.95')
 			),
 			'include' => 'attribute'
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
 		$header = array();
 		$status = 500;
 
-		$result = json_decode( $this->object->get( '', $header, $status ), true );
+		$result = json_decode($this->object->get('', $header, $status), true);
 
-		$this->assertEquals( 200, $status );
-		$this->assertEquals( 1, count( $header ) );
-		$this->assertEquals( 2, $result['meta']['total'] );
-		$this->assertEquals( 2, count( $result['data'] ) );
-		$this->assertEquals( 'price', $result['data'][0]['type'] );
-		$this->assertEquals( 0, count( $result['data'][0]['relationships'] ) );
-		$this->assertEquals( 0, count( $result['included'] ) );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$this->assertEquals(200, $status);
+		$this->assertEquals(1, count($header));
+		$this->assertEquals(2, $result['meta']['total']);
+		$this->assertEquals(2, count($result['data']));
+		$this->assertEquals('price', $result['data'][0]['type']);
+		$this->assertEquals(0, count($result['data'][0]['relationships']));
+		$this->assertEquals(0, count($result['included']));
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

admin/jsonadm/tests/Admin/JsonAdm/Attribute/StandardTest.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
 		$templatePaths = \TestHelperJadm::getJsonadmPaths();
 		$this->view = $this->context->getView();
 
-		$this->object = new \Aimeos\Admin\JsonAdm\Attribute\Standard( $this->context, $this->view, $templatePaths, 'attribute' );
+		$this->object = new \Aimeos\Admin\JsonAdm\Attribute\Standard($this->context, $this->view, $templatePaths, 'attribute');
 	}
 
 
@@ -30,25 +30,25 @@  discard block
 block discarded – undo
 	{
 		$params = array(
 			'filter' => array(
-				'==' => array( 'attribute.code' => 's' )
+				'==' => array('attribute.code' => 's')
 			),
 			'include' => 'text'
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
 		$header = array();
 		$status = 500;
 
-		$result = json_decode( $this->object->get( '', $header, $status ), true );
+		$result = json_decode($this->object->get('', $header, $status), true);
 
-		$this->assertEquals( 200, $status );
-		$this->assertEquals( 1, count( $header ) );
-		$this->assertEquals( 1, $result['meta']['total'] );
-		$this->assertEquals( 1, count( $result['data'] ) );
-		$this->assertEquals( 'attribute', $result['data'][0]['type'] );
-		$this->assertEquals( 1, count( $result['data'][0]['relationships']['text'] ) );
-		$this->assertEquals( 1, count( $result['included'] ) );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$this->assertEquals(200, $status);
+		$this->assertEquals(1, count($header));
+		$this->assertEquals(1, $result['meta']['total']);
+		$this->assertEquals(1, count($result['data']));
+		$this->assertEquals('attribute', $result['data'][0]['type']);
+		$this->assertEquals(1, count($result['data'][0]['relationships']['text']));
+		$this->assertEquals(1, count($result['included']));
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

admin/jsonadm/tests/Admin/JsonAdm/Service/StandardTest.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
 		$templatePaths = \TestHelperJadm::getJsonadmPaths();
 		$this->view = $this->context->getView();
 
-		$this->object = new \Aimeos\Admin\JsonAdm\Service\Standard( $this->context, $this->view, $templatePaths, 'service' );
+		$this->object = new \Aimeos\Admin\JsonAdm\Service\Standard($this->context, $this->view, $templatePaths, 'service');
 	}
 
 
@@ -30,25 +30,25 @@  discard block
 block discarded – undo
 	{
 		$params = array(
 			'filter' => array(
-				'==' => array( 'service.code' => 'unitpaymentcode' )
+				'==' => array('service.code' => 'unitpaymentcode')
 			),
 			'include' => 'text'
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
 		$header = array();
 		$status = 500;
 
-		$result = json_decode( $this->object->get( '', $header, $status ), true );
+		$result = json_decode($this->object->get('', $header, $status), true);
 
-		$this->assertEquals( 200, $status );
-		$this->assertEquals( 1, count( $header ) );
-		$this->assertEquals( 1, $result['meta']['total'] );
-		$this->assertEquals( 1, count( $result['data'] ) );
-		$this->assertEquals( 'service', $result['data'][0]['type'] );
-		$this->assertEquals( 3, count( $result['data'][0]['relationships']['text'] ) );
-		$this->assertEquals( 3, count( $result['included'] ) );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$this->assertEquals(200, $status);
+		$this->assertEquals(1, count($header));
+		$this->assertEquals(1, $result['meta']['total']);
+		$this->assertEquals(1, count($result['data']));
+		$this->assertEquals('service', $result['data'][0]['type']);
+		$this->assertEquals(3, count($result['data'][0]['relationships']['text']));
+		$this->assertEquals(3, count($result['included']));
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

admin/jsonadm/tests/Admin/JsonAdm/Media/StandardTest.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
 		$templatePaths = \TestHelperJadm::getJsonadmPaths();
 		$this->view = $this->context->getView();
 
-		$this->object = new \Aimeos\Admin\JsonAdm\Media\Standard( $this->context, $this->view, $templatePaths, 'media' );
+		$this->object = new \Aimeos\Admin\JsonAdm\Media\Standard($this->context, $this->view, $templatePaths, 'media');
 	}
 
 
@@ -30,25 +30,25 @@  discard block
 block discarded – undo
 	{
 		$params = array(
 			'filter' => array(
-				'==' => array( 'media.label' => 'cn_colombie_179x178' )
+				'==' => array('media.label' => 'cn_colombie_179x178')
 			),
 			'include' => 'attribute'
 		);
-		$helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
-		$this->view->addHelper( 'param', $helper );
+		$helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
+		$this->view->addHelper('param', $helper);
 
 		$header = array();
 		$status = 500;
 
-		$result = json_decode( $this->object->get( '', $header, $status ), true );
+		$result = json_decode($this->object->get('', $header, $status), true);
 
-		$this->assertEquals( 200, $status );
-		$this->assertEquals( 1, count( $header ) );
-		$this->assertEquals( 1, $result['meta']['total'] );
-		$this->assertEquals( 1, count( $result['data'] ) );
-		$this->assertEquals( 'media', $result['data'][0]['type'] );
-		$this->assertEquals( 1, count( $result['data'][0]['relationships']['attribute'] ) );
-		$this->assertEquals( 1, count( $result['included'] ) );
-		$this->assertArrayNotHasKey( 'errors', $result );
+		$this->assertEquals(200, $status);
+		$this->assertEquals(1, count($header));
+		$this->assertEquals(1, $result['meta']['total']);
+		$this->assertEquals(1, count($result['data']));
+		$this->assertEquals('media', $result['data'][0]['type']);
+		$this->assertEquals(1, count($result['data'][0]['relationships']['attribute']));
+		$this->assertEquals(1, count($result['included']));
+		$this->assertArrayNotHasKey('errors', $result);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -20,17 +20,17 @@ discard block
		block discarded – undo
20	20	$context = \TestHelperJadm::getContext();
21	21	$view = $context->getView();
22	22
23		- $this->stub = $this->getMockBuilder( '\\Aimeos\\Admin\\JsonAdm\\Standard' )
24		- ->setConstructorArgs( array( $context, $view, array(), 'attribute' ) )
	23	+ $this->stub = $this->getMockBuilder('\\Aimeos\\Admin\\JsonAdm\\Standard')
	24	+ ->setConstructorArgs(array($context, $view, array(), 'attribute'))
25	25	->getMock();
26	26
27		- $this->object = new TestBase( $this->stub, $context, $view, array(), 'attribute' );
	27	+ $this->object = new TestBase($this->stub, $context, $view, array(), 'attribute');
28	28	}
29	29
30	30
31	31	protected function tearDown()
32	32	{
33		- unset( $this->object, $this->stub );
	33	+ unset($this->object, $this->stub);
34	34	}
35	35
36	36
		@@ -39,11 +39,11 @@ discard block
		block discarded – undo
39	39	$status = 0;
40	40	$header = array();
41	41
42		- $this->stub->expects( $this->once() )
43		- ->method( 'delete' )
44		- ->will( $this->returnValue( 'test' ) );
	42	+ $this->stub->expects($this->once())
	43	+ ->method('delete')
	44	+ ->will($this->returnValue('test'));
45	45
46		- $this->assertEquals( 'test', $this->object->delete( '', $header, $status ) );
	46	+ $this->assertEquals('test', $this->object->delete('', $header, $status));
47	47	}
48	48
49	49
		@@ -52,11 +52,11 @@ discard block
		block discarded – undo
52	52	$status = 0;
53	53	$header = array();
54	54
55		- $this->stub->expects( $this->once() )
56		- ->method( 'get' )
57		- ->will( $this->returnValue( 'test' ) );
	55	+ $this->stub->expects($this->once())
	56	+ ->method('get')
	57	+ ->will($this->returnValue('test'));
58	58
59		- $this->assertEquals( 'test', $this->object->get( '', $header, $status ) );
	59	+ $this->assertEquals('test', $this->object->get('', $header, $status));
60	60	}
61	61
62	62
		@@ -65,11 +65,11 @@ discard block
		block discarded – undo
65	65	$status = 0;
66	66	$header = array();
67	67
68		- $this->stub->expects( $this->once() )
69		- ->method( 'patch' )
70		- ->will( $this->returnValue( 'test' ) );
	68	+ $this->stub->expects($this->once())
	69	+ ->method('patch')
	70	+ ->will($this->returnValue('test'));
71	71
72		- $this->assertEquals( 'test', $this->object->patch( '', $header, $status ) );
	72	+ $this->assertEquals('test', $this->object->patch('', $header, $status));
73	73	}
74	74
75	75
		@@ -78,11 +78,11 @@ discard block
		block discarded – undo
78	78	$status = 0;
79	79	$header = array();
80	80
81		- $this->stub->expects( $this->once() )
82		- ->method( 'post' )
83		- ->will( $this->returnValue( 'test' ) );
	81	+ $this->stub->expects($this->once())
	82	+ ->method('post')
	83	+ ->will($this->returnValue('test'));
84	84
85		- $this->assertEquals( 'test', $this->object->post( '', $header, $status ) );
	85	+ $this->assertEquals('test', $this->object->post('', $header, $status));
86	86	}
87	87
88	88
		@@ -91,11 +91,11 @@ discard block
		block discarded – undo
91	91	$status = 0;
92	92	$header = array();
93	93
94		- $this->stub->expects( $this->once() )
95		- ->method( 'put' )
96		- ->will( $this->returnValue( 'test' ) );
	94	+ $this->stub->expects($this->once())
	95	+ ->method('put')
	96	+ ->will($this->returnValue('test'));
97	97
98		- $this->assertEquals( 'test', $this->object->put( '', $header, $status ) );
	98	+ $this->assertEquals('test', $this->object->put('', $header, $status));
99	99	}
100	100
101	101
		@@ -104,35 +104,35 @@ discard block
		block discarded – undo
104	104	$status = 0;
105	105	$header = array();
106	106
107		- $this->stub->expects( $this->once() )
108		- ->method( 'options' )
109		- ->will( $this->returnValue( 'test' ) );
	107	+ $this->stub->expects($this->once())
	108	+ ->method('options')
	109	+ ->will($this->returnValue('test'));
110	110
111		- $this->assertEquals( 'test', $this->object->options( '', $header, $status ) );
	111	+ $this->assertEquals('test', $this->object->options('', $header, $status));
112	112	}
113	113
114	114
115	115	public function testGetContext()
116	116	{
117		- $this->assertInstanceOf( '\\Aimeos\\MShop\\Context\\Item\\Iface', $this->object->getContextPublic() );
	117	+ $this->assertInstanceOf('\\Aimeos\\MShop\\Context\\Item\\Iface', $this->object->getContextPublic());
118	118	}
119	119
120	120
121	121	public function testGetTemplatePaths()
122	122	{
123		- $this->assertEquals( array(), $this->object->getTemplatePathsPublic() );
	123	+ $this->assertEquals(array(), $this->object->getTemplatePathsPublic());
124	124	}
125	125
126	126
127	127	public function testGetPath()
128	128	{
129		- $this->assertEquals( 'attribute', $this->object->getPathPublic() );
	129	+ $this->assertEquals('attribute', $this->object->getPathPublic());
130	130	}
131	131
132	132
133	133	public function testCall()
134	134	{
135		- $this->markTestIncomplete( 'PHP warning is triggered instead of exception' );
	135	+ $this->markTestIncomplete('PHP warning is triggered instead of exception');
136	136	}
137	137
138	138	}

		@@ -22,7 +22,7 @@ discard block
		block discarded – undo
22	22	$templatePaths = \TestHelperJadm::getJsonadmPaths();
23	23	$this->view = $this->context->getView();
24	24
25		- $this->object = new \Aimeos\Admin\JsonAdm\Coupon\Standard( $this->context, $this->view, $templatePaths, 'coupon' );
	25	+ $this->object = new \Aimeos\Admin\JsonAdm\Coupon\Standard($this->context, $this->view, $templatePaths, 'coupon');
26	26	}
27	27
28	28
		@@ -30,26 +30,26 @@ discard block
		block discarded – undo
30	30	{
31	31	$params = array(
32	32	'filter' => array(
33		- '==' => array( 'coupon.code.code' => '90AB' )
	33	+ '==' => array('coupon.code.code' => '90AB')
34	34	),
35	35	'include' => 'coupon/code'
36	36	);
37		- $helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
38		- $this->view->addHelper( 'param', $helper );
	37	+ $helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
	38	+ $this->view->addHelper('param', $helper);
39	39
40	40	$header = array();
41	41	$status = 500;
42	42
43		- $result = json_decode( $this->object->get( '', $header, $status ), true );
	43	+ $result = json_decode($this->object->get('', $header, $status), true);
44	44
45		- $this->assertEquals( 200, $status );
46		- $this->assertEquals( 1, count( $header ) );
47		- $this->assertEquals( 1, $result['meta']['total'] );
48		- $this->assertEquals( 1, count( $result['data'] ) );
49		- $this->assertEquals( 'coupon', $result['data'][0]['type'] );
50		- $this->assertEquals( 1, count( $result['data'][0]['relationships']['coupon/code'] ) );
51		- $this->assertEquals( 1, count( $result['included'] ) );
52		- $this->assertArrayNotHasKey( 'errors', $result );
	45	+ $this->assertEquals(200, $status);
	46	+ $this->assertEquals(1, count($header));
	47	+ $this->assertEquals(1, $result['meta']['total']);
	48	+ $this->assertEquals(1, count($result['data']));
	49	+ $this->assertEquals('coupon', $result['data'][0]['type']);
	50	+ $this->assertEquals(1, count($result['data'][0]['relationships']['coupon/code']));
	51	+ $this->assertEquals(1, count($result['included']));
	52	+ $this->assertArrayNotHasKey('errors', $result);
53	53	}
54	54
55	55
		@@ -62,22 +62,22 @@ discard block
		block discarded – undo
62	62	'sort' => 'coupon.id',
63	63	'include' => 'coupon/code'
64	64	);
65		- $helper = new \Aimeos\MW\View\Helper\Param\Standard( $this->view, $params );
66		- $this->view->addHelper( 'param', $helper );
	65	+ $helper = new \Aimeos\MW\View\Helper\Param\Standard($this->view, $params);
	66	+ $this->view->addHelper('param', $helper);
67	67
68	68	$header = array();
69	69	$status = 500;
70	70
71		- $result = json_decode( $this->object->get( '', $header, $status ), true );
72		-
73		- $this->assertEquals( 200, $status );
74		- $this->assertEquals( 1, count( $header ) );
75		- $this->assertEquals( 5, $result['meta']['total'] );
76		- $this->assertEquals( 5, count( $result['data'] ) );
77		- $this->assertEquals( 'coupon', $result['data'][0]['type'] );
78		- $this->assertEquals( 2, count( $result['data'][0]['attributes'] ) );
79		- $this->assertEquals( 1, count( $result['data'][0]['relationships']['coupon/code'] ) );
80		- $this->assertEquals( 5, count( $result['included'] ) );
81		- $this->assertArrayNotHasKey( 'errors', $result );
	71	+ $result = json_decode($this->object->get('', $header, $status), true);
	72	+
	73	+ $this->assertEquals(200, $status);
	74	+ $this->assertEquals(1, count($header));
	75	+ $this->assertEquals(5, $result['meta']['total']);
	76	+ $this->assertEquals(5, count($result['data']));
	77	+ $this->assertEquals('coupon', $result['data'][0]['type']);
	78	+ $this->assertEquals(2, count($result['data'][0]['attributes']));
	79	+ $this->assertEquals(1, count($result['data'][0]['relationships']['coupon/code']));
	80	+ $this->assertEquals(5, count($result['included']));
	81	+ $this->assertArrayNotHasKey('errors', $result);
82	82	}
83	83	}
84	84	\ No newline at end of file

aimeos / ai-admin-jsonadm

Push — master ( 786415...fa87fb )

Status

Category

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

Spacing +32 added lines, -32 removed lines patch added patch discarded remove patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch