Inspection of "Update index and cache when deleting items" - aimeos/ai-admin-jqadm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3b83d2...39a0ee )

by Aimeos

created 2016-06-16 21:30 UTC

Status

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 	/**
 	 * Copies a resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function copy()
 	{
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
 	/**
 	 * Creates a new resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function create()
 	{
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
 	/**
 	 * Returns a single resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function get()
 	{

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Product/Price/Standard.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 	/**
 	 * Copies a resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function copy()
 	{
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
 	/**
 	 * Creates a new resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function create()
 	{
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
 	/**
 	 * Returns a single resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function get()
 	{

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Product/Selection/Standard.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 	/**
 	 * Copies a resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function copy()
 	{
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
 	/**
 	 * Creates a new resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function create()
 	{
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
 	/**
 	 * Returns a single resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function get()
 	{

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Product/Standard.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 	/**
 	 * Copies a resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function copy()
 	{
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
 	/**
 	 * Creates a new resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function create()
 	{
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
 	/**
 	 * Returns a single resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function get()
 	{

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Product/Stock/Standard.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 	/**
 	 * Copies a resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function copy()
 	{
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
 	/**
 	 * Creates a new resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function create()
 	{
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
 	/**
 	 * Returns a single resource
 	 *
-	 * @return string|null admin output to display or null for redirecting to the list
+	 * @return string admin output to display or null for redirecting to the list
 	 */
 	public function get()
 	{

Please login to merge, or discard this patch.

admin/jqadm/tests/Admin/JQAdm/Common/Factory/BaseTest.php 1 patch

Doc Comments +10 added lines patch added patch discarded remove patch

@@ -121,18 +121,28 @@
 block discarded – undo
 class TestAbstract
 	extends \Aimeos\Admin\JQAdm\Common\Factory\Base
 {
+	/**
+	 * @param string $classprefix
+	 */
 	public static function addDecoratorsPublic( \Aimeos\MShop\Context\Item\Iface $context,
 		\Aimeos\Admin\JQAdm\Iface $client, $templatePaths, array $decorators, $classprefix )
 	{
 		return self::addDecorators( $context, $client, $templatePaths, $decorators, $classprefix );
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public static function addClientDecoratorsPublic( \Aimeos\MShop\Context\Item\Iface $context,
 		\Aimeos\Admin\JQAdm\Iface $client, $templatePaths, $path )
 	{
 		return self::addClientDecorators( $context, $client, $templatePaths, $path );
 	}
 
+	/**
+	 * @param string $classname
+	 * @param string $interface
+	 */
 	public static function createClientBasePublic( \Aimeos\MShop\Context\Item\Iface $context,
 		$classname, $interface, $templatePath )
 	{

Please login to merge, or discard this patch.

		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	/**
64	64	* Copies a resource
65	65	*
66		- * @return string\|null admin output to display or null for redirecting to the list
	66	+ * @return string admin output to display or null for redirecting to the list
67	67	*/
68	68	public function copy()
69	69	{
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86	/**
87	87	* Creates a new resource
88	88	*
89		- * @return string\|null admin output to display or null for redirecting to the list
	89	+ * @return string admin output to display or null for redirecting to the list
90	90	*/
91	91	public function create()
92	92	{
		@@ -109,7 +109,7 @@ discard block
		block discarded – undo
109	109	/**
110	110	* Returns a single resource
111	111	*
112		- * @return string\|null admin output to display or null for redirecting to the list
	112	+ * @return string admin output to display or null for redirecting to the list
113	113	*/
114	114	public function get()
115	115	{

		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	/**
64	64	* Copies a resource
65	65	*
66		- * @return string\|null admin output to display or null for redirecting to the list
	66	+ * @return string admin output to display or null for redirecting to the list
67	67	*/
68	68	public function copy()
69	69	{
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86	/**
87	87	* Creates a new resource
88	88	*
89		- * @return string\|null admin output to display or null for redirecting to the list
	89	+ * @return string admin output to display or null for redirecting to the list
90	90	*/
91	91	public function create()
92	92	{
		@@ -109,7 +109,7 @@ discard block
		block discarded – undo
109	109	/**
110	110	* Returns a single resource
111	111	*
112		- * @return string\|null admin output to display or null for redirecting to the list
	112	+ * @return string admin output to display or null for redirecting to the list
113	113	*/
114	114	public function get()
115	115	{

		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	/**
64	64	* Copies a resource
65	65	*
66		- * @return string\|null admin output to display or null for redirecting to the list
	66	+ * @return string admin output to display or null for redirecting to the list
67	67	*/
68	68	public function copy()
69	69	{
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86	/**
87	87	* Creates a new resource
88	88	*
89		- * @return string\|null admin output to display or null for redirecting to the list
	89	+ * @return string admin output to display or null for redirecting to the list
90	90	*/
91	91	public function create()
92	92	{
		@@ -109,7 +109,7 @@ discard block
		block discarded – undo
109	109	/**
110	110	* Returns a single resource
111	111	*
112		- * @return string\|null admin output to display or null for redirecting to the list
	112	+ * @return string admin output to display or null for redirecting to the list
113	113	*/
114	114	public function get()
115	115	{

		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	/**
64	64	* Copies a resource
65	65	*
66		- * @return string\|null admin output to display or null for redirecting to the list
	66	+ * @return string admin output to display or null for redirecting to the list
67	67	*/
68	68	public function copy()
69	69	{
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86	/**
87	87	* Creates a new resource
88	88	*
89		- * @return string\|null admin output to display or null for redirecting to the list
	89	+ * @return string admin output to display or null for redirecting to the list
90	90	*/
91	91	public function create()
92	92	{
		@@ -109,7 +109,7 @@ discard block
		block discarded – undo
109	109	/**
110	110	* Returns a single resource
111	111	*
112		- * @return string\|null admin output to display or null for redirecting to the list
	112	+ * @return string admin output to display or null for redirecting to the list
113	113	*/
114	114	public function get()
115	115	{

		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	/**
64	64	* Copies a resource
65	65	*
66		- * @return string\|null admin output to display or null for redirecting to the list
	66	+ * @return string admin output to display or null for redirecting to the list
67	67	*/
68	68	public function copy()
69	69	{
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86	/**
87	87	* Creates a new resource
88	88	*
89		- * @return string\|null admin output to display or null for redirecting to the list
	89	+ * @return string admin output to display or null for redirecting to the list
90	90	*/
91	91	public function create()
92	92	{
		@@ -109,7 +109,7 @@ discard block
		block discarded – undo
109	109	/**
110	110	* Returns a single resource
111	111	*
112		- * @return string\|null admin output to display or null for redirecting to the list
	112	+ * @return string admin output to display or null for redirecting to the list
113	113	*/
114	114	public function get()
115	115	{

		@@ -121,18 +121,28 @@
		block discarded – undo
121	121	class TestAbstract
122	122	extends \Aimeos\Admin\JQAdm\Common\Factory\Base
123	123	{
	124	+ /**
	125	+ * @param string $classprefix
	126	+ */
124	127	public static function addDecoratorsPublic( \Aimeos\MShop\Context\Item\Iface $context,
125	128	\Aimeos\Admin\JQAdm\Iface $client, $templatePaths, array $decorators, $classprefix )
126	129	{
127	130	return self::addDecorators( $context, $client, $templatePaths, $decorators, $classprefix );
128	131	}
129	132
	133	+ /**
	134	+ * @param string $path
	135	+ */
130	136	public static function addClientDecoratorsPublic( \Aimeos\MShop\Context\Item\Iface $context,
131	137	\Aimeos\Admin\JQAdm\Iface $client, $templatePaths, $path )
132	138	{
133	139	return self::addClientDecorators( $context, $client, $templatePaths, $path );
134	140	}
135	141
	142	+ /**
	143	+ * @param string $classname
	144	+ * @param string $interface
	145	+ */
136	146	public static function createClientBasePublic( \Aimeos\MShop\Context\Item\Iface $context,
137	147	$classname, $interface, $templatePath )
138	148	{

aimeos / ai-admin-jqadm

Push — master ( 3b83d2...39a0ee )

Status

Category

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +10 added lines patch added patch discarded remove patch