Inspection of "Fixed setting customer code and label" - aimeos/ai-admin-jqadm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ca3ab2...36dc87 )

by Aimeos

created 2019-06-14 08:35 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -281,7 +281,7 @@
 block discarded – undo
 
 		$search = $manager->createSearch( true )->setSlice( 0, 10000 );
 		$search->setConditions( $search->compare( '!=', 'product.property.type.code', $excludes ) );
-		$search->setSortations( [$search->sort( '+', 'product.property.type.position')] );
+		$search->setSortations( [$search->sort( '+', 'product.property.type.position' )] );
 
 		return $this->map( $manager->searchItems( $search ) );
 	}

Please login to merge, or discard this patch.

admin/jqadm/templates/catalog/item-media-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addPropertyItem(idx)">
 					</div>
 				</th>
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 
 				<td class="actions">
 					<div v-if="!checkSite('media.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removePropertyItem(idx, propidx)">
 					</div>
 				</td>

Please login to merge, or discard this patch.

admin/jqadm/templates/locale/currency/item-standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -57,7 +57,7 @@
 block discarded – undo
 
 				<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
 					<li class="nav-item <?= $enc->attr( $subpart ); ?>">
-						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
+						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
 							<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
 						</a>
 					</li>

Please login to merge, or discard this patch.

admin/jqadm/templates/locale/language/list-standard.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -109,7 +109,7 @@  discard block
 block discarded – undo
 				<th class="actions">
 					<a class="btn fa act-add" tabindex="1"
 						href="<?= $enc->attr( $this->url( $newTarget, $newCntl, $newAction, $params, [], $newConfig ) ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						aria-label="<?= $enc->attr( $this->translate( 'admin', 'Add' ) ); ?>">
 					</a>
 
@@ -171,11 +171,11 @@  discard block
 block discarded – undo
 					<td class="actions">
 						<a class="btn act-copy fa" tabindex="1"
 							href="<?= $enc->attr( $this->url( $copyTarget, $copyCntl, $copyAction, ['id' => $id] + $params, [], $copyConfig ) ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Copy this entry') ); ?>"
+							title="<?= $enc->attr( $this->translate( 'admin', 'Copy this entry' ) ); ?>"
 							aria-label="<?= $enc->attr( $this->translate( 'admin', 'Copy' ) ); ?>"></a>
 						<a class="btn act-delete fa" tabindex="1"
 							href="<?= $enc->attr( $this->url( $delTarget, $delCntl, $delAction, ['id' => $id] + $params, [], $delConfig ) ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 							aria-label="<?= $enc->attr( $this->translate( 'admin', 'Delete' ) ); ?>"></a>
 					</td>
 				</tr>

Please login to merge, or discard this patch.

admin/jqadm/templates/locale/language/item-standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -57,7 +57,7 @@
 block discarded – undo
 
 				<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
 					<li class="nav-item <?= $enc->attr( $subpart ); ?>">
-						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
+						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
 							<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
 						</a>
 					</li>

Please login to merge, or discard this patch.

admin/jqadm/templates/product/item-characteristic-variant-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addItem()">
 					</div>
 				</th>
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
 				</td>
 				<td class="actions">
 					<div v-if="!checkSite('product.lists.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removeItem(idx)">
 				</td>
 

Please login to merge, or discard this patch.

admin/jqadm/templates/product/item-related-suggest-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addItem()">
 					</div>
 				</th>
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
 				</td>
 				<td class="actions">
 					<div v-if="!checkSite('product.lists.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removeItem(idx)">
 				</td>
 			</tr>

Please login to merge, or discard this patch.

admin/jqadm/templates/product/item-characteristic-attribute-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addItem()">
 					</div>
 				</th>
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
 				</td>
 				<td class="actions">
 					<div v-if="!checkSite('product.lists.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removeItem(idx)">
 				</td>
 

Please login to merge, or discard this patch.

admin/jqadm/templates/product/item-media-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addPropertyItem(idx)">
 					</div>
 				</th>
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 
 				<td class="actions">
 					<div v-if="!checkSite('media.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removePropertyItem(idx, propidx)">
 					</div>
 				</td>

Please login to merge, or discard this patch.

		@@ -281,7 +281,7 @@
		block discarded – undo
281	281
282	282	$search = $manager->createSearch( true )->setSlice( 0, 10000 );
283	283	$search->setConditions( $search->compare( '!=', 'product.property.type.code', $excludes ) );
284		- $search->setSortations( [$search->sort( '+', 'product.property.type.position')] );
	284	+ $search->setSortations( [$search->sort( '+', 'product.property.type.position' )] );
285	285
286	286	return $this->map( $manager->searchItems( $search ) );
287	287	}

		@@ -57,7 +57,7 @@
		block discarded – undo
57	57
58	58	<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
59	59	<li class="nav-item <?= $enc->attr( $subpart ); ?>">
60		- <a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
	60	+ <a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
61	61	<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
62	62	</a>
63	63	</li>

		@@ -109,7 +109,7 @@ discard block
		block discarded – undo
109	109	<th class="actions">
110	110	<a class="btn fa act-add" tabindex="1"
111	111	href="<?= $enc->attr( $this->url( $newTarget, $newCntl, $newAction, $params, [], $newConfig ) ); ?>"
112		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	112	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
113	113	aria-label="<?= $enc->attr( $this->translate( 'admin', 'Add' ) ); ?>">
114	114	</a>
115	115
		@@ -171,11 +171,11 @@ discard block
		block discarded – undo
171	171	<td class="actions">
172	172	<a class="btn act-copy fa" tabindex="1"
173	173	href="<?= $enc->attr( $this->url( $copyTarget, $copyCntl, $copyAction, ['id' => $id] + $params, [], $copyConfig ) ); ?>"
174		- title="<?= $enc->attr( $this->translate( 'admin', 'Copy this entry') ); ?>"
	174	+ title="<?= $enc->attr( $this->translate( 'admin', 'Copy this entry' ) ); ?>"
175	175	aria-label="<?= $enc->attr( $this->translate( 'admin', 'Copy' ) ); ?>"></a>
176	176	<a class="btn act-delete fa" tabindex="1"
177	177	href="<?= $enc->attr( $this->url( $delTarget, $delCntl, $delAction, ['id' => $id] + $params, [], $delConfig ) ); ?>"
178		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	178	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
179	179	aria-label="<?= $enc->attr( $this->translate( 'admin', 'Delete' ) ); ?>"></a>
180	180	</td>
181	181	</tr>

		@@ -57,7 +57,7 @@
		block discarded – undo
57	57
58	58	<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
59	59	<li class="nav-item <?= $enc->attr( $subpart ); ?>">
60		- <a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
	60	+ <a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
61	61	<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
62	62	</a>
63	63	</li>

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	</th>
25	25	<th class="actions">
26	26	<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
27		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	27	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
28	28	v-on:click="addPropertyItem(idx)">
29	29	</div>
30	30	</th>
		@@ -77,7 +77,7 @@ discard block
		block discarded – undo
77	77
78	78	<td class="actions">
79	79	<div v-if="!checkSite('media.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
80		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	80	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
81	81	v-on:click.stop="removePropertyItem(idx, propidx)">
82	82	</div>
83	83	</td>

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33	</th>
34	34	<th class="actions">
35	35	<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
36		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	36	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
37	37	v-on:click="addItem()">
38	38	</div>
39	39	</th>
		@@ -68,7 +68,7 @@ discard block
		block discarded – undo
68	68	</td>
69	69	<td class="actions">
70	70	<div v-if="!checkSite('product.lists.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
71		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	71	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
72	72	v-on:click.stop="removeItem(idx)">
73	73	</td>
74	74

		@@ -31,7 +31,7 @@ discard block
		block discarded – undo
31	31	</th>
32	32	<th class="actions">
33	33	<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
34		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	34	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
35	35	v-on:click="addItem()">
36	36	</div>
37	37	</th>
		@@ -67,7 +67,7 @@ discard block
		block discarded – undo
67	67	</td>
68	68	<td class="actions">
69	69	<div v-if="!checkSite('product.lists.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
70		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	70	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
71	71	v-on:click.stop="removeItem(idx)">
72	72	</td>
73	73	</tr>

aimeos / ai-admin-jqadm

Push — master ( ca3ab2...36dc87 )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch