Inspection of "Fixed setting customer code and label" - aimeos/ai-admin-jqadm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ca3ab2...36dc87 )

by Aimeos

created 2019-06-14 08:35 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -57,7 +57,7 @@
 block discarded – undo
 
 				<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
 					<li class="nav-item <?= $enc->attr( $subpart ); ?>">
-						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
+						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
 							<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
 						</a>
 					</li>

Please login to merge, or discard this patch.

admin/jqadm/templates/supplier/item-standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -57,7 +57,7 @@
 block discarded – undo
 
 				<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
 					<li class="nav-item <?= $enc->attr( $subpart ); ?>">
-						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
+						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
 							<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
 						</a>
 					</li>

Please login to merge, or discard this patch.

admin/jqadm/templates/attribute/item-standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -57,7 +57,7 @@
 block discarded – undo
 
 				<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
 					<li class="nav-item <?= $enc->attr( $subpart ); ?>">
-						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
+						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
 							<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
 						</a>
 					</li>

Please login to merge, or discard this patch.

admin/jqadm/templates/attribute/item-media-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addPropertyItem(idx)">
 					</div>
 				</th>
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 
 				<td class="actions">
 					<div v-if="!checkSite('media.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removePropertyItem(idx, propidx)">
 					</div>
 				</td>

Please login to merge, or discard this patch.

admin/jqadm/templates/service/item-media-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addPropertyItem(idx)">
 					</div>
 				</th>
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 
 				<td class="actions">
 					<div v-if="!checkSite('media.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removePropertyItem(idx, propidx)">
 					</div>
 				</td>

Please login to merge, or discard this patch.

admin/jqadm/templates/customer/item-standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -57,7 +57,7 @@
 block discarded – undo
 
 				<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
 					<li class="nav-item <?= $enc->attr( $subpart ); ?>">
-						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
+						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
 							<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
 						</a>
 					</li>

Please login to merge, or discard this patch.

admin/jqadm/templates/order/item-standard.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -110,14 +110,14 @@  discard block
 block discarded – undo
 			</span>
 			<div class="item-actions">
 				<a class="btn btn-secondary act-cancel"
-					title="<?= $enc->attr( $this->translate( 'admin', 'Cancel and return to list') ); ?>"
+					title="<?= $enc->attr( $this->translate( 'admin', 'Cancel and return to list' ) ); ?>"
 					href="<?= $enc->attr( $this->url( $listTarget, $listCntl, $listAction, $searchParams, [], $listConfig ) ); ?>">
 					<?= $enc->html( $this->translate( 'admin', 'Cancel' ) ); ?>
 				</a>
 
 				<div class="btn-group">
 					<button type="submit" class="btn btn-primary act-save"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Save entry (Ctrl+S)') ); ?>">
+						title="<?= $enc->attr( $this->translate( 'admin', 'Save entry (Ctrl+S)' ) ); ?>">
 						<?= $enc->html( $this->translate( 'admin', 'Save' ) ); ?>
 					</button>
 					<button type="button" class="btn btn-primary dropdown-toggle dropdown-toggle-split" data-toggle="dropdown"
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
 
 					<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $type => $subpart ) : ?>
 						<li class="nav-item <?= $enc->attr( $subpart ); ?>">
-							<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$type+1; ?>">
+							<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$type + 1; ?>">
 								<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
 							</a>
 						</li>
@@ -578,7 +578,7 @@  discard block
 block discarded – undo
 												<input class="form-control item-website" type="url" tabindex="1" data-field="website"
 													name="<?= $enc->attr( $this->formparam( array( 'item', 'address', $type, $pos, 'order.base.address.website' ) ) ); ?>"
 													placeholder="<?= $enc->attr( $this->translate( 'admin', 'Web site URL (optional)' ) ); ?>"
-													value="<?= $enc->attr( $this->get( 'itemData/address/' . $type . '/' . $pos . '/order.base.address.website') ); ?>"
+													value="<?= $enc->attr( $this->get( 'itemData/address/' . $type . '/' . $pos . '/order.base.address.website' ) ); ?>"
 													<?= $this->site()->readonly( $basket->getLocale()->getSiteId() ); ?> />
 											</div>
 											<div class="col-sm-12 form-text text-muted help-text">
@@ -635,7 +635,7 @@  discard block
 block discarded – undo
 										</div>
 									</div>
 
-									<table class="service-attr table table-striped" data-id="<?= $enc->attr($serviceId ) ?>"
+									<table class="service-attr table table-striped" data-id="<?= $enc->attr( $serviceId ) ?>"
 										data-codes="<?= $enc->attr( isset( $serviceAttrCodes[$type] ) ? implode( ',', $serviceAttrCodes[$type] ) : '' ); ?>">
 										<thead>
 											<tr>
@@ -651,7 +651,7 @@  discard block
 block discarded – undo
 												<th class="actions">
 													<?php if( !$this->site()->readonly( $basket->getLocale()->getSiteId() ) ) : ?>
 														<div class="btn act-add fa" tabindex="1"
-															title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>">
+															title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>">
 														</div>
 													<?php endif; ?>
 												</th>
@@ -690,7 +690,7 @@  discard block
 block discarded – undo
 													<td class="actions">
 														<?php if( !$this->site()->readonly( $basket->getLocale()->getSiteId() ) ) : ?>
 															<div class="btn act-delete fa" tabindex="1"
-																title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>">
+																title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>">
 															</div>
 														<?php endif; ?>
 													</td>
@@ -719,7 +719,7 @@  discard block
 block discarded – undo
 												<td class="actions">
 													<?php if( !$this->site()->readonly( $basket->getLocale()->getSiteId() ) ) : ?>
 														<div class="btn act-delete fa" tabindex="1"
-															title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>">
+															title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>">
 														</div>
 													<?php endif; ?>
 												</td>

Please login to merge, or discard this patch.

admin/jqadm/templates/group/item-standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -57,7 +57,7 @@
 block discarded – undo
 
 				<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
 					<li class="nav-item <?= $enc->attr( $subpart ); ?>">
-						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
+						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
 							<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
 						</a>
 					</li>

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -62,7 +62,7 @@
 block discarded – undo
 			throw new \Aimeos\Admin\JQAdm\Exception( sprintf( 'Invalid factory "%1$s"', $factory ) );
 		}
 
-		return $client->setAimeos( $aimeos )->setView( $view );;
+		return $client->setAimeos( $aimeos )->setView( $view ); ;
 	}
 
 }

Please login to merge, or discard this patch.

		@@ -110,14 +110,14 @@ discard block
		block discarded – undo
110	110	</span>
111	111	<div class="item-actions">
112	112	<a class="btn btn-secondary act-cancel"
113		- title="<?= $enc->attr( $this->translate( 'admin', 'Cancel and return to list') ); ?>"
	113	+ title="<?= $enc->attr( $this->translate( 'admin', 'Cancel and return to list' ) ); ?>"
114	114	href="<?= $enc->attr( $this->url( $listTarget, $listCntl, $listAction, $searchParams, [], $listConfig ) ); ?>">
115	115	<?= $enc->html( $this->translate( 'admin', 'Cancel' ) ); ?>
116	116	</a>
117	117
118	118	<div class="btn-group">
119	119	<button type="submit" class="btn btn-primary act-save"
120		- title="<?= $enc->attr( $this->translate( 'admin', 'Save entry (Ctrl+S)') ); ?>">
	120	+ title="<?= $enc->attr( $this->translate( 'admin', 'Save entry (Ctrl+S)' ) ); ?>">
121	121	<?= $enc->html( $this->translate( 'admin', 'Save' ) ); ?>
122	122	</button>
123	123	<button type="button" class="btn btn-primary dropdown-toggle dropdown-toggle-split" data-toggle="dropdown"
		@@ -144,7 +144,7 @@ discard block
		block discarded – undo
144	144
145	145	<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $type => $subpart ) : ?>
146	146	<li class="nav-item <?= $enc->attr( $subpart ); ?>">
147		- <a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$type+1; ?>">
	147	+ <a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$type + 1; ?>">
148	148	<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
149	149	</a>
150	150	</li>
		@@ -578,7 +578,7 @@ discard block
		block discarded – undo
578	578	<input class="form-control item-website" type="url" tabindex="1" data-field="website"
579	579	name="<?= $enc->attr( $this->formparam( array( 'item', 'address', $type, $pos, 'order.base.address.website' ) ) ); ?>"
580	580	placeholder="<?= $enc->attr( $this->translate( 'admin', 'Web site URL (optional)' ) ); ?>"
581		- value="<?= $enc->attr( $this->get( 'itemData/address/' . $type . '/' . $pos . '/order.base.address.website') ); ?>"
	581	+ value="<?= $enc->attr( $this->get( 'itemData/address/' . $type . '/' . $pos . '/order.base.address.website' ) ); ?>"
582	582	<?= $this->site()->readonly( $basket->getLocale()->getSiteId() ); ?> />
583	583	</div>
584	584	<div class="col-sm-12 form-text text-muted help-text">
		@@ -635,7 +635,7 @@ discard block
		block discarded – undo
635	635	</div>
636	636	</div>
637	637
638		- <table class="service-attr table table-striped" data-id="<?= $enc->attr($serviceId ) ?>"
	638	+ <table class="service-attr table table-striped" data-id="<?= $enc->attr( $serviceId ) ?>"
639	639	data-codes="<?= $enc->attr( isset( $serviceAttrCodes[$type] ) ? implode( ',', $serviceAttrCodes[$type] ) : '' ); ?>">
640	640	<thead>
641	641	<tr>
		@@ -651,7 +651,7 @@ discard block
		block discarded – undo
651	651	<th class="actions">
652	652	<?php if( !$this->site()->readonly( $basket->getLocale()->getSiteId() ) ) : ?>
653	653	<div class="btn act-add fa" tabindex="1"
654		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>">
	654	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>">
655	655	</div>
656	656	<?php endif; ?>
657	657	</th>
		@@ -690,7 +690,7 @@ discard block
		block discarded – undo
690	690	<td class="actions">
691	691	<?php if( !$this->site()->readonly( $basket->getLocale()->getSiteId() ) ) : ?>
692	692	<div class="btn act-delete fa" tabindex="1"
693		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>">
	693	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>">
694	694	</div>
695	695	<?php endif; ?>
696	696	</td>
		@@ -719,7 +719,7 @@ discard block
		block discarded – undo
719	719	<td class="actions">
720	720	<?php if( !$this->site()->readonly( $basket->getLocale()->getSiteId() ) ) : ?>
721	721	<div class="btn act-delete fa" tabindex="1"
722		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>">
	722	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>">
723	723	</div>
724	724	<?php endif; ?>
725	725	</td>

		@@ -57,7 +57,7 @@
		block discarded – undo
57	57
58	58	<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
59	59	<li class="nav-item <?= $enc->attr( $subpart ); ?>">
60		- <a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
	60	+ <a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
61	61	<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
62	62	</a>
63	63	</li>

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	</th>
25	25	<th class="actions">
26	26	<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
27		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	27	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
28	28	v-on:click="addPropertyItem(idx)">
29	29	</div>
30	30	</th>
		@@ -77,7 +77,7 @@ discard block
		block discarded – undo
77	77
78	78	<td class="actions">
79	79	<div v-if="!checkSite('media.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
80		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	80	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
81	81	v-on:click.stop="removePropertyItem(idx, propidx)">
82	82	</div>
83	83	</td>

		@@ -62,7 +62,7 @@
		block discarded – undo
62	62	throw new \Aimeos\Admin\JQAdm\Exception( sprintf( 'Invalid factory "%1$s"', $factory ) );
63	63	}
64	64
65		- return $client->setAimeos( $aimeos )->setView( $view );;
	65	+ return $client->setAimeos( $aimeos )->setView( $view ); ;
66	66	}
67	67
68	68	}

aimeos / ai-admin-jqadm

Push — master ( ca3ab2...36dc87 )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch