Inspection of "Allow only super users to delete sites" - aimeos/ai-admin-jqadm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bf45b2...a4371c )

by Aimeos

created 2019-09-07 17:23 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -285,7 +285,7 @@
 block discarded – undo
 			$manager = \Aimeos\MShop::create( $context, 'index' );
 
 			$search = $manager->createSearch();
-			$search->setSortations( [$search->sort( '+', 'product.id')] );
+			$search->setSortations( [$search->sort( '+', 'product.id' )] );
 			$search = $this->initCriteria( $search, $params );
 
 			$view->items = $manager->searchItems( $search, array_diff( $this->getDomains(), ['product'] ), $total );

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Attribute/Media/Standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -416,7 +416,7 @@
 block discarded – undo
 
 			if( $file && $file->getError() !== UPLOAD_ERR_NO_FILE ) {
 				$refItem = $cntl->add( $refItem, $file );
-			} elseif ( $refItem->getId() === null && $refItem->getUrl() !== '' ) {
+			} elseif( $refItem->getId() === null && $refItem->getUrl() !== '' ) {
 				$refItem = $cntl->copy( $refItem );
 			}
 

Please login to merge, or discard this patch.

admin/jqadm/templates/common/page-standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -214,7 +214,7 @@
 block discarded – undo
 
 									<?php foreach( $navitem as $subresource ) : ?>
 										<?php if( $this->access( $this->config( 'admin/jqadm/resource/' . $subresource . '/groups', [] ) ) ) : ?>
-											<li class="<?= str_replace( '/', '-', $subresource); ?>">
+											<li class="<?= str_replace( '/', '-', $subresource ); ?>">
 												<a href="<?= $enc->attr( $this->url( $searchTarget, $cntl, $action, ['resource' => $subresource] + $params, [], $config ) ); ?>">
 													<span class="name"><?= $enc->html( $this->translate( 'admin', $subresource ) ); ?></span>
 												</a>

Please login to merge, or discard this patch.

admin/jqadm/templates/product/item-price-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addPropertyItem(idx)">
 					</div>
 				</th>
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 
 				<td class="actions">
 					<div v-if="!checkSite('price.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removePropertyItem(idx, propidx)">
 					</div>
 				</td>

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Service/Price/Property/Standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -218,7 +218,7 @@
 block discarded – undo
 
 		$search = $manager->createSearch( true )->setSlice( 0, 10000 );
 		$search->setConditions( $search->compare( '==', 'price.property.type.domain', 'price' ) );
-		$search->setSortations( [$search->sort( '+', 'price.property.type.position')] );
+		$search->setSortations( [$search->sort( '+', 'price.property.type.position' )] );
 
 		$view->propertyTypes = $this->map( $manager->searchItems( $search ) );
 

Please login to merge, or discard this patch.

admin/jqadm/templates/attribute/item-price-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addPropertyItem(idx)">
 					</div>
 				</th>
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 
 				<td class="actions">
 					<div v-if="!checkSite('price.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removePropertyItem(idx, propidx)">
 					</div>
 				</td>

Please login to merge, or discard this patch.

admin/jqadm/templates/service/item-price-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addPropertyItem(idx)">
 					</div>
 				</th>
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 
 				<td class="actions">
 					<div v-if="!checkSite('price.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removePropertyItem(idx, propidx)">
 					</div>
 				</td>

Please login to merge, or discard this patch.

admin/jqadm/templates/customer/item-address-standard.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -32,14 +32,14 @@  discard block
 block discarded – undo
 					v-bind:aria-controls="'item-address-group-data-' + idx" aria-expanded="false">
 					<div class="card-tools-left">
 						<div class="btn btn-card-header act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry' ) ); ?>">
 						</div>
 					</div>
 					<span class="item-label header-label">{{ getLabel(idx, 'customer.address.') }}</span>
 					&nbsp;
 					<div class="card-tools-right">
 						<div class="btn btn-card-header act-copy fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Duplicate entry (Ctrl+D)') ); ?>"
+							title="<?= $enc->attr( $this->translate( 'admin', 'Duplicate entry (Ctrl+D)' ) ); ?>"
 							v-on:click.stop="duplicateItem(idx)">
 						</div>
 						<div v-if="!checkSite('customer.address.siteid', idx)"
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
 						</div>
 						<div v-if="!checkSite('customer.address.siteid', idx)"
 							class="btn btn-card-header act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 							v-on:click="removeItem(idx)">
 						</div>
 					</div>
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
 
 			<div slot="footer" class="card-tools-more">
 				<div class="btn btn-primary btn-card-more act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-					title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+					title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 					v-on:click="addItem('customer.address.')" >
 				</div>
 			</div>

Please login to merge, or discard this patch.

admin/jqadm/templates/service/item-text-standard.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 					v-bind:aria-controls="'item-text-group-data-' + idx" aria-expanded="false">
 					<div class="card-tools-left">
 						<div class="btn btn-card-header act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry' ) ); ?>">
 						</div>
 					</div>
 					<span class="item-label header-label" v-html="getLabel(idx)"></span>
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
 						</div>
 						<div v-if="!checkSite('service.lists.siteid', idx)"
 							class="btn btn-card-header act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 							v-on:click.stop="removeItem(idx)">
 						</div>
 					</div>
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
 					<div v-on:click="toggle(idx)" class="col-xl-12 advanced" v-bind:class="{ 'collapsed': !advanced[idx] }">
 						<div class="card-tools-left">
 							<div class="btn act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-								title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data') ); ?>">
+								title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data' ) ); ?>">
 							</div>
 						</div>
 						<span class="header-label"><?= $enc->html( $this->translate( 'admin', 'Advanced' ) ); ?></span>
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
 									</th>
 									<th class="actions">
 										<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-											title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+											title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 											v-bind:readonly="checkSite('service.lists.siteid', idx)"
 											v-on:click="addConfig(idx)" >
 										</div>
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
 									<td class="actions">
 										<div v-if="!checkSite('service.lists.siteid', idx)" v-on:click="removeConfig(idx, pos)"
 											class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-											title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>">
+											title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>">
 										</div>
 									</td>
 								</tr>
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
 
 			<div slot="footer" class="card-tools-more">
 				<div class="btn btn-primary btn-card-more act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-					title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+					title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 					v-on:click="addItem('service.lists.')" >
 				</div>
 			</div>

Please login to merge, or discard this patch.

		@@ -416,7 +416,7 @@
		block discarded – undo
416	416
417	417	if( $file && $file->getError() !== UPLOAD_ERR_NO_FILE ) {
418	418	$refItem = $cntl->add( $refItem, $file );
419		- } elseif ( $refItem->getId() === null && $refItem->getUrl() !== '' ) {
	419	+ } elseif( $refItem->getId() === null && $refItem->getUrl() !== '' ) {
420	420	$refItem = $cntl->copy( $refItem );
421	421	}
422	422

		@@ -218,7 +218,7 @@
		block discarded – undo
218	218
219	219	$search = $manager->createSearch( true )->setSlice( 0, 10000 );
220	220	$search->setConditions( $search->compare( '==', 'price.property.type.domain', 'price' ) );
221		- $search->setSortations( [$search->sort( '+', 'price.property.type.position')] );
	221	+ $search->setSortations( [$search->sort( '+', 'price.property.type.position' )] );
222	222
223	223	$view->propertyTypes = $this->map( $manager->searchItems( $search ) );
224	224

		@@ -285,7 +285,7 @@
		block discarded – undo
285	285	$manager = \Aimeos\MShop::create( $context, 'index' );
286	286
287	287	$search = $manager->createSearch();
288		- $search->setSortations( [$search->sort( '+', 'product.id')] );
	288	+ $search->setSortations( [$search->sort( '+', 'product.id' )] );
289	289	$search = $this->initCriteria( $search, $params );
290	290
291	291	$view->items = $manager->searchItems( $search, array_diff( $this->getDomains(), ['product'] ), $total );

		@@ -214,7 +214,7 @@
		block discarded – undo
214	214
215	215	<?php foreach( $navitem as $subresource ) : ?>
216	216	<?php if( $this->access( $this->config( 'admin/jqadm/resource/' . $subresource . '/groups', [] ) ) ) : ?>
217		- <li class="<?= str_replace( '/', '-', $subresource); ?>">
	217	+ <li class="<?= str_replace( '/', '-', $subresource ); ?>">
218	218	<a href="<?= $enc->attr( $this->url( $searchTarget, $cntl, $action, ['resource' => $subresource] + $params, [], $config ) ); ?>">
219	219	<span class="name"><?= $enc->html( $this->translate( 'admin', $subresource ) ); ?></span>
220	220	</a>

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	</th>
25	25	<th class="actions">
26	26	<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
27		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	27	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
28	28	v-on:click="addPropertyItem(idx)">
29	29	</div>
30	30	</th>
		@@ -77,7 +77,7 @@ discard block
		block discarded – undo
77	77
78	78	<td class="actions">
79	79	<div v-if="!checkSite('price.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
80		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	80	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
81	81	v-on:click.stop="removePropertyItem(idx, propidx)">
82	82	</div>
83	83	</td>

		@@ -32,14 +32,14 @@ discard block
		block discarded – undo
32	32	v-bind:aria-controls="'item-address-group-data-' + idx" aria-expanded="false">
33	33	<div class="card-tools-left">
34	34	<div class="btn btn-card-header act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
35		- title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry') ); ?>">
	35	+ title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry' ) ); ?>">
36	36	</div>
37	37	</div>
38	38	<span class="item-label header-label">{{ getLabel(idx, 'customer.address.') }}</span>
39	39
40	40	<div class="card-tools-right">
41	41	<div class="btn btn-card-header act-copy fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
42		- title="<?= $enc->attr( $this->translate( 'admin', 'Duplicate entry (Ctrl+D)') ); ?>"
	42	+ title="<?= $enc->attr( $this->translate( 'admin', 'Duplicate entry (Ctrl+D)' ) ); ?>"
43	43	v-on:click.stop="duplicateItem(idx)">
44	44	</div>
45	45	<div v-if="!checkSite('customer.address.siteid', idx)"
		@@ -48,7 +48,7 @@ discard block
		block discarded – undo
48	48	</div>
49	49	<div v-if="!checkSite('customer.address.siteid', idx)"
50	50	class="btn btn-card-header act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
51		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	51	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
52	52	v-on:click="removeItem(idx)">
53	53	</div>
54	54	</div>
		@@ -342,7 +342,7 @@ discard block
		block discarded – undo
342	342
343	343	<div slot="footer" class="card-tools-more">
344	344	<div class="btn btn-primary btn-card-more act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
345		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	345	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
346	346	v-on:click="addItem('customer.address.')" >
347	347	</div>
348	348	</div>

		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30	v-bind:aria-controls="'item-text-group-data-' + idx" aria-expanded="false">
31	31	<div class="card-tools-left">
32	32	<div class="btn btn-card-header act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
33		- title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry') ); ?>">
	33	+ title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide this entry' ) ); ?>">
34	34	</div>
35	35	</div>
36	36	<span class="item-label header-label" v-html="getLabel(idx)"></span>
		@@ -42,7 +42,7 @@ discard block
		block discarded – undo
42	42	</div>
43	43	<div v-if="!checkSite('service.lists.siteid', idx)"
44	44	class="btn btn-card-header act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
45		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	45	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
46	46	v-on:click.stop="removeItem(idx)">
47	47	</div>
48	48	</div>
		@@ -180,7 +180,7 @@ discard block
		block discarded – undo
180	180	<div v-on:click="toggle(idx)" class="col-xl-12 advanced" v-bind:class="{ 'collapsed': !advanced[idx] }">
181	181	<div class="card-tools-left">
182	182	<div class="btn act-show fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
183		- title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data') ); ?>">
	183	+ title="<?= $enc->attr( $this->translate( 'admin', 'Show/hide advanced data' ) ); ?>">
184	184	</div>
185	185	</div>
186	186	<span class="header-label"><?= $enc->html( $this->translate( 'admin', 'Advanced' ) ); ?></span>
		@@ -262,7 +262,7 @@ discard block
		block discarded – undo
262	262	</th>
263	263	<th class="actions">
264	264	<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
265		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	265	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
266	266	v-bind:readonly="checkSite('service.lists.siteid', idx)"
267	267	v-on:click="addConfig(idx)" >
268	268	</div>
		@@ -289,7 +289,7 @@ discard block
		block discarded – undo
289	289	<td class="actions">
290	290	<div v-if="!checkSite('service.lists.siteid', idx)" v-on:click="removeConfig(idx, pos)"
291	291	class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
292		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>">
	292	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>">
293	293	</div>
294	294	</td>
295	295	</tr>
		@@ -305,7 +305,7 @@ discard block
		block discarded – undo
305	305
306	306	<div slot="footer" class="card-tools-more">
307	307	<div class="btn btn-primary btn-card-more act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
308		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	308	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
309	309	v-on:click="addItem('service.lists.')" >
310	310	</div>
311	311	</div>

aimeos / ai-admin-jqadm

Push — master ( bf45b2...a4371c )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch