Inspection of "Improved error resilience" - aimeos/ai-admin-jqadm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5b7841...744d05 )

by Aimeos

created 2019-10-18 15:48 UTC

Status

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -52,8 +52,11 @@
 block discarded – undo
 								</option>
 							<?php endforeach; ?>
 						</select>
-					<?php else : ?>
-						<input class="form-control" type="<?= $enc->attr( $type ); ?>" tabindex="<?= $this->get( 'tabindex' ); ?>"
+					<?php else {
+	: ?>
+						<input class="form-control" type="<?= $enc->attr( $type );
+}
+?>" tabindex="<?= $this->get( 'tabindex' ); ?>"
 							name="<?= $enc->attr( $this->formparam( array_merge( $group, ['filter', 'val', $idx] ) ) ); ?>"
 							value="<?= $enc->attr( $this->value( $filter, 'val/' . $idx, '' ) ); ?>" />
 					<?php endif; ?>

Please login to merge, or discard this patch.

admin/jqadm/templates/product/item-stock-standard.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -70,9 +70,12 @@
 block discarded – undo
 							v-bind:readonly="checkSite(idx)"
 							v-bind:value="item['stock.type']" >
 						</select>
-					<?php else : ?>
+					<?php else {
+	: ?>
 						<input class="item-type" type="hidden"
-							v-bind:name="'<?= $enc->attr( $this->formparam( ['stock', 'idx', 'stock.type'] ) ); ?>'.replace( 'idx', idx )"
+							v-bind:name="'<?= $enc->attr( $this->formparam( ['stock', 'idx', 'stock.type'] ) );
+}
+?>'.replace( 'idx', idx )"
 							value="<?= $enc->attr( key( $stockTypes ) ); ?>" />
 					<?php endif; ?>
 				</td>

Please login to merge, or discard this patch.

admin/jqadm/templates/attribute/item-price-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 					</th>
 					<th class="actions">
 						<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>" v-on:click="add()"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>">
 						</div>
 					</th>
 				</tr>
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
 					</td>
 					<td class="actions">
 						<div v-if="!readonly" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>" v-on:click.stop="remove(propidx)">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>" v-on:click.stop="remove(propidx)">
 						</div>
 					</td>
 				</tr>

Please login to merge, or discard this patch.

admin/jqadm/templates/attribute/item-media-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 					</th>
 					<th class="actions">
 						<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>" v-on:click="add()"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>">
 						</div>
 					</th>
 				</tr>
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
 					</td>
 					<td class="actions">
 						<div v-if="!readonly" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>" v-on:click.stop="remove(propidx)">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>" v-on:click.stop="remove(propidx)">
 						</div>
 					</td>
 				</tr>

Please login to merge, or discard this patch.

admin/jqadm/templates/service/item-price-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 					</th>
 					<th class="actions">
 						<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>" v-on:click="add()"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>">
 						</div>
 					</th>
 				</tr>
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
 					</td>
 					<td class="actions">
 						<div v-if="!readonly" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>" v-on:click.stop="remove(propidx)">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>" v-on:click.stop="remove(propidx)">
 						</div>
 					</td>
 				</tr>

Please login to merge, or discard this patch.

admin/jqadm/templates/service/item-media-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 					</th>
 					<th class="actions">
 						<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>" v-on:click="add()"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>">
 						</div>
 					</th>
 				</tr>
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
 					</td>
 					<td class="actions">
 						<div v-if="!readonly" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>" v-on:click.stop="remove(propidx)">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>" v-on:click.stop="remove(propidx)">
 						</div>
 					</td>
 				</tr>

Please login to merge, or discard this patch.

admin/jqadm/templates/product/item-price-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 					</th>
 					<th class="actions">
 						<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>" v-on:click="add()"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>">
 						</div>
 					</th>
 				</tr>
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
 					</td>
 					<td class="actions">
 						<div v-if="!readonly" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>" v-on:click.stop="remove(propidx)">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>" v-on:click.stop="remove(propidx)">
 						</div>
 					</td>
 				</tr>

Please login to merge, or discard this patch.

admin/jqadm/templates/product/item-media-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 					</th>
 					<th class="actions">
 						<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>" v-on:click="add()"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>">
 						</div>
 					</th>
 				</tr>
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
 					</td>
 					<td class="actions">
 						<div v-if="!readonly" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>" v-on:click.stop="remove(propidx)">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>" v-on:click.stop="remove(propidx)">
 						</div>
 					</td>
 				</tr>

Please login to merge, or discard this patch.

admin/jqadm/templates/supplier/item-media-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 					</th>
 					<th class="actions">
 						<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>" v-on:click="add()"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>">
 						</div>
 					</th>
 				</tr>
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
 					</td>
 					<td class="actions">
 						<div v-if="!readonly" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>" v-on:click.stop="remove(propidx)">
+							title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>" v-on:click.stop="remove(propidx)">
 						</div>
 					</td>
 				</tr>

Please login to merge, or discard this patch.

		@@ -52,8 +52,11 @@
		block discarded – undo
52	52	</option>
53	53	<?php endforeach; ?>
54	54	</select>
55		- <?php else : ?>
56		- <input class="form-control" type="<?= $enc->attr( $type ); ?>" tabindex="<?= $this->get( 'tabindex' ); ?>"
	55	+ <?php else {
	56	+ : ?>
	57	+ <input class="form-control" type="<?= $enc->attr( $type );
	58	+}
	59	+?>" tabindex="<?= $this->get( 'tabindex' ); ?>"
57	60	name="<?= $enc->attr( $this->formparam( array_merge( $group, ['filter', 'val', $idx] ) ) ); ?>"
58	61	value="<?= $enc->attr( $this->value( $filter, 'val/' . $idx, '' ) ); ?>" />
59	62	<?php endif; ?>

		@@ -70,9 +70,12 @@
		block discarded – undo
70	70	v-bind:readonly="checkSite(idx)"
71	71	v-bind:value="item['stock.type']" >
72	72	</select>
73		- <?php else : ?>
	73	+ <?php else {
	74	+ : ?>
74	75	<input class="item-type" type="hidden"
75		- v-bind:name="'<?= $enc->attr( $this->formparam( ['stock', 'idx', 'stock.type'] ) ); ?>'.replace( 'idx', idx )"
	76	+ v-bind:name="'<?= $enc->attr( $this->formparam( ['stock', 'idx', 'stock.type'] ) );
	77	+}
	78	+?>'.replace( 'idx', idx )"
76	79	value="<?= $enc->attr( key( $stockTypes ) ); ?>" />
77	80	<?php endif; ?>
78	81	</td>

		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30	</th>
31	31	<th class="actions">
32	32	<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>" v-on:click="add()"
33		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>">
	33	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>">
34	34	</div>
35	35	</th>
36	36	</tr>
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69	</td>
70	70	<td class="actions">
71	71	<div v-if="!readonly" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
72		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>" v-on:click.stop="remove(propidx)">
	72	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>" v-on:click.stop="remove(propidx)">
73	73	</div>
74	74	</td>
75	75	</tr>

aimeos / ai-admin-jqadm

Push — master ( 5b7841...744d05 )

Status

Category

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch