Inspection of "Implemented price property sub-panels" - aimeos/ai-admin-jqadm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 331f12...0643a3 )

by Aimeos

created 2019-06-14 20:47 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addPropertyItem(idx)">
 					</div>
 				</th>
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 
 				<td class="actions">
 					<div v-if="!checkSite('media.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removePropertyItem(idx, propidx)">
 					</div>
 				</td>

Please login to merge, or discard this patch.

admin/jqadm/templates/service/item-media-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addPropertyItem(idx)">
 					</div>
 				</th>
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 
 				<td class="actions">
 					<div v-if="!checkSite('media.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removePropertyItem(idx, propidx)">
 					</div>
 				</td>

Please login to merge, or discard this patch.

admin/jqadm/templates/group/item-standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -57,7 +57,7 @@
 block discarded – undo
 
 				<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
 					<li class="nav-item <?= $enc->attr( $subpart ); ?>">
-						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
+						<a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
 							<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
 						</a>
 					</li>

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -62,7 +62,7 @@
 block discarded – undo
 			throw new \Aimeos\Admin\JQAdm\Exception( sprintf( 'Invalid factory "%1$s"', $factory ) );
 		}
 
-		return $client->setAimeos( $aimeos )->setView( $view );;
+		return $client->setAimeos( $aimeos )->setView( $view ); ;
 	}
 
 }

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Product/Standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -285,7 +285,7 @@
 block discarded – undo
 			$manager = \Aimeos\MShop::create( $context, 'index' );
 
 			$search = $manager->createSearch();
-			$search->setSortations( [$search->sort( '+', 'product.id')] );
+			$search->setSortations( [$search->sort( '+', 'product.id' )] );
 			$search = $this->initCriteria( $search, $params );
 
 			$view->items = $manager->searchItems( $search, array_diff( $this->getDomains(), ['product'] ), $total );

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Attribute/Media/Standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -416,7 +416,7 @@
 block discarded – undo
 
 			if( $file && $file->getError() !== UPLOAD_ERR_NO_FILE ) {
 				$refItem = $cntl->add( $refItem, $file );
-			} elseif ( $refItem->getId() === null && $refItem->getUrl() !== '' ) {
+			} elseif( $refItem->getId() === null && $refItem->getUrl() !== '' ) {
 				$refItem = $cntl->copy( $refItem );
 			}
 

Please login to merge, or discard this patch.

admin/jqadm/templates/common/page-standard.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -214,7 +214,7 @@
 block discarded – undo
 
 									<?php foreach( $navitem as $subresource ) : ?>
 										<?php if( $this->access( $this->config( 'admin/jqadm/resource/' . $subresource . '/groups', [] ) ) ) : ?>
-											<li class="<?= str_replace( '/', '-', $subresource); ?>">
+											<li class="<?= str_replace( '/', '-', $subresource ); ?>">
 												<a href="<?= $enc->attr( $this->url( $searchTarget, $cntl, $action, ['resource' => $subresource] + $params, [], $config ) ); ?>">
 													<span class="name"><?= $enc->html( $this->translate( 'admin', $subresource ) ); ?></span>
 												</a>

Please login to merge, or discard this patch.

admin/jqadm/templates/product/item-price-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addPropertyItem(idx)">
 					</div>
 				</th>
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 
 				<td class="actions">
 					<div v-if="!checkSite('price.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removePropertyItem(idx, propidx)">
 					</div>
 				</td>

Please login to merge, or discard this patch.

admin/jqadm/templates/attribute/item-price-property-standard.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 				</th>
 				<th class="actions">
 					<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
 						v-on:click="addPropertyItem(idx)">
 					</div>
 				</th>
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 
 				<td class="actions">
 					<div v-if="!checkSite('price.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
-						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
+						title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
 						v-on:click.stop="removePropertyItem(idx, propidx)">
 					</div>
 				</td>

Please login to merge, or discard this patch.

		@@ -62,7 +62,7 @@
		block discarded – undo
62	62	throw new \Aimeos\Admin\JQAdm\Exception( sprintf( 'Invalid factory "%1$s"', $factory ) );
63	63	}
64	64
65		- return $client->setAimeos( $aimeos )->setView( $view );;
	65	+ return $client->setAimeos( $aimeos )->setView( $view ); ;
66	66	}
67	67
68	68	}

		@@ -285,7 +285,7 @@
		block discarded – undo
285	285	$manager = \Aimeos\MShop::create( $context, 'index' );
286	286
287	287	$search = $manager->createSearch();
288		- $search->setSortations( [$search->sort( '+', 'product.id')] );
	288	+ $search->setSortations( [$search->sort( '+', 'product.id' )] );
289	289	$search = $this->initCriteria( $search, $params );
290	290
291	291	$view->items = $manager->searchItems( $search, array_diff( $this->getDomains(), ['product'] ), $total );

		@@ -416,7 +416,7 @@
		block discarded – undo
416	416
417	417	if( $file && $file->getError() !== UPLOAD_ERR_NO_FILE ) {
418	418	$refItem = $cntl->add( $refItem, $file );
419		- } elseif ( $refItem->getId() === null && $refItem->getUrl() !== '' ) {
	419	+ } elseif( $refItem->getId() === null && $refItem->getUrl() !== '' ) {
420	420	$refItem = $cntl->copy( $refItem );
421	421	}
422	422

		@@ -214,7 +214,7 @@
		block discarded – undo
214	214
215	215	<?php foreach( $navitem as $subresource ) : ?>
216	216	<?php if( $this->access( $this->config( 'admin/jqadm/resource/' . $subresource . '/groups', [] ) ) ) : ?>
217		- <li class="<?= str_replace( '/', '-', $subresource); ?>">
	217	+ <li class="<?= str_replace( '/', '-', $subresource ); ?>">
218	218	<a href="<?= $enc->attr( $this->url( $searchTarget, $cntl, $action, ['resource' => $subresource] + $params, [], $config ) ); ?>">
219	219	<span class="name"><?= $enc->html( $this->translate( 'admin', $subresource ) ); ?></span>
220	220	</a>

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24	</th>
25	25	<th class="actions">
26	26	<div class="btn act-add fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
27		- title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)') ); ?>"
	27	+ title="<?= $enc->attr( $this->translate( 'admin', 'Insert new entry (Ctrl+I)' ) ); ?>"
28	28	v-on:click="addPropertyItem(idx)">
29	29	</div>
30	30	</th>
		@@ -77,7 +77,7 @@ discard block
		block discarded – undo
77	77
78	78	<td class="actions">
79	79	<div v-if="!checkSite('media.siteid', idx)" class="btn act-delete fa" tabindex="<?= $this->get( 'tabindex' ); ?>"
80		- title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry') ); ?>"
	80	+ title="<?= $enc->attr( $this->translate( 'admin', 'Delete this entry' ) ); ?>"
81	81	v-on:click.stop="removePropertyItem(idx, propidx)">
82	82	</div>
83	83	</td>

		@@ -57,7 +57,7 @@
		block discarded – undo
57	57
58	58	<?php foreach( array_values( $this->get( 'itemSubparts', [] ) ) as $idx => $subpart ) : ?>
59	59	<li class="nav-item <?= $enc->attr( $subpart ); ?>">
60		- <a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx+1; ?>">
	60	+ <a class="nav-link" href="#<?= $enc->attr( $subpart ); ?>" data-toggle="tab" role="tab" tabindex="<?= ++$idx + 1; ?>">
61	61	<?= $enc->html( $this->translate( 'admin', $subpart ) ); ?>
62	62	</a>
63	63	</li>

aimeos / ai-admin-jqadm

Push — master ( 331f12...0643a3 )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch