Inspection of "Fixed saving plugin configuration of existing item..." - aimeos/ai-admin-jqadm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6e8b10...d2a4bf )

by Aimeos

created 2018-12-24 10:06 UTC

Status

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -17,42 +17,42 @@
 block discarded – undo
 	protected function setUp()
 	{
 		$this->context = \TestHelperJqadm::getContext();
-		$this->context->setView( \TestHelperJqadm::getView() );
+		$this->context->setView(\TestHelperJqadm::getView());
 	}
 
 
 	public function testCreateClient()
 	{
-		$client = \Aimeos\Admin\JQAdm\Service\Factory::createClient( $this->context );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Service\Factory::createClient($this->context);
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientName()
 	{
-		$client = \Aimeos\Admin\JQAdm\Service\Factory::createClient( $this->context, 'Standard' );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Service\Factory::createClient($this->context, 'Standard');
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientNameEmpty()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Service\Factory::createClient( $this->context, '' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Service\Factory::createClient($this->context, '');
 	}
 
 
 	public function testCreateClientNameInvalid()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Service\Factory::createClient( $this->context, '%service' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Service\Factory::createClient($this->context, '%service');
 	}
 
 
 	public function testCreateClientNameNotFound()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Service\Factory::createClient( $this->context, 'test' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Service\Factory::createClient($this->context, 'test');
 	}
 
 }

Please login to merge, or discard this patch.

admin/jqadm/tests/Admin/JQAdm/Dashboard/FactoryTest.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -17,42 +17,42 @@
 block discarded – undo
 	protected function setUp()
 	{
 		$this->context = \TestHelperJqadm::getContext();
-		$this->context->setView( \TestHelperJqadm::getView() );
+		$this->context->setView(\TestHelperJqadm::getView());
 	}
 
 
 	public function testCreateClient()
 	{
-		$client = \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient( $this->context );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient($this->context);
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientName()
 	{
-		$client = \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient( $this->context, 'Standard' );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient($this->context, 'Standard');
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientNameEmpty()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Dashboard\Factory::createClient( $this->context, '' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Dashboard\Factory::createClient($this->context, '');
 	}
 
 
 	public function testCreateClientNameInvalid()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Dashboard\Factory::createClient( $this->context, '%dash' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Dashboard\Factory::createClient($this->context, '%dash');
 	}
 
 
 	public function testCreateClientNameNotFound()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Dashboard\Factory::createClient( $this->context, 'test' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Dashboard\Factory::createClient($this->context, 'test');
 	}
 
 }

Please login to merge, or discard this patch.

admin/jqadm/tests/Admin/JQAdm/Supplier/FactoryTest.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -17,42 +17,42 @@
 block discarded – undo
 	protected function setUp()
 	{
 		$this->context = \TestHelperJqadm::getContext();
-		$this->context->setView( \TestHelperJqadm::getView() );
+		$this->context->setView(\TestHelperJqadm::getView());
 	}
 
 
 	public function testCreateClient()
 	{
-		$client = \Aimeos\Admin\JQAdm\Supplier\Factory::createClient( $this->context );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Supplier\Factory::createClient($this->context);
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientName()
 	{
-		$client = \Aimeos\Admin\JQAdm\Supplier\Factory::createClient( $this->context, 'Standard' );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Supplier\Factory::createClient($this->context, 'Standard');
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientNameEmpty()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Supplier\Factory::createClient( $this->context, '' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Supplier\Factory::createClient($this->context, '');
 	}
 
 
 	public function testCreateClientNameInvalid()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Supplier\Factory::createClient( $this->context, '%supplier' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Supplier\Factory::createClient($this->context, '%supplier');
 	}
 
 
 	public function testCreateClientNameNotFound()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Supplier\Factory::createClient( $this->context, 'test' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Supplier\Factory::createClient($this->context, 'test');
 	}
 
 }

Please login to merge, or discard this patch.

admin/jqadm/tests/Admin/JQAdm/Catalog/FactoryTest.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -16,42 +16,42 @@
 block discarded – undo
 	protected function setUp()
 	{
 		$this->context = \TestHelperJqadm::getContext();
-		$this->context->setView( \TestHelperJqadm::getView() );
+		$this->context->setView(\TestHelperJqadm::getView());
 	}
 
 
 	public function testCreateClient()
 	{
-		$client = \Aimeos\Admin\JQAdm\Catalog\Factory::createClient( $this->context );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Catalog\Factory::createClient($this->context);
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientName()
 	{
-		$client = \Aimeos\Admin\JQAdm\Catalog\Factory::createClient( $this->context, 'Standard' );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Catalog\Factory::createClient($this->context, 'Standard');
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientNameEmpty()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Catalog\Factory::createClient( $this->context, '' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Catalog\Factory::createClient($this->context, '');
 	}
 
 
 	public function testCreateClientNameInvalid()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Catalog\Factory::createClient( $this->context, '%catalog' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Catalog\Factory::createClient($this->context, '%catalog');
 	}
 
 
 	public function testCreateClientNameNotFound()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Catalog\Factory::createClient( $this->context, 'test' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Catalog\Factory::createClient($this->context, 'test');
 	}
 
 }

Please login to merge, or discard this patch.

admin/jqadm/tests/Admin/JQAdm/Locale/FactoryTest.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -17,42 +17,42 @@
 block discarded – undo
 	protected function setUp()
 	{
 		$this->context = \TestHelperJqadm::getContext();
-		$this->context->setView( \TestHelperJqadm::getView() );
+		$this->context->setView(\TestHelperJqadm::getView());
 	}
 
 
 	public function testCreateClient()
 	{
-		$client = \Aimeos\Admin\JQAdm\Locale\Factory::createClient( $this->context );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Locale\Factory::createClient($this->context);
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientName()
 	{
-		$client = \Aimeos\Admin\JQAdm\Locale\Factory::createClient( $this->context, 'Standard' );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Locale\Factory::createClient($this->context, 'Standard');
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientNameEmpty()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Factory::createClient( $this->context, '' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Factory::createClient($this->context, '');
 	}
 
 
 	public function testCreateClientNameInvalid()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Factory::createClient( $this->context, '%locale' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Factory::createClient($this->context, '%locale');
 	}
 
 
 	public function testCreateClientNameNotFound()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Factory::createClient( $this->context, 'test' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Factory::createClient($this->context, 'test');
 	}
 
 }

Please login to merge, or discard this patch.

admin/jqadm/tests/Admin/JQAdm/Locale/Language/FactoryTest.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -17,42 +17,42 @@
 block discarded – undo
 	protected function setUp()
 	{
 		$this->context = \TestHelperJqadm::getContext();
-		$this->context->setView( \TestHelperJqadm::getView() );
+		$this->context->setView(\TestHelperJqadm::getView());
 	}
 
 
 	public function testCreateClient()
 	{
-		$client = \Aimeos\Admin\JQAdm\Locale\Language\Factory::createClient( $this->context );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Locale\Language\Factory::createClient($this->context);
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientName()
 	{
-		$client = \Aimeos\Admin\JQAdm\Locale\Language\Factory::createClient( $this->context, 'Standard' );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Locale\Language\Factory::createClient($this->context, 'Standard');
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientNameEmpty()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Language\Factory::createClient( $this->context, '' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Language\Factory::createClient($this->context, '');
 	}
 
 
 	public function testCreateClientNameInvalid()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Language\Factory::createClient( $this->context, '%locale/language' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Language\Factory::createClient($this->context, '%locale/language');
 	}
 
 
 	public function testCreateClientNameNotFound()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Language\Factory::createClient( $this->context, 'test' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Language\Factory::createClient($this->context, 'test');
 	}
 
 }

Please login to merge, or discard this patch.

admin/jqadm/tests/Admin/JQAdm/Locale/Currency/FactoryTest.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -17,42 +17,42 @@
 block discarded – undo
 	protected function setUp()
 	{
 		$this->context = \TestHelperJqadm::getContext();
-		$this->context->setView( \TestHelperJqadm::getView() );
+		$this->context->setView(\TestHelperJqadm::getView());
 	}
 
 
 	public function testCreateClient()
 	{
-		$client = \Aimeos\Admin\JQAdm\Locale\Currency\Factory::createClient( $this->context );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Locale\Currency\Factory::createClient($this->context);
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientName()
 	{
-		$client = \Aimeos\Admin\JQAdm\Locale\Currency\Factory::createClient( $this->context, 'Standard' );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Locale\Currency\Factory::createClient($this->context, 'Standard');
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientNameEmpty()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Currency\Factory::createClient( $this->context, '' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Currency\Factory::createClient($this->context, '');
 	}
 
 
 	public function testCreateClientNameInvalid()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Currency\Factory::createClient( $this->context, '%locale/currency' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Currency\Factory::createClient($this->context, '%locale/currency');
 	}
 
 
 	public function testCreateClientNameNotFound()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Currency\Factory::createClient( $this->context, 'test' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Currency\Factory::createClient($this->context, 'test');
 	}
 
 }

Please login to merge, or discard this patch.

admin/jqadm/tests/Admin/JQAdm/Locale/Site/FactoryTest.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -17,42 +17,42 @@
 block discarded – undo
 	protected function setUp()
 	{
 		$this->context = \TestHelperJqadm::getContext();
-		$this->context->setView( \TestHelperJqadm::getView() );
+		$this->context->setView(\TestHelperJqadm::getView());
 	}
 
 
 	public function testCreateClient()
 	{
-		$client = \Aimeos\Admin\JQAdm\Locale\Site\Factory::createClient( $this->context );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Locale\Site\Factory::createClient($this->context);
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientName()
 	{
-		$client = \Aimeos\Admin\JQAdm\Locale\Site\Factory::createClient( $this->context, 'Standard' );
-		$this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
+		$client = \Aimeos\Admin\JQAdm\Locale\Site\Factory::createClient($this->context, 'Standard');
+		$this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
 	}
 
 
 	public function testCreateClientNameEmpty()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Site\Factory::createClient( $this->context, '' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Site\Factory::createClient($this->context, '');
 	}
 
 
 	public function testCreateClientNameInvalid()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Site\Factory::createClient( $this->context, '%locale/site' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Site\Factory::createClient($this->context, '%locale/site');
 	}
 
 
 	public function testCreateClientNameNotFound()
 	{
-		$this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
-		\Aimeos\Admin\JQAdm\Locale\Site\Factory::createClient( $this->context, 'test' );
+		$this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
+		\Aimeos\Admin\JQAdm\Locale\Site\Factory::createClient($this->context, 'test');
 	}
 
 }

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Order/Factory.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 	 * @return \Aimeos\Admin\JQAdm\Iface Filter part implementing \Aimeos\Admin\JQAdm\Iface
 	 * @throws \Aimeos\Admin\JQAdm\Exception If requested client implementation couldn't be found or initialisation fails
 	 */
-	public static function createClient( \Aimeos\MShop\Context\Item\Iface $context, $name = null )
+	public static function createClient(\Aimeos\MShop\Context\Item\Iface $context, $name = null)
 	{
 		/** admin/jqadm/order/name
 		 * Class name of the used account favorite client implementation
@@ -64,22 +64,22 @@  discard block
 block discarded – undo
 		 * @since 2016.01
 		 * @category Developer
 		 */
-		if( $name === null ) {
-			$name = $context->getConfig()->get( 'admin/jqadm/order/name', 'Standard' );
+		if ($name === null) {
+			$name = $context->getConfig()->get('admin/jqadm/order/name', 'Standard');
 		}
 
-		if( ctype_alnum( $name ) === false )
+		if (ctype_alnum($name) === false)
 		{
-			$classname = is_string( $name ) ? '\\Aimeos\\Admin\\JQAdm\\Order\\' . $name : '<not a string>';
-			throw new \Aimeos\Admin\JQAdm\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
+			$classname = is_string($name) ? '\\Aimeos\\Admin\\JQAdm\\Order\\' . $name : '<not a string>';
+			throw new \Aimeos\Admin\JQAdm\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
 		}
 
 		$iface = '\\Aimeos\\Admin\\JQAdm\\Iface';
 		$classname = '\\Aimeos\\Admin\\JQAdm\\Order\\' . $name;
 
-		$client = self::createClientBase( $context, $classname, $iface );
+		$client = self::createClientBase($context, $classname, $iface);
 
-		return self::addClientDecorators( $context, $client, 'order' );
+		return self::addClientDecorators($context, $client, 'order');
 	}
 
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -17,42 +17,42 @@
		block discarded – undo
17	17	protected function setUp()
18	18	{
19	19	$this->context = \TestHelperJqadm::getContext();
20		- $this->context->setView( \TestHelperJqadm::getView() );
	20	+ $this->context->setView(\TestHelperJqadm::getView());
21	21	}
22	22
23	23
24	24	public function testCreateClient()
25	25	{
26		- $client = \Aimeos\Admin\JQAdm\Service\Factory::createClient( $this->context );
27		- $this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
	26	+ $client = \Aimeos\Admin\JQAdm\Service\Factory::createClient($this->context);
	27	+ $this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
28	28	}
29	29
30	30
31	31	public function testCreateClientName()
32	32	{
33		- $client = \Aimeos\Admin\JQAdm\Service\Factory::createClient( $this->context, 'Standard' );
34		- $this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
	33	+ $client = \Aimeos\Admin\JQAdm\Service\Factory::createClient($this->context, 'Standard');
	34	+ $this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
35	35	}
36	36
37	37
38	38	public function testCreateClientNameEmpty()
39	39	{
40		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
41		- \Aimeos\Admin\JQAdm\Service\Factory::createClient( $this->context, '' );
	40	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	41	+ \Aimeos\Admin\JQAdm\Service\Factory::createClient($this->context, '');
42	42	}
43	43
44	44
45	45	public function testCreateClientNameInvalid()
46	46	{
47		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
48		- \Aimeos\Admin\JQAdm\Service\Factory::createClient( $this->context, '%service' );
	47	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	48	+ \Aimeos\Admin\JQAdm\Service\Factory::createClient($this->context, '%service');
49	49	}
50	50
51	51
52	52	public function testCreateClientNameNotFound()
53	53	{
54		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
55		- \Aimeos\Admin\JQAdm\Service\Factory::createClient( $this->context, 'test' );
	54	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	55	+ \Aimeos\Admin\JQAdm\Service\Factory::createClient($this->context, 'test');
56	56	}
57	57
58	58	}

		@@ -17,42 +17,42 @@
		block discarded – undo
17	17	protected function setUp()
18	18	{
19	19	$this->context = \TestHelperJqadm::getContext();
20		- $this->context->setView( \TestHelperJqadm::getView() );
	20	+ $this->context->setView(\TestHelperJqadm::getView());
21	21	}
22	22
23	23
24	24	public function testCreateClient()
25	25	{
26		- $client = \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient( $this->context );
27		- $this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
	26	+ $client = \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient($this->context);
	27	+ $this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
28	28	}
29	29
30	30
31	31	public function testCreateClientName()
32	32	{
33		- $client = \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient( $this->context, 'Standard' );
34		- $this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
	33	+ $client = \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient($this->context, 'Standard');
	34	+ $this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
35	35	}
36	36
37	37
38	38	public function testCreateClientNameEmpty()
39	39	{
40		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
41		- \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient( $this->context, '' );
	40	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	41	+ \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient($this->context, '');
42	42	}
43	43
44	44
45	45	public function testCreateClientNameInvalid()
46	46	{
47		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
48		- \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient( $this->context, '%dash' );
	47	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	48	+ \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient($this->context, '%dash');
49	49	}
50	50
51	51
52	52	public function testCreateClientNameNotFound()
53	53	{
54		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
55		- \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient( $this->context, 'test' );
	54	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	55	+ \Aimeos\Admin\JQAdm\Dashboard\Factory::createClient($this->context, 'test');
56	56	}
57	57
58	58	}

		@@ -17,42 +17,42 @@
		block discarded – undo
17	17	protected function setUp()
18	18	{
19	19	$this->context = \TestHelperJqadm::getContext();
20		- $this->context->setView( \TestHelperJqadm::getView() );
	20	+ $this->context->setView(\TestHelperJqadm::getView());
21	21	}
22	22
23	23
24	24	public function testCreateClient()
25	25	{
26		- $client = \Aimeos\Admin\JQAdm\Supplier\Factory::createClient( $this->context );
27		- $this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
	26	+ $client = \Aimeos\Admin\JQAdm\Supplier\Factory::createClient($this->context);
	27	+ $this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
28	28	}
29	29
30	30
31	31	public function testCreateClientName()
32	32	{
33		- $client = \Aimeos\Admin\JQAdm\Supplier\Factory::createClient( $this->context, 'Standard' );
34		- $this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
	33	+ $client = \Aimeos\Admin\JQAdm\Supplier\Factory::createClient($this->context, 'Standard');
	34	+ $this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
35	35	}
36	36
37	37
38	38	public function testCreateClientNameEmpty()
39	39	{
40		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
41		- \Aimeos\Admin\JQAdm\Supplier\Factory::createClient( $this->context, '' );
	40	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	41	+ \Aimeos\Admin\JQAdm\Supplier\Factory::createClient($this->context, '');
42	42	}
43	43
44	44
45	45	public function testCreateClientNameInvalid()
46	46	{
47		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
48		- \Aimeos\Admin\JQAdm\Supplier\Factory::createClient( $this->context, '%supplier' );
	47	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	48	+ \Aimeos\Admin\JQAdm\Supplier\Factory::createClient($this->context, '%supplier');
49	49	}
50	50
51	51
52	52	public function testCreateClientNameNotFound()
53	53	{
54		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
55		- \Aimeos\Admin\JQAdm\Supplier\Factory::createClient( $this->context, 'test' );
	54	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	55	+ \Aimeos\Admin\JQAdm\Supplier\Factory::createClient($this->context, 'test');
56	56	}
57	57
58	58	}

		@@ -16,42 +16,42 @@
		block discarded – undo
16	16	protected function setUp()
17	17	{
18	18	$this->context = \TestHelperJqadm::getContext();
19		- $this->context->setView( \TestHelperJqadm::getView() );
	19	+ $this->context->setView(\TestHelperJqadm::getView());
20	20	}
21	21
22	22
23	23	public function testCreateClient()
24	24	{
25		- $client = \Aimeos\Admin\JQAdm\Catalog\Factory::createClient( $this->context );
26		- $this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
	25	+ $client = \Aimeos\Admin\JQAdm\Catalog\Factory::createClient($this->context);
	26	+ $this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
27	27	}
28	28
29	29
30	30	public function testCreateClientName()
31	31	{
32		- $client = \Aimeos\Admin\JQAdm\Catalog\Factory::createClient( $this->context, 'Standard' );
33		- $this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
	32	+ $client = \Aimeos\Admin\JQAdm\Catalog\Factory::createClient($this->context, 'Standard');
	33	+ $this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
34	34	}
35	35
36	36
37	37	public function testCreateClientNameEmpty()
38	38	{
39		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
40		- \Aimeos\Admin\JQAdm\Catalog\Factory::createClient( $this->context, '' );
	39	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	40	+ \Aimeos\Admin\JQAdm\Catalog\Factory::createClient($this->context, '');
41	41	}
42	42
43	43
44	44	public function testCreateClientNameInvalid()
45	45	{
46		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
47		- \Aimeos\Admin\JQAdm\Catalog\Factory::createClient( $this->context, '%catalog' );
	46	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	47	+ \Aimeos\Admin\JQAdm\Catalog\Factory::createClient($this->context, '%catalog');
48	48	}
49	49
50	50
51	51	public function testCreateClientNameNotFound()
52	52	{
53		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
54		- \Aimeos\Admin\JQAdm\Catalog\Factory::createClient( $this->context, 'test' );
	53	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	54	+ \Aimeos\Admin\JQAdm\Catalog\Factory::createClient($this->context, 'test');
55	55	}
56	56
57	57	}

		@@ -17,42 +17,42 @@
		block discarded – undo
17	17	protected function setUp()
18	18	{
19	19	$this->context = \TestHelperJqadm::getContext();
20		- $this->context->setView( \TestHelperJqadm::getView() );
	20	+ $this->context->setView(\TestHelperJqadm::getView());
21	21	}
22	22
23	23
24	24	public function testCreateClient()
25	25	{
26		- $client = \Aimeos\Admin\JQAdm\Locale\Factory::createClient( $this->context );
27		- $this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
	26	+ $client = \Aimeos\Admin\JQAdm\Locale\Factory::createClient($this->context);
	27	+ $this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
28	28	}
29	29
30	30
31	31	public function testCreateClientName()
32	32	{
33		- $client = \Aimeos\Admin\JQAdm\Locale\Factory::createClient( $this->context, 'Standard' );
34		- $this->assertInstanceOf( '\\Aimeos\\Admin\\JQAdm\\Iface', $client );
	33	+ $client = \Aimeos\Admin\JQAdm\Locale\Factory::createClient($this->context, 'Standard');
	34	+ $this->assertInstanceOf('\\Aimeos\\Admin\\JQAdm\\Iface', $client);
35	35	}
36	36
37	37
38	38	public function testCreateClientNameEmpty()
39	39	{
40		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
41		- \Aimeos\Admin\JQAdm\Locale\Factory::createClient( $this->context, '' );
	40	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	41	+ \Aimeos\Admin\JQAdm\Locale\Factory::createClient($this->context, '');
42	42	}
43	43
44	44
45	45	public function testCreateClientNameInvalid()
46	46	{
47		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
48		- \Aimeos\Admin\JQAdm\Locale\Factory::createClient( $this->context, '%locale' );
	47	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	48	+ \Aimeos\Admin\JQAdm\Locale\Factory::createClient($this->context, '%locale');
49	49	}
50	50
51	51
52	52	public function testCreateClientNameNotFound()
53	53	{
54		- $this->setExpectedException( '\\Aimeos\\Admin\\JQAdm\\Exception' );
55		- \Aimeos\Admin\JQAdm\Locale\Factory::createClient( $this->context, 'test' );
	54	+ $this->setExpectedException('\\Aimeos\\Admin\\JQAdm\\Exception');
	55	+ \Aimeos\Admin\JQAdm\Locale\Factory::createClient($this->context, 'test');
56	56	}
57	57
58	58	}

		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29	* @return \Aimeos\Admin\JQAdm\Iface Filter part implementing \Aimeos\Admin\JQAdm\Iface
30	30	* @throws \Aimeos\Admin\JQAdm\Exception If requested client implementation couldn't be found or initialisation fails
31	31	*/
32		- public static function createClient( \Aimeos\MShop\Context\Item\Iface $context, $name = null )
	32	+ public static function createClient(\Aimeos\MShop\Context\Item\Iface $context, $name = null)
33	33	{
34	34	/** admin/jqadm/order/name
35	35	* Class name of the used account favorite client implementation
		@@ -64,22 +64,22 @@ discard block
		block discarded – undo
64	64	* @since 2016.01
65	65	* @category Developer
66	66	*/
67		- if( $name === null ) {
68		- $name = $context->getConfig()->get( 'admin/jqadm/order/name', 'Standard' );
	67	+ if ($name === null) {
	68	+ $name = $context->getConfig()->get('admin/jqadm/order/name', 'Standard');
69	69	}
70	70
71		- if( ctype_alnum( $name ) === false )
	71	+ if (ctype_alnum($name) === false)
72	72	{
73		- $classname = is_string( $name ) ? '\\Aimeos\\Admin\\JQAdm\\Order\\' . $name : '<not a string>';
74		- throw new \Aimeos\Admin\JQAdm\Exception( sprintf( 'Invalid characters in class name "%1$s"', $classname ) );
	73	+ $classname = is_string($name) ? '\\Aimeos\\Admin\\JQAdm\\Order\\' . $name : '<not a string>';
	74	+ throw new \Aimeos\Admin\JQAdm\Exception(sprintf('Invalid characters in class name "%1$s"', $classname));
75	75	}
76	76
77	77	$iface = '\\Aimeos\\Admin\\JQAdm\\Iface';
78	78	$classname = '\\Aimeos\\Admin\\JQAdm\\Order\\' . $name;
79	79
80		- $client = self::createClientBase( $context, $classname, $iface );
	80	+ $client = self::createClientBase($context, $classname, $iface);
81	81
82		- return self::addClientDecorators( $context, $client, 'order' );
	82	+ return self::addClientDecorators($context, $client, 'order');
83	83	}
84	84
85	85	}
86	86	\ No newline at end of file

aimeos / ai-admin-jqadm

Push — master ( 6e8b10...d2a4bf )

Status

Category

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch