Inspection of "Fixed duplicate config lines in plugin panel" - aimeos/ai-admin-jqadm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0229de...f71bfb )

by Aimeos

created 2019-01-17 14:36 UTC

Status

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -145,14 +145,12 @@
 block discarded – undo
 			}
 
 			return;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'catalog-item-media' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'catalog-item-media' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Catalog/Product/Standard.php 1 patch

Braces +8 added lines, -16 removed lines patch added patch discarded remove patch

@@ -52,14 +52,12 @@  discard block
 block discarded – undo
 			foreach( $this->getSubClients() as $client ) {
 				$view->productBody .= $client->copy();
 			}
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'catalog-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'catalog-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;
@@ -87,14 +85,12 @@  discard block
 block discarded – undo
 			foreach( $this->getSubClients() as $client ) {
 				$view->productBody .= $client->create();
 			}
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'catalog-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'catalog-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;
@@ -129,14 +125,12 @@  discard block
 block discarded – undo
 			foreach( $this->getSubClients() as $client ) {
 				$view->productBody .= $client->get();
 			}
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'catalog-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'catalog-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;
@@ -171,14 +165,12 @@  discard block
 block discarded – undo
 
 			$manager->commit();
 			return;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'catalog-item-media' => $context->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'catalog-item-media' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Service/Media/Property/Standard.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -291,8 +291,7 @@
 block discarded – undo
 				{
 					$propItem = $propItems[$entry['media.property.id']];
 					unset( $propItems[$entry['media.property.id']] );
-				}
-				else
+				} else
 				{
 					$propItem = $propManager->createItem();
 				}

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Service/Media/Standard.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -145,14 +145,12 @@
 block discarded – undo
 			}
 
 			return;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'service-item-media' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'service-item-media' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Customer/Product/Standard.php 1 patch

Braces +8 added lines, -16 removed lines patch added patch discarded remove patch

@@ -52,14 +52,12 @@  discard block
 block discarded – undo
 			foreach( $this->getSubClients() as $client ) {
 				$view->productBody .= $client->copy();
 			}
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'customer-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'customer-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;
@@ -87,14 +85,12 @@  discard block
 block discarded – undo
 			foreach( $this->getSubClients() as $client ) {
 				$view->productBody .= $client->create();
 			}
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'customer-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'customer-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;
@@ -129,14 +125,12 @@  discard block
 block discarded – undo
 			foreach( $this->getSubClients() as $client ) {
 				$view->productBody .= $client->search();
 			}
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'customer-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'customer-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;
@@ -171,14 +165,12 @@  discard block
 block discarded – undo
 
 			$manager->commit();
 			return;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'customer-item-media' => $context->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'customer-item-media' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Supplier/Media/Property/Standard.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -291,8 +291,7 @@
 block discarded – undo
 				{
 					$propItem = $propItems[$entry['media.property.id']];
 					unset( $propItems[$entry['media.property.id']] );
-				}
-				else
+				} else
 				{
 					$propItem = $propManager->createItem();
 				}

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Supplier/Media/Standard.php 1 patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -145,14 +145,12 @@
 block discarded – undo
 			}
 
 			return;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'supplier-item-media' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'supplier-item-media' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Supplier/Product/Standard.php 1 patch

Braces +8 added lines, -16 removed lines patch added patch discarded remove patch

@@ -52,14 +52,12 @@  discard block
 block discarded – undo
 			foreach( $this->getSubClients() as $client ) {
 				$view->productBody .= $client->copy();
 			}
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'supplier-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'supplier-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;
@@ -87,14 +85,12 @@  discard block
 block discarded – undo
 			foreach( $this->getSubClients() as $client ) {
 				$view->productBody .= $client->create();
 			}
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'supplier-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'supplier-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;
@@ -129,14 +125,12 @@  discard block
 block discarded – undo
 			foreach( $this->getSubClients() as $client ) {
 				$view->productBody .= $client->search();
 			}
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'supplier-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'supplier-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;
@@ -171,14 +165,12 @@  discard block
 block discarded – undo
 
 			$manager->commit();
 			return;
-		}
-		catch( \Aimeos\MShop\Exception $e )
+		} catch( \Aimeos\MShop\Exception $e )
 		{
 			$error = array( 'supplier-item-media' => $context->getI18n()->dt( 'mshop', $e->getMessage() ) );
 			$view->errors = $view->get( 'errors', [] ) + $error;
 			$this->logException( $e );
-		}
-		catch( \Exception $e )
+		} catch( \Exception $e )
 		{
 			$error = array( 'supplier-item-media' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
 			$view->errors = $view->get( 'errors', [] ) + $error;

Please login to merge, or discard this patch.

admin/jqadm/src/Admin/JQAdm/Product/Media/Property/Standard.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -291,8 +291,7 @@
 block discarded – undo
 				{
 					$propItem = $propItems[$entry['media.property.id']];
 					unset( $propItems[$entry['media.property.id']] );
-				}
-				else
+				} else
 				{
 					$propItem = $propManager->createItem();
 				}

Please login to merge, or discard this patch.

		@@ -145,14 +145,12 @@
		block discarded – undo
145	145	}
146	146
147	147	return;
148		- }
149		- catch( \Aimeos\MShop\Exception $e )
	148	+ } catch( \Aimeos\MShop\Exception $e )
150	149	{
151	150	$error = array( 'catalog-item-media' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
152	151	$view->errors = $view->get( 'errors', [] ) + $error;
153	152	$this->logException( $e );
154		- }
155		- catch( \Exception $e )
	153	+ } catch( \Exception $e )
156	154	{
157	155	$error = array( 'catalog-item-media' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
158	156	$view->errors = $view->get( 'errors', [] ) + $error;

		@@ -52,14 +52,12 @@ discard block
		block discarded – undo
52	52	foreach( $this->getSubClients() as $client ) {
53	53	$view->productBody .= $client->copy();
54	54	}
55		- }
56		- catch( \Aimeos\MShop\Exception $e )
	55	+ } catch( \Aimeos\MShop\Exception $e )
57	56	{
58	57	$error = array( 'catalog-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
59	58	$view->errors = $view->get( 'errors', [] ) + $error;
60	59	$this->logException( $e );
61		- }
62		- catch( \Exception $e )
	60	+ } catch( \Exception $e )
63	61	{
64	62	$error = array( 'catalog-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
65	63	$view->errors = $view->get( 'errors', [] ) + $error;
		@@ -87,14 +85,12 @@ discard block
		block discarded – undo
87	85	foreach( $this->getSubClients() as $client ) {
88	86	$view->productBody .= $client->create();
89	87	}
90		- }
91		- catch( \Aimeos\MShop\Exception $e )
	88	+ } catch( \Aimeos\MShop\Exception $e )
92	89	{
93	90	$error = array( 'catalog-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
94	91	$view->errors = $view->get( 'errors', [] ) + $error;
95	92	$this->logException( $e );
96		- }
97		- catch( \Exception $e )
	93	+ } catch( \Exception $e )
98	94	{
99	95	$error = array( 'catalog-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
100	96	$view->errors = $view->get( 'errors', [] ) + $error;
		@@ -129,14 +125,12 @@ discard block
		block discarded – undo
129	125	foreach( $this->getSubClients() as $client ) {
130	126	$view->productBody .= $client->get();
131	127	}
132		- }
133		- catch( \Aimeos\MShop\Exception $e )
	128	+ } catch( \Aimeos\MShop\Exception $e )
134	129	{
135	130	$error = array( 'catalog-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
136	131	$view->errors = $view->get( 'errors', [] ) + $error;
137	132	$this->logException( $e );
138		- }
139		- catch( \Exception $e )
	133	+ } catch( \Exception $e )
140	134	{
141	135	$error = array( 'catalog-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
142	136	$view->errors = $view->get( 'errors', [] ) + $error;
		@@ -171,14 +165,12 @@ discard block
		block discarded – undo
171	165
172	166	$manager->commit();
173	167	return;
174		- }
175		- catch( \Aimeos\MShop\Exception $e )
	168	+ } catch( \Aimeos\MShop\Exception $e )
176	169	{
177	170	$error = array( 'catalog-item-media' => $context->getI18n()->dt( 'mshop', $e->getMessage() ) );
178	171	$view->errors = $view->get( 'errors', [] ) + $error;
179	172	$this->logException( $e );
180		- }
181		- catch( \Exception $e )
	173	+ } catch( \Exception $e )
182	174	{
183	175	$error = array( 'catalog-item-media' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
184	176	$view->errors = $view->get( 'errors', [] ) + $error;

		@@ -291,8 +291,7 @@
		block discarded – undo
291	291	{
292	292	$propItem = $propItems[$entry['media.property.id']];
293	293	unset( $propItems[$entry['media.property.id']] );
294		- }
295		- else
	294	+ } else
296	295	{
297	296	$propItem = $propManager->createItem();
298	297	}

		@@ -145,14 +145,12 @@
		block discarded – undo
145	145	}
146	146
147	147	return;
148		- }
149		- catch( \Aimeos\MShop\Exception $e )
	148	+ } catch( \Aimeos\MShop\Exception $e )
150	149	{
151	150	$error = array( 'service-item-media' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
152	151	$view->errors = $view->get( 'errors', [] ) + $error;
153	152	$this->logException( $e );
154		- }
155		- catch( \Exception $e )
	153	+ } catch( \Exception $e )
156	154	{
157	155	$error = array( 'service-item-media' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
158	156	$view->errors = $view->get( 'errors', [] ) + $error;

		@@ -52,14 +52,12 @@ discard block
		block discarded – undo
52	52	foreach( $this->getSubClients() as $client ) {
53	53	$view->productBody .= $client->copy();
54	54	}
55		- }
56		- catch( \Aimeos\MShop\Exception $e )
	55	+ } catch( \Aimeos\MShop\Exception $e )
57	56	{
58	57	$error = array( 'customer-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
59	58	$view->errors = $view->get( 'errors', [] ) + $error;
60	59	$this->logException( $e );
61		- }
62		- catch( \Exception $e )
	60	+ } catch( \Exception $e )
63	61	{
64	62	$error = array( 'customer-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
65	63	$view->errors = $view->get( 'errors', [] ) + $error;
		@@ -87,14 +85,12 @@ discard block
		block discarded – undo
87	85	foreach( $this->getSubClients() as $client ) {
88	86	$view->productBody .= $client->create();
89	87	}
90		- }
91		- catch( \Aimeos\MShop\Exception $e )
	88	+ } catch( \Aimeos\MShop\Exception $e )
92	89	{
93	90	$error = array( 'customer-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
94	91	$view->errors = $view->get( 'errors', [] ) + $error;
95	92	$this->logException( $e );
96		- }
97		- catch( \Exception $e )
	93	+ } catch( \Exception $e )
98	94	{
99	95	$error = array( 'customer-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
100	96	$view->errors = $view->get( 'errors', [] ) + $error;
		@@ -129,14 +125,12 @@ discard block
		block discarded – undo
129	125	foreach( $this->getSubClients() as $client ) {
130	126	$view->productBody .= $client->search();
131	127	}
132		- }
133		- catch( \Aimeos\MShop\Exception $e )
	128	+ } catch( \Aimeos\MShop\Exception $e )
134	129	{
135	130	$error = array( 'customer-product' => $this->getContext()->getI18n()->dt( 'mshop', $e->getMessage() ) );
136	131	$view->errors = $view->get( 'errors', [] ) + $error;
137	132	$this->logException( $e );
138		- }
139		- catch( \Exception $e )
	133	+ } catch( \Exception $e )
140	134	{
141	135	$error = array( 'customer-product' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
142	136	$view->errors = $view->get( 'errors', [] ) + $error;
		@@ -171,14 +165,12 @@ discard block
		block discarded – undo
171	165
172	166	$manager->commit();
173	167	return;
174		- }
175		- catch( \Aimeos\MShop\Exception $e )
	168	+ } catch( \Aimeos\MShop\Exception $e )
176	169	{
177	170	$error = array( 'customer-item-media' => $context->getI18n()->dt( 'mshop', $e->getMessage() ) );
178	171	$view->errors = $view->get( 'errors', [] ) + $error;
179	172	$this->logException( $e );
180		- }
181		- catch( \Exception $e )
	173	+ } catch( \Exception $e )
182	174	{
183	175	$error = array( 'customer-item-media' => $e->getMessage() . ', ' . $e->getFile() . ':' . $e->getLine() );
184	176	$view->errors = $view->get( 'errors', [] ) + $error;

aimeos / ai-admin-jqadm

Push — master ( 0229de...f71bfb )

Status

Category

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +8 added lines, -16 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +8 added lines, -16 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Braces +8 added lines, -16 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch