| Conditions | 1 |
| Paths | 1 |
| Total Lines | 115 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 48 | public function getErrorList($testFile) |
||
| 49 | { |
||
| 50 | $errors = array( |
||
| 51 | 11 => 1, |
||
| 52 | 12 => 1, |
||
| 53 | 13 => 1, |
||
| 54 | 14 => 1, |
||
| 55 | 15 => 1, |
||
| 56 | 16 => 1, |
||
| 57 | 17 => 1, |
||
| 58 | 18 => 1, |
||
| 59 | 19 => 1, |
||
| 60 | 20 => 1, |
||
| 61 | 24 => 1, |
||
| 62 | 25 => 1, |
||
| 63 | 26 => 1, |
||
| 64 | 27 => 1, |
||
| 65 | 28 => 1, |
||
| 66 | 29 => 1, |
||
| 67 | 30 => 1, |
||
| 68 | 31 => 1, |
||
| 69 | 32 => 1, |
||
| 70 | 33 => 1, |
||
| 71 | 35 => 1, |
||
| 72 | 36 => 1, |
||
| 73 | 37 => 1, |
||
| 74 | 38 => 1, |
||
| 75 | 39 => 1, |
||
| 76 | 40 => 1, |
||
| 77 | 43 => 1, |
||
| 78 | 44 => 1, |
||
| 79 | 45 => 1, |
||
| 80 | 46 => 1, |
||
| 81 | 50 => 1, |
||
| 82 | 51 => 1, |
||
| 83 | 52 => 1, |
||
| 84 | 53 => 1, |
||
| 85 | 56 => 1, |
||
| 86 | 57 => 1, |
||
| 87 | 58 => 1, |
||
| 88 | 59 => 1, |
||
| 89 | 67 => 1, |
||
| 90 | 68 => 1, |
||
| 91 | 69 => 1, |
||
| 92 | 70 => 1, |
||
| 93 | 71 => 1, |
||
| 94 | 72 => 1, |
||
| 95 | 73 => 1, |
||
| 96 | 74 => 1, |
||
| 97 | 75 => 1, |
||
| 98 | 76 => 1, |
||
| 99 | 80 => 1, |
||
| 100 | 81 => 1, |
||
| 101 | 82 => 1, |
||
| 102 | 83 => 1, |
||
| 103 | 84 => 1, |
||
| 104 | 85 => 1, |
||
| 105 | 86 => 1, |
||
| 106 | 87 => 1, |
||
| 107 | 88 => 1, |
||
| 108 | 89 => 1, |
||
| 109 | 91 => 1, |
||
| 110 | 92 => 1, |
||
| 111 | 93 => 1, |
||
| 112 | 94 => 1, |
||
| 113 | 95 => 1, |
||
| 114 | 96 => 1, |
||
| 115 | 99 => 1, |
||
| 116 | 100 => 1, |
||
| 117 | 101 => 1, |
||
| 118 | 102 => 1, |
||
| 119 | 106 => 1, |
||
| 120 | 107 => 1, |
||
| 121 | 108 => 1, |
||
| 122 | 109 => 1, |
||
| 123 | 112 => 1, |
||
| 124 | 113 => 1, |
||
| 125 | 114 => 1, |
||
| 126 | 115 => 1, |
||
| 127 | 121 => 1, |
||
| 128 | 122 => 1, |
||
| 129 | 123 => 1, |
||
| 130 | 124 => 1, |
||
| 131 | 125 => 1, |
||
| 132 | 126 => 1, |
||
| 133 | 127 => 2, |
||
| 134 | 128 => 2, |
||
| 135 | 129 => 2, |
||
| 136 | 130 => 2, |
||
| 137 | 149 => 1, |
||
| 138 | 151 => 1, |
||
| 139 | 152 => 1, |
||
| 140 | 155 => 1, |
||
| 141 | 156 => 1, |
||
| 142 | 157 => 1, |
||
| 143 | 158 => 1, |
||
| 144 | 159 => 1, |
||
| 145 | 160 => 1, |
||
| 146 | 161 => 1, |
||
| 147 | 162 => 1, |
||
| 148 | 163 => 1, |
||
| 149 | 164 => 1, |
||
| 150 | 165 => 1, |
||
| 151 | 166 => 3, |
||
| 152 | 167 => 1, |
||
| 153 | 169 => 1, |
||
| 154 | 170 => 1, |
||
| 155 | 171 => 3, |
||
| 156 | 173 => 2, |
||
| 157 | 174 => 1, |
||
| 158 | 175 => 1, |
||
| 159 | ); |
||
| 160 | |||
| 161 | return $errors; |
||
| 162 | }//end getErrorList() |
||
| 163 | |||
| 180 |