Test::incorrectFunction() - Code Metrics - Inspection of "Minor code reorganization" - aik099/CodingStandard - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( c7ef78...c451af )

by Alexander

created 2016-05-15 11:52 UTC

Test::incorrectFunction() A

↳ Parent: Test

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
cc	1
eloc	7
c	2
b	0
f	1
nc	1
nop	1
dl	0
loc	10
rs	9.4285

<?php
class Test {

    function correctFunction($param) {

        echo 'ok';
        parent::correctFunction();
        echo 'test';
    }

    function incorrectFunction($param) {

        echo 'ok';
        parent::correctFunction();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        echo 'test';

        $fields['UserType']['options'] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            CustomUserType::PARENT => 'lc_opt_UserTypeParent',
            CustomUserType::CAREGIVER => 'lc_opt_UserTypeCaregiver',
        );
    }

}


1			<?php
2			class Test {
3
4			function correctFunction($param) {
			0 ignored issues – show Unused Code introduced 2016-05-15 11:54 UTC by Report Bug Copy Issue Report The parameter `$param` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Best Practice introduced 2016-05-15 11:54 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
5			echo 'ok';
6			parent::correctFunction();
7			echo 'test';
8			}
9
10			function incorrectFunction($param) {
			0 ignored issues – show Unused Code introduced 2016-05-15 11:54 UTC by Report Bug Copy Issue Report The parameter `$param` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Best Practice introduced 2016-05-15 11:54 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
11			echo 'ok';
12			parent::correctFunction();
			0 ignored issues – show Comprehensibility Bug introduced 2016-05-15 11:54 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`correctFunction()` instead of `incorrectFunction()`). Are you sure this is correct? If so, you might want to change this to `$this->correctFunction()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
13			echo 'test';
14
15			$fields['UserType']['options'] = array(
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-15 11:54 UTC by Report Bug Copy Issue Report `$fields` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$fields = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
16			CustomUserType::PARENT => 'lc_opt_UserTypeParent',
17			CustomUserType::CAREGIVER => 'lc_opt_UserTypeCaregiver',
18			);
19			}
20
21			}
22

aik099 / CodingStandard

Push — master ( c7ef78...c451af )

Test::incorrectFunction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like