Lepton\Helpers\Functions::getDeclarationLine()

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
static function getDeclarationLine(\ReflectionProperty $prop){

It is generally recommended to explicitly declare the visibility for methods.

  $declaringClass = $prop->getDeclaringClass();
  $propname = $prop->getName();
  $classFile      = new \SplFileObject($declaringClass->getFileName());
  foreach ($classFile as $line => $content) {
      if (preg_match(
          '/
              (private|protected|public|var|static) # match visibility or var
              \s                             # followed 1 whitespace
              \$'.$propname.'                          # followed by the var name $bar
          /x',
          $content)

It seems like $content can also be of type array; however, parameter $subject of preg_match() does only seem to accept string, maybe add an additional type check?

      ) {
          return $line + 1;
      }
  }
  return 1;
}