ahnames\hipanel\tests\acceptance\module\finance\manager\CertificateCrudCest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	40
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	ensureThatICanCreateTariffPlan()	12	12	1
A	ensureThatICanAddPrices()	8	8	1
A	ensureICanUpdatePrices()	5	5	1

<?php

namespace ahnames\hipanel\tests\acceptance\module\finance\manager;

use hipanel\helpers\Url;
use hipanel\modules\finance\tests\_support\Page\plan\Create as PlanCreatePage;
use hipanel\modules\finance\tests\_support\Page\price\certificate\Create as PriceCertificateCreate;
use hipanel\modules\finance\tests\_support\Page\price\certificate\Update as PriceCertificateUpdate;
use hipanel\tests\_support\Step\Acceptance\Manager;

class CertificateCrudCest

This class seems to be duplicated in your project.

{
    /**
     * @var string
     */
    private $id;

    /**
     * @var array
     */
    private $fields;

    public function ensureThatICanCreateTariffPlan(Manager $I): void
    {
        $this->fields = [
            'name' => uniqid(),
            'type' => 'Certificate tariff',
            'client' => 'hipanel_test_manager@hiqdev.com',
            'currency' => 'USD',
            'note' => 'test note',
        ];
        $page = new PlanCreatePage($I, $this->fields);
        $this->id = $page->createPlan();

The property $id was declared of type string, but $page->createPlan() is of type integer. Maybe add a type cast?

    }

    public function ensureThatICanAddPrices(Manager $I): void
    {
        $I->needPage(Url::to(['@plan/view', 'id' => $this->id]));
        $I->see('No prices found');
        $price = new PriceCertificateCreate($I, $this->id);
        $price->addPrices('Certificate tariff');
        $price->ensureThereNoSuggestions('Certificate tariff');
    }

    public function ensureICanUpdatePrices(Manager $I): void
    {
        $price = new PriceCertificateUpdate($I, $this->id);
        $price->updatePrices();
    }
}