Issues in StaticThemeAssetsController.php (master) - Issues in master - ahilles107/web-publisher - Measure and Improve Code Quality continuously with Scrutinizer

Issues (541)

Security Analysis 8 potential vulnerabilities

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Cross-Site Scripting (6)

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure (1)

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection (1)

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Controller/StaticThemeAssetsController.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the Superdesk Web Publisher Core Bundle.
 *
 * Copyright 2015 Sourcefabric z.u. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2015 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\CoreBundle\Controller;

use Hoa\File\Read;
use Hoa\Mime\Mime;
use Sylius\Bundle\ThemeBundle\HierarchyProvider\ThemeHierarchyProviderInterface;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\ResponseHeaderBag;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class StaticThemeAssetsController extends Controller

{
    /**
     * Directory with assets inside theme.
     */
    const ASSETS_DIRECTORY = 'public';

    /**
     * @Route("/{fileName}.{fileExtension}", methods={"GET"}, name="static_theme_assets_root", requirements={"fileName": "sw|manifest|favicon|ads|OneSignalSDKWorker|OneSignalSDKUpdaterWorker|amp-web-push-helper-frame|amp-web-push-permission-dialog"})
     * @Route("/public-{fileName}.{fileExtension}", methods={"GET"}, name="static_theme_assets_root_public", requirements={"fileName"=".+"})
     * @Route("/public/{fileName}.{fileExtension}", methods={"GET"}, name="static_theme_assets_public", requirements={"fileName"=".+"})
     */
    public function rootAction($fileName, $fileExtension)
    {
        $themes = $this->get(ThemeHierarchyProviderInterface::class)->getThemeHierarchy(
            $this->get('swp_core.theme.context.tenant_aware')->getTheme()
        );

        $fileName = (null === $fileExtension) ? basename($fileName) : $fileName.'.'.$fileExtension;
        foreach ($themes as $theme) {
            $filePath = $theme->getPath().'/'.self::ASSETS_DIRECTORY.'/'.$fileName;
            if (null !== $response = $this->handleFileLoading($filePath)) {
                return $response;
            }
        }

        throw new NotFoundHttpException('File was not found.');
    }

    /**
     * @Route("/themes/{type}/{themeName}/screenshots/{fileName}", methods={"GET"}, name="static_theme_screenshots", requirements={
     *     "type": "organization|tenant"
     * })
     */
    public function screenshotsAction(string $type, string $themeName, $fileName)
    {
        if ('organization' === $type) {
            $theme = $this->loadOrganizationTheme(str_replace('__', '/', $themeName));
        } elseif ('tenant' === $type) {
            $theme = $this->loadTenantTheme(str_replace('__', '/', $themeName));
        } else {
            throw new NotFoundHttpException('File was not found.');
        }

        $filePath = $theme->getPath().'/screenshots/'.$fileName;
        if (null !== $response = $this->handleFileLoading($filePath)) {
            return $response;
        }

        throw new NotFoundHttpException('File was not found.');
    }

    /**
     * @param $filePath
     *
     * @return Response
     */
    private function handleFileLoading($filePath)
    {
        if (file_exists($filePath)) {
            $response = new Response(file_get_contents($filePath));
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
            $disposition = $response->headers->makeDisposition(
                ResponseHeaderBag::DISPOSITION_INLINE,
                basename($filePath)
            );
            $response->headers->set('Content-Disposition', $disposition);

            try {
                $type = new Mime(new Read($filePath));
                $mime = str_replace('/x-', '/', Mime::getMimeFromExtension($type->getExtension()));
            } catch (\Exception $e) {
                $mime = 'text/plain';
            }

            $response->headers->set('Content-Type', $mime);
            $response->setStatusCode(Response::HTTP_OK);
            $response->setPublic();
            $response->setMaxAge(3600);
            $response->setSharedMaxAge(7200);

            return $response;
        }
    }

    /**
     * @param string $themeName
     *
     * @return mixed
     */
    private function loadOrganizationTheme(string $themeName)
    {
        $loadedThemes = $this->get('swp_core.loader.organization.theme')->load();

        return $this->filterThemes($loadedThemes, $themeName);
    }

    /**
     * @param string $themeName
     *
     * @return mixed
     */
    private function loadTenantTheme(string $themeName)
    {
        $loadedThemes = $this->get('sylius.repository.theme')->findAll();

        return $this->filterThemes($loadedThemes, $themeName);
    }

    /**
     * @param array  $loadedThemes
     * @param string $themeName
     *
     * @return mixed
     */
    private function filterThemes($loadedThemes, string $themeName)
    {
        $themes = array_filter(
            $loadedThemes,
            function ($element) use (&$themeName) {
                return $element->getName() === $themeName;
            }
        );

        if (0 === count($themes)) {
            throw new NotFoundHttpException(sprintf('Theme with name "%s" was not found in organization themes.', $themeName));
        }

        return reset($themes);
    }
}


1		<?php
2
3		/*
4		* This file is part of the Superdesk Web Publisher Core Bundle.
5		*
6		* Copyright 2015 Sourcefabric z.u. and contributors.
7		*
8		* For the full copyright and license information, please see the
9		* AUTHORS and LICENSE files distributed with this source code.
10		*
11		* @copyright 2015 Sourcefabric z.ú
12		* @license http://www.superdesk.org/license
13		*/
14
15		namespace SWP\Bundle\CoreBundle\Controller;
16
17		use Hoa\File\Read;
18		use Hoa\Mime\Mime;
19		use Sylius\Bundle\ThemeBundle\HierarchyProvider\ThemeHierarchyProviderInterface;
20		use Symfony\Component\Routing\Annotation\Route;
21		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
22		use Symfony\Component\HttpFoundation\Response;
23		use Symfony\Component\HttpFoundation\ResponseHeaderBag;
24		use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
25
26		class StaticThemeAssetsController extends Controller
		0 ignored issues – show Deprecated Code introduced 2019-04-18 08:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `Symfony\Bundle\Framework...e\Controller\Controller` has been deprecated with message: since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
27		{
28		/**
29		* Directory with assets inside theme.
30		*/
31		const ASSETS_DIRECTORY = 'public';
32
33		/**
34		* @Route("/{fileName}.{fileExtension}", methods={"GET"}, name="static_theme_assets_root", requirements={"fileName": "sw\|manifest\|favicon\|ads\|OneSignalSDKWorker\|OneSignalSDKUpdaterWorker\|amp-web-push-helper-frame\|amp-web-push-permission-dialog"})
35		* @Route("/public-{fileName}.{fileExtension}", methods={"GET"}, name="static_theme_assets_root_public", requirements={"fileName"=".+"})
36		* @Route("/public/{fileName}.{fileExtension}", methods={"GET"}, name="static_theme_assets_public", requirements={"fileName"=".+"})
37		*/
38		public function rootAction($fileName, $fileExtension)
39	1	{
40		$themes = $this->get(ThemeHierarchyProviderInterface::class)->getThemeHierarchy(
41	1	$this->get('swp_core.theme.context.tenant_aware')->getTheme()
42	1	);
43	1
44	1	$fileName = (null === $fileExtension) ? basename($fileName) : $fileName.'.'.$fileExtension;
45		foreach ($themes as $theme) {
46		$filePath = $theme->getPath().'/'.self::ASSETS_DIRECTORY.'/'.$fileName;
47		if (null !== $response = $this->handleFileLoading($filePath)) {
48		return $response;
49		}
50		}
51
52		throw new NotFoundHttpException('File was not found.');
53		}
54	1
55		/**
56	1	* @Route("/themes/{type}/{themeName}/screenshots/{fileName}", methods={"GET"}, name="static_theme_screenshots", requirements={
57	1	* "type": "organization\|tenant"
58	1	* })
59	1	*/
60		public function screenshotsAction(string $type, string $themeName, $fileName)
61		{
62	1	if ('organization' === $type) {
63		$theme = $this->loadOrganizationTheme(str_replace('__', '/', $themeName));
64		} elseif ('tenant' === $type) {
65		$theme = $this->loadTenantTheme(str_replace('__', '/', $themeName));
66		} else {
67		throw new NotFoundHttpException('File was not found.');
68		}
69
70	2	$filePath = $theme->getPath().'/screenshots/'.$fileName;
71		if (null !== $response = $this->handleFileLoading($filePath)) {
72	2	return $response;
73	2	}
74	2
75	2	throw new NotFoundHttpException('File was not found.');
76		}
77
78	2	/**
79	2	* @param $filePath
80	2	*
81	2	* @return Response
82	2	*/
83		private function handleFileLoading($filePath)
84	2	{
85		if (file_exists($filePath)) {
86	1	$response = new Response(file_get_contents($filePath));
		0 ignored issues – show Security File Exposure introduced 2017-10-25 11:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$filePath` can contain request data and is used in file inclusion context(s) leading to a potential security vulnerability. 2 paths for user data to reach this point 1. Path: Entered via action parameter `$fileName` in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 38 Entered via action parameter `$fileName` in vendor/src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 38 `$fileName` is assigned in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 44 `$filePath` is assigned in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 46 `$filePath` is passed to StaticThemeAssetsController::handleFileLoading() in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 47 2. Path: Entered via action parameter `$fileName` in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 60 Entered via action parameter `$fileName` in vendor/src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 60 `$filePath` is assigned in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 70 `$filePath` is passed to StaticThemeAssetsController::handleFileLoading() in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 71 General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history... Security Cross-Site Scripting introduced 2019-03-13 12:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `file_get_contents($filePath)` can contain request data and is used in output context(s) leading to a potential security vulnerability. 2 paths for user data to reach this point 1. Path: Entered via action parameter `$fileName` in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 38 Entered via action parameter `$fileName` in vendor/src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 38 `$fileName` is assigned in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 44 `$filePath` is assigned in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 46 `$filePath` is passed to StaticThemeAssetsController::handleFileLoading() in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 47 `$filePath` is passed through file_get_contents() in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 86 2. Path: Entered via action parameter `$fileName` in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 60 Entered via action parameter `$fileName` in vendor/src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 60 `$filePath` is assigned in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 70 `$filePath` is passed to StaticThemeAssetsController::handleFileLoading() in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 71 `$filePath` is passed through file_get_contents() in src/SWP/Bundle/CoreBundle/Controller/StaticThemeAssetsController.php on line 86 Used in output context Response::__construct() uses Response::setContent() ($content) in vendor/Response.php on line 202 Response::setContent() uses property Response::$content for writing in vendor/Response.php on line 404 Property Response::$content is used in echo in vendor/Response.php on line 363 Preventing Cross-Site-Scripting Attacks Cross-Site-Scripting allows an attacker to inject malicious code into your website - in particular Javascript code, and have that code executed with the privileges of a visiting user. This can be used to obtain data, or perform actions on behalf of that visiting user. In order to prevent this, make sure to escape all user-provided data: // for HTML $sanitized = htmlentities($tainted, ENT_QUOTES); // for URLs $sanitized = urlencode($tainted); General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
87		$disposition = $response->headers->makeDisposition(
88		ResponseHeaderBag::DISPOSITION_INLINE,
89		basename($filePath)
90		);
91		$response->headers->set('Content-Disposition', $disposition);
92
93		try {
94		$type = new Mime(new Read($filePath));
95		$mime = str_replace('/x-', '/', Mime::getMimeFromExtension($type->getExtension()));
96		} catch (\Exception $e) {
97		$mime = 'text/plain';
98		}
99
100		$response->headers->set('Content-Type', $mime);
101		$response->setStatusCode(Response::HTTP_OK);
102		$response->setPublic();
103		$response->setMaxAge(3600);
104		$response->setSharedMaxAge(7200);
105
106		return $response;
107		}
108		}
109
110		/**
111		* @param string $themeName
112		*
113		* @return mixed
114		*/
115		private function loadOrganizationTheme(string $themeName)
116		{
117		$loadedThemes = $this->get('swp_core.loader.organization.theme')->load();
118
119		return $this->filterThemes($loadedThemes, $themeName);
120		}
121
122		/**
123		* @param string $themeName
124		*
125		* @return mixed
126		*/
127		private function loadTenantTheme(string $themeName)
128		{
129		$loadedThemes = $this->get('sylius.repository.theme')->findAll();
130
131		return $this->filterThemes($loadedThemes, $themeName);
132		}
133
134		/**
135		* @param array $loadedThemes
136		* @param string $themeName
137		*
138		* @return mixed
139		*/
140		private function filterThemes($loadedThemes, string $themeName)
141		{
142		$themes = array_filter(
143		$loadedThemes,
144		function ($element) use (&$themeName) {
145		return $element->getName() === $themeName;
146		}
147		);
148
149		if (0 === count($themes)) {
150		throw new NotFoundHttpException(sprintf('Theme with name "%s" was not found in organization themes.', $themeName));
151		}
152
153		return reset($themes);
154		}
155		}
156

ahilles107 / web-publisher

Issues (541)

Security Analysis 8 potential vulnerabilities

Controller/StaticThemeAssetsController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

2 paths for user data to reach this point

General Strategies to prevent injection

2 paths for user data to reach this point

Used in output context

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like