Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
29 | class RouteController extends FOSRestController |
||
30 | { |
||
31 | /** |
||
32 | * Lists current tenant routes. |
||
33 | * |
||
34 | * @ApiDoc( |
||
35 | * resource=true, |
||
36 | * description="Lists current tenant routes", |
||
37 | * statusCodes={ |
||
38 | * 200="Returned on success." |
||
39 | * } |
||
40 | * ) |
||
41 | * @Route("/api/{version}/content/routes/", options={"expose"=true}, defaults={"version"="v1"}, name="swp_api_content_list_routes") |
||
42 | * @Method("GET") |
||
43 | * |
||
44 | * @Cache(expires="10 minutes", public=true) |
||
45 | */ |
||
46 | 1 | public function listAction(Request $request) |
|
57 | |||
58 | /** |
||
59 | * Show single tenant route. |
||
60 | * |
||
61 | * @ApiDoc( |
||
62 | * resource=true, |
||
63 | * description="Show single tenant route", |
||
64 | * statusCodes={ |
||
65 | * 200="Returned on success." |
||
66 | * } |
||
67 | * ) |
||
68 | * @Route("/api/{version}/content/routes/{id}", options={"expose"=true}, defaults={"version"="v1"}, name="swp_api_content_show_routes", requirements={"id"=".+"}) |
||
69 | * @Method("GET") |
||
70 | * |
||
71 | * @Cache(expires="10 minutes", public=true) |
||
72 | */ |
||
73 | public function getAction($id) |
||
77 | |||
78 | /** |
||
79 | * Delete single tenant route. |
||
80 | * |
||
81 | * @ApiDoc( |
||
82 | * resource=true, |
||
83 | * description="Delete single tenant route", |
||
84 | * statusCodes={ |
||
85 | * 204="Returned on success." |
||
86 | * } |
||
87 | * ) |
||
88 | * @Route("/api/{version}/content/routes/{id}", options={"expose"=true}, defaults={"version"="v1"}, name="swp_api_content_delete_routes", requirements={"id"=".+"}) |
||
89 | * @Method("DELETE") |
||
90 | */ |
||
91 | 1 | public function deleteAction($id) |
|
106 | |||
107 | /** |
||
108 | * Creates routes for current tenant. |
||
109 | * |
||
110 | * Parameter `type` cane have one of two values: `content` or `collection`. |
||
111 | * |
||
112 | * Content path should be provided without tenant information: |
||
113 | * |
||
114 | * Instead full content path like: ```/swp/<tenant_code>/content/test-content-article``` provide path like this: ```test-content-article``` |
||
115 | * |
||
116 | * @ApiDoc( |
||
117 | * resource=true, |
||
118 | * description="Creates routes for current tenant", |
||
119 | * statusCodes={ |
||
120 | * 201="Returned on success." |
||
121 | * }, |
||
122 | * input="SWP\Bundle\ContentBundle\Form\Type\RouteType" |
||
123 | * ) |
||
124 | * @Route("/api/{version}/content/routes/", options={"expose"=true}, defaults={"version"="v1"}, name="swp_api_content_create_routes") |
||
125 | * @Method("POST") |
||
126 | */ |
||
127 | 15 | View Code Duplication | public function createAction(Request $request) |
146 | |||
147 | /** |
||
148 | * Updates routes for current tenant. |
||
149 | * |
||
150 | * Parameter `type` cane have one of two values: `content` or `collection`. |
||
151 | * |
||
152 | * Content path should be provided without tenant information: |
||
153 | * |
||
154 | * Instead full content path like: ```/swp/<tenant_code>/content/test-content-article``` provide path like this: ```test-content-article``` |
||
155 | * |
||
156 | * @ApiDoc( |
||
157 | * resource=true, |
||
158 | * description="Updates routes for current tenant", |
||
159 | * statusCodes={ |
||
160 | * 200="Returned on success.", |
||
161 | * 404="Returned when route not found." |
||
162 | * }, |
||
163 | * input="SWP\Bundle\ContentBundle\Form\Type\RouteType" |
||
164 | * ) |
||
165 | * @Route("/api/{version}/content/routes/{id}", options={"expose"=true}, defaults={"version"="v1"}, name="swp_api_content_update_routes", requirements={"id"=".+"}) |
||
166 | * @Method("PATCH") |
||
167 | */ |
||
168 | 4 | View Code Duplication | public function updateAction(Request $request, $id) |
187 | |||
188 | 5 | private function findOr404($id) |
|
196 | } |
||
197 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.