SWP\Bundle\CoreBundle\Command\UpdateOrganizationCommand

Complexity

Total Complexity

9

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	8

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	16	1
A	execute()	0	18	2
A	sendOutput()	0	12	3
A	interact()	0	4	1
A	updateOrganization()	0	7	2

<?php

/*
 * This file is part of the Superdesk Web Publisher MultiTenancyBundle.
 *
 * Copyright 2016 Sourcefabric z.ú. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2016 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\CoreBundle\Command;

use SWP\Bundle\CoreBundle\Model\OrganizationInterface;
use SWP\Bundle\MultiTenancyBundle\Command\CreateOrganizationCommand;

This use statement conflicts with another class in this namespace, SWP\Bundle\CoreBundle\Command\CreateOrganizationCommand.

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class UpdateOrganizationCommand extends CreateOrganizationCommand
{
    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName('swp:organization:update')
            ->setDescription('Updates existing organization.')
            ->setDefinition([
                new InputArgument('name', InputArgument::OPTIONAL, 'Organization name'),
                new InputOption('disabled', null, InputOption::VALUE_NONE, 'Set the organization as a disabled'),
                new InputOption('secretToken', null, InputOption::VALUE_REQUIRED, 'Organization secret token'),
            ])
            ->setHelp(
                <<<'EOT'
                The <info>%command.name%</info> command updates existing organization.
EOT
            );
    }

    /**
     * @param InputInterface  $input
     * @param OutputInterface $output
     *
     * @return int|null|void
     *
     * @throws \Doctrine\ORM\NonUniqueResultException
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $name = $input->getArgument('name');
        $disabled = $input->getOption('disabled');
        $secretToken = $input->getOption('secretToken');

        /** @var OrganizationInterface $organization */
        $organization = $this->getOrganizationRepository()->findOneByName($name);
        if (null !== $organization) {
            $this->updateOrganization($organization, $disabled, $secretToken);
        } else {
            throw new \InvalidArgumentException(sprintf('"%s" organization don\'t exists!', $name));
        }

        $this->getObjectManager()->persist($organization);
        $this->getObjectManager()->flush();
        $this->sendOutput($output, $organization);
    }

    /**
     * @param OutputInterface       $output
     * @param OrganizationInterface $organization
     */
    protected function sendOutput(OutputInterface $output, $organization)
    {
        $output->writeln(
            sprintf(
                'Organization <info>%s</info> (code: <info>%s</info>%s) has been updated and is <info>%s</info>!',
                $organization->getName(),
                $organization->getCode(),
                $organization->getSecretToken() ? ', secret token: <info>'.$organization->getSecretToken().'</info>' : '',
                $organization->isEnabled() ? 'enabled' : 'disabled'
            )
        );
    }

    /**
     * {@inheritdoc}
     */
    protected function interact(InputInterface $input, OutputInterface $output)
    {
        $this->askAndValidateInteract($input, $output, 'name');
    }

    /**
     * @param OrganizationInterface $organization
     * @param bool                  $disabled
     * @param null|string           $secretToken
     */
    protected function updateOrganization(OrganizationInterface $organization, bool $disabled, ?string $secretToken)
    {
        $organization->setEnabled(!$disabled);
        if ($secretToken) {

The expression $secretToken of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $organization->setSecretToken($secretToken);
        }
    }
}