SWP\Bundle\CoreBundle\Fragment\ExternalFragmentRenderer

Complexity

Total Complexity

11

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	render()	0	32	8
A	getName()	0	4	1
A	createExternalRequest()	0	6	1

<?php

/*
 * This file is part of the Superdesk Web Publisher Core Bundle.
 *
 * Copyright 2016 Sourcefabric z.ú. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2016 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\CoreBundle\Fragment;

use SWP\Bundle\BridgeBundle\Client\GuzzleClient;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent;
use Symfony\Component\HttpKernel\Fragment\FragmentRendererInterface;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\HttpKernel\KernelEvents;

/**
 * Class ExternalFragmentRenderer.
 *
 * Render content fetched from external uri with guzzle.
 */
class ExternalFragmentRenderer implements FragmentRendererInterface
{
    /**
     * @var HttpKernelInterface
     */
    private $kernel;

    /**
     * @var EventDispatcherInterface
     */
    private $dispatcher;

    /**
     * Constructor.
     *
     * @param HttpKernelInterface      $kernel     A HttpKernelInterface instance
     * @param EventDispatcherInterface $dispatcher A EventDispatcherInterface instance
     */
    public function __construct(HttpKernelInterface $kernel, EventDispatcherInterface $dispatcher = null)
    {
        $this->kernel = $kernel;
        $this->dispatcher = $dispatcher;
    }

    /**
     * {@inheritdoc}
     */
    public function render($uri, Request $request, array $options = [])
    {
        $level = ob_get_level();

        try {
            return new Response($this->createExternalRequest($uri));

It seems like $uri defined by parameter $uri on line 58 can also be of type object<Symfony\Component\HttpKernel\Controller\ControllerReference>; however, SWP\Bundle\CoreBundle\Fragment\ExternalFragmentRenderer::createExternalRequest() does only seem to accept string, maybe add an additional type check?

        } catch (\Throwable $e) {
            // we dispatch the exception event to trigger the logging
            // the response that comes back is simply ignored
            if (isset($options['ignore_errors']) && $options['ignore_errors'] && $this->dispatcher) {
                $event = new GetResponseForExceptionEvent($this->kernel, $request, HttpKernelInterface::SUB_REQUEST, $e);

$e of type object<Throwable> is not a sub-type of object<Exception>. It seems like you assume a concrete implementation of the interface Throwable to be always present.

                $this->dispatcher->dispatch(KernelEvents::EXCEPTION, $event);
            }

            // let's clean up the output buffers that were created by the sub-request
            Response::closeOutputBuffers($level, false);

            if (isset($options['alt'])) {
                $alt = $options['alt'];
                unset($options['alt']);

                return $this->render($alt, $request, $options);
            }

            if (!isset($options['ignore_errors']) || !$options['ignore_errors']) {
                throw $e;
            }

            return new Response();
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'external';
    }

    /**
     * @param string $uri
     *
     * @return mixed
     */
    private function createExternalRequest(string $uri)
    {
        $client = new GuzzleClient();

        return $client->makeCall($uri)['body'];
    }
}