FacebookInstantArticlesManager - Code Metrics - Inspection of "Implement and expose article keywords (#213)" - ahilles107/web-publisher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8d3dbf...7592af )

by Paweł

created 2017-01-12 19:27 UTC

FacebookInstantArticlesManager A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

15.79%

Importance

Changes

Metric	Value
wmc	8
lcom	0
cbo	4
dl	0
loc	69
ccs	3
cts	19
cp	0.1579
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	getFacebookManager()	4	1
A	getPageAccessToken()	4	1
A	getPagesAndTokens()	7	1
A	loopThroughPagesAndFindOneById()	17	4

<?php

declare(strict_types=1);

/*
 * This file is part of the Superdesk Web Publisher Facebook Instant Articles Bundle.
 *
 * Copyright 2016 Sourcefabric z.ú. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2016 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\FacebookInstantArticlesBundle\Manager;

use Facebook;

class FacebookInstantArticlesManager implements FacebookInstantArticlesManagerInterface
{
    /**
     * @var FacebookManagerInterface
     */
    protected $facebookManager;

    /**
     * FacebookInstantArticlesManager constructor.
     *
     * @param FacebookManagerInterface $facebookManager
     */
    public function __construct(FacebookManagerInterface $facebookManager)
    {
        $this->facebookManager = $facebookManager;
    }

    /**
     * @return FacebookManagerInterface
     */
    public function getFacebookManager()
    {
        return $this->facebookManager;
    }

    /**
     * {@inheritdoc}
     */
    public function getPageAccessToken(Facebook\Facebook $facebook, $pageId)
    {
        return $this->loopThroughPagesAndFindOneById($facebook, $this->getPagesAndTokens($facebook), $pageId);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }

    /**
     * {@inheritdoc}
     */
    public function getPagesAndTokens(Facebook\Facebook $facebook)
    {
        $userAccessToken = $facebook->getRedirectLoginHelper()->getAccessToken();
        $helper = new Facebook\InstantArticles\Client\Helper($facebook);

        return $helper->getPagesAndTokens($userAccessToken);
    }

    /**
     * @param Facebook\Facebook             $facebook
     * @param Facebook\GraphNodes\GraphEdge $pagesAndAccessTokens
     * @param string                        $pageId
     *
     * @return string|null
     */
    private function loopThroughPagesAndFindOneById($facebook, $pagesAndAccessTokens, $pageId)
    {
        foreach ($pagesAndAccessTokens as $page) {
            /** @var Facebook\GraphNodes\GraphNode $page */
            $page = $page->asArray();

            if ($page['id'] == $pageId) {
                return $page['access_token'];
            }
        }

        if (null !== $nextPagesAndAccessTokens = $facebook->next($pagesAndAccessTokens)) {
            return $this->loopThroughPagesAndFindOneById($facebook, $nextPagesAndAccessTokens, $pageId);
        }

        return;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the Superdesk Web Publisher Facebook Instant Articles Bundle.
7		*
8		* Copyright 2016 Sourcefabric z.ú. and contributors.
9		*
10		* For the full copyright and license information, please see the
11		* AUTHORS and LICENSE files distributed with this source code.
12		*
13		* @copyright 2016 Sourcefabric z.ú
14		* @license http://www.superdesk.org/license
15		*/
16
17		namespace SWP\Bundle\FacebookInstantArticlesBundle\Manager;
18
19		use Facebook;
20
21		class FacebookInstantArticlesManager implements FacebookInstantArticlesManagerInterface
22		{
23		/**
24		* @var FacebookManagerInterface
25		*/
26		protected $facebookManager;
27
28		/**
29		* FacebookInstantArticlesManager constructor.
30		*
31		* @param FacebookManagerInterface $facebookManager
32		*/
33	14	public function __construct(FacebookManagerInterface $facebookManager)
34		{
35	14	$this->facebookManager = $facebookManager;
36	14	}
37
38		/**
39		* @return FacebookManagerInterface
40		*/
41		public function getFacebookManager()
42		{
43		return $this->facebookManager;
44		}
45
46		/**
47		* {@inheritdoc}
48		*/
49		public function getPageAccessToken(Facebook\Facebook $facebook, $pageId)
50		{
51		return $this->loopThroughPagesAndFindOneById($facebook, $this->getPagesAndTokens($facebook), $pageId);
		0 ignored issues – show Bug introduced 2017-01-12 20:29 UTC by Report Bug Copy Issue Report It seems like `$this->getPagesAndTokens($facebook)` can be `null`; however, `loopThroughPagesAndFindOneById()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
52		}
53
54		/**
55		* {@inheritdoc}
56		*/
57		public function getPagesAndTokens(Facebook\Facebook $facebook)
58		{
59		$userAccessToken = $facebook->getRedirectLoginHelper()->getAccessToken();
60		$helper = new Facebook\InstantArticles\Client\Helper($facebook);
61
62		return $helper->getPagesAndTokens($userAccessToken);
63		}
64
65		/**
66		* @param Facebook\Facebook $facebook
67		* @param Facebook\GraphNodes\GraphEdge $pagesAndAccessTokens
68		* @param string $pageId
69		*
70		* @return string\|null
71		*/
72		private function loopThroughPagesAndFindOneById($facebook, $pagesAndAccessTokens, $pageId)
73		{
74		foreach ($pagesAndAccessTokens as $page) {
75		/** @var Facebook\GraphNodes\GraphNode $page */
76		$page = $page->asArray();
77
78		if ($page['id'] == $pageId) {
79		return $page['access_token'];
80		}
81		}
82
83		if (null !== $nextPagesAndAccessTokens = $facebook->next($pagesAndAccessTokens)) {
84		return $this->loopThroughPagesAndFindOneById($facebook, $nextPagesAndAccessTokens, $pageId);
85		}
86
87		return;
88		}
89		}
90

ahilles107 / web-publisher

Push — master ( 8d3dbf...7592af )

FacebookInstantArticlesManager A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like