SWP\Bundle\CoreBundle\Controller\FbApplicationController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	100
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	11

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	listAction()	12	12	1
A	createAction()	16	16	2
A	deleteAction()	15	15	3
A	checkIfApplicationExists()	9	9	2

<?php

/*
 * This file is part of the Superdesk Web Publisher Core Bundle.
 *
 * Copyright 2016 Sourcefabric z.ú. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2016 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\CoreBundle\Controller;

use Nelmio\ApiDocBundle\Annotation\ApiDoc;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use SWP\Bundle\CoreBundle\Form\Type\FacebookApplicationType;
use SWP\Bundle\CoreBundle\Model\FacebookApplication;
use SWP\Bundle\FacebookInstantArticlesBundle\Model\ApplicationInterface;
use SWP\Component\Common\Criteria\Criteria;
use SWP\Component\Common\Pagination\PaginationData;
use SWP\Component\Common\Response\ResourcesListResponse;
use SWP\Component\Common\Response\ResponseContext;
use SWP\Component\Common\Response\SingleResourceResponse;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\ConflictHttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class FbApplicationController extends Controller

This class seems to be duplicated in your project.

{
    /**
     * @ApiDoc(
     *     resource=true,
     *     description="Lists Facebook Applications",
     *     statusCodes={
     *         200="Returned on success.",
     *         500="Unexpected error."
     *     }
     * )
     * @Route("/api/{version}/facebook/applications/", options={"expose"=true}, defaults={"version"="v1"}, name="swp_api_list_facebook_applications")
     * @Method("GET")
     */
    public function listAction(Request $request)
    {
        $repository = $this->get('swp.repository.facebook_application');

        $items = $repository->getPaginatedByCriteria(
            new Criteria(),
            ['id' => 'asc'],
            new PaginationData($request)
        );

        return new ResourcesListResponse($items);
    }

    /**
     * @ApiDoc(
     *     resource=true,
     *     description="Create Facebook application",
     *     statusCodes={
     *         201="Returned on success.",
     *         400="Returned when not valid data."
     *     },
     *     input="SWP\Bundle\CoreBundle\Form\Type\FacebookApplicationType"
     * )
     * @Route("/api/{version}/facebook/applications/", options={"expose"=true}, defaults={"version"="v1"}, name="swp_api_create_facebook_applications")
     * @Method("POST")
     */
    public function createAction(Request $request)
    {
        /* @var FacebookApplication $feed */
        $application = $this->get('swp.factory.facebook_application')->create();
        $form = $this->createForm(FacebookApplicationType::class, $application, ['method' => $request->getMethod()]);

        $form->handleRequest($request);
        if ($form->isValid()) {
            $this->checkIfApplicationExists($application);
            $this->get('swp.repository.facebook_application')->add($application);

            return new SingleResourceResponse($application, new ResponseContext(201));
        }

        return new SingleResourceResponse($form, new ResponseContext(400));
    }

    /**
     * @ApiDoc(
     *     resource=true,
     *     description="Delete Facebook application",
     *     statusCodes={
     *         204="Returned on success.",
     *         500="Unexpected error.",
     *         404="Application not found",
     *         409="Application is used by page"
     *     }
     * )
     * @Route("/api/{version}/facebook/applications/{id}", options={"expose"=true}, defaults={"version"="v1"}, name="swp_api_delete_facebook_applications")
     * @Method("DELETE")
     */
    public function deleteAction($id)
    {
        $repository = $this->get('swp.repository.facebook_application');
        if (null === $application = $repository->findOneBy(['id' => $id])) {
            throw new NotFoundHttpException('There is no Application with provided id!');
        }

        if (null !== $page = $this->get('swp.repository.facebook_page')->findOneBy(['id' => $id])) {
            throw new ConflictHttpException(sprintf('This Application is used by page with id: %s!', $page->getId()));
        }

        $repository->remove($application);

        return new SingleResourceResponse(null, new ResponseContext(204));
    }

    /**
     * @param ApplicationInterface $application
     */
    private function checkIfApplicationExists(ApplicationInterface $application)
    {
        if (null !== $this->get('swp.repository.facebook_application')->findOneBy([
                'appId' => $application->getAppId(),
            ])
        ) {
            throw new ConflictHttpException('This Application already exists!');
        }
    }
}