SWP\Bundle\CoreBundle\Resolver\TemplateNameResolver

Complexity

Total Complexity

19

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

83.87%

Importance

Changes	3
Bugs	1	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	resolve()	0	10	3
B	resolveFromArticle()	0	19	6
B	resolveFromRoute()	0	20	7
A	getTemplateNameFromRouteContent()	0	10	3

<?php

/**
 * This file is part of the Superdesk Web Publisher Core Bundle.
 *
 * Copyright 2016 Sourcefabric z.u. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * Some parts of that file were taken from the Liip/ThemeBundle
 * (c) Liip AG
 *
 * @copyright 2016 Sourcefabric z.ú.
 * @license http://www.superdesk.org/license
 */
namespace SWP\Bundle\CoreBundle\Resolver;

use SWP\Bundle\ContentBundle\Doctrine\ODM\PHPCR\RouteObjectInterface;
use SWP\Bundle\ContentBundle\Model\ArticleInterface;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

/**
 * Class TemplateNameResolver.
 */
class TemplateNameResolver implements TemplateNameResolverInterface
{
    /**
     * {@inheritdoc}
     */
    public function resolve($object, $defaultFileName = 'article.html.twig')
    {
        if ($object instanceof ArticleInterface) {
            return $this->resolveFromArticle($object);
        } elseif ($object instanceof RouteObjectInterface) {
            return $this->resolveFromRoute($object);

The expression $this->resolveFromRoute($object); of type boolean|string adds the type boolean to the return on line 36 which is incompatible with the return type declared by the interface SWP\Bundle\CoreBundle\Resolver\TemplateNameResolverInterface::resolve of type string.

        }

        return $defaultFileName;
    }

    /**
     * {@inheritdoc}
     */
    public function resolveFromArticle(ArticleInterface $article, $templateName = 'article.html.twig')
    {
        /** @param $route RouteObjectInterface */
        if (null !== ($route = $article->getRoute())) {
            if (null !== $route->getTemplateName()) {
                $templateName = $route->getTemplateName();
            }

            if (RouteObjectInterface::TYPE_COLLECTION === $route->getType() && null !== $route->getArticlesTemplateName()) {
                $templateName = $route->getArticlesTemplateName();
            }
        }

        if (null !== $article->getTemplateName()) {
            $templateName = $article->getTemplateName();
        }

        return $templateName;
    }

    /**
     * {@inheritdoc}
     */
    public function resolveFromRoute(RouteObjectInterface $route, $templateName = 'article.html.twig')
    {
        if (null !== $route->getTemplateName()) {
            $templateName = $route->getTemplateName();
        }

        if (RouteObjectInterface::TYPE_COLLECTION === $route->getType() && null === $route->getTemplateName()) {
            if ($contentTemplateName = $this->getTemplateNameFromRouteContent($route)) {

The expression $this->getTemplateNameFromRouteContent($route); of type boolean adds the type boolean to the return on line 86 which is incompatible with the return type declared by the interface SWP\Bundle\CoreBundle\Resolver\TemplateNameResolverInterface::resolveFromRoute of type string.

                $templateName = $contentTemplateName;
            } else {
                throw new NotFoundHttpException(sprintf('There is no template file defined for "%s" route!', $route->getId()));
            }
        } elseif (RouteObjectInterface::TYPE_CONTENT === $route->getType()) {
            if ($contentTemplateName = $this->getTemplateNameFromRouteContent($route)) {

The expression $this->getTemplateNameFromRouteContent($route); of type boolean adds the type boolean to the return on line 86 which is incompatible with the return type declared by the interface SWP\Bundle\CoreBundle\Resolver\TemplateNameResolverInterface::resolveFromRoute of type string.

                $templateName = $contentTemplateName;
            }
        }

        return $templateName;
    }

    /**
     * @param RouteObjectInterface $route
     *
     * @return bool
     */
    private function getTemplateNameFromRouteContent(RouteObjectInterface $route)
    {
        if (null !== $route->getContent()) {
            if (null !== $templateName = $route->getContent()->getTemplateName()) {
                return $templateName;
            }
        }

        return false;
    }
}