Each::getDescription() - Code Metrics - Inspection of "refactoring" - agoalofalife/postman - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (328f34)

by Chubarov

created 2017-10-14 17:49 UTC

Each::getDescription() A

↳ Parent: Each

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	3
Ratio	100 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	3
loc	3
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	1
nc	1
nop	0
crap	1

<?php
namespace agoalofalife\postman\Modes;

use agoalofalife\postman\Contract\Mode;
use agoalofalife\postman\Models\SheduleEmail;
use Illuminate\Support\Facades\Mail;

class Each implements Mode

{
    /**
     * @param SheduleEmail $tasks
     * @return mixed|void
     */
    public function postEmail(SheduleEmail $tasks)
    {
        Mail::raw($tasks->email->text, function ($message) use ($tasks) {
        $message->subject($tasks->email->theme);
        $message->from(config('mail.from.address'));
        $message->to($tasks->email->users->map(function($value){ return $value->email;})->toArray());
    });

        // if to reached the sender
        if (empty(Mail::failures())) {
            $tasks->status_action = 1;
            $tasks->save();
        }
    }

    /**
     *  Get name mode
     * @return string
     */
    public function getName(): string
    {
        return trans('postman::mode.two.name');

    }

    /**
     * Get full description
     * @return string
     */
    public function getDescription(): string
    {
        return trans('postman::mode.two.name');

    }
}

1			<?php
2			namespace agoalofalife\postman\Modes;
3
4			use agoalofalife\postman\Contract\Mode;
5			use agoalofalife\postman\Models\SheduleEmail;
6			use Illuminate\Support\Facades\Mail;
7
8		View Code Duplication	class Each implements Mode
			0 ignored issues – show Duplication introduced 2017-10-14 17:54 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9			{
10			/**
11			* @param SheduleEmail $tasks
12			* @return mixed\|void
13			*/
14			public function postEmail(SheduleEmail $tasks)
15			{
16			Mail::raw($tasks->email->text, function ($message) use ($tasks) {
17			$message->subject($tasks->email->theme);
18			$message->from(config('mail.from.address'));
19			$message->to($tasks->email->users->map(function($value){ return $value->email;})->toArray());
20			});
21
22			// if to reached the sender
23			if (empty(Mail::failures())) {
24			$tasks->status_action = 1;
25			$tasks->save();
26			}
27			}
28
29			/**
30			* Get name mode
31			* @return string
32			*/
33	2		public function getName(): string
34			{
35	2		return trans('postman::mode.two.name');
			0 ignored issues – show Bug Best Practice introduced 2017-10-14 17:54 UTC by Report Bug Copy Issue Report The expression `return trans('postman::mode.two.name')` could return the type `Illuminate\Contracts\Tra...n\Translator\|null\|array` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
36			}
37
38			/**
39			* Get full description
40			* @return string
41			*/
42	2		public function getDescription(): string
43			{
44	2		return trans('postman::mode.two.name');
			0 ignored issues – show Bug Best Practice introduced 2017-10-14 17:54 UTC by Report Bug Copy Issue Report The expression `return trans('postman::mode.two.name')` could return the type `Illuminate\Contracts\Tra...n\Translator\|null\|array` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
45			}
46			}

agoalofalife / postman

Branch — master (328f34)

Each::getDescription() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like