Create::query() - Code Metrics - Inspection of "add test" - agoalofalife/bpm-online - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — 2.0.0 (25c5b4)

by Chubarov

created 2017-04-25 16:32 UTC

Create::query() A

↳ Parent: Create

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	0
dl	0
loc	14
ccs	0
cts	11
cp	0
crap	2
rs	9.4285
c	0
b	0
f	0

<?php
namespace agoalofalife\bpm\Actions;

use agoalofalife\bpm\Assistants\QueryBuilder;
use agoalofalife\bpm\Contracts\Action;
use agoalofalife\bpm\Contracts\ActionSet;
use agoalofalife\bpm\KernelBpm;


/**
 * Class Create
 * Class to create a new object in the BPM
 *
 * @property KernelBpm kernel
 * @property string HTTP_TYPE
 * @property array data
 * @package agoalofalife\bpm\Actions
 */
class Create implements Action, ActionSet
{
    use QueryBuilder;

    protected $kernel;
    protected $url = '/';
    /**
     * Request type to created
     * @var string
     */
    protected $HTTP_TYPE = 'POST';
    protected $data = [];

    public function injectionKernel(KernelBpm $bpm)
    {
        $this->kernel = $bpm;
    }

    public function getUrl()
    {
        return $this->url;
    }

    public function processData()
    {
        $this->query();
        return $this->kernel->getHandler();
    }

    public function setData(array $data)
    {
        $this->data = $data;
    }

    private function query()
    {
        $parameters = str_replace(' ', '%20', $this->url);

        $url        = $this->kernel->getCollection() . $parameters;
        $urlHome    = config($this->kernel->getPrefixConfig() . '.UrlHome');

        $this->headers()->getCookie()->body()->httpErrorsFalse()->get();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $response   =  $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome . $url,
                       $this->headers()->getCookie()->body()->httpErrorsFalse()->get()
        );
        $body       = $response->getBody();
        $this->kernel->getHandler()->parse($body->getContents());

    }
}

1		<?php
2		namespace agoalofalife\bpm\Actions;
3
4		use agoalofalife\bpm\Assistants\QueryBuilder;
5		use agoalofalife\bpm\Contracts\Action;
6		use agoalofalife\bpm\Contracts\ActionSet;
7		use agoalofalife\bpm\KernelBpm;
8
9
10		/**
11		* Class Create
12		* Class to create a new object in the BPM
13		*
14		* @property KernelBpm kernel
15		* @property string HTTP_TYPE
16		* @property array data
17		* @package agoalofalife\bpm\Actions
18		*/
19		class Create implements Action, ActionSet
20		{
21		use QueryBuilder;
22
23		protected $kernel;
24		protected $url = '/';
25		/**
26		* Request type to created
27		* @var string
28		*/
29		protected $HTTP_TYPE = 'POST';
30		protected $data = [];
31
32	1	public function injectionKernel(KernelBpm $bpm)
33		{
34	1	$this->kernel = $bpm;
35	1	}
36
37	1	public function getUrl()
38		{
39	1	return $this->url;
40		}
41
42		public function processData()
43		{
44		$this->query();
45		return $this->kernel->getHandler();
46		}
47
48	1	public function setData(array $data)
49		{
50	1	$this->data = $data;
51	1	}
52
53		private function query()
54		{
55		$parameters = str_replace(' ', '%20', $this->url);
56
57		$url = $this->kernel->getCollection() . $parameters;
58		$urlHome = config($this->kernel->getPrefixConfig() . '.UrlHome');
59
60		$this->headers()->getCookie()->body()->httpErrorsFalse()->get();
		0 ignored issues – show Unused Code introduced 2017-04-25 12:21 UTC by Report Bug Copy Issue Report The call to the method `agoalofalife\bpm\Actions\Create::get()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
61		$response = $this->kernel->getCurl()->request($this->HTTP_TYPE, $urlHome . $url,
62		$this->headers()->getCookie()->body()->httpErrorsFalse()->get()
63		);
64		$body = $response->getBody();
65		$this->kernel->getHandler()->parse($body->getContents());
		0 ignored issues – show Bug introduced 2017-04-25 12:21 UTC by Report Bug Copy Issue Report The method `parse()` does not seem to exist on `object<Illuminate\Container\Container>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
66		}
67		}

agoalofalife / bpm-online

Branch — 2.0.0 (25c5b4)

Create::query() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like