ConstructorUrl::concatenationUrlCurl() - Code Metrics - Inspection of "update read me" - agoalofalife/bpm-online - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9a4fb7...cb90a4 )

by Chubarov

created 2017-04-28 07:34 UTC

ConstructorUrl::concatenationUrlCurl() A

↳ Parent: ConstructorUrl

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	4
eloc	10
nc	4
nop	1
dl	0
loc	14
ccs	10
cts	10
cp	1
crap	4
rs	9.2
c	1
b	0
f	1

<?php
namespace agoalofalife\bpm\Assistants;

/**
 * Class ConstructorUrl
 *
 * @package agoalofalife\bpm\Assistants
 */
trait ConstructorUrl
{
    use VerifyValues;

    /**
     * Concatenation Url In Curl
     * @param $newParameters string
     * @return $this
     */
    protected function concatenationUrlCurl($newParameters)
    {
        if ($this->url  == '?') {
            $this->url .= $newParameters;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        } elseif ($this->url == '') {
            $this->url .= $newParameters;
        } elseif ($this->url == '/') {
            $this->url .= $newParameters;
        }
        else {
            $this->url .= '&'.$newParameters;
        }
        return $this;
    }

    /**
     * Contains guid
     * @param $guid
     * @return $this
     */
    public function guid($guid)
    {
        $this->checkGuId($guid);
        $this->url      = '';
        $ParameterQuery = '(guid';
        $ParameterQuery.= "'";
        $ParameterQuery.= $guid;
        $ParameterQuery.= "'";
        $ParameterQuery.=')';

        return $this->concatenationUrlCurl($ParameterQuery);
    }
}

1		<?php
2		namespace agoalofalife\bpm\Assistants;
3
4		/**
5		* Class ConstructorUrl
6		*
7		* @package agoalofalife\bpm\Assistants
8		*/
9		trait ConstructorUrl
10		{
11		use VerifyValues;
12
13		/**
14		* Concatenation Url In Curl
15		* @param $newParameters string
16		* @return $this
17		*/
18	11	protected function concatenationUrlCurl($newParameters)
19		{
20	11	if ($this->url == '?') {
21	5	$this->url .= $newParameters;
		0 ignored issues – show Bug introduced 2017-04-24 15:01 UTC by Report Bug Copy Issue Report The property `url` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22	11	} elseif ($this->url == '') {
23	4	$this->url .= $newParameters;
24	6	} elseif ($this->url == '/') {
25	1	$this->url .= $newParameters;
26	1	}
27		else {
28	2	$this->url .= '&'.$newParameters;
29		}
30	11	return $this;
31		}
32
33		/**
34		* Contains guid
35		* @param $guid
36		* @return $this
37		*/
38	7	public function guid($guid)
39		{
40	7	$this->checkGuId($guid);
41	4	$this->url = '';
42	4	$ParameterQuery = '(guid';
43	4	$ParameterQuery.= "'";
44	4	$ParameterQuery.= $guid;
45	4	$ParameterQuery.= "'";
46	4	$ParameterQuery.=')';
47
48	4	return $this->concatenationUrlCurl($ParameterQuery);
49		}
50		}

agoalofalife / bpm-online

Push — master ( 9a4fb7...cb90a4 )

ConstructorUrl::concatenationUrlCurl() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like