Core\Services\FileService

Complexity

Total Complexity

2

Size/Duplication

Total Lines	13
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	moveUploadedFile()	0	7	1
A	delete()	0	3	1

<?php
namespace Core\Services;

use Core\Interfaces\_Service;
use Slim\Http\UploadedFile;

class FileService extends _Service
{
	public function moveUploadedFile($directory,$fileName, UploadedFile $uploadedFile)
	{
	    $extension = pathinfo($uploadedFile->getClientFilename(), PATHINFO_EXTENSION);
	    $basename = bin2hex(random_bytes(8)); // see http://php.net/manual/en/function.random-bytes.php

The assignment to $basename is dead and can be removed.

	    $filename = sprintf('%s.%0.8s', $fileName, $extension);
	    $uploadedFile->moveTo($directory . DIRECTORY_SEPARATOR . $filename);
	    return $directory . DIRECTORY_SEPARATOR . $filename;
	}
	public function delete($file)
	{
		@unlink($file);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

	}

}