afrittella / back-project

src/app/Http/Controllers/RolesController.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Afrittella\BackProject\Http\Requests\RoleEdit;
 use Afrittella\BackProject\Repositories\Permissions;
 use Afrittella\BackProject\Repositories\Roles;
-use Illuminate\Http\Request;
 use Prologue\Alerts\Facades\Alert;
 
 class RolesController extends Controller

Spacing +2 added lines, -2 removed lines

@@ -37,12 +37,12 @@
 
     public function create(Permissions $permissions)
     {
-        return view('back-project::roles.create')->with('permissions',  $permissions->all());
+        return view('back-project::roles.create')->with('permissions', $permissions->all());
     }
 
     public function store(RoleAdd $request, Roles $roles)
     {
-        $role= $roles->create($request->all());
+        $role = $roles->create($request->all());
 
         Alert::add('success', trans('back-project::crud.model_created', ['model' => trans('back-project::roles.role')]))->flash();
 

src/app/Http/Controllers/UsersController.php

Unused Use Statements -2 removed lines

@@ -3,13 +3,11 @@
 namespace Afrittella\BackProject\Http\Controllers;
 
 use Afrittella\BackProject\Http\Requests\AccountStore;
-use Afrittella\BackProject\Http\Requests\AccountEdit;
 use Afrittella\BackProject\Repositories\Users;
 use Afrittella\BackProject\Repositories\Roles;
 use Afrittella\BackProject\Http\Requests\UserAdd;
 use Afrittella\BackProject\Http\Requests\UserEdit;
 use Afrittella\BackProject\Events\UserRegistered as Registered;
-use Illuminate\Http\Request;
 use Prologue\Alerts\Facades\Alert;
 use Auth;
 

src/app/Listeners/SendRegistrationEmail.php

Unused Use Statements -3 removed lines

@@ -3,11 +3,8 @@
 namespace Afrittella\BackProject\Listeners;
 
 use Afrittella\BackProject\Events\UserRegistered;
-use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Contracts\Queue\ShouldQueue;
-
 use Afrittella\BackProject\Repositories\Users;
-
 use Illuminate\Support\Facades\Log;
 use Afrittella\BackProject\Notifications\RegistrationEmail;
 

Indentation +3 added lines, -3 removed lines

@@ -32,12 +32,12 @@
      */
     public function handle(UserRegistered $event)
     {
-      //try {
+        //try {
         $user = $this->users->findBy('id', $event->user_id);
         $user->notify(new RegistrationEmail($user));
-      //} catch(\Exception $e) {
+        //} catch(\Exception $e) {
         //Log::error('lavoro fallito');
-      //}
+        //}
 
     }
 

src/app/Listeners/SendRegistrationEmailNoQueue.php

Unused Use Statements -4 removed lines

@@ -3,11 +3,7 @@
 namespace Afrittella\BackProject\Listeners;
 
 use Afrittella\BackProject\Events\UserRegistered;
-use Illuminate\Queue\InteractsWithQueue;
-use Illuminate\Contracts\Queue\ShouldQueue;
-
 use Afrittella\BackProject\Repositories\Users;
-
 use Illuminate\Support\Facades\Log;
 use Afrittella\BackProject\Notifications\RegistrationEmail;
 

Indentation +3 added lines, -3 removed lines

@@ -31,12 +31,12 @@
      */
     public function handle(UserRegistered $event)
     {
-      //try {
+        //try {
         $user = $this->users->findBy('id', $event->user_id);
         $user->notify(new RegistrationEmail($user));
-      //} catch(\Exception $e) {
+        //} catch(\Exception $e) {
         //Log::error('lavoro fallito');
-      //}
+        //}
 
     }
 

src/app/Notifications/RegistrationEmail.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
      * Get the notification's delivery channels.
      *
      * @param  mixed  $notifiable
-     * @return array
+     * @return string[]
      */
     public function via($notifiable)
     {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Illuminate\Bus\Queueable;
 use Illuminate\Notifications\Notification;
-use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Notifications\Messages\MailMessage;
 
 class RegistrationEmail extends Notification

src/app/Repositories/Base.php

Doc Comments +3 added lines

@@ -96,6 +96,9 @@
         return $this->model->findOrCreate($data);
     }
 
+    /**
+     * @param string $attribute
+     */
     public function findBy($attribute, $value, $columns = array('*'))
     {
         $this->applyCriteria();

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Afrittella\BackProject\Exceptions\NotSavedException;
 use Afrittella\BackProject\Exceptions\RepositoryException;
 use Afrittella\BackProject\Repositories\Criteria\Criteria;
-use Illuminate\Container\Container as App;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Collection;
 

Spacing +5 added lines, -5 removed lines

@@ -48,7 +48,7 @@ 
         return $this->model->create($data);
     }
 
-    public function update(array $data, $id, $attribute="id")
+    public function update(array $data, $id, $attribute = "id")
     {
         $model_data = $this->model->where($attribute, '=', $id)->first();
 
@@ -123,7 +123,7 @@ 
         return $this;
     }
 
-    public function skipCriteria($status = true){
+    public function skipCriteria($status = true) {
         $this->skipCriteria = $status;
         return $this;
     }
@@ -143,11 +143,11 @@ 
     }
 
     public function  applyCriteria() {
-        if($this->skipCriteria === true)
+        if ($this->skipCriteria === true)
             return $this;
 
-        foreach($this->getCriteria() as $criteria) {
-            if($criteria instanceof Criteria)
+        foreach ($this->getCriteria() as $criteria) {
+            if ($criteria instanceof Criteria)
                 $this->model = $criteria->apply($this->model, $this);
         }
 

Braces +9 added lines, -6 removed lines

@@ -107,8 +107,9 @@ 
         //$model = $this->app->make($this->model());
         $model = app()->make($this->model());
 
-        if (!$model instanceof Model)
-            throw new RepositoryException("Class {$this->model()} must be an instance of Illuminate\\Database\\Eloquent\\Model");
+        if (!$model instanceof Model) {
+                    throw new RepositoryException("Class {$this->model()} must be an instance of Illuminate\\Database\\Eloquent\\Model");
+        }
 
         return $this->model = $model;
     }
@@ -143,12 +144,14 @@ 
     }
 
     public function  applyCriteria() {
-        if($this->skipCriteria === true)
-            return $this;
+        if($this->skipCriteria === true) {
+                    return $this;
+        }
 
         foreach($this->getCriteria() as $criteria) {
-            if($criteria instanceof Criteria)
-                $this->model = $criteria->apply($this->model, $this);
+            if($criteria instanceof Criteria) {
+                            $this->model = $criteria->apply($this->model, $this);
+            }
         }
 
         return $this;

src/app/Repositories/Criteria/Attachments/ByUser.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 namespace Afrittella\BackProject\Repositories\Criteria\Attachments;
 
 use Afrittella\BackProject\Repositories\Criteria\Criteria;
-use Afrittella\BackProject\Contracts\BaseRepository as  Repository;
+use Afrittella\BackProject\Contracts\BaseRepository as Repository;
 use Illuminate\Support\Facades\Auth;
 
 class ByUser extends Criteria {

src/app/Repositories/Criteria/ByUser.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 namespace Afrittella\BackProject\Repositories\Criteria;
 
 use Afrittella\BackProject\Repositories\Criteria\Criteria;
-use Afrittella\BackProject\Contracts\BaseRepository as  Repository;
+use Afrittella\BackProject\Contracts\BaseRepository as Repository;
 use Illuminate\Support\Facades\Auth;
 
 class ByUser extends Criteria {

src/app/Repositories/Menus.php

Doc Comments +3 added lines

@@ -26,6 +26,9 @@
         return $this->model->withDepth()->find($id, $columns);
     }
 
+    /**
+     * @param string $name
+     */
     public function tree($name)
     {
         $root = $this->findBy('name', $name);

Unused Use Statements -2 removed lines

@@ -1,8 +1,6 @@
 <?php
 namespace Afrittella\BackProject\Repositories;
 
-use Afrittella\BackProject\Contracts\BaseRepository;
-
 class Menus extends Base
 {
     function model()

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
         $body = [];
 
         foreach ($data as $row):
-            $actions =[
+            $actions = [
                 'edit' => ['url' => route('menus.edit', [$row->id])]
             ];