RoleEdit::__construct() - Code Metrics - afrittella/back-project - Measure and Improve Code Quality continuously with Scrutinizer

RoleEdit::__construct() A
last analyzed 2018-02-11 23:44 UTC

↳ Parent: RoleEdit

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	5
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	8
dl	5
loc	5
rs	9.4285
c	0
b	0
f	0

How to fix Many Parameters

<?php

namespace Afrittella\BackProject\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;

use Afrittella\BackProject\Repositories\Roles;
use Illuminate\Container\Container as App;

class RoleEdit extends FormRequest

{
    protected $roles;
    public function __construct(array $query = array(), array $request = array(), array $attributes = array(), array $cookies = array(), array $files = array(), array $server = array(), $content = null, Roles $roles)
    {
        parent::__construct($query, $request, $attributes, $cookies, $files, $server, $content);
        $this->roles = $roles;
    }

    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return \Auth::check();
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {

        //$roleRepository = new RoleRepository($this->app);

        $role = $this->roles->findBy('id', $this->route('role'));

        return [
            'name' => 'required|max:255|unique:roles,name,'.$role->id,
        ];
    }
}


1		<?php
2
3		namespace Afrittella\BackProject\Http\Requests;
4
5		use Illuminate\Foundation\Http\FormRequest;
6
7		use Afrittella\BackProject\Repositories\Roles;
8		use Illuminate\Container\Container as App;
9
10	View Code Duplication	class RoleEdit extends FormRequest
		0 ignored issues – show Duplication introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		protected $roles;
13		public function __construct(array $query = array(), array $request = array(), array $attributes = array(), array $cookies = array(), array $files = array(), array $server = array(), $content = null, Roles $roles)
14		{
15		parent::__construct($query, $request, $attributes, $cookies, $files, $server, $content);
16		$this->roles = $roles;
17		}
18
19		/**
20		* Determine if the user is authorized to make this request.
21		*
22		* @return bool
23		*/
24		public function authorize()
25		{
26		return \Auth::check();
27		}
28
29		/**
30		* Get the validation rules that apply to the request.
31		*
32		* @return array
33		*/
34		public function rules()
35		{
36
37		//$roleRepository = new RoleRepository($this->app);
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
38		$role = $this->roles->findBy('id', $this->route('role'));
39
40		return [
41		'name' => 'required\|max:255\|unique:roles,name,'.$role->id,
42		];
43		}
44		}
45

afrittella / back-project

GitHub Access Token became invalid

RoleEdit::__construct() A last analyzed 2018-02-11 23:44 UTC

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like

RoleEdit::__construct() A
last analyzed 2018-02-11 23:44 UTC