RolesController::update() - Code Metrics - afrittella/back-project - Measure and Improve Code Quality continuously with Scrutinizer

RolesController::update() A
last analyzed 2018-02-11 23:44 UTC

↳ Parent: RolesController

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	3
dl	8
loc	8
rs	9.4285
c	0
b	0
f	0

<?php

namespace Afrittella\BackProject\Http\Controllers;

use Afrittella\BackProject\Http\Requests\RoleAdd;
use Afrittella\BackProject\Http\Requests\RoleEdit;
use Afrittella\BackProject\Repositories\Permissions;
use Afrittella\BackProject\Repositories\Roles;
use Prologue\Alerts\Facades\Alert;

class RolesController extends Controller

{
    public function __construct()
    {
        $this->middleware('admin');
    }

    public function index(Roles $roles)
    {
        return view('back-project::roles.index')->with('roles', $roles->transform($roles->all()));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function edit(Roles $roles, Permissions $permissions, $id)
    {
        return view('back-project::roles.edit')->with('role', $roles->find($id))->with('permissions', $permissions->all());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function update(RoleEdit $request, Roles $roles, $id)
    {
        $role = $roles->update($request->all(), $id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        Alert::add('success', trans('back-project::crud.model_updated', ['model' => trans('back-project::roles.role')]))->flash();

        return redirect(route('bp.roles.index'));
    }

    public function create(Permissions $permissions)
    {
        return view('back-project::roles.create')->with('permissions', $permissions->all());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function store(RoleAdd $request, Roles $roles)
    {
        $role = $roles->create($request->all());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        Alert::add('success', trans('back-project::crud.model_created', ['model' => trans('back-project::roles.role')]))->flash();

        return redirect(route('bp.roles.index'));
    }

    public function delete(Roles $roles, $id)
    {
        $roles->delete($id);

        Alert::add('success', trans('back-project::crud.model_deleted', ['model' => trans('back-project::roles.role')]))->flash();

        return back();
    }
}

1		<?php
2
3		namespace Afrittella\BackProject\Http\Controllers;
4
5		use Afrittella\BackProject\Http\Requests\RoleAdd;
6		use Afrittella\BackProject\Http\Requests\RoleEdit;
7		use Afrittella\BackProject\Repositories\Permissions;
8		use Afrittella\BackProject\Repositories\Roles;
9		use Prologue\Alerts\Facades\Alert;
10
11	View Code Duplication	class RolesController extends Controller
		0 ignored issues – show Duplication introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12		{
13		public function __construct()
14		{
15		$this->middleware('admin');
16		}
17
18		public function index(Roles $roles)
19		{
20		return view('back-project::roles.index')->with('roles', $roles->transform($roles->all()));
		0 ignored issues – show Bug introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
21		}
22
23		public function edit(Roles $roles, Permissions $permissions, $id)
24		{
25		return view('back-project::roles.edit')->with('role', $roles->find($id))->with('permissions', $permissions->all());
		0 ignored issues – show Bug introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
26		}
27
28		public function update(RoleEdit $request, Roles $roles, $id)
29		{
30		$role = $roles->update($request->all(), $id);
		0 ignored issues – show Unused Code introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report `$role` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
31
32		Alert::add('success', trans('back-project::crud.model_updated', ['model' => trans('back-project::roles.role')]))->flash();
33
34		return redirect(route('bp.roles.index'));
35		}
36
37		public function create(Permissions $permissions)
38		{
39		return view('back-project::roles.create')->with('permissions', $permissions->all());
		0 ignored issues – show Bug introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
40		}
41
42		public function store(RoleAdd $request, Roles $roles)
43		{
44		$role = $roles->create($request->all());
		0 ignored issues – show Unused Code introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report `$role` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
45
46		Alert::add('success', trans('back-project::crud.model_created', ['model' => trans('back-project::roles.role')]))->flash();
47
48		return redirect(route('bp.roles.index'));
49		}
50
51		public function delete(Roles $roles, $id)
52		{
53		$roles->delete($id);
54
55		Alert::add('success', trans('back-project::crud.model_deleted', ['model' => trans('back-project::roles.role')]))->flash();
56
57		return back();
58		}
59		}

afrittella / back-project

GitHub Access Token became invalid

RolesController::update() A last analyzed 2018-02-11 23:44 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

RolesController::update() A
last analyzed 2018-02-11 23:44 UTC