RemoveAttachableWheDeletingAttachment - Code Metrics - afrittella/back-project - Measure and Improve Code Quality continuously with Scrutinizer

RemoveAttachableWheDeletingAttachment A
last analyzed 2018-02-11 23:44 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	18
rs	10
c	0
b	0
f	0
wmc	2
lcom	0
cbo	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	deleting()	0	4	1

<?php namespace Afrittella\BackProject\Models\Observers;

use Illuminate\Http\Request;
use Afrittella\BackProject\Models\Attachment;
use Illuminate\Support\Facades\DB;

class RemoveAttachableWheDeletingAttachment
{
    protected $request;

    public function __construct(Request $request)

    {
        $this->request = $request;
    }

    /**
     *  When we remove attachment, we must delete all "attachables" reference
     * @param Attachment $attachment
     */
    public function deleting(Attachment $attachment)
    {
        DB::table('attachables')->where('attachment_id', '=', $attachment->id)->delete();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php namespace Afrittella\BackProject\Models\Observers;
2
3			use Illuminate\Http\Request;
4			use Afrittella\BackProject\Models\Attachment;
5			use Illuminate\Support\Facades\DB;
6
7			class RemoveAttachableWheDeletingAttachment
8			{
9			protected $request;
10
11			public function __construct(Request $request)
			0 ignored issues – show Bug introduced 2017-10-18 05:42 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
12			{
13			$this->request = $request;
14			}
15
16			/**
17			* When we remove attachment, we must delete all "attachables" reference
18			* @param Attachment $attachment
19			*/
20			public function deleting(Attachment $attachment)
21			{
22			DB::table('attachables')->where('attachment_id', '=', $attachment->id)->delete();
			0 ignored issues – show Documentation introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Afrittella\BackProject\Models\Attachment>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
23			}
24			}
25

afrittella / back-project

GitHub Access Token became invalid

RemoveAttachableWheDeletingAttachment A last analyzed 2018-02-11 23:44 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

RemoveAttachableWheDeletingAttachment A
last analyzed 2018-02-11 23:44 UTC