MediaController - Code Metrics - afrittella/back-project - Measure and Improve Code Quality continuously with Scrutinizer

MediaController A
last analyzed 2018-02-11 23:44 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	52
Duplicated Lines	26.92 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

Metric	Value
dl	14
loc	52
rs	10
c	0
b	0
f	0
wmc	6
lcom	0
cbo	6

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	5	1
A	edit()	0	4	1
A	store()	14	14	1
A	update()	0	9	1
A	delete()	0	8	1

How to fix Duplicated Code

<?php

namespace Afrittella\BackProject\Http\Controllers;

use Afrittella\BackProject\Repositories\Attachments;
use Afrittella\BackProject\Repositories\Criteria\Attachments\All;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Prologue\Alerts\Facades\Alert;

class MediaController extends Controller
{
    public function __construct()
    {
        $this->middleware('admin');
    }

    public function index(Attachments $attachments)
    {
        $attachments->pushCriteria(new All());
        return view('back-project::media.index')->with('attachments', $attachments->all());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function edit(Attachments $attachments, $id)
    {
        return view('back-project::media.edit')->with('attachment', $attachments->find($id));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function store(Request $request, Attachments $attachments)

    {
        $user = Auth::user();

        $success = $attachments->create(array_merge($request->all(), ['user_id' => $user->id]));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        Alert::add('success', trans('back-project::base.image_uploaded'))->flash();

        return response()->json([
            'success' => true,
            'message' => trans('back-project::base.image_uploaded')
        ]);

    }

    public function update(Request $request, Attachments $attachments, $id)
    {

        $attachment = $attachments->update($request->all(), $id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        Alert::add('success', trans('back-project::crud.model_updated', ['model' => trans('back-project::media.image')]))->flash();

        return redirect(route('bp.media.index'));
    }

    public function delete(Attachments $attachments, $id)
    {
        $attachments->delete($id);

        Alert::add('success', trans('back-project::crud.model_deleted', ['model' => trans('back-project::media.image')]))->flash();

        return back();
    }
}

1		<?php
2
3		namespace Afrittella\BackProject\Http\Controllers;
4
5		use Afrittella\BackProject\Repositories\Attachments;
6		use Afrittella\BackProject\Repositories\Criteria\Attachments\All;
7		use Illuminate\Http\Request;
8		use Illuminate\Support\Facades\Auth;
9		use Prologue\Alerts\Facades\Alert;
10
11		class MediaController extends Controller
12		{
13		public function __construct()
14		{
15		$this->middleware('admin');
16		}
17
18		public function index(Attachments $attachments)
19		{
20		$attachments->pushCriteria(new All());
21		return view('back-project::media.index')->with('attachments', $attachments->all());
		0 ignored issues – show Bug introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
22		}
23
24		public function edit(Attachments $attachments, $id)
25		{
26		return view('back-project::media.edit')->with('attachment', $attachments->find($id));
		0 ignored issues – show Bug introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
27		}
28
29	View Code Duplication	public function store(Request $request, Attachments $attachments)
		0 ignored issues – show Duplication introduced 2017-10-18 05:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		{
31		$user = Auth::user();
32
33		$success = $attachments->create(array_merge($request->all(), ['user_id' => $user->id]));
		0 ignored issues – show Bug introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Unused Code introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report `$success` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
34
35		Alert::add('success', trans('back-project::base.image_uploaded'))->flash();
36
37		return response()->json([
38		'success' => true,
39		'message' => trans('back-project::base.image_uploaded')
40		]);
41
42		}
43
44		public function update(Request $request, Attachments $attachments, $id)
45		{
46
47		$attachment = $attachments->update($request->all(), $id);
		0 ignored issues – show Unused Code introduced 2017-04-07 07:13 UTC by Report Bug Copy Issue Report `$attachment` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
48
49		Alert::add('success', trans('back-project::crud.model_updated', ['model' => trans('back-project::media.image')]))->flash();
50
51		return redirect(route('bp.media.index'));
52		}
53
54		public function delete(Attachments $attachments, $id)
55		{
56		$attachments->delete($id);
57
58		Alert::add('success', trans('back-project::crud.model_deleted', ['model' => trans('back-project::media.image')]))->flash();
59
60		return back();
61		}
62		}

afrittella / back-project

GitHub Access Token became invalid

MediaController A last analyzed 2018-02-11 23:44 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

MediaController A
last analyzed 2018-02-11 23:44 UTC