AE\History\ViewHelpers\AssetExistsViewHelper

Complexity

Total Complexity

3

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	render()	0	11	2
A	initializeArguments()	0	5	1

<?php
namespace AE\History\ViewHelpers;

use Doctrine\ORM\EntityNotFoundException;
use Neos\Flow\Annotations as Flow;
use Neos\FluidAdaptor\Core\ViewHelper\AbstractViewHelper;
use Neos\Media\Domain\Model\AssetInterface;

class AssetExistsViewHelper extends AbstractViewHelper
{
    /**
     * @var boolean
     */
    protected $escapeOutput = false;

    /**
     * @throws \Neos\FluidAdaptor\Core\ViewHelper\Exception
     */
    public function initializeArguments()
    {
        parent::initializeArguments();

        $this->registerArgument('asset', AssetInterface::class, 'AssetInterface', true);
    }

    /**
     * Checks if an asset exists.
     *
     * @return string
     */
    public function render() : string
    {
        $asset = $this->arguments['asset'];

        try {
            $asset->getResource();
        } catch (EntityNotFoundException $e) {
            return '';
        }

        return $this->renderChildren();

The expression return $this->renderChildren() could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}