View GitHub Repository ramda

Schedule Inspection
Subscribe
Passed
Pull Request — master (#25)
by Siwapun
04:37
created
Status
Category
Toggle Patches
test/SumTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -10,7 +10,7 @@
 
 block discarded – undo
10 10 
   public function testSum()
11 11 
   {
12 12 
     $expect = 121;
13 
-    $actual = sum()([2,4,6,8,100,1]);
13 
+    $actual = sum()([2, 4, 6, 8, 100, 1]);
14 14 
     $this->assertEquals($expect, $actual);
15 15 
   }
16 16 
 }
Please login to merge, or discard this patch.
test/StartsWithTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -39,21 +39,21 @@
 
 block discarded – undo
39 39 
   public function testStartsWithEmptyArray()
40 40 
   {
41 41 
     $prefix = [];
42 
-    $list = [1, 2 ,3, 4];
42 
+    $list = [1, 2, 3, 4];
43 43 
     $actual = startsWith($prefix)($list);
44 44 
     $this->assertTrue($actual);
45 45 
   }
46 46 
   public function testStartsWithValidArray()
47 47 
   {
48 48 
     $prefix = [1];
49 
-    $list = [1, 2 ,3, 4];
49 
+    $list = [1, 2, 3, 4];
50 50 
     $actual = startsWith($prefix)($list);
51 51 
     $this->assertTrue($actual);
52 52 
   }
53 53 
   public function testStartsWithInvalidArray()
54 54 
   {
55 55 
     $prefix = [5];
56 
-    $list = [1, 2 ,3, 4];
56 
+    $list = [1, 2, 3, 4];
57 57 
     $actual = startsWith($prefix)($list);
58 58 
     $this->assertFalse($actual);
59 59 
   }
Please login to merge, or discard this patch.
src/list.php 1 patch
Spacing   +37 added lines, -37 removed lines patch added patch discarded remove patch 
@@ -8,7 +8,7 @@  discard block
 
 block discarded – undo
8 8 
  */
9 9 
 function all()
10 10 
 {
11 
-  $all = function (callable $predicateFunction, array $array): bool {
11 
+  $all = function(callable $predicateFunction, array $array): bool {
12 12 
     if (empty($array)) {
13 13 
       return false;
14 14 
     }
 
@@ -31,7 +31,7 @@  discard block
 
 block discarded – undo
31 31 
  */
32 32 
 function any()
33 33 
 {
34 
-  $any = function (callable $predicateFunction, array $array) {
34 
+  $any = function(callable $predicateFunction, array $array) {
35 35 
     if (empty($array)) {
36 36 
       return false;
37 37 
     }
 
@@ -54,7 +54,7 @@  discard block
 
 block discarded – undo
54 54 
  */
55 55 
 function arrayForEach()
56 56 
 {
57 
-  $arrayForEach = function (callable $fn, array $array) {
57 
+  $arrayForEach = function(callable $fn, array $array) {
58 58 
     foreach ($array as $item) {
59 59 
       $fn($item);
60 60 
     }
 
@@ -72,7 +72,7 @@  discard block
 
 block discarded – undo
72 72 
  */
73 73 
 function append()
74 74 
 {
75 
-  $append = function ($item, array $array) {
75 
+  $append = function($item, array $array) {
76 76 
     return array_merge($array, [$item]);
77 77 
   };
78 78 
   $arguments = func_get_args();
 
@@ -88,7 +88,7 @@  discard block
 
 block discarded – undo
88 88 
  */
89 89 
 function concat()
90 90 
 {
91 
-  $concat = function (array $firstArray, array $secondArray) {
91 
+  $concat = function(array $firstArray, array $secondArray) {
92 92 
     return array_merge($firstArray, $secondArray);
93 93 
   };
94 94 
   $arguments = func_get_args();
 
@@ -117,7 +117,7 @@  discard block
 
 block discarded – undo
117 117 
  */
118 118 
 function drop()
119 119 
 {
120 
-  $drop = function (int $index, array $array) {
120 
+  $drop = function(int $index, array $array) {
121 121 
     return array_merge(array_slice($array, 0, $index), array_slice($array, $index + 1));
122 122 
   };
123 123 
   $arguments = func_get_args();
 
@@ -143,8 +143,8 @@  discard block
 
 block discarded – undo
143 143 
  */
144 144 
 function dropLast()
145 145 
 {
146 
-  $dropLast = function (array $array) {
147 
-    $index = count($array)-1;
146 
+  $dropLast = function(array $array) {
147 
+    $index = count($array) - 1;
148 148 
     return array_merge(array_slice($array, 0, $index), array_slice($array, $index + 1));
149 149 
   };
150 150 
 
@@ -160,7 +160,7 @@  discard block
 
 block discarded – undo
160 160 
  */
161 161 
 function endsWith()
162 162 
 {
163 
-  $endsWith = function ($suffix, $list) {
163 
+  $endsWith = function($suffix, $list) {
164 164 
     if (is_string($suffix) && is_string($list)) {
165 165 
       return $suffix === '' || (($temp = strlen($list) - strlen($suffix)) >= 0 && strpos($list, $suffix) !== false);
166 166 
     }
 
@@ -174,7 +174,7 @@  discard block
 
 block discarded – undo
174 174 
       }
175 175 
       return true;
176 176 
     }
177 
-    throw new \InvalidArgumentException(__FUNCTION__ . 'accepts only string or array as it arguments');
177 
+    throw new \InvalidArgumentException(__FUNCTION__.'accepts only string or array as it arguments');
178 178 
   };
179 179 
   $arguments = func_get_args();
180 180 
   $curried = curryN($endsWith, 2);
 
@@ -188,7 +188,7 @@  discard block
 
 block discarded – undo
188 188 
  */
189 189 
 function filter()
190 190 
 {
191 
-  $filter = function (callable $predicateFunction, array $array) {
191 
+  $filter = function(callable $predicateFunction, array $array) {
192 192 
      return array_values(array_filter($array, $predicateFunction));
193 193 
   };
194 194 
   $arguments = func_get_args();
 
@@ -203,7 +203,7 @@  discard block
 
 block discarded – undo
203 203 
  */
204 204 
 function filterPreserveKey()
205 205 
 {
206 
-  $filter = function (callable $predicateFunction, array $array) {
206 
+  $filter = function(callable $predicateFunction, array $array) {
207 207 
     return array_filter($array, $predicateFunction);
208 208 
   };
209 209 
   $arguments = func_get_args();
 
@@ -218,7 +218,7 @@  discard block
 
 block discarded – undo
218 218 
  */
219 219 
 function find()
220 220 
 {
221 
-  $find = function (callable $predicateFunction, array $list) {
221 
+  $find = function(callable $predicateFunction, array $list) {
222 222 
     foreach ($list as $item) {
223 223 
       if ($predicateFunction($item)) {
224 224 
         return $item;
 
@@ -233,7 +233,7 @@  discard block
 
 block discarded – undo
233 233
234 234 
 function first()
235 235 
 {
236 
-  $first = function (array $array) {
236 
+  $first = function(array $array) {
237 237 
     if (empty($array)) {
238 238 
       return null;
239 239 
     }
 
@@ -250,8 +250,8 @@  discard block
 
 block discarded – undo
250 250 
  */
251 251 
 function flatten()
252 252 
 {
253 
-  $flatten = function (array $array) use (&$flatten) {
254 
-    $accumulator = function ($acc, $item) use ($flatten) {
253 
+  $flatten = function(array $array) use (&$flatten) {
254 
+    $accumulator = function($acc, $item) use ($flatten) {
255 255 
       if (is_array($item)) {
256 256 
         return array_merge($acc, $flatten($item));
257 257 
       }
 
@@ -272,8 +272,8 @@  discard block
 
 block discarded – undo
272 272 
  */
273 273 
 function groupBy()
274 274 
 {
275 
-  $groupBy = function (callable $keySelector, array $array) {
276 
-    $accumulator = function ($acc, $item) use ($keySelector) {
275 
+  $groupBy = function(callable $keySelector, array $array) {
276 
+    $accumulator = function($acc, $item) use ($keySelector) {
277 277 
       $key = $keySelector($item);
278 278 
       $acc[$key] = array_key_exists($key, $acc) ? array_merge($acc[$key], [$item]) : [$item];
279 279 
       return $acc;
 
@@ -293,7 +293,7 @@  discard block
 
 block discarded – undo
293 293 
  */
294 294 
 function insert()
295 295 
 {
296 
-  $insert = function (int $index, $element, array $array) {
296 
+  $insert = function(int $index, $element, array $array) {
297 297 
     return array_merge(
298 298 
       array_slice($array, 0, $index),
299 299 
       [$element],
 
@@ -319,7 +319,7 @@  discard block
 
 block discarded – undo
319 319
320 320 
 function last()
321 321 
 {
322 
-  $last = function (array $array) {
322 
+  $last = function(array $array) {
323 323 
     if (empty($array)) {
324 324 
       return null;
325 325 
     }
 
@@ -356,7 +356,7 @@  discard block
 
 block discarded – undo
356 356 
  */
357 357 
 function pair()
358 358 
 {
359 
-  $pair = function ($firstValue, $secondValue) {
359 
+  $pair = function($firstValue, $secondValue) {
360 360 
     return [$firstValue, $secondValue];
361 361 
   };
362 362 
   $arguments = func_get_args();
 
@@ -372,7 +372,7 @@  discard block
 
 block discarded – undo
372 372 
  */
373 373 
 function prepend()
374 374 
 {
375 
-  $prepend = function ($item, array $array) {
375 
+  $prepend = function($item, array $array) {
376 376 
     return array_merge([$item], $array);
377 377 
   };
378 378 
   $arguments = func_get_args();
 
@@ -401,7 +401,7 @@  discard block
 
 block discarded – undo
401 401 
  */
402 402 
 function reduce()
403 403 
 {
404 
-  $reduce = function (callable $accumulator, $initialValue, array $array) {
404 
+  $reduce = function(callable $accumulator, $initialValue, array $array) {
405 405 
     return array_reduce($array, $accumulator, $initialValue);
406 406 
   };
407 407 
   $arguments = func_get_args();
 
@@ -416,7 +416,7 @@  discard block
 
 block discarded – undo
416 416 
  */
417 417 
 function reject()
418 418 
 {
419 
-  $reject = function ($predicate, array $array) {
419 
+  $reject = function($predicate, array $array) {
420 420 
     return array_values(array_filter($array, compose(not(), $predicate)));
421 421 
   };
422 422 
   $arguments = func_get_args();
 
@@ -431,7 +431,7 @@  discard block
 
 block discarded – undo
431 431 
  */
432 432 
 function rejectPreserveKey()
433 433 
 {
434 
-  $reject = function ($predicate, array $array) {
434 
+  $reject = function($predicate, array $array) {
435 435 
     return array_filter($array, compose(not(), $predicate));
436 436 
   };
437 437 
   $arguments = func_get_args();
 
@@ -448,7 +448,7 @@  discard block
 
 block discarded – undo
448 448 
  */
449 449 
 function remove()
450 450 
 {
451 
-  $remove = function (int $start, int $count, array $array) {
451 
+  $remove = function(int $start, int $count, array $array) {
452 452 
     return array_merge(array_slice($array, 0, $start), array_slice($array, $start + $count));
453 453 
   };
454 454 
   $arguments = func_get_args();
 
@@ -463,10 +463,10 @@  discard block
 
 block discarded – undo
463 463 
  */
464 464 
 function repeat()
465 465 
 {
466 
-  $repeat = function ($item, int $count) {
466 
+  $repeat = function($item, int $count) {
467 467 
     return array_reduce(
468 468 
       range(1, $count),
469 
-      function ($acc, $unsedItem) use ($item) {
469 
+      function($acc, $unsedItem) use ($item) {
470 470 
         return array_merge($acc, [$item]);
471 471 
       },
472 472 
       []
 
@@ -483,7 +483,7 @@  discard block
 
 block discarded – undo
483 483 
  */
484 484 
 function reverse()
485 485 
 {
486 
-  $reverse = function ($list) {
486 
+  $reverse = function($list) {
487 487 
     if (is_array($list)) {
488 488 
       return array_reverse($list);
489 489 
     }
 
@@ -505,15 +505,15 @@  discard block
 
 block discarded – undo
505 505 
  */
506 506 
 function slice()
507 507 
 {
508 
-  $slice = function (int $fromIndex, int $toIndex, $list) {
508 
+  $slice = function(int $fromIndex, int $toIndex, $list) {
509 509 
     if (is_array($list)) {
510 
-      $listCount =  count($list);
510 
+      $listCount = count($list);
511 511 
       $actualFromIndex = $fromIndex < 0 ? $listCount + $fromIndex : $fromIndex;
512 512 
       $actualToIndex = $toIndex < 0 ? $listCount + $toIndex : $toIndex;
513 513 
       return array_slice($list, $actualFromIndex, $actualToIndex - $actualFromIndex);
514 514 
     }
515 515 
     if (is_string($list)) {
516 
-      $listCount =  strlen($list);
516 
+      $listCount = strlen($list);
517 517 
       $actualFromIndex = $fromIndex < 0 ? $listCount + $fromIndex : $fromIndex;
518 518 
       $actualToIndex = $toIndex < 0 ? $listCount + $toIndex : $toIndex;
519 519 
       return substr($list, $actualFromIndex, $actualToIndex - $actualFromIndex);
 
@@ -532,7 +532,7 @@  discard block
 
 block discarded – undo
532 532 
  */
533 533 
 function sort()
534 534 
 {
535 
-  $sort = function (callable $comparator, array $array) {
535 
+  $sort = function(callable $comparator, array $array) {
536 536 
     usort($array, $comparator);
537 537 
     return $array;
538 538 
   };
 
@@ -548,7 +548,7 @@  discard block
 
 block discarded – undo
548 548 
  */
549 549 
 function sortBy()
550 550 
 {
551 
-  $sortBy = function (callable $keySelector, array $array) {
551 
+  $sortBy = function(callable $keySelector, array $array) {
552 552 
     $groupedArray = groupBy($keySelector, $array);
553 553 
     ksort($groupedArray);
554 554 
     return apply('array_merge', array_values($groupedArray));
 
@@ -565,7 +565,7 @@  discard block
 
 block discarded – undo
565 565 
  */
566 566 
 function startsWith($prefix = null, $list = null)
567 567 
 {
568 
-  $startsWith = function ($prefix, $list) {
568 
+  $startsWith = function($prefix, $list) {
569 569 
     if (is_string($prefix) && is_string($list)) {
570 570 
       return $prefix === '' || strpos($list, $prefix) === 0;
571 571 
     }
 
@@ -577,7 +577,7 @@  discard block
 
 block discarded – undo
577 577 
       }
578 578 
       return true;
579 579 
     }
580 
-    throw new \InvalidArgumentException(__FUNCTION__ . 'accepts only string or array as it arguments');
580 
+    throw new \InvalidArgumentException(__FUNCTION__.'accepts only string or array as it arguments');
581 581 
   };
582 582 
   $arguments = func_get_args();
583 583 
   $curried = curryN($startsWith, 2);
 
@@ -586,7 +586,7 @@  discard block
 
 block discarded – undo
586 586
587 587 
 function tail()
588 588 
 {
589 
-  $tail = function (array $array) {
589 
+  $tail = function(array $array) {
590 590 
     if (empty($array)) {
591 591 
       return null;
592 592 
     }
Please login to merge, or discard this patch.