View GitHub Repository ramda

Schedule Inspection
Subscribe
Passed
Pull Request — master (#23)
by Siwapun
04:18
created
Status
Category
Toggle Patches
test/SortTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -9,10 +9,10 @@
 
 block discarded – undo
9 9 
 {
10 10 
   public function testSort()
11 11 
   {
12 
-    $diff = function ($a, $b) {
12 
+    $diff = function($a, $b) {
13 13 
       return $a - $b;
14 14 
     };
15 
-    $array = [4,2,7,5];
15 
+    $array = [4, 2, 7, 5];
16 16 
     $expect = [2, 4, 5, 7];
17 17 
     $actual = sort($diff)($array);
18 18 
     $this->assertEquals($expect, $actual);
Please login to merge, or discard this patch.
src/list.php 1 patch
Spacing   +36 added lines, -36 removed lines patch added patch discarded remove patch 
@@ -8,7 +8,7 @@  discard block
 
 block discarded – undo
8 8 
  */
9 9 
 function all()
10 10 
 {
11 
-  $all = function (callable $predicateFunction, array $array): bool {
11 
+  $all = function(callable $predicateFunction, array $array): bool {
12 12 
     if (empty($array)) {
13 13 
       return false;
14 14 
     }
 
@@ -31,7 +31,7 @@  discard block
 
 block discarded – undo
31 31 
  */
32 32 
 function any()
33 33 
 {
34 
-  $any = function (callable $predicateFunction, array $array) {
34 
+  $any = function(callable $predicateFunction, array $array) {
35 35 
     if (empty($array)) {
36 36 
       return false;
37 37 
     }
 
@@ -54,7 +54,7 @@  discard block
 
 block discarded – undo
54 54 
  */
55 55 
 function arrayForEach()
56 56 
 {
57 
-  $arrayForEach = function (callable $fn, array $array) {
57 
+  $arrayForEach = function(callable $fn, array $array) {
58 58 
     foreach ($array as $item) {
59 59 
       $fn($item);
60 60 
     }
 
@@ -72,7 +72,7 @@  discard block
 
 block discarded – undo
72 72 
  */
73 73 
 function append()
74 74 
 {
75 
-  $append = function ($item, array $array) {
75 
+  $append = function($item, array $array) {
76 76 
     return array_merge($array, [$item]);
77 77 
   };
78 78 
   $arguments = func_get_args();
 
@@ -88,7 +88,7 @@  discard block
 
 block discarded – undo
88 88 
  */
89 89 
 function concat()
90 90 
 {
91 
-  $concat = function (array $firstArray, array $secondArray) {
91 
+  $concat = function(array $firstArray, array $secondArray) {
92 92 
     return array_merge($firstArray, $secondArray);
93 93 
   };
94 94 
   $arguments = func_get_args();
 
@@ -117,7 +117,7 @@  discard block
 
 block discarded – undo
117 117 
  */
118 118 
 function drop()
119 119 
 {
120 
-  $drop = function (int $index, array $array) {
120 
+  $drop = function(int $index, array $array) {
121 121 
     return array_merge(array_slice($array, 0, $index), array_slice($array, $index + 1));
122 122 
   };
123 123 
   $arguments = func_get_args();
 
@@ -143,8 +143,8 @@  discard block
 
 block discarded – undo
143 143 
  */
144 144 
 function dropLast()
145 145 
 {
146 
-  $dropLast = function (array $array) {
147 
-    $index = count($array)-1;
146 
+  $dropLast = function(array $array) {
147 
+    $index = count($array) - 1;
148 148 
     return array_merge(array_slice($array, 0, $index), array_slice($array, $index + 1));
149 149 
   };
150 150 
 
@@ -160,7 +160,7 @@  discard block
 
 block discarded – undo
160 160 
  */
161 161 
 function endsWith()
162 162 
 {
163 
-  $endsWith = function ($suffix, $list) {
163 
+  $endsWith = function($suffix, $list) {
164 164 
     if (is_string($suffix) && is_string($list)) {
165 165 
       return $suffix === '' || (($temp = strlen($list) - strlen($suffix)) >= 0 && strpos($list, $suffix) !== false);
166 166 
     }
 
@@ -174,7 +174,7 @@  discard block
 
 block discarded – undo
174 174 
       }
175 175 
       return true;
176 176 
     }
177 
-    throw new \InvalidArgumentException(__FUNCTION__ . 'accepts only string or array as it arguments');
177 
+    throw new \InvalidArgumentException(__FUNCTION__.'accepts only string or array as it arguments');
178 178 
   };
179 179 
   $arguments = func_get_args();
180 180 
   $curried = curryN($endsWith, 2);
 
@@ -188,7 +188,7 @@  discard block
 
 block discarded – undo
188 188 
  */
189 189 
 function filter()
190 190 
 {
191 
-  $filter = function (callable $predicateFunction, array $array) {
191 
+  $filter = function(callable $predicateFunction, array $array) {
192 192 
      return array_values(array_filter($array, $predicateFunction));
193 193 
   };
194 194 
   $arguments = func_get_args();
 
@@ -203,7 +203,7 @@  discard block
 
 block discarded – undo
203 203 
  */
204 204 
 function filterPreserveKey()
205 205 
 {
206 
-  $filter = function (callable $predicateFunction, array $array) {
206 
+  $filter = function(callable $predicateFunction, array $array) {
207 207 
     return array_filter($array, $predicateFunction);
208 208 
   };
209 209 
   $arguments = func_get_args();
 
@@ -218,7 +218,7 @@  discard block
 
 block discarded – undo
218 218 
  */
219 219 
 function find()
220 220 
 {
221 
-  $find = function (callable $predicateFunction, array $list) {
221 
+  $find = function(callable $predicateFunction, array $list) {
222 222 
     foreach ($list as $item) {
223 223 
       if ($predicateFunction($item)) {
224 224 
         return $item;
 
@@ -233,7 +233,7 @@  discard block
 
 block discarded – undo
233 233
234 234 
 function first()
235 235 
 {
236 
-  $first = function (array $array) {
236 
+  $first = function(array $array) {
237 237 
     if (empty($array)) {
238 238 
       return null;
239 239 
     }
 
@@ -250,8 +250,8 @@  discard block
 
 block discarded – undo
250 250 
  */
251 251 
 function flatten()
252 252 
 {
253 
-  $flatten = function (array $array) use (&$flatten) {
254 
-    $accumulator = function ($acc, $item) use ($flatten) {
253 
+  $flatten = function(array $array) use (&$flatten) {
254 
+    $accumulator = function($acc, $item) use ($flatten) {
255 255 
       if (is_array($item)) {
256 256 
         return array_merge($acc, $flatten($item));
257 257 
       }
 
@@ -272,8 +272,8 @@  discard block
 
 block discarded – undo
272 272 
  */
273 273 
 function groupBy()
274 274 
 {
275 
-  $groupBy = function (callable $keySelector, array $array) {
276 
-    $accumulator = function ($acc, $item) use ($keySelector) {
275 
+  $groupBy = function(callable $keySelector, array $array) {
276 
+    $accumulator = function($acc, $item) use ($keySelector) {
277 277 
       $key = $keySelector($item);
278 278 
       $acc[$key] = array_key_exists($key, $acc) ? array_merge($acc[$key], [$item]) : [$item];
279 279 
       return $acc;
 
@@ -287,7 +287,7 @@  discard block
 
 block discarded – undo
287 287
288 288 
 function head()
289 289 
 {
290 
-  $head = function (array $array) {
290 
+  $head = function(array $array) {
291 291 
     if (empty($array)) {
292 292 
       return null;
293 293 
     }
 
@@ -306,7 +306,7 @@  discard block
 
 block discarded – undo
306 306 
  */
307 307 
 function insert()
308 308 
 {
309 
-  $insert = function (int $index, $element, array $array) {
309 
+  $insert = function(int $index, $element, array $array) {
310 310 
     return array_merge(
311 311 
       array_slice($array, 0, $index),
312 312 
       [$element],
 
@@ -332,7 +332,7 @@  discard block
 
 block discarded – undo
332 332
333 333 
 function last()
334 334 
 {
335 
-  $last = function (array $array) {
335 
+  $last = function(array $array) {
336 336 
     if (empty($array)) {
337 337 
       return null;
338 338 
     }
 
@@ -369,7 +369,7 @@  discard block
 
 block discarded – undo
369 369 
  */
370 370 
 function pair()
371 371 
 {
372 
-  $pair = function ($firstValue, $secondValue) {
372 
+  $pair = function($firstValue, $secondValue) {
373 373 
     return [$firstValue, $secondValue];
374 374 
   };
375 375 
   $arguments = func_get_args();
 
@@ -385,7 +385,7 @@  discard block
 
 block discarded – undo
385 385 
  */
386 386 
 function prepend()
387 387 
 {
388 
-  $prepend = function ($item, array $array) {
388 
+  $prepend = function($item, array $array) {
389 389 
     return array_merge([$item], $array);
390 390 
   };
391 391 
   $arguments = func_get_args();
 
@@ -414,7 +414,7 @@  discard block
 
 block discarded – undo
414 414 
  */
415 415 
 function reduce()
416 416 
 {
417 
-  $reduce = function (callable $accumulator, $initialValue, array $array) {
417 
+  $reduce = function(callable $accumulator, $initialValue, array $array) {
418 418 
     return array_reduce($array, $accumulator, $initialValue);
419 419 
   };
420 420 
   $arguments = func_get_args();
 
@@ -429,7 +429,7 @@  discard block
 
 block discarded – undo
429 429 
  */
430 430 
 function reject()
431 431 
 {
432 
-  $reject = function ($predicate, array $array) {
432 
+  $reject = function($predicate, array $array) {
433 433 
     return array_values(array_filter($array, compose(not(), $predicate)));
434 434 
   };
435 435 
   $arguments = func_get_args();
 
@@ -444,7 +444,7 @@  discard block
 
 block discarded – undo
444 444 
  */
445 445 
 function rejectPreserveKey()
446 446 
 {
447 
-  $reject = function ($predicate, array $array) {
447 
+  $reject = function($predicate, array $array) {
448 448 
     return array_filter($array, compose(not(), $predicate));
449 449 
   };
450 450 
   $arguments = func_get_args();
 
@@ -461,7 +461,7 @@  discard block
 
 block discarded – undo
461 461 
  */
462 462 
 function remove()
463 463 
 {
464 
-  $remove = function (int $start, int $count, array $array) {
464 
+  $remove = function(int $start, int $count, array $array) {
465 465 
     return array_merge(array_slice($array, 0, $start), array_slice($array, $start + $count));
466 466 
   };
467 467 
   $arguments = func_get_args();
 
@@ -476,10 +476,10 @@  discard block
 
 block discarded – undo
476 476 
  */
477 477 
 function repeat()
478 478 
 {
479 
-  $repeat = function ($item, int $count) {
479 
+  $repeat = function($item, int $count) {
480 480 
     return array_reduce(
481 481 
       range(1, $count),
482 
-      function ($acc, $unsedItem) use ($item) {
482 
+      function($acc, $unsedItem) use ($item) {
483 483 
         return array_merge($acc, [$item]);
484 484 
       },
485 485 
       []
 
@@ -496,7 +496,7 @@  discard block
 
 block discarded – undo
496 496 
  */
497 497 
 function reverse()
498 498 
 {
499 
-  $reverse = function ($list) {
499 
+  $reverse = function($list) {
500 500 
     if (is_array($list)) {
501 501 
       return array_reverse($list);
502 502 
     }
 
@@ -518,15 +518,15 @@  discard block
 
 block discarded – undo
518 518 
  */
519 519 
 function slice()
520 520 
 {
521 
-  $slice = function (int $fromIndex, int $toIndex, $list) {
521 
+  $slice = function(int $fromIndex, int $toIndex, $list) {
522 522 
     if (is_array($list)) {
523 
-      $listCount =  count($list);
523 
+      $listCount = count($list);
524 524 
       $actualFromIndex = $fromIndex < 0 ? $listCount + $fromIndex : $fromIndex;
525 525 
       $actualToIndex = $toIndex < 0 ? $listCount + $toIndex : $toIndex;
526 526 
       return array_slice($list, $actualFromIndex, $actualToIndex - $actualFromIndex);
527 527 
     }
528 528 
     if (is_string($list)) {
529 
-      $listCount =  strlen($list);
529 
+      $listCount = strlen($list);
530 530 
       $actualFromIndex = $fromIndex < 0 ? $listCount + $fromIndex : $fromIndex;
531 531 
       $actualToIndex = $toIndex < 0 ? $listCount + $toIndex : $toIndex;
532 532 
       return substr($list, $actualFromIndex, $actualToIndex - $actualFromIndex);
 
@@ -545,7 +545,7 @@  discard block
 
 block discarded – undo
545 545 
  */
546 546 
 function sort()
547 547 
 {
548 
-  $sort = function (callable $comparator, array $array) {
548 
+  $sort = function(callable $comparator, array $array) {
549 549 
     usort($array, $comparator);
550 550 
     return $array;
551 551 
   };
 
@@ -561,7 +561,7 @@  discard block
 
 block discarded – undo
561 561 
  */
562 562 
 function sortBy()
563 563 
 {
564 
-  $sortBy = function (callable $keySelector, array $array) {
564 
+  $sortBy = function(callable $keySelector, array $array) {
565 565 
     $groupedArray = groupBy($keySelector, $array);
566 566 
     ksort($groupedArray);
567 567 
     return apply('array_merge', array_values($groupedArray));
 
@@ -573,7 +573,7 @@  discard block
 
 block discarded – undo
573 573
574 574 
 function tail()
575 575 
 {
576 
-  $tail = function (array $array) {
576 
+  $tail = function(array $array) {
577 577 
     if (empty($array)) {
578 578 
       return null;
579 579 
     }
Please login to merge, or discard this patch.
src/math.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch 
@@ -9,7 +9,7 @@  discard block
 
 block discarded – undo
9 9 
  */
10 10 
 function add()
11 11 
 {
12 
-  $add = function ($firstValue, $secondValue) {
12 
+  $add = function($firstValue, $secondValue) {
13 13 
     return $firstValue + $secondValue;
14 14 
   };
15 15 
   $arguments = func_get_args();
 
@@ -25,7 +25,7 @@  discard block
 
 block discarded – undo
25 25 
  */
26 26 
 function divide()
27 27 
 {
28 
-  $divide = function ($firstValue, $secondValue) {
28 
+  $divide = function($firstValue, $secondValue) {
29 29 
     return $firstValue / $secondValue;
30 30 
   };
31 31 
   $arguments = func_get_args();
 
@@ -39,7 +39,7 @@  discard block
 
 block discarded – undo
39 39 
  */
40 40 
 function inc()
41 41 
 {
42 
-  $inc = function ($value) {
42 
+  $inc = function($value) {
43 43 
     return $value + 1;
44 44 
   };
45 45 
   $arguments = func_get_args();
 
@@ -53,12 +53,12 @@  discard block
 
 block discarded – undo
53 53 
  */
54 54 
 function mean()
55 55 
 {
56 
-  $mean = function (array $numbers) {
56 
+  $mean = function(array $numbers) {
57 57 
     $length = count($numbers);
58 58 
     if ($length === 0) {
59 59 
       throw new \InvalidArgumentException('$numbers passed to mean() must not be empty');
60 60 
     }
61 
-    return array_sum($numbers)/$length;
61 
+    return array_sum($numbers) / $length;
62 62 
   };
63 63 
   $arguments = func_get_args();
64 64 
   $curried = curryN($mean, 1);
 
@@ -67,13 +67,13 @@  discard block
 
 block discarded – undo
67 67
68 68 
 function median()
69 69 
 {
70 
-  $median = function (array $numbers) {
70 
+  $median = function(array $numbers) {
71 71 
     $length = count($numbers);
72 72 
     \sort($numbers, SORT_NUMERIC);
73 73 
     if ($length % 2 == 0) {
74 
-      return mean([$numbers[$length/2], $numbers[$length/2 - 1]]);
74 
+      return mean([$numbers[$length / 2], $numbers[$length / 2 - 1]]);
75 75 
     }
76 
-    return $numbers[($length-1)/2];
76 
+    return $numbers[($length - 1) / 2];
77 77 
   };
78 78 
   $arguments = func_get_args();
79 79 
   $curried = curryN($median, 1);
 
@@ -87,7 +87,7 @@  discard block
 
 block discarded – undo
87 87 
  */
88 88 
 function modulo()
89 89 
 {
90 
-  $modulo = function ($firstValue, $secondValue) {
90 
+  $modulo = function($firstValue, $secondValue) {
91 91 
     return $firstValue % $secondValue;
92 92 
   };
93 93 
   $arguments = func_get_args();
 
@@ -104,7 +104,7 @@  discard block
 
 block discarded – undo
104 104 
  */
105 105 
 function multiply()
106 106 
 {
107 
-  $multiply = function ($firstValue, $secondValue) {
107 
+  $multiply = function($firstValue, $secondValue) {
108 108 
     return $firstValue * $secondValue;
109 109 
   };
110 110 
   $arguments = func_get_args();
 
@@ -120,7 +120,7 @@  discard block
 
 block discarded – undo
120 120 
  */
121 121 
 function subtract()
122 122 
 {
123 
-  $subtract = function ($firstValue, $secondValue) {
123 
+  $subtract = function($firstValue, $secondValue) {
124 124 
     return $firstValue - $secondValue;
125 125 
   };
126 126 
   $arguments = func_get_args();
Please login to merge, or discard this patch.