Completed
Pull Request — master (#110)
by Milos
16:00 queued 04:09
created
src/AerialShip/SamlSPBundle/Bridge/AssertionConsumer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
      * @throws \RuntimeException
62 62
      * @throws \Symfony\Component\Security\Core\Exception\AuthenticationException
63 63
      * @throws \InvalidArgumentException if cannot manage the Request
64
-     * @return \Symfony\Component\HttpFoundation\RedirectResponse|SamlSpInfo
64
+     * @return SamlSpInfo
65 65
      */
66 66
     public function manage(Request $request)
67 67
     {
Please login to merge, or discard this patch.
src/AerialShip/SamlSPBundle/Bridge/LogoutReceiveResponse.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
      * @param \Symfony\Component\HttpFoundation\Request $request
71 71
      * @throws \RuntimeException
72 72
      * @throws \InvalidArgumentException if cannot manage the Request
73
-     * @return \Symfony\Component\HttpFoundation\Response|SamlSpInfo|null
73
+     * @return \Symfony\Component\HttpFoundation\RedirectResponse
74 74
      */
75 75
     public function manage(Request $request)
76 76
     {
Please login to merge, or discard this patch.
src/AerialShip/SamlSPBundle/Bridge/LogoutSendRequest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
      * @param \Symfony\Component\HttpFoundation\Request $request
70 70
      * @throws \RuntimeException  if no signing provider set
71 71
      * @throws \InvalidArgumentException if cannot manage the Request
72
-     * @return \Symfony\Component\HttpFoundation\Response|SamlSpInfo
72
+     * @return Response
73 73
      */
74 74
     function manage(Request $request)
75 75
     {
Please login to merge, or discard this patch.
src/AerialShip/SamlSPBundle/Config/SpEntityDescriptorBuilder.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -42,6 +42,11 @@
 block discarded – undo
42 42
 
43 43
 
44 44
 
45
+    /**
46
+     * @param string $authenticationServiceID
47
+     * @param string $checkPath
48
+     * @param string $logoutPath
49
+     */
45 50
     public function __construct(
46 51
         $authenticationServiceID,
47 52
         SPSigningProviderInterface $signingProvider,
Please login to merge, or discard this patch.
Security/Core/Authentication/Provider/SamlSpAuthenticationProvider.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,6 +30,9 @@  discard block
 block discarded – undo
30 30
 
31 31
 
32 32
 
33
+    /**
34
+     * @param string $providerKey
35
+     */
33 36
     public function __construct(
34 37
         $providerKey,
35 38
         UserManagerInterface $userProvider = null,
@@ -52,7 +55,7 @@  discard block
 block discarded – undo
52 55
     /**
53 56
      * Attempts to authenticate a TokenInterface object.
54 57
      * @param TokenInterface $token The TokenInterface instance to authenticate
55
-     * @return TokenInterface An authenticated TokenInterface instance, never null
58
+     * @return null|SamlSpToken An authenticated TokenInterface instance, never null
56 59
      * @throws AuthenticationException if the authentication fails
57 60
      */
58 61
     public function authenticate(TokenInterface $token)
@@ -82,7 +85,7 @@  discard block
 block discarded – undo
82 85
 
83 86
     /**
84 87
      * @param SamlSpToken $token
85
-     * @return mixed|UserInterface
88
+     * @return UserInterface
86 89
      */
87 90
     protected function getUser(SamlSpToken $token)
88 91
     {
@@ -113,7 +116,7 @@  discard block
 block discarded – undo
113 116
      * @param \AerialShip\SamlSPBundle\Bridge\SamlSpInfo $samlInfo
114 117
      * @param array $attributes
115 118
      * @param array $roles
116
-     * @param mixed $user
119
+     * @param UserInterface $user
117 120
      * @return SamlSpToken
118 121
      */
119 122
     protected function createAuthenticatedToken(SamlSpInfo $samlInfo, array $attributes, array $roles, $user)
Please login to merge, or discard this patch.
src/AerialShip/SamlSPBundle/State/SSO/AbstractSSOStateStore.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
     protected $entityClass;
11 11
 
12 12
     /**
13
-     * @param $entityClass
13
+     * @param string $entityClass
14 14
      */
15 15
     public function __construct($entityClass)
16 16
     {
Please login to merge, or discard this patch.
src/AerialShip/SamlSPBundle/Tests/Config/ServiceInfoCollectionTest.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -254,8 +254,8 @@  discard block
 block discarded – undo
254 254
 
255 255
 
256 256
     /**
257
-     * @param $providerID
258
-     * @param $idpID
257
+     * @param string $providerID
258
+     * @param string $idpID
259 259
      * @param $spProvider
260 260
      * @param $idpProvider
261 261
      * @param $spMetaProvider
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
     }
304 304
 
305 305
     /**
306
-     * @param $entityID
306
+     * @param string $entityID
307 307
      * @return EntityDescriptor|\PHPUnit_Framework_MockObject_MockObject
308 308
      */
309 309
     protected function createEntityDescriptorStub($entityID)
Please login to merge, or discard this patch.
src/AerialShip/SamlSPBundle/Tests/Config/SpEntityDescriptorBuilderTest.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
 
292 292
 
293 293
     /**
294
-     * @return \PHPUnit_Framework_MockObject_MockObject|SPSigningProviderInterface
294
+     * @return SPSigningProviderInterface
295 295
      */
296 296
     protected function createSPSigningProviderMock()
297 297
     {
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 
301 301
 
302 302
     /**
303
-     * @param $enabled
303
+     * @param boolean $enabled
304 304
      * @param $certificate
305 305
      * @param $key
306 306
      * @return SPSigningProviderInterface|\PHPUnit_Framework_MockObject_MockObject
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
     }
321 321
 
322 322
     /**
323
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\Security\Http\HttpUtils
323
+     * @return null|\Symfony\Component\Security\Http\HttpUtils
324 324
      */
325 325
     protected function createHttpUtilsMock()
326 326
     {
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
     }
329 329
 
330 330
     /**
331
-     * @param $generateUriReturn
331
+     * @param string $generateUriReturn
332 332
      * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\Security\Http\HttpUtils
333 333
      */
334 334
     protected function createHttpUtilsStub($generateUriReturn)
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 
351 351
 
352 352
     /**
353
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\HttpFoundation\Request
353
+     * @return \Symfony\Component\HttpFoundation\Request
354 354
      */
355 355
     private function createRequestMock()
356 356
     {
Please login to merge, or discard this patch.
AerialShip/SamlSPBundle/Tests/RelyingParty/RelyingPartyCollectionTest.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
     }
234 234
 
235 235
     /**
236
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\HttpFoundation\Request
236
+     * @return \Symfony\Component\HttpFoundation\Request
237 237
      */
238 238
     public function createRequestMock()
239 239
     {
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
     }
242 242
 
243 243
     /**
244
-     * @return \PHPUnit_Framework_MockObject_MockObject|\AerialShip\SamlSPBundle\RelyingParty\RelyingPartyInterface
244
+     * @return \AerialShip\SamlSPBundle\RelyingParty\RelyingPartyInterface
245 245
      */
246 246
     public function createRelyingPartyMock()
247 247
     {
Please login to merge, or discard this patch.