Completed
Pull Request — master (#110)
by Milos
16:00 queued 04:09
created
AerialShip/SamlSPBundle/Tests/RelyingParty/RelyingPartyCollectionTest.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
     }
234 234
 
235 235
     /**
236
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\HttpFoundation\Request
236
+     * @return \Symfony\Component\HttpFoundation\Request
237 237
      */
238 238
     public function createRequestMock()
239 239
     {
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
     }
242 242
 
243 243
     /**
244
-     * @return \PHPUnit_Framework_MockObject_MockObject|\AerialShip\SamlSPBundle\RelyingParty\RelyingPartyInterface
244
+     * @return \AerialShip\SamlSPBundle\RelyingParty\RelyingPartyInterface
245 245
      */
246 246
     public function createRelyingPartyMock()
247 247
     {
Please login to merge, or discard this patch.
SamlSPBundle/Tests/Security/Http/SamlSpAuthenticationListenerTest.php 1 patch
Doc Comments   +14 added lines, -11 removed lines patch added patch discarded remove patch
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
      * @param bool $hasPreviousSession
256 256
      * @param mixed $duplicateReturn
257 257
      * @param mixed $getSessionReturn
258
-     * @return \PHPUnit_Framework_MockObject_MockObject|Request
258
+     * @return Request|null
259 259
      */
260 260
     private function createRequestStub($hasSessionReturn = null, $hasPreviousSession = null, $duplicateReturn = null, $getSessionReturn = null)
261 261
     {
@@ -286,13 +286,16 @@  discard block
 block discarded – undo
286 286
     }
287 287
 
288 288
     /**
289
-     * @return \PHPUnit_Framework_MockObject_MockObject|RelyingPartyInterface
289
+     * @return RelyingPartyInterface
290 290
      */
291 291
     private function createRelyingPartyMock()
292 292
     {
293 293
         return $this->getMock('AerialShip\SamlSPBundle\RelyingParty\RelyingPartyInterface');
294 294
     }
295 295
 
296
+    /**
297
+     * @param boolean $supportsReturn
298
+     */
296 299
     private function createRelyingPartyStub($supportsReturn = null, $manageReturn = null)
297 300
     {
298 301
         $relyingPartyMock = $this->createRelyingPartyMock();
@@ -321,7 +324,7 @@  discard block
 block discarded – undo
321 324
 
322 325
     /**
323 326
      * @param Request|null $request
324
-     * @return \PHPUnit_Framework_MockObject_MockObject|GetResponseEvent
327
+     * @return GetResponseEvent
325 328
      */
326 329
     private function createGetResponseEventStub($request = null)
327 330
     {
@@ -346,7 +349,7 @@  discard block
 block discarded – undo
346 349
     }
347 350
 
348 351
     /**
349
-     * @return \PHPUnit_Framework_MockObject_MockObject|SecurityContextInterface
352
+     * @return \Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface
350 353
      */
351 354
     private function createSecurityContextMock()
352 355
     {
@@ -362,7 +365,7 @@  discard block
 block discarded – undo
362 365
     }
363 366
 
364 367
     /**
365
-     * @return \PHPUnit_Framework_MockObject_MockObject|SessionAuthenticationStrategyInterface
368
+     * @return SessionAuthenticationStrategyInterface
366 369
      */
367 370
     private function createSessionAuthenticationStrategyMock()
368 371
     {
@@ -370,7 +373,7 @@  discard block
 block discarded – undo
370 373
     }
371 374
 
372 375
     /**
373
-     * @return \PHPUnit_Framework_MockObject_MockObject|HttpUtils
376
+     * @return HttpUtils
374 377
      */
375 378
     private function createHttpUtilsMock()
376 379
     {
@@ -378,8 +381,8 @@  discard block
 block discarded – undo
378 381
     }
379 382
 
380 383
     /**
381
-     * @param null $checkRequestPathResult
382
-     * @param null $createRedirectResponseReturn
384
+     * @param boolean $checkRequestPathResult
385
+     * @param RedirectResponse $createRedirectResponseReturn
383 386
      * @return \PHPUnit_Framework_MockObject_MockObject|HttpUtils
384 387
      */
385 388
     private function createHttpUtilsStub($checkRequestPathResult = null, $createRedirectResponseReturn = null)
@@ -402,7 +405,7 @@  discard block
 block discarded – undo
402 405
 
403 406
 
404 407
     /**
405
-     * @return \PHPUnit_Framework_MockObject_MockObject|AuthenticationSuccessHandlerInterface
408
+     * @return AuthenticationSuccessHandlerInterface
406 409
      */
407 410
     private function createAuthenticationSuccessHandlerMock()
408 411
     {
@@ -410,7 +413,7 @@  discard block
 block discarded – undo
410 413
     }
411 414
 
412 415
     /**
413
-     * @return \PHPUnit_Framework_MockObject_MockObject|AuthenticationSuccessHandlerInterface
416
+     * @return AuthenticationSuccessHandlerInterface
414 417
      */
415 418
     protected function createAuthenticationSuccessHandlerStub()
416 419
     {
@@ -426,7 +429,7 @@  discard block
 block discarded – undo
426 429
     }
427 430
 
428 431
     /**
429
-     * @return \PHPUnit_Framework_MockObject_MockObject|AuthenticationFailureHandlerInterface
432
+     * @return AuthenticationFailureHandlerInterface
430 433
      */
431 434
     private function createAuthenticationFailureHandlerMock()
432 435
     {
Please login to merge, or discard this patch.
src/AerialShip/SamlSPBundle/Bridge/Discovery.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
      * @param \Symfony\Component\HttpFoundation\Request $request
70 70
      * @throws \RuntimeException  if no signing provider set
71 71
      * @throws \InvalidArgumentException if cannot manage the Request
72
-     * @return \Symfony\Component\HttpFoundation\Response|SamlSpInfo
72
+     * @return Response
73 73
      */
74 74
     function manage(Request $request)
75 75
     {
Please login to merge, or discard this patch.
src/AerialShip/SamlSPBundle/Bridge/FederationMetadata.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
      * @param \Symfony\Component\HttpFoundation\Request $request
70 70
      * @throws \RuntimeException  if no signing provider set
71 71
      * @throws \InvalidArgumentException if cannot manage the Request
72
-     * @return \Symfony\Component\HttpFoundation\Response|SamlSpInfo
72
+     * @return Response
73 73
      */
74 74
     function manage(Request $request)
75 75
     {
Please login to merge, or discard this patch.
src/AerialShip/SamlSPBundle/Bridge/LogoutFallback.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
      * @param \Symfony\Component\HttpFoundation\Request $request
71 71
      * @throws \RuntimeException
72 72
      * @throws \InvalidArgumentException if cannot manage the Request
73
-     * @return \Symfony\Component\HttpFoundation\Response|SamlSpInfo|null
73
+     * @return \Symfony\Component\HttpFoundation\RedirectResponse
74 74
      */
75 75
     public function manage(Request $request)
76 76
     {
Please login to merge, or discard this patch.