Issues in SpEntityDescriptorBuilderTest.php - New Issues - Inspection of "Merge pull request #110 from tmilos/limit_symfony_..." - aerialship/SamlSPBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d5bbb9...ab4758 )

by Milos

created 2016-01-03 08:15 UTC

Tests/Config/SpEntityDescriptorBuilderTest.php (16 issues)

Labels

Bug 16

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace AerialShip\SamlSPBundle\Tests\Config;

use AerialShip\LightSaml\Bindings;
use AerialShip\SamlSPBundle\Config\SpEntityDescriptorBuilder;
use AerialShip\SamlSPBundle\Config\SPSigningProviderInterface;

class SpEntityDescriptorBuilderTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @test
     */
    public function shouldImplementEntityDescriptorProviderInterface()
    {
        $rc = new \ReflectionClass('AerialShip\SamlSPBundle\Config\SpEntityDescriptorBuilder');
        $this->assertTrue($rc->implementsInterface('AerialShip\SamlSPBundle\Config\EntityDescriptorProviderInterface'));
    }

    /**
     * @test
     */
    public function shouldBeConstructedWithRequiredArguments()
    {
        new SpEntityDescriptorBuilder(
            'idp',
            $this->createSPSigningProviderMock(),

            array('entity_id'=>'entityID', 'base_url'=>'http://site.com'),
            'check_path',
            'logout_path',
            $this->createHttpUtilsMock()

        );
    }

    /**
     * @test
     */
    public function shouldReturnIdpIDSetInConstructor()
    {
        $builder = new SpEntityDescriptorBuilder(
            $expectedIDP = 'idp',
            $this->createSPSigningProviderMock(),

            array('entity_id'=>'entityID', 'base_url'=>'http://site.com'),
            'check_path',
            'logout_path',
            $this->createHttpUtilsMock()

        );

        $this->assertEquals($expectedIDP, $builder->getAuthenticationServiceID());
    }

    /**
     * @test
     * @expectedException \RuntimeException
     * @expectedExceptionMessage Missing required config entity_id
     */
    public function shouldThrowIfConstructedWithoutEntityID()
    {
        new SpEntityDescriptorBuilder(
            'idp',
            $this->createSPSigningProviderMock(),

            array('base_url'=>'http://site.com'),
            'check_path',
            'logout_path',
            $this->createHttpUtilsMock()

        );
    }

    /**
     * @test
     * @expectedException \RuntimeException
     * @expectedExceptionMessage If config base_url is not set, then httpUtils are required
     */
    public function shouldThrowIfConstructedWithoutBaseUrlAndHttpUtils()
    {
        new SpEntityDescriptorBuilder(
            'idp',
            $this->createSPSigningProviderMock(),

            array('entity_id'=>'entityID'),
            'check_path',
            'logout_path',
            null
        );
    }


    /**
     * @test
     */
    public function shouldBuildWithSigningDisabledAndBasePathSet()
    {
        $signingProvider = $this->createSPSigningProviderStub(false, null, null);
        $expectedEntityID = 'entityID';
        $expectedBaseUrl = 'http://site.com';
        $checkPath = '/check_path';
        $logoutPath = '/logout_path';

        $builder = new SpEntityDescriptorBuilder(
            'idp',
            $signingProvider,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            array('entity_id'=>$expectedEntityID, 'base_url'=>$expectedBaseUrl),
            $checkPath,
            $logoutPath,
            null
        );

        $ed = $builder->getEntityDescriptor();

        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\EntityDescriptor', $ed);

        $this->assertEquals($expectedEntityID, $ed->getEntityID());

        $arr = $ed->getAllSpSsoDescriptors();
        $this->assertInternalType('array', $arr);
        $this->assertCount(1, $arr);

        $sp = $ed->getFirstSpSsoDescriptor();
        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\SpSsoDescriptor', $sp);

        $arr = $sp->getKeyDescriptors();
        $this->assertInternalType('array', $arr);
        $this->assertCount(0, $arr);

        // SLO
        $arr = $sp->findSingleLogoutServices();
        $this->assertInternalType('array', $arr);
        $this->assertCount(2, $arr);
        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\Service\SingleLogoutService', $arr[0]);
        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\Service\SingleLogoutService', $arr[1]);
        $this->assertEquals($expectedBaseUrl.$logoutPath, $arr[0]->getLocation());
        $this->assertEquals($expectedBaseUrl.$logoutPath, $arr[1]->getLocation());

        $arr = $sp->findSingleLogoutServices(Bindings::SAML2_HTTP_REDIRECT);
        $this->assertInternalType('array', $arr);
        $this->assertCount(1, $arr);

        $arr = $sp->findSingleLogoutServices(Bindings::SAML2_HTTP_POST);
        $this->assertInternalType('array', $arr);
        $this->assertCount(1, $arr);

        // ACS
        $arr = $sp->findAssertionConsumerServices();
        $this->assertInternalType('array', $arr);
        $this->assertCount(2, $arr);
        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\Service\AssertionConsumerService', $arr[0]);
        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\Service\AssertionConsumerService', $arr[1]);
        $this->assertEquals($expectedBaseUrl.$checkPath, $arr[0]->getLocation());
        $this->assertEquals($expectedBaseUrl.$checkPath, $arr[1]->getLocation());

        $arr = $sp->findAssertionConsumerServices(Bindings::SAML2_HTTP_REDIRECT);
        $this->assertInternalType('array', $arr);
        $this->assertCount(1, $arr);

        $arr = $sp->findAssertionConsumerServices(Bindings::SAML2_HTTP_POST);
        $this->assertInternalType('array', $arr);
        $this->assertCount(1, $arr);
    }


    /**
     * @test
     */
    public function shouldBuildWithSigningEnabled()
    {
        $expectedCertificate = $this->createX509CertificateMock();
        $signingProvider = $this->createSPSigningProviderStub(true, $expectedCertificate, null);
        $expectedEntityID = 'entityID';
        $expectedBaseUrl = 'http://site.com';
        $checkPath = '/check_path';
        $logoutPath = '/logout_path';

        $builder = new SpEntityDescriptorBuilder(
            'idp',
            $signingProvider,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            array('entity_id'=>$expectedEntityID, 'base_url'=>$expectedBaseUrl),
            $checkPath,
            $logoutPath,
            null
        );

        $ed = $builder->getEntityDescriptor();

        $sp = $ed->getFirstSpSsoDescriptor();
        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\SpSsoDescriptor', $sp);

        $arr = $sp->getKeyDescriptors();
        $this->assertInternalType('array', $arr);
        $this->assertCount(1, $arr);
        $this->assertEquals($expectedCertificate, $arr[0]->getCertificate());
    }


    /**
     * @test
     * @expectedException \RuntimeException
     * @expectedExceptionMessage Request not set
     */
    public function shouldThrowWhenBuildIsCalledWithoutSetBaseUrlAndRequest()
    {
        $signingProvider = $this->createSPSigningProviderStub(false, null, null);
        $expectedEntityID = 'entityID';
        $checkPath = '/check_path';
        $logoutPath = '/logout_path';

        $builder = new SpEntityDescriptorBuilder(
            'idp',
            $signingProvider,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            array('entity_id'=>$expectedEntityID),
            $checkPath,
            $logoutPath,
            $this->createHttpUtilsMock()

        );

        $builder->getEntityDescriptor();
    }


    /**
     * @test
     */
    public function shouldBuildWithoutBaseUrlAndWithHttpUtils()
    {
        $signingProvider = $this->createSPSigningProviderStub(false, null, null);
        $expectedEntityID = 'entityID';
        $checkPath = '/check_path';
        $logoutPath = '/logout_path';
        $httpUtils = $this->createHttpUtilsStub($expectedLocation = 'generated_location');

        $builder = new SpEntityDescriptorBuilder(
            'idp',
            $signingProvider,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            array('entity_id'=>$expectedEntityID),
            $checkPath,
            $logoutPath,
            $httpUtils
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        );

        $builder->setRequest($this->createRequestMock());

        $ed = $builder->getEntityDescriptor();

        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\EntityDescriptor', $ed);

        $this->assertEquals($expectedEntityID, $ed->getEntityID());

        $arr = $ed->getAllSpSsoDescriptors();
        $this->assertInternalType('array', $arr);
        $this->assertCount(1, $arr);

        $sp = $ed->getFirstSpSsoDescriptor();
        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\SpSsoDescriptor', $sp);

        $arr = $sp->getKeyDescriptors();
        $this->assertInternalType('array', $arr);
        $this->assertCount(0, $arr);

        // SLO
        $arr = $sp->findSingleLogoutServices();
        $this->assertInternalType('array', $arr);
        $this->assertCount(2, $arr);
        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\Service\SingleLogoutService', $arr[0]);
        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\Service\SingleLogoutService', $arr[1]);
        $this->assertEquals($expectedLocation, $arr[0]->getLocation());
        $this->assertEquals($expectedLocation, $arr[1]->getLocation());

        $arr = $sp->findSingleLogoutServices(Bindings::SAML2_HTTP_REDIRECT);
        $this->assertInternalType('array', $arr);
        $this->assertCount(1, $arr);

        $arr = $sp->findSingleLogoutServices(Bindings::SAML2_HTTP_POST);
        $this->assertInternalType('array', $arr);
        $this->assertCount(1, $arr);

        // ACS
        $arr = $sp->findAssertionConsumerServices();
        $this->assertInternalType('array', $arr);
        $this->assertCount(2, $arr);
        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\Service\AssertionConsumerService', $arr[0]);
        $this->assertInstanceOf('AerialShip\LightSaml\Model\Metadata\Service\AssertionConsumerService', $arr[1]);
        $this->assertEquals($expectedLocation, $arr[0]->getLocation());
        $this->assertEquals($expectedLocation, $arr[1]->getLocation());

        $arr = $sp->findAssertionConsumerServices(Bindings::SAML2_HTTP_REDIRECT);
        $this->assertInternalType('array', $arr);
        $this->assertCount(1, $arr);

        $arr = $sp->findAssertionConsumerServices(Bindings::SAML2_HTTP_POST);
        $this->assertInternalType('array', $arr);
        $this->assertCount(1, $arr);
    }



    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|SPSigningProviderInterface
     */
    protected function createSPSigningProviderMock()
    {
        return $this->getMock('AerialShip\SamlSPBundle\Config\SPSigningProviderInterface');
    }


    /**
     * @param $enabled
     * @param $certificate
     * @param $key
     * @return SPSigningProviderInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    protected function createSPSigningProviderStub($enabled, $certificate, $key)
    {
        $result = $this->createSPSigningProviderMock();
        $result->expects($this->any())->method('isEnabled')->will($this->returnValue($enabled));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        if ($enabled) {
            $result->expects($this->any())->method('getCertificate')->will($this->returnValue($certificate));
            $result->expects($this->any())->method('getPrivateKey')->will($this->returnValue($key));
        } else {
            $result->expects($this->never())->method('getCertificate');
            $result->expects($this->never())->method('getPrivateKey');
        }
        return $result;
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\Security\Http\HttpUtils
     */
    protected function createHttpUtilsMock()
    {
        return $this->getMock('Symfony\Component\Security\Http\HttpUtils');
    }

    /**
     * @param $generateUriReturn
     * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\Security\Http\HttpUtils
     */
    protected function createHttpUtilsStub($generateUriReturn)
    {
        $result = $this->createHttpUtilsMock();
        $result->expects($this->any())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                ->method('generateUri')
                ->will($this->returnValue($generateUriReturn));
        return $result;
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|\AerialShip\LightSaml\Security\X509Certificate
     */
    protected function createX509CertificateMock()
    {
        return $this->getMock('AerialShip\LightSaml\Security\X509Certificate');
    }


    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\HttpFoundation\Request
     */
    private function createRequestMock()
    {
        return $this->getMock('Symfony\Component\HttpFoundation\Request', array(), array(), '', false, false);
    }
} 


Push — master ( d5bbb9...ab4758 )

Tests/Config/SpEntityDescriptorBuilderTest.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

1			<?php
2
3			namespace AerialShip\SamlSPBundle\Tests\Config;
4
5			use AerialShip\LightSaml\Bindings;
6			use AerialShip\SamlSPBundle\Config\SpEntityDescriptorBuilder;
7			use AerialShip\SamlSPBundle\Config\SPSigningProviderInterface;
8
9			class SpEntityDescriptorBuilderTest extends \PHPUnit_Framework_TestCase
10			{
11			/**
12			* @test
13			*/
14			public function shouldImplementEntityDescriptorProviderInterface()
15			{
16			$rc = new \ReflectionClass('AerialShip\SamlSPBundle\Config\SpEntityDescriptorBuilder');
17			$this->assertTrue($rc->implementsInterface('AerialShip\SamlSPBundle\Config\EntityDescriptorProviderInterface'));
18			}
19
20			/**
21			* @test
22			*/
23			public function shouldBeConstructedWithRequiredArguments()
24			{
25			new SpEntityDescriptorBuilder(
26			'idp',
27			$this->createSPSigningProviderMock(),
			0 ignored issues – show Bug introduced 2016-01-03 08:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createSPSigningProviderMock()` targeting `AerialShip\SamlSPBundle\...SPSigningProviderMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `AerialShip\SamlSPBundle\...rBuilder::__construct()` does only seem to accept `object<AerialShip\SamlSP...gningProviderInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
28			array('entity_id'=>'entityID', 'base_url'=>'http://site.com'),
29			'check_path',
30			'logout_path',
31			$this->createHttpUtilsMock()
			0 ignored issues – show Bug introduced 2016-01-03 08:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createHttpUtilsMock()` targeting `AerialShip\SamlSPBundle\...::createHttpUtilsMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `AerialShip\SamlSPBundle\...rBuilder::__construct()` does only seem to accept `null\|object<Symfony\Comp...ecurity\Http\HttpUtils>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
32			);
33			}
34
35			/**
36			* @test
37			*/
38			public function shouldReturnIdpIDSetInConstructor()

aerialship / SamlSPBundle

Push — master ( d5bbb9...ab4758 )

Tests/Config/SpEntityDescriptorBuilderTest.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like