Issues in ServiceInfoCollectionTest.php - New Issues - Inspection of "Merge pull request #110 from tmilos/limit_symfony_..." - aerialship/SamlSPBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d5bbb9...ab4758 )

by Milos

created 2016-01-03 08:15 UTC

Tests/Config/ServiceInfoCollectionTest.php (14 issues)

Labels

Bug 14

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace AerialShip\SamlSPBundle\Tests\Config;

use AerialShip\LightSaml\Model\Metadata\EntityDescriptor;
use AerialShip\SamlSPBundle\Config\EntityDescriptorProviderInterface;
use AerialShip\SamlSPBundle\Config\ServiceInfo;
use AerialShip\SamlSPBundle\Config\ServiceInfoCollection;

class ServiceInfoCollectionTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @test
     */
    public function couldBeConstructed()
    {
        new ServiceInfoCollection();
    }

    /**
     * @test
     */
    public function shouldReturnNullForNonExistingService()
    {
        $col = new ServiceInfoCollection();
        $this->assertNull($col->get('something'));
    }

    /**
     * @test
     */
    public function shouldReturnServiceInfoByIdpIDWhenGetIsCalled()
    {
        $col = new ServiceInfoCollection();

        $expectedServiceInfo_1 = $this->createServiceInfoStub(
            $expectedProviderID_1 = 'main',
            $expectedIdpID_1 = 'idp1',
            null,
            null,
            null,
            null
        );
        $expectedServiceInfo_2 = $this->createServiceInfoStub(
            $expectedProviderID_2 = 'main',
            $expectedIdpID_2 = 'idp2',
            null,
            null,
            null,
            null
        );

        $col->add($expectedServiceInfo_1);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $col->add($expectedServiceInfo_2);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $this->assertEquals($expectedServiceInfo_1, $col->get($expectedIdpID_1));
        $this->assertEquals($expectedServiceInfo_2, $col->get($expectedIdpID_2));
    }

    /**
     * @test
     */
    public function shouldReturnAllThatAreAddedWhenAllIsCalled()
    {
        $col = new ServiceInfoCollection();

        $expectedServiceInfo_1 = $this->createServiceInfoStub(
            $expectedProviderID_1 = 'main',
            $expectedIdpID_1 = 'idp1',
            null,
            null,
            null,
            null
        );
        $expectedServiceInfo_2 = $this->createServiceInfoStub(
            $expectedProviderID_2 = 'main',
            $expectedIdpID_2 = 'idp2',
            null,
            null,
            null,
            null
        );

        $col->add($expectedServiceInfo_1);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $col->add($expectedServiceInfo_2);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $all = $col->all();

        $this->assertInternalType('array', $all);
        $this->assertCount(2, $all);
        $this->assertEquals($expectedServiceInfo_1, $all[$expectedIdpID_1]);
        $this->assertEquals($expectedServiceInfo_2, $all[$expectedIdpID_2]);
    }


    /**
     * @test
     */
    public function shouldReturnEmptyArrayWhenAllCalledAndNoneAdded()
    {
        $col = new ServiceInfoCollection();

        $all = $col->all();

        $this->assertInternalType('array', $all);
        $this->assertCount(0, $all);
    }

    /**
     * @test
     */
    public function shouldReturnServiceInfoWhenFindByAsIsCalledWithNullAndThereIsOnlyOne()
    {
        $col = new ServiceInfoCollection();

        $expectedServiceInfo = $this->createServiceInfoStub(
            $expectedProviderID = 'main',
            $expectedIdpID = 'idp',
            null,
            null,
            null,
            null
        );

        $col->add($expectedServiceInfo);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $this->assertEquals($expectedServiceInfo, $col->findByAS(null));
    }


    /**
     * @test
     */
    public function shouldReturnNullWhenFindByAsIsCalledWithNullAndThereIsMoreThenOne()
    {
        $col = new ServiceInfoCollection();

        $expectedServiceInfo_1 = $this->createServiceInfoStub(
            $expectedProviderID_1 = 'main',
            $expectedIdpID_1 = 'idp1',
            null,
            null,
            null,
            null
        );
        $expectedServiceInfo_2 = $this->createServiceInfoStub(
            $expectedProviderID_2 = 'main',
            $expectedIdpID_2 = 'idp2',
            null,
            null,
            null,
            null
        );

        $col->add($expectedServiceInfo_1);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $col->add($expectedServiceInfo_2);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $this->assertNull($col->findByAS(null));
    }

    /**
     * @test
     */
    public function shouldReturnServiceInfoWhenFindByAsIsCalledWithIdpIDAndThereIsMoreThenOne()
    {
        $col = new ServiceInfoCollection();

        $expectedServiceInfo_1 = $this->createServiceInfoStub(
            $expectedProviderID_1 = 'main',
            $expectedIdpID_1 = 'idp1',
            null,
            null,
            null,
            null
        );
        $expectedServiceInfo_2 = $this->createServiceInfoStub(
            $expectedProviderID_2 = 'main',
            $expectedIdpID_2 = 'idp2',
            null,
            null,
            null,
            null
        );

        $col->add($expectedServiceInfo_1);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $col->add($expectedServiceInfo_2);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $this->assertEquals($expectedServiceInfo_1, $col->findByAS($expectedIdpID_1));
        $this->assertEquals($expectedServiceInfo_2, $col->findByAS($expectedIdpID_2));
    }


    /**
     * @test
     */
    public function shouldReturnServiceInfoWhenFindByIDPEntityIDIsCalledWithEntityID()
    {
        $expectedProviderID = 'main';

        $col = new ServiceInfoCollection();

        $ed_1 = $this->createEntityDescriptorStub($expectedEntityID_1 = 'entity_1');
        $expectedIdpProvider_1 = $this->createEntityDescriptorProviderStub($ed_1);
        $expectedServiceInfo_1 = $this->createServiceInfoStub(
            $expectedProviderID,
            $expectedIdpID_1 = 'idp_1',
            $expectedSpProvider = null,
            $expectedIdpProvider_1,
            null,
            null
        );

        $ed_2 = $this->createEntityDescriptorStub($expectedEntityID_2 = 'entity_2');
        $expectedIdpProvider_2 = $this->createEntityDescriptorProviderStub($ed_2);
        $expectedServiceInfo_2 = $this->createServiceInfoStub(
            $expectedProviderID,
            $expectedIdpID_2 = 'idp_2',
            $expectedSpProvider = null,
            $expectedIdpProvider_2,
            null,
            null
        );

        $col->add($expectedServiceInfo_1);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $col->add($expectedServiceInfo_2);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $this->assertEquals($expectedServiceInfo_1, $col->findByIDPEntityID($expectedEntityID_1));
        $this->assertEquals($expectedServiceInfo_2, $col->findByIDPEntityID($expectedEntityID_2));
        $this->assertNull($col->findByIDPEntityID('foo'));
    }


    /**
     * @test
     */
    public function shouldReturnNullWhenFindByIDPEntityIDIsCalledWithUnknownEntityID()
    {
        $col = new ServiceInfoCollection();

        $this->assertNull($col->findByIDPEntityID('foo'));
    }





    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|ServiceInfo
     */
    protected function createServiceInfoMock()
    {
        return $this->getMock('AerialShip\SamlSPBundle\Config\ServiceInfo', array(), array(), '', false, false);
    }


    /**
     * @param $providerID
     * @param $idpID
     * @param $spProvider
     * @param $idpProvider
     * @param $spMetaProvider
     * @param $signingProvider
     * @return ServiceInfo|\PHPUnit_Framework_MockObject_MockObject
     */
    protected function createServiceInfoStub($providerID, $idpID, $spProvider, $idpProvider, $spMetaProvider, $signingProvider)
    {
        $result = $this->createServiceInfoMock();
        $result->expects($this->any())->method('getProviderID')->will($this->returnValue($providerID));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $result->expects($this->any())->method('getAuthenticationService')->will($this->returnValue($idpID));
        $result->expects($this->any())->method('getSpProvider')->will($this->returnValue($spProvider));
        $result->expects($this->any())->method('getIdpProvider')->will($this->returnValue($idpProvider));
        $result->expects($this->any())->method('getSpMetaProvider')->will($this->returnValue($spMetaProvider));
        $result->expects($this->any())->method('getSpSigningProvider')->will($this->returnValue($signingProvider));
        return $result;
    }


    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|EntityDescriptorProviderInterface
     */
    protected function createEntityDescriptorProviderMock()
    {
        return $this->getMock('AerialShip\SamlSPBundle\Config\EntityDescriptorProviderInterface');
    }

    /**
     * @param $ed
     * @return EntityDescriptorProviderInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    protected function createEntityDescriptorProviderStub($ed)
    {
        $result = $this->createEntityDescriptorProviderMock();
        $result->expects($this->any())->method('getEntityDescriptor')->will($this->returnValue($ed));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        return $result;
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|EntityDescriptor
     */
    protected function createEntityDescriptorMock()
    {
        return $this->getMock('AerialShip\LightSaml\Model\Metadata\EntityDescriptor');
    }

    /**
     * @param $entityID
     * @return EntityDescriptor|\PHPUnit_Framework_MockObject_MockObject
     */
    protected function createEntityDescriptorStub($entityID)
    {
        $result = $this->createEntityDescriptorMock();
        $result->expects($this->any())->method('getEntityID')->will($this->returnValue($entityID));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        return $result;
    }
}


Push — master ( d5bbb9...ab4758 )

Tests/Config/ServiceInfoCollectionTest.php (14 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace AerialShip\SamlSPBundle\Tests\Config;
4
5			use AerialShip\LightSaml\Model\Metadata\EntityDescriptor;
6			use AerialShip\SamlSPBundle\Config\EntityDescriptorProviderInterface;
7			use AerialShip\SamlSPBundle\Config\ServiceInfo;
8			use AerialShip\SamlSPBundle\Config\ServiceInfoCollection;
9
10			class ServiceInfoCollectionTest extends \PHPUnit_Framework_TestCase
11			{
12			/**
13			* @test
14			*/
15			public function couldBeConstructed()
16			{
17			new ServiceInfoCollection();
18			}
19
20			/**
21			* @test
22			*/
23			public function shouldReturnNullForNonExistingService()
24			{
25			$col = new ServiceInfoCollection();
26			$this->assertNull($col->get('something'));
27			}
28
29			/**
30			* @test
31			*/
32			public function shouldReturnServiceInfoByIdpIDWhenGetIsCalled()
33			{
34			$col = new ServiceInfoCollection();
35
36			$expectedServiceInfo_1 = $this->createServiceInfoStub(
37			$expectedProviderID_1 = 'main',
38			$expectedIdpID_1 = 'idp1',
39			null,
40			null,

aerialship / SamlSPBundle

Push — master ( d5bbb9...ab4758 )

Tests/Config/ServiceInfoCollectionTest.php (14 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like